Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-19 Thread Andrew Morton
On Thu, 19 Apr 2007 16:27:26 - "Cameron, Steve" <[EMAIL PROTECTED]> wrote: > > Something like > > if (sizeof(blah) > 4) { >do all the assignments with shifts > } > > might be slighly better since the CDB is already zeroed > by cmd_alloc() and doesn't need to be zeroed a 2nd time. > >

Re: [PATCH] add two SCSI command opcodes

2007-04-19 Thread Steven Hayter
Matthew Wilcox wrote: > On Thu, Apr 19, 2007 at 07:39:59PM +0300, Dan Aloni wrote: >> On Thu, Apr 19, 2007 at 05:47:43PM +0200, Jan-Benedict Glaw wrote: >>> Where's the user? >> A privately maintained kernel driver. >> >> Do we _must_ have in-tree users? I'd consider the change for completion's

[PATCH 1/1] scsi: EH Start Unit timeout

2007-04-19 Thread Brian King
Use the sysfs configurable timeout when issuing a START_UNIT command from the scsi error handler. This is needed for devices which take longer than thirty seconds to respond to the start unit. The problem was observed when sending a start unit to a disk array device in an ipr RAID adapter, which r

Re: Major qla2xxx regression on sparc64

2007-04-19 Thread Andrew Vasquez
On Wed, 18 Apr 2007, David Miller wrote: > > On Wed, 18 Apr 2007, Christoph Hellwig wrote: > > > > > I don't think a module option is a good idea at this point. The problem > > > is you broke some so far perfectly working setups, which is not okay. > > > The only first step can be printing a rea

[PATCH] megaraid: update version reported by MEGAIOC_QDRVRVER

2007-04-19 Thread David Milburn
Update the driver version reported by MEGAIOC_QDRVRVER to match LSI_COMMON_MOD_VERSION. Signed-off-by: David Milburn <[EMAIL PROTECTED]> --- drivers/scsi/megaraid/megaraid_mm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_mm.c b/driver

Re: [PATCH] add two SCSI command opcodes

2007-04-19 Thread Matthew Wilcox
On Thu, Apr 19, 2007 at 07:39:59PM +0300, Dan Aloni wrote: > On Thu, Apr 19, 2007 at 05:47:43PM +0200, Jan-Benedict Glaw wrote: > > Where's the user? > > A privately maintained kernel driver. > > Do we _must_ have in-tree users? I'd consider the change for completion's > sake. I agree with Dan -

Re: [PATCH] add two SCSI command opcodes

2007-04-19 Thread Dan Aloni
On Thu, Apr 19, 2007 at 05:47:43PM +0200, Jan-Benedict Glaw wrote: > On Thu, 2007-04-19 18:10:54 +0300, Dan Aloni <[EMAIL PROTECTED]> wrote: > > diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h > > index 5c0e979..dff842a 100644 > > --- a/include/scsi/scsi.h > > +++ b/include/scsi/scsi.h > > @

RE: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-19 Thread Cameron, Steve
Something like if (sizeof(blah) > 4) { do all the assignments with shifts } might be slighly better since the CDB is already zeroed by cmd_alloc() and doesn't need to be zeroed a 2nd time. -- steve -Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Thu 4/19/20

RE: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-19 Thread Miller, Mike (OS Dev)
> -Original Message- > From: James Bottomley [mailto:[EMAIL PROTECTED] > Sent: Thursday, April 19, 2007 11:22 AM > To: Miller, Mike (OS Dev) > Cc: Hisashi Hifumi; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [EMAIL PROTECTED]; > linux-scsi@vger.kernel.org; Cameron, Steve > Subject: RE: [PA

RE: [PATCH] cciss: Fix warnings during compilation under 32bit environment

2007-04-19 Thread James Bottomley
On Thu, 2007-04-19 at 16:12 +, Miller, Mike (OS Dev) wrote: > > > Nak. You still haven't told where you saw these warnings. What > > > compiler are you using? I do not see these in my 32-bit environment. > > > > I think it's seen with CONFIG_LBD=n on 32 bits > > > > In that configuration, se

Re: [PATCH] add two SCSI command opcodes

2007-04-19 Thread Jan-Benedict Glaw
On Thu, 2007-04-19 18:10:54 +0300, Dan Aloni <[EMAIL PROTECTED]> wrote: > diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h > index 5c0e979..dff842a 100644 > --- a/include/scsi/scsi.h > +++ b/include/scsi/scsi.h > @@ -103,6 +103,7 @@ extern const unsigned char scsi_command_size[8]; > #define

RE: [PATCH] cciss: Fix warnings during compilation under 32bit environment

2007-04-19 Thread Miller, Mike (OS Dev)
> -Original Message- > From: James Bottomley [mailto:[EMAIL PROTECTED] > Sent: Thursday, April 19, 2007 10:19 AM > To: Miller, Mike (OS Dev) > Cc: Hisashi Hifumi; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [EMAIL PROTECTED]; > linux-scsi@vger.kernel.org; Cameron, Steve > Subject: RE: [PA

[PATCH] add two SCSI command opcodes

2007-04-19 Thread Dan Aloni
Applies for 2.6.20.7 and beyond. Signed-off-by: Dan Aloni <[EMAIL PROTECTED]> diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h index 5c0e979..dff842a 100644 --- a/include/scsi/scsi.h +++ b/include/scsi/scsi.h @@ -103,6 +103,7 @@ extern const unsigned char scsi_command_size[8]; #define READ

RE: [PATCH] cciss: Fix warnings during compilation under 32bit environment

2007-04-19 Thread James Bottomley
On Thu, 2007-04-19 at 15:09 +, Miller, Mike (OS Dev) wrote: > Nak. You still haven't told where you saw these warnings. What compiler > are you using? I do not see these in my 32-bit environment. I think it's seen with CONFIG_LBD=n on 32 bits In that configuration, sector_t is a u32 (it's u64

RE: [PATCH] cciss: Fix warnings during compilation under 32bit environment

2007-04-19 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Hisashi Hifumi [mailto:[EMAIL PROTECTED] > Sent: Wednesday, April 18, 2007 2:03 AM > To: Miller, Mike (OS Dev); [EMAIL PROTECTED] > Subject: [PATCH] cciss: Fix warnings during compilation under > 32bit environment > > > Hi. > > I fixed following warnings

Re: [RFC][PATCH] fix for async scsi scan sysfs problem (resend)

2007-04-19 Thread Josef Bacik
On Thu, Apr 19, 2007 at 10:02:36AM -0400, James Bottomley wrote: > On Thu, 2007-04-19 at 09:25 -0400, Josef Bacik wrote: > > Looking through everything I came to the conclusion that we don't really > > need > > the scsi_sysfs_add_devices in scsi_finish_async_scan, which gets run > > everytime > >

Re: [RFC][PATCH] fix for async scsi scan sysfs problem (resend)

2007-04-19 Thread James Bottomley
On Thu, 2007-04-19 at 09:25 -0400, Josef Bacik wrote: > Looking through everything I came to the conclusion that we don't really need > the scsi_sysfs_add_devices in scsi_finish_async_scan, which gets run everytime > we do a do_scan_async. In doing the scanning, if we come upon anything we > will

[PATCH 1/1] ipr: Proper return codes for eh_dev_reset for SATA devices

2007-04-19 Thread Brian King
Currently ipr always returns success from eh_dev_reset when called for a SATA device. If ata_do_eh is unable to recover for some reason, this can result in commands that are still outstanding when ata_do_eh returns. Change ipr to verify no commands are outstanding before returning success. Signed

[RFC][PATCH] fix for async scsi scan sysfs problem (resend)

2007-04-19 Thread Josef Bacik
Hello, Resending this to a wider audience (thanks Andrew). I'm having a problem on the newest version of linus's git tree with my qla2xxx card. This is on a UP box, the problem doesn't happen on my similarly configured SMP box. When I unload and then try to load the qla2xxx driver again I ge