Re: qla2xxx BUG: workqueue leaked lock or atomic

2007-03-06 Thread Andrew Morton
On Wed, 28 Feb 2007 16:37:22 +0100 Andre Noll <[EMAIL PROTECTED]> wrote: > On 16:18, Andre Noll wrote: > > > With 2.6.21-rc2 I am unable to reproduce this BUG message. However, > > writing to both raid systems at the same time via lvm still locks up > > the system within minutes. > > Screenshot

Re: [PATCH 3/3] tgt: fix scsi command leak

2007-03-06 Thread FUJITA Tomonori
From: Douglas Gilbert <[EMAIL PROTECTED]> Subject: Re: [PATCH 3/3] tgt: fix scsi command leak Date: Mon, 05 Mar 2007 10:36:15 -0500 > >> What about an option for descriptor sense format? With SAT now > >> a standard, we now have one more reason to support > >> descriptor format when required. The

Re: WRITE BUFFER commands through SG_IO getting rounded up to sector past 32k

2007-03-06 Thread Mike Christie
Aravind Parchuri wrote: > In fact, even with the newer kernel, all commands smaller than 32k make > it through with the right size, which leads me to think it's something > to do with the scatter-gather list. I'm not particularly familiar with > the scsi code, but inside scsi_execute_async, in scsi

WRITE BUFFER commands through SG_IO getting rounded up to sector past 32k

2007-03-06 Thread Aravind Parchuri
While trying to fire WRITE BUFFER commands to an iscsi target, we found that if the command is larger than 32kB, it gets rounded up to the next sector before it reaches the LLD (in this case, open-iscsi). If this is expected behavior, please disregard the rest of the message. Unfortunately, I h

Re: improve sg_luns output for iscsi

2007-03-06 Thread Doug Maxey
On Tue, 06 Mar 2007 19:04:28 +0100, Olaf Hering wrote: > > Upcoming IBM pSeries firmware can boot from iscsi. To configure the > openfirmware boot-device string, we need to construct a correct > devicepath. This path includes the lun. Its currently not 100% clear > how exactly this lun value has

Re: improve sg_luns output for iscsi

2007-03-06 Thread Douglas Gilbert
Olaf Hering wrote: > Upcoming IBM pSeries firmware can boot from iscsi. To configure the > openfirmware boot-device string, we need to construct a correct > devicepath. This path includes the lun. Its currently not 100% clear > how exactly this lun value has to look like. > > sg_luns may be the to

improve sg_luns output for iscsi

2007-03-06 Thread Olaf Hering
Upcoming IBM pSeries firmware can boot from iscsi. To configure the openfirmware boot-device string, we need to construct a correct devicepath. This path includes the lun. Its currently not 100% clear how exactly this lun value has to look like. sg_luns may be the tool to get the value. But its c

Re: SG_IO inquiry...

2007-03-06 Thread Douglas Gilbert
MASTHAN DUDEKULA wrote: > Hi All, > > By using SG_IO ioctl How can we get device related info (like device > type--disk,tape,cdrom..etc) ? If you look at http://www.torque.net/sg/sg3_utils.html and fetch a tarball (e.g. sg3_utils-1.23.tgz) then have a look at the examples/sg_simple1.c file. Doug

Re: bug or typo in scsi_debug.c

2007-03-06 Thread Douglas Gilbert
Mark Harvey wrote: > Looking thru this driver, I saw what looks to be a bug/typo if an error > occurs when > calling driver_register() from scsi_debug_init() > > Cheers > Mark > > --- scsi_debug-orig.c 2007-03-03 19:38:23.0 +1100 > +++ scsi_debug.c2007-03-03 19:39:51.0 +

[patch 19/29] make seagate_st0x_detect() static

2007-03-06 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> seagate_st0x_detect() can become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/seagate.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/scsi/seagate.c~ma

[patch 18/29] drivers/scsi/qla4xxx/: possible cleanups

2007-03-06 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - make needlessly global code static - #if 0 unused functions Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Ravi Anand <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/qla4xxx/ql4_dbg.c |4 drivers/s

[patch 15/29] drivers/scsi/wd33c93.c: cleanups

2007-03-06 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - #include for getting the prototypes of {dis,en}able_irq() - make the needlessly global wd33c93_setup() static Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/wd33c93.c |4 +++- 1 file

[patch 22/29] drivers/scsi/aacraid/: cleanups

2007-03-06 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - proper prototypes for global code in aacraid.h - aac_rx_start_adapter() can now become static Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/aacraid/

[patch 02/29] drivers/scsi/advansys.c: cleanups

2007-03-06 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - remove the unneeded advansys.h - remove the unused advansys_setup() - make needlessly global functions static Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/advansys.c | 101 +++---

[patch 06/29] drivers/scsi/dpt_i2o.c: remove dead code

2007-03-06 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> The Coverity checker spotted this dead code introduced by commit a07f353701acae77e023f6270e8af353b37af7c4. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/dpt_i2o.c |2 -- 1 file changed,

[patch 03/29] megaraid: fix warnings when CONFIG_PROC_FS=n

2007-03-06 Thread akpm
From: walter harms <[EMAIL PROTECTED]> Signed-off-by: walter harms <[EMAIL PROTECTED]> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Cc: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c | 17 +++-- drivers/scsi/megara

[patch 13/29] drivers/scsi/aic7xxx/: make functions static

2007-03-06 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Hannes Reinecke <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/aic7xxx/aic79xx_osm.c |6 -- drivers/scsi/aic7xxx/aic79xx_osm.h |2 -- drivers/scsi/a

[patch 29/29] bug in gdth.c crashing machine

2007-03-06 Thread akpm
From: Joerg Dorchain <[EMAIL PROTECTED]> Undocumented... Signed-off-by: Joerg Dorchain <[EMAIL PROTECTED]> Acked-by: "Leubner, Achim" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/gdth.c |

[patch 01/29] drivers/scsi/: small cleanups

2007-03-06 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> This patch contains the following cleanups: - make needlessly global functions static - every file should #include the headers containing the prototypes for it's global functions Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PRO

[patch 23/29] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-03-06 Thread akpm
From: Richard Knutsson <[EMAIL PROTECTED]> Convert: FALSE -> false TRUE -> true Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/aic7xxx_old.c | 242 ++ drivers/scsi/aic7xxx_old/aic7xxx_proc.

[patch 17/29] Fix the reproducible oops in scsi

2007-03-06 Thread akpm
From: OGAWA Hirofumi <[EMAIL PROTECTED]> I got the oops after some hotplug events. And the similar oops can reproduce by the following step. plug usb-storage (e.g. scsi_host of usb is "host5", and device is sde) # mount /dev/sde1 /mnt # echo 1 > /sys/block/sde/device/delete # echo - -

[patch 25/29] Fix |/|| confusion in fusion driver

2007-03-06 Thread akpm
From: Dirk Mueller <[EMAIL PROTECTED]> This patch corrects a |/|| confusion in mptscsih_copy_sense_data. Using || means that the data that ends up being written is (almost always) 1, instead of being bit-wise or'ed. Cc: Eric Moore <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signe

[patch 28/29] fusion kernel-doc warning fixes

2007-03-06 Thread akpm
From: Randy Dunlap <[EMAIL PROTECTED]> Fix kernel-doc warnings in fusion driver code. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> Acked-by: "Moore, Eric Dean" <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/message/fus

[patch 20/29] Remove some unused SCSI-related kernel config variables.

2007-03-06 Thread akpm
From: "Robert P. J. Day" <[EMAIL PROTECTED]> Remove the unused SCSI-related kernel config variables SCSI_NCR53C8XX_PROFILE_SUPPORT SCSI_NCR53C8XX_PROFILE 53C700_IO_MAPPED AIC79XX_ENABLE_RD_STRM AIC7XXX_PROBE_EISA_VL Signed-off-by: Robert P. J. Day <[EMAIL

[patch 16/29] scsi: cover up bugs^W^W^WFix up compiler warnings in megaraid driver

2007-03-06 Thread akpm
From: Martin Bligh <[EMAIL PROTECTED]> Fix up compiler warnings in megaraid driver [EMAIL PROTECTED]: build fix] Signed-off-by: Martin J. Bligh <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c | 22 +++

[patch 24/29] cleanup variable usage in mesh interrupt handler

2007-03-06 Thread akpm
From: Olaf Hering <[EMAIL PROTECTED]> _ convert void* to struct mesh_state* - remove unused irq argument from mesh_interrupt() Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/mesh.c | 14

[patch 21/29] SCSI: Fix obvious typo "spin_lock_irqrestore()" in gdth.c

2007-03-06 Thread akpm
From: "Robert P. J. Day" <[EMAIL PROTECTED]> Fix misspelled "spin_lock_irqrestore" to read "spin_unlock_irqrestore" instead. Presumably, GDTH_RTC doesn't get used a lot. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off

[patch 26/29] scsi: megaraid_sas - throttle io if cmds are in risk of being timed-out

2007-03-06 Thread akpm
From: Sumant Patro <[EMAIL PROTECTED]> Driver to throttle IO to reduce risk of OS timing out cmds. Implemented a circular queue to keep track of pending OS cmds in FW. This queue is periodically (every 10 sec) checked by a timer routine. If there is any cmd that is in risk of getting timed-out by

[patch 12/29] drivers/scsi/mca_53c9x.c : save_flags()/cli() removal

2007-03-06 Thread akpm
From: Amol Lad <[EMAIL PROTECTED]> Replaced save_flags()/cli() with spin_lock alternatives [EMAIL PROTECTED]: no longer BROKEN_ON_SMP] Signed-off-by: Amol Lad <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Cc: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTE

[patch 10/29] drivers/scsi/megaraid.c: Replacing yield() with a better alternative

2007-03-06 Thread akpm
From: Amol Lad <[EMAIL PROTECTED]> For this driver cond_resched() seems to be a better alternative Signed-off-by: Amol Lad <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN drive

[patch 11/29] scsi: whitespace cleanup in the dpt driver

2007-03-06 Thread akpm
From: Henne <[EMAIL PROTECTED]> Remove some trailing whitespaces and some replace whitespaces with tabs. Signed-off-by: Henrik Kretzschmar <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/dpt/dpti_i2o.h | 48 drivers/scsi

[patch 14/29] sym53c8xx_2 claims cpqarray device

2007-03-06 Thread akpm
From: Chip Coldwell <[EMAIL PROTECTED]> Apropos this thread http://marc.theaimsgroup.com/?l=linux-scsi&m=115591706804045&w=2 which led to this patch http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-rc-fixes-2.6.git;a=commit;h=b2b3c121076961333977f485f0d54c22121df920 do we not also need

[patch 04/29] scsi: remove unnecessary check in drivers/scsi/sg.c

2007-03-06 Thread akpm
From: Eric Sesterhenn <[EMAIL PROTECTED]> coverity spotted this (cid #758). All callers dereference sfp, so we dont need this check. In addition to this, we dereference it earlier in the function. Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]> Cc: Douglas Gilbert <[EMAIL PROTECTED]> Cc: Jam

[patch 07/29] MPT fusion: handle PCI layer error on resume

2007-03-06 Thread akpm
From: Jeff Garzik <[EMAIL PROTECTED]> In the unlikely event of pci_enable_device() failure during resume, we do the minimalist solution and simply exit, rather than continuing to enable the hardware. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Cc: "Moore, Eric Dean" <[EMAIL PROTECTED]> Cc: Jam

[patch 08/29] MPT fusion: handle mpt_resume() failure while resuming

2007-03-06 Thread akpm
From: Dmitriy Monakhov <[EMAIL PROTECTED]> Since mpt-fusion-handle-pci-layer-error-on-resume.patch function mpt_resume() can return error code. Signed-off-by: Monakhov Dmitriy <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: "Moore, Eric Dean" <[EMAIL PROTECTED]> Cc: James Bottomley <[

[patch 09/29] drivers/scsi/NCR5380.c: Replacing yield() with a better alternative

2007-03-06 Thread akpm
From: Amol Lad <[EMAIL PROTECTED]> Replaced yield() with cond_resched() Signed-off-by: Amol Lad <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/NCR5380.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[patch 05/29] pci_module_init() convertion in tmscsim.c

2007-03-06 Thread akpm
From: Henrik Kretzschmar <[EMAIL PROTECTED]> pci_module_init() convertion in tmscsim.c Signed-off-by: Henrik Kretzschmar <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/tmscsim.c |6 -- 1 file changed, 4 insert