Re: end to end error recovery musings

2007-02-28 Thread H. Peter Anvin
James Bottomley wrote: On Wed, 2007-02-28 at 12:42 -0500, Martin K. Petersen wrote: 4104. It's 8 bytes per hardware sector. At least for T10... Er ... that won't look good to the 512 ATA compatibility remapping ... Well, in that case you'd only see 8x512 data bytes, no metadata...

[PATCH 1/7] flush iscsi work before freeing connection

2007-02-28 Thread michaelc
From: Mike Christie <[EMAIL PROTECTED]> It's possible that we call iscsi_xmitworker after iscsi_conn_release which causes a oops. This patch flushes the workqueue. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> Signed-off-by: Mike Christie <[EMAIL PROTECTED]> --- drivers/scsi/libiscsi.c |

[PATCH 2/7] clear mtask

2007-02-28 Thread michaelc
From: Mike Christie <[EMAIL PROTECTED]> Consolidate the mtask clearing code. Signed-off-by: Mike Christie <[EMAIL PROTECTED]> --- drivers/scsi/libiscsi.c | 19 --- 1 files changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c i

[PATCH 6/7] Increase iscsi tcp max_sectors

2007-02-28 Thread michaelc
From: Mike Christie <[EMAIL PROTECTED]> For a while now, the block layer has seperated max sectors and max hw sectors. Software iscsi has no limit so this patch increases max hw sectors, so we can support large pass through commands. Signed-off-by: Mike Christie <[EMAIL PROTECTED]> --- drivers/sc

[PATCH 7/7] Print useful error message when iscsi crc23c allocation fails

2007-02-28 Thread michaelc
From: Mike Christie <[EMAIL PROTECTED]> People do not read the README and seem to like to unselect the crc32c module even though iscsi_tcp selects it for them. This patch spits a error that tells the user that they really do need the module. Hopefully, we will get less people asking about this now

[PATCH 5/7] use get_unaligned

2007-02-28 Thread michaelc
From: Mike Christie <[EMAIL PROTECTED]> Dave Miller meantioned that the data buffer in a past sense fixup patch was not gauranteed to be aligned properly for ia64. This patch has libiscsi use get_unalinged to make sure. There are a couple more places in the digest handling we may need to do this,

[PATCH 4/7] use atomic for session_nr allocations

2007-02-28 Thread michaelc
From: Mike Christie <[EMAIL PROTECTED]> qla4xxx and iscsi_tcp or iser could be creating sessions at the same time, so make session_nr id allocation atomic. Signed-off-by: Mike Christie <[EMAIL PROTECTED]> --- drivers/scsi/scsi_transport_iscsi.c |6 -- 1 files changed, 4 insertions(+), 2 d

[PATCH 3/7] rename DEFAULT_MAX_RECV_DATA_SEGMENT_LENGTH

2007-02-28 Thread michaelc
From: Mike Christie <[EMAIL PROTECTED]> This patch renames DEFAULT_MAX_RECV_DATA_SEGMENT_LENGTH to avoid confusion with the drivers default values (DEFAULT_MAX_RECV_DATA_SEGMENT_LENGTH is the iscsi RFC specific default). Signed-off-by: Mike Christie <[EMAIL PROTECTED]> --- drivers/infiniband/ulp/

iscsi bugfixes and small cleanups

2007-02-28 Thread michaelc
The following patches are some small bug fixes or cleanups we have had in our tree. The patches are not critical and could just go into scsi-misc. The patches are also small and not adding features so I guess they could also go to scsi-rc-fixes if more patches are being sent for 2.6.21. The patche

Re: [PATCH] SCSI: Update ASC list and make it const

2007-02-28 Thread Daniel J. Priem
"Martin K. Petersen" <[EMAIL PROTECTED]> writes: >> "Daniel" == Daniel J Priem <[EMAIL PROTECTED]> writes: > > Daniel> - * http://www.t10.org/lists/asc-num.txt+ */ > Daniel> + * http://www.t10.org/lists/asc-num.txt */ > > Daniel> its a typo. > > The diff looks fine both here and in the arch

Re: [PATCH] SCSI: Update ASC list and make it const

2007-02-28 Thread Martin K. Petersen
> "Daniel" == Daniel J Priem <[EMAIL PROTECTED]> writes: Daniel> - * http://www.t10.org/lists/asc-num.txt+ */ Daniel> + * http://www.t10.org/lists/asc-num.txt */ Daniel> its a typo. The diff looks fine both here and in the archives. Maybe your mailer mangled it? -- Martin K. Petersen

Re: end to end error recovery musings

2007-02-28 Thread James Bottomley
On Wed, 2007-02-28 at 12:42 -0500, Martin K. Petersen wrote: > 4104. It's 8 bytes per hardware sector. At least for T10... Er ... that won't look good to the 512 ATA compatibility remapping ... James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a mess

Re: [PATCH] SCSI: Update ASC list and make it const

2007-02-28 Thread Daniel J. Priem
"Martin K. Petersen" <[EMAIL PROTECTED]> writes: > + * The canonical list of T10 Additional Sense Codes is available at: > + * http://www.t10.org/lists/asc-num.txt+ */ Please do a - * http://www.t10.org/lists/asc-num.txt+ */ + * http://www.t10.org/lists/asc-num.txt */ its a typo. Regards Daniel

Re: end to end error recovery musings

2007-02-28 Thread Martin K. Petersen
> "James" == James Bottomley <[EMAIL PROTECTED]> writes: James> However, I could see the SATA manufacturers selling capacity at James> 512 (or the new 4096) sectors but allowing their OEMs to James> reformat them 520 (or 4160) 4104. It's 8 bytes per hardware sector. At least for T10... --

Re: [PATCH] SCSI: Update ASC list

2007-02-28 Thread Michael Tokarev
Martin K. Petersen wrote: [] > --- scsi-misc-2.6.orig/drivers/scsi/constants.c > +++ scsi-misc-2.6/drivers/scsi/constants.c [] > static struct error_info additional[] = static CONST struct error_info additional[]... ? > { > {0x, "No additional sense information"}, [] /mjt - To unsubsc

[PATCH] SCSI: Update ASC list and make it const

2007-02-28 Thread Martin K. Petersen
Add missing additional sense code and provide pointer to upstream reference (from Doug Gilbert). Add missing const (from Michael Tokarev). Signed-off-by: Martin K. Petersen <[EMAIL PROTECTED]> --- constants.c |7 ++- 1 files changed, 6 insertions(+), 1 deletion(-) Index: scsi-misc-

Re: [PATCH] SCSI: Update ASC list

2007-02-28 Thread Martin K. Petersen
> "Michael" == Michael Tokarev <[EMAIL PROTECTED]> writes: Michael> static CONST struct error_info additional[]... ? Good spotting - updated patch coming... -- Martin K. Petersen Oracle Linux Engineering - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the bod

Re: end to end error recovery musings

2007-02-28 Thread James Bottomley
On Wed, 2007-02-28 at 12:16 -0500, Martin K. Petersen wrote: > It's cool that it's on the radar in terms of the protocol. > > That doesn't mean that drive manufacturers are going to implement it, > though. The ones I've talked to were unwilling to sacrifice capacity > because that's the main co

RE: end to end error recovery musings

2007-02-28 Thread Martin K. Petersen
> "Eric" == Moore, Eric <[EMAIL PROTECTED]> writes: [Trimmed the worldwide broadcast CC: list down to linux-scsi] Eric> I from the scsi lld perspective, all we need 32 byte cdbs, and a Eric> mechinism to pass the tags down from above. Ok, so your board only supports Type 2 protection? Er

Re: end to end error recovery musings

2007-02-28 Thread Martin K. Petersen
> "Doug" == Douglas Gilbert <[EMAIL PROTECTED]> writes: Doug> Work on SAT-2 is now underway and one of the agenda items is Doug> "end to end data protection" and is in the hands of the t13 Doug> ATA8-ACS technical editor. So it looks like data integrity is on Doug> the radar in the SATA world.

[PATCH] SCSI: Update ASC list

2007-02-28 Thread Martin K. Petersen
Add missing additional sense code and provide pointer to upstream reference (from Doug Gilbert). Signed-off-by: Martin K. Petersen <[EMAIL PROTECTED]> --- constants.c |5 + 1 files changed, 5 insertions(+) Index: scsi-misc-2.6/drivers/scsi/constants.c ===

Re: [PATCH 0/4] SCSI: Printing cleanups

2007-02-28 Thread Martin K. Petersen
> "Doug" == Douglas Gilbert <[EMAIL PROTECTED]> writes: Doug> If you need to revise anything, perhaps you could add a comment Doug> with this url near the list of additional sense codes: Doug> http://www.t10.org/lists/asc-num.txt Oh, that's super helpful. Much easier than searching the SPC d

Re: qla2xxx BUG: workqueue leaked lock or atomic

2007-02-28 Thread Andre Noll
On 16:18, Andre Noll wrote: > With 2.6.21-rc2 I am unable to reproduce this BUG message. However, > writing to both raid systems at the same time via lvm still locks up > the system within minutes. Screenshot of the resulting kernel panic: http://systemlinux.org/~maan/shots/kernel-panic-

RE: end to end error recovery musings

2007-02-28 Thread Moore, Eric
On Tuesday, February 27, 2007 12:07 PM, Martin K. Petersen wrote: > > Not sure you're up-to-date on the T10 data integrity feature. > Essentially it's an extension of the 520 byte sectors common in disk > arrays. For each 512 byte sector (or 4KB ditto) you get 8 bytes of > protection data. Ther

Re: qla2xxx BUG: workqueue leaked lock or atomic

2007-02-28 Thread Andre Noll
On 10:51, Andrew Vasquez wrote: > On Tue, 27 Feb 2007, Andre Noll wrote: > > [ 68.532665] BUG: at kernel/lockdep.c:1860 trace_hardirqs_on() > > Ok, since 2.6.20, there been a patch added to qla2xxx which drops the > spin_unlock_irq() call while attempting to ramp-up the queue-depth: > > Could y

Re: end to end error recovery musings

2007-02-28 Thread Douglas Gilbert
Martin K. Petersen wrote: >> "Alan" == Alan <[EMAIL PROTECTED]> writes: > >>> Not sure you're up-to-date on the T10 data integrity feature. >>> Essentially it's an extension of the 520 byte sectors common in >>> disk > > [...] > > Alan> but here's a minor bit of passing bad news - quite a f

[PATCH] aacraid: Use DMA_31BIT_MASK

2007-02-28 Thread Tobias Klauser
Use constants from linux/dma-mapping.h for pci_set_dma_mask() and pci_set_consistent_dma_mask() Signed-off-by: Tobias Klauser <[EMAIL PROTECTED]> --- drivers/scsi/aacraid/commsup.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aacraid/commsup.c b/drive