Re: [Patch 2/2] cciss: add reboot notifier support to driver

2007-02-21 Thread Christoph Hellwig
On Wed, Feb 21, 2007 at 03:12:51PM -0600, Mike Miller (OS Dev) wrote: > Patch 2/2 > > This patch adds reboot_notifier support to cciss. Changes in firmware make > this patch > essential. Without this patch there may be valid data left in the > controller's battery > backed write cache (BBWC) on

Re: [Patch 2/2] cciss: add reboot notifier support to driver

2007-02-21 Thread Andrew Morton
On Wed, 21 Feb 2007 15:12:51 -0600 "Mike Miller (OS Dev)" <[EMAIL PROTECTED]> wrote: > @@ -3293,6 +3327,12 @@ #endif > ((hba[i]->nr_cmds + BITS_PER_LONG - >1) / BITS_PER_LONG) * sizeof(unsigned long)); > > + if (notify_count == 0) { > + register_rebo

Re: [Patch 1/2] cciss: fix for 2TB support

2007-02-21 Thread Andrew Morton
On Wed, 21 Feb 2007 15:10:39 -0600 "Mike Miller (OS Dev)" <[EMAIL PROTECTED]> wrote: > Patch 1/2 > > This patch changes the way we determine if a logical volume is larger than > 2TB. The > original test looked for a total_size of 0. Originally we added 1 to the > total_size. > That would make

Re: [PATCH] qla2xxx: fix RSCN handling on big-endian systems

2007-02-21 Thread malahal
I have JBOD in FL-port and if I unplug the cable or disable the switch port, the qla2xxx driver doesn't fail the I/O soon. The remote port status is 'online' all the time. The I/O's usually timeout after the usual scsi timeout. Based on the existing structure, al_pa is at the lowest addressed byte,

RE: [PATCH] qla2xxx: fix RSCN handling on big-endian systems

2007-02-21 Thread Seokmann Ju
On Monday, February 19, 2007 10:19 AM, Malahal Naineni wrote: > qla2xxx driver fails to handle RSCN events affecting area or > domain due to an endian issue on big endian systems. This > fixes the port_id_t structure on big endian systems. Can you provide more details on the fails you are getti

Re: Please help if u can.

2007-02-21 Thread Aravind Parchuri
[EMAIL PROTECTED] wrote: John Scarpa wrote: First a very big thanks to all of u! I have been suffering a serious lack of sleep problem lately.. i should have noticed that by whom has been submitting the past 500 fixes and updates! Quick question, is the driver still consider experimental??

[Patch 2/2] cciss: add reboot notifier support to driver

2007-02-21 Thread Mike Miller (OS Dev)
Patch 2/2 This patch adds reboot_notifier support to cciss. Changes in firmware make this patch essential. Without this patch there may be valid data left in the controller's battery backed write cache (BBWC) on shutdown. We found out the hard way that the kernel does not call our cleanup routi

[Patch 1/2] cciss: fix for 2TB support

2007-02-21 Thread Mike Miller (OS Dev)
Patch 1/2 This patch changes the way we determine if a logical volume is larger than 2TB. The original test looked for a total_size of 0. Originally we added 1 to the total_size. That would make our read_capacity return size 0 for >2TB lv's. We assumed that we could not have a lv size of 0 so i

Re: Please help if u can.

2007-02-21 Thread Darrick J. Wong
John Scarpa wrote: > First a very big thanks to all of u! I have been suffering a serious > lack of sleep problem lately.. i should have noticed that by whom has > been submitting the past 500 fixes and updates! > > Quick question, is the driver still consider experimental?? Very much so. The S

Re: Please help if u can.

2007-02-21 Thread John Scarpa
First a very big thanks to all of u! I have been suffering a serious lack of sleep problem lately.. i should have noticed that by whom has been submitting the past 500 fixes and updates! Quick question, is the driver still consider experimental?? the guys i work with say it doesn't support sa

Re: initio.h header user confusion

2007-02-21 Thread Srdjan Todorovic
On Wed, 21 Feb 2007, James Bottomley wrote: > On Wed, 2007-02-21 at 16:12 +, Srdjan Todorovic wrote: > > I'm working on a set of patches for the initio scsi driver and I found > > some strangeness with its header file, initio.h. I noticed that > > sun3_scsi.c and sun3_scsi_vme.c include the he

Re: program inquiry is using a deprecated scsi_ioctl , please convert it to SG_IO

2007-02-21 Thread James Bottomley
If you want help, please don't drop linux-scsi. On Wed, 2007-02-21 at 12:03 +0530, MASTHAN DUDEKULA wrote: > Thanks for your reply. > > I have one question to you. > Can you please answetr this one ? > What is SG_IO equivalent of SCSI_IOCTL_SCSI_COMMAND on sd devices ? > > In otherwords How ca

Re: initio.h header user confusion

2007-02-21 Thread James Bottomley
On Wed, 2007-02-21 at 16:12 +, Srdjan Todorovic wrote: > I'm working on a set of patches for the initio scsi driver and I found > some strangeness with its header file, initio.h. I noticed that > sun3_scsi.c and sun3_scsi_vme.c include the header, and it uses defines > such as SCSI_ABORT_SNOOZE

Re: initio.h header user confusion

2007-02-21 Thread Matthew Wilcox
On Wed, Feb 21, 2007 at 04:36:59PM +, Srdjan Todorovic wrote: > I'll recheck the other drivers then. It would seem the only users then > are initio and sun3*. What's the best thing to do about it? > Should I keep things as they are with SCSI_ABORT_* or should I > move them to include/scsi/ or s

Re: initio.h header user confusion

2007-02-21 Thread Srdjan Todorovic
On Wed, 21 Feb 2007, Matthew Wilcox wrote: > On Wed, Feb 21, 2007 at 04:12:06PM +, Srdjan Todorovic wrote: > > So how is it possible that other drivers such as aha1542.c use these > > defines? > > Possibly, they don't. I just looked at the ncr53c8xx driver, and the > only uses of SCSI_ABORT

Re: initio.h header user confusion

2007-02-21 Thread Matthew Wilcox
On Wed, Feb 21, 2007 at 04:12:06PM +, Srdjan Todorovic wrote: > So how is it possible that other drivers such as aha1542.c use these defines? Possibly, they don't. I just looked at the ncr53c8xx driver, and the only uses of SCSI_ABORT_* are inside an #if 0 block. The same is true for aha1542

initio.h header user confusion

2007-02-21 Thread Srdjan Todorovic
Hi, I'm working on a set of patches for the initio scsi driver and I found some strangeness with its header file, initio.h. I noticed that sun3_scsi.c and sun3_scsi_vme.c include the header, and it uses defines such as SCSI_ABORT_SNOOZE (defined in initio.h). I did some grepping and am now confus

zfcp: fix likely/unlikely usage

2007-02-21 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> zfcp_fsf_protstatus_eval() takes always the 'wrong' branch. Likely Profiling Results - [+- ] Type | # True | # False | Function:[EMAIL PROTECTED] +unlikely | 11042|0 zfcp_fsf_protstatus_e