Re: [PATCH] scsi_debug: illegal blocking memory allocation

2007-01-03 Thread Douglas Gilbert
Jens Axboe wrote: > Hi Doug, > > resp_inquiry() does a GFP_KERNEL memory allocation, but it's not allowed > to from the queuecommand context. There's no good way to return this > error, so I used DID_ERROR which is used from similar paths. That > doesn't seem quite right though, it would be better

megaraid_sas xscale interrupt mask?

2007-01-03 Thread Joe Malicki
Hi Sumant, While trying to debug Dell PERC 5/i RAID controller problems we've been having with the megaraid_sas driver, we've been inspecting differences between the Red Hat EL 4 kernel (which Dell officially supports) versus the stock Linux 2.6.17.13 driver we use. We found a very interesting ch

Re: [PATCH] SCSI, libata: add support for ATA_16 commands to libata ATAPI devices

2007-01-03 Thread Mark Lord
James Bottomley wrote: As I read the code Mark sent me, current libata will only accept ATA_16 for ATAPI devices (whether type 5 or not) ... pehaps this needs to be altered? It could be. Both ATA_12 and ATA_16 are just ways of getting a taskfile sent down to the LLD, and ATA_12 is merely a re

RE: [PATCH] Fix race condition between scsi scan and sdev block/unblock

2007-01-03 Thread Bino . Sebastian
NACK this patch. Reason for NACK : Upstream code in the sdev state change routine validates the state change and returns success when old state and new state are same and this result in unblocking the request queue correctly in scsi_internal_device_unblock function, which is not what is describe

Re: [PATCH 5/5] lpfc : Make Emulex lpfc driver legacy I/O port free

2007-01-03 Thread James Bottomley
On Wed, 2007-01-03 at 14:23 -0800, Andrew Morton wrote: > > drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_pci_probe_one': > > drivers/scsi/lpfc/lpfc_init.c:1418: warning: implicit declaration of > > function 'pci_select_bars' > > drivers/scsi/lpfc/lpfc_init.c:1422: warning: implicit declaration

Re: [PATCH 5/5] lpfc : Make Emulex lpfc driver legacy I/O port free

2007-01-03 Thread Andrew Morton
On Wed, 03 Jan 2007 16:06:48 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Wed, 2006-11-22 at 10:44 -0500, James Smart wrote: > > ACK :) > > > > (I thought this had already gone in a while ago) > > Actually, there seems to be missing infrastructure for this: > > CC [M] drivers/scsi/

Re: [PATCH 5/5] lpfc : Make Emulex lpfc driver legacy I/O port free

2007-01-03 Thread James Bottomley
On Wed, 2006-11-22 at 10:44 -0500, James Smart wrote: > ACK :) > > (I thought this had already gone in a while ago) Actually, there seems to be missing infrastructure for this: CC [M] drivers/scsi/lpfc/lpfc_init.o drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_pci_probe_one': drivers/scsi/

Re: [PATCH] SCSI, libata: add support for ATA_16 commands to libata ATAPI devices

2007-01-03 Thread James Bottomley
On Wed, 2007-01-03 at 14:39 -0500, Douglas Gilbert wrote: > James Bottomley wrote: > > Those send out taskfile commands ... my point is that the SAT SCSI > > commands only come down the SCSI paths, so without additional processing > > in the ATAPI path they're just packaged up as PACKET commands an

Re: [PATCH] SCSI, libata: add support for ATA_16 commands to libata ATAPI devices

2007-01-03 Thread Douglas Gilbert
James Bottomley wrote: > On Wed, 2007-01-03 at 00:42 -0500, Mark Lord wrote: >> James Bottomley wrote: >>> I don't think I quite understand what you're trying to do here. My >>> understanding is that ATA_12 and ATA_16 are part of the SAT layer. i.e. >>> they're used when we're speaking SCSI to an

Re: [PATCH] scsi: lpfc error path fix

2007-01-03 Thread James Smart
ACK -- james Mariusz Kozlowski wrote: Hello, Add kmalloc failure check and fix the loop on error path. Without the patch pool element at index [0] will not be freed. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/lpfc/lpfc_mem.c |6 +- 1 file changed, 5 in

Re: [PATCH] SCSI, libata: add support for ATA_16 commands to libata ATAPI devices

2007-01-03 Thread Mark Lord
James Bottomley wrote: Er I've only seen one patch ... I did ask if there was another to add the ATA_16 interpretation ... did that get lost by the SCSI reflector? Ahh.. my apologies on that, James. The two patches apply and build independently, and the second patch was only for libata, so it

Re: [PATCH] convert sg dio to use the block layer functions

2007-01-03 Thread Mike Christie
FUJITA Tomonori wrote: > This patch makes sg dio use the block layer functions > (blk_rq_map_user, blk_execute_rq_nowait, etc). It's an updated version > of the following patch: > > http://marc.theaimsgroup.com/?l=linux-scsi&m=116527334121826&w=2 > > This doesn't break any existing features. Whil

Re: [PATCH] SCSI, libata: add support for ATA_16 commands to libata ATAPI devices

2007-01-03 Thread James Bottomley
On Wed, 2007-01-03 at 10:45 -0500, Jeff Garzik wrote: > James Bottomley wrote: > > On Wed, 2007-01-03 at 00:42 -0500, Mark Lord wrote: > >> James Bottomley wrote: > >>> I don't think I quite understand what you're trying to do here. My > >>> understanding is that ATA_12 and ATA_16 are part of the

Re: [PATCH] SCSI, libata: add support for ATA_16 commands to libata ATAPI devices

2007-01-03 Thread Jeff Garzik
James Bottomley wrote: On Wed, 2007-01-03 at 00:42 -0500, Mark Lord wrote: James Bottomley wrote: I don't think I quite understand what you're trying to do here. My understanding is that ATA_12 and ATA_16 are part of the SAT layer. i.e. they're used when we're speaking SCSI to an underlying AT

Re: [PATCH] SCSI, libata: add support for ATA_16 commands to libata ATAPI devices

2007-01-03 Thread James Bottomley
On Wed, 2007-01-03 at 00:42 -0500, Mark Lord wrote: > James Bottomley wrote: > > I don't think I quite understand what you're trying to do here. My > > understanding is that ATA_12 and ATA_16 are part of the SAT layer. i.e. > > they're used when we're speaking SCSI to an underlying ATA device to >

[PATCH] scsi_debug: illegal blocking memory allocation

2007-01-03 Thread Jens Axboe
Hi Doug, resp_inquiry() does a GFP_KERNEL memory allocation, but it's not allowed to from the queuecommand context. There's no good way to return this error, so I used DID_ERROR which is used from similar paths. That doesn't seem quite right though, it would be better to return an error indicating

[PATCH] convert sg dio to use the block layer functions

2007-01-03 Thread FUJITA Tomonori
This patch makes sg dio use the block layer functions (blk_rq_map_user, blk_execute_rq_nowait, etc). It's an updated version of the following patch: http://marc.theaimsgroup.com/?l=linux-scsi&m=116527334121826&w=2 This doesn't break any existing features. While it converts sg dio to use the block