James Bottomley wrote:
..
I don't think I quite understand what you're trying to do here. My
understanding is that ATA_12 and ATA_16 are part of the SAT layer. i.e.
they're used when we're speaking SCSI to an underlying ATA device to
send taskfiles. However, ATAPI devices don't use SAT ... ever
Thanks for the review.
I will resubmit the patch.
Regards,
Sumant
-Original Message-
From: Randy Dunlap [mailto:[EMAIL PROTECTED]
Sent: Friday, December 29, 2006 1:38 PM
To: Patro, Sumant
Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED];
linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.or
Being the Application Client, SCSI Core needs entry points
for SCSI Event notifications.
For example, Transport Reset event notification entry is
nowhere to be found. Although to be fare, for this to exist,
SCSI Core needs to have a concept of SCSI Port and it doesn't
have that.
Currently, SCSI
On Tue, 2007-01-02 at 19:35 -0500, Mark Lord wrote:
> In an ideal world, we would use the existing ATA_12 opcode
> to issue 12-byte ATA passthrough commands for libata ATAPI drives
> from userspace.
>
> But ATA_12 happens to have the same SCSI opcode value as the older
> CD/RW "BLANK" command, wid
In an ideal world, we would use the existing ATA_12 opcode
to issue 12-byte ATA passthrough commands for libata ATAPI drives
from userspace.
But ATA_12 happens to have the same SCSI opcode value as the older
CD/RW "BLANK" command, widely used by cdrecord and friends.
So, to achieve ATA passthru c
With recent kernels (and possibly much older ones, too),
ioctl() calls for ATAPI devices never make it to the driver layers.
The reason for this is a borked return code test in drivers/scsi/sr.c.
This patch fixes it.
Signed-off-by: Mark Lord <[EMAIL PROTECTED]>
---
--- old/drivers/scsi/sr.c
Jeff Garzik wrote:
Mark Lord wrote:
...
ret = cdrom_ioctl(file, &cd->cdi, inode, cmd, arg);
-if (ret != ENOSYS)
+if (ret != -ENOSYS)
I think Tejun posted the same patch earlier today.
Ahh.. missed it -- could have saved me an hour or two of debugging!
Cheers!
-
To unsubscribe
Mark Lord wrote:
With recent kernels (and possibly much older ones, too),
ioctl() calls for ATAPI devices never make it to the driver layers.
The reason for this is a borked return code test in drivers/scsi/sr.c.
This patch fixes it.
Signed-off-by: Mark Lord <[EMAIL PROTECTED]>
---
--- old/dr
Hello!
I'm trying to upgrade my kernel from 2.6.15, but my external RAID drops back to
5 MB/s due to domain validation errors. With my current kernel 2.6.15 the
performance is OK.
Here are the details:
- kernel: 2.6.15-1-686 i686 GNU/Linux
- kernel driver: sym53c8xx - 2.2.1
- hostadapter: L
All per-device queueing is handled by the scsi midlayer for quite
a while so we can remove the code to deal with it. It has been
completly disabled at the cpp level already.
Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
Index: linux-2.6/drivers/scsi/sym53c8xx_2/sym_glue.h
===
Merge sym_queue_command, sym_setup_cdb and sym_setup_data_and_start into
sym53c8xx_queue_command. Rename sym_queue_scsiio into sym_init_scsiio
now that it doesn't start I/O anymore but is simply a helper for
sym53c8xx_queue_command.
Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
Index: sc
On Wed, Jan 03, 2007 at 12:02:20AM +0900, FUJITA Tomonori wrote:
> > > blk_fill_sghdr_rq doesn't work for SG v4 so verify_command needed to
> > > be exported.
> >
> > So fixup blk_fill_sghdr_rq to deal with SG v4 aswell. We really
> > need to support all SGv4 features in the core code - bsg shoul
On Tue, 2 Jan 2007, Christoph Hellwig wrote:
On Tue, Dec 12, 2006 at 02:26:00PM +0100, Christoph Hellwig wrote:
On Tue, Dec 12, 2006 at 11:38:42AM +0100, Christoph Hellwig wrote:
This is because the packet driver tries to send down read/write
BLOCK_PC commands that don't use a bio and do not u
From: Christoph Hellwig <[EMAIL PROTECTED]>
Subject: Re: [PATCH 1/3] block: export blk_verify_command for SG v4
Date: Tue, 2 Jan 2007 11:49:16 +
> On Sat, Dec 16, 2006 at 12:18:23AM +0900, FUJITA Tomonori wrote:
> > blk_fill_sghdr_rq doesn't work for SG v4 so verify_command needed to
> > be ex
On Tue, Jan 02 2007, Christoph Hellwig wrote:
> On Tue, Jan 02, 2007 at 01:34:18PM +0100, Jens Axboe wrote:
> > On Tue, Jan 02 2007, Christoph Hellwig wrote:
> > > This gets a little offtopic for the original issue, so let's cut the Cc
> > > list and change the subject.
> > >
> > > On Tue, Dec 12,
On Tue, Jan 02, 2007 at 01:34:18PM +0100, Jens Axboe wrote:
> On Tue, Jan 02 2007, Christoph Hellwig wrote:
> > This gets a little offtopic for the original issue, so let's cut the Cc
> > list and change the subject.
> >
> > On Tue, Dec 12, 2006 at 04:21:23PM +0200, Boaz Harrosh wrote:
> > > I'm a
On Tue, Jan 02 2007, Christoph Hellwig wrote:
> This gets a little offtopic for the original issue, so let's cut the Cc
> list and change the subject.
>
> On Tue, Dec 12, 2006 at 04:21:23PM +0200, Boaz Harrosh wrote:
> > I'm afraid this might not be enough because of code in
> > drivers/ide/ide-c
On Tue, Dec 12, 2006 at 02:26:00PM +0100, Christoph Hellwig wrote:
> On Tue, Dec 12, 2006 at 11:38:42AM +0100, Christoph Hellwig wrote:
> > This is because the packet driver tries to send down read/write
> > BLOCK_PC commands that don't use a bio and do not use sg lists.
> > As part of the patch yo
scsi_retry_command only has a single caller, so there is no point
in having this function. Additionally the memset of the sense
buffer it does is entirely superflous as scsi_request_fn already
calls scsi_init_cmd_errh to perform this memset before the command
is reissued.
Signed-off-by: Christop
On Mon, Dec 11, 2006 at 03:42:34PM -0600, Michael Reed wrote:
> Due to a firmware mismatch between a host and target (names withheld to
> protect the innocent?), the LLDD was returning DID_RESET for every
> i/o command. This patch modifies the scsi layer to take into account
> when the command whi
This gets a little offtopic for the original issue, so let's cut the Cc
list and change the subject.
On Tue, Dec 12, 2006 at 04:21:23PM +0200, Boaz Harrosh wrote:
> I'm afraid this might not be enough because of code in drivers/ide/ide-cd.c.
> It does IO off of request->data.
Only for FS request
On Mon, Dec 25, 2006 at 09:32:04PM +0100, Thomas Bogendoerfer wrote:
> This patch adds a SCSI driver for the onboard 53c710 chip of some
> SNI RM machines.
Nice, this looks really clean. I haven't seen the code to declare
the platform devices in the mips queue yet, do you plan to submit it
soon?
On Sat, Dec 16, 2006 at 12:18:23AM +0900, FUJITA Tomonori wrote:
> blk_fill_sghdr_rq doesn't work for SG v4 so verify_command needed to
> be exported.
So fixup blk_fill_sghdr_rq to deal with SG v4 aswell. We really
need to support all SGv4 features in the core code - bsg should
only be a small wr
On Sat, Dec 09, 2006 at 10:37:05AM +0100, Geert Uytterhoeven wrote:
> +#include "initio.h"
This is definitly wrong. This is a header file for a specific driver.
I suspect you want the old-EH definitions for SCSI_RESET_*/SCSI_ABORT_*?
You're returning them from the EH routines which are plugged i
On Tue, Dec 05, 2006 at 08:00:34AM +0900, FUJITA Tomonori wrote:
> This patch makes sg dio use the block layer functions (calls
> blk_rq_map_user and blk_execute_rq_nowait).
>
> It doesn't break any existing features. So sg dio uses the block layer
> functions and sg mmap and indirectio use scsi_e
On Wed, Nov 29, 2006 at 06:16:24AM -0700, Matthew Wilcox wrote:
> On Wed, Nov 29, 2006 at 11:04:22AM +0100, Adrian Bunk wrote:
> > +#include "scsi_transport_api.h"
>
> scsi_transport_api.h is a weird little file. It's not included by
> anything in the drivers/scsi directory, only
> drivers/scsi/l
sr_block_ioctl() should proceed to SCSI ioctls if cdrom_ioctl()
returns -ENOSYS. However it tested for ENOSYS instead of -ENOSYS
rendering all SCSI ioctls other than GET_IDLUN and GET_BUS_NUMBER
inaccessible. Fix it.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
diff --git a/drivers/scsi/sr.c b/
27 matches
Mail list logo
