[PATCH 2/2] cciss: fix XFER_READ/XFER_WRITE in do_cciss_request

2006-12-15 Thread Mike Miller (OS Dev)
Patch 2 of 2 This patch fixes a stupid bug. Sometime during the 2tb enhancement I ended up replacing the macros XFER_READ and XFER_WRITE with h->cciss_read and h->cciss_write respectively. It seemed to work somehow at least on x86_64 and ia64. I don't know how. But people started complaining about

[PATCH 1/2] cciss: set default raid level when reading geometry fails

2006-12-15 Thread Mike Miller (OS Dev)
PATCH 1 of 2 This patch sets a default raid level on a volume that either does not support reading the geometry or reports an invalid geometry for whatever reason. We were always setting some values for heads and sectors but never set a raid level. This caused lots of problems on some buggy firmwa

[PATCHSET] Various sas_ata feature additions and EH fixes

2006-12-15 Thread Darrick J. Wong
Hi again, As a companion to today's libsas roll-up, this is the queue of patches for the SATL connector between SAS and ATA. For patches not specifically focusing on SAS ATA, please refer to my previous email (or the patches themselves). Each patch has its own preamble description, but I'd like

[PATCHSET] Various libsas/aic94xx stability and EH fixes

2006-12-15 Thread Darrick J. Wong
Hi all, It has been a while since I posted the last batch of patches against libsas and aic94xx. In that time, we've been working with Adaptec engineers to stabilize the driver under disk stress workloads and reboot tests, and these patches represent the results of this work and a few other clean

Re: [patch 17/30] scsi: fix uaccess handling

2006-12-15 Thread Heiko Carstens
On Fri, Dec 15, 2006 at 01:50:14PM -0600, James Bottomley wrote: > On Mon, 2006-12-04 at 15:18 -0800, [EMAIL PROTECTED] wrote: > > From: Heiko Carstens <[EMAIL PROTECTED]> > > > > Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> > > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> > > No in curre

Re: [PATCH 0/3] SG v4 support

2006-12-15 Thread Jens Axboe
On Fri, Dec 15 2006, James Bottomley wrote: > On Fri, 2006-12-15 at 19:57 +0100, Jens Axboe wrote: > > Good start! Just one comment before I look over this and merge it - > > I'd > > prefer keeping this out of sg.c. One of the problems we have right now > > are dual pieces of code for sg v3, and I

[PATCH] bsg: minor cleanups

2006-12-15 Thread FUJITA Tomonori
This just kills linux/config.h and dprintk warnings. The patch is over Jens's bsg branch. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/bsg.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/block/bsg.c b/block/bsg.c index 724b693..53a09a5 1006

[PATCH 1/3] block: export blk_verify_command for SG v4

2006-12-15 Thread FUJITA Tomonori
blk_fill_sghdr_rq doesn't work for SG v4 so verify_command needed to be exported. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/scsi_ioctl.c |7 --- include/linux/blkdev.h |1 + 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/block/scsi_ioctl.c b/blo

[PATCH 2/3] scsi: add sg_io_v4 structure

2006-12-15 Thread FUJITA Tomonori
This patch adds sg_io_v4 structure that Doug proposed last month. There's one major change from the RFC. I dropped iovec, which needs compat stuff. The bsg code simply calls blk_rq_map_user against dout_xferp/din_xferp. So if possible, the page frames are directly mapped. If not possible, the bloc

[PATCH 3/3] bsg: replace SG v3 with SG v4

2006-12-15 Thread FUJITA Tomonori
This replaces SG v3 in bsg with SG v4. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/bsg.c | 193 --- 1 files changed, 119 insertions(+), 74 deletions(-) diff --git a/block/bsg.c b/block/bsg.c index 53a09a5..70da2fc 100644

[PATCH] block: use blk_rq_unmap_user's new interface

2006-12-15 Thread FUJITA Tomonori
This converts block/scsi_ioctl.c use blk_rq_unmap_user's new interface. Now blk_unmap_sghdr_rq is too simple and it might be better to remove it. The patch is over Jens's bsg branch. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/scsi_ioctl.c | 14 ++ 1 files changed

Re: [patch 21/30] scsi: in2000 scsi_cmnd convertion

2006-12-15 Thread James Bottomley
On Mon, 2006-12-04 at 15:18 -0800, [EMAIL PROTECTED] wrote: > From: Henrik Kretzschmar <[EMAIL PROTECTED]> > > Changes the obsolete Scsi_Cmnd to struct scsi_cmnd and replace some > whitespaces. No to this ... an update was requested but none so far received. James - To unsubscribe from this li

Re: [patch 01/30] drivers/scsi/: small cleanups

2006-12-15 Thread Andrew Morton
On Fri, 15 Dec 2006 09:29:29 -0800 Randy Dunlap <[EMAIL PROTECTED]> wrote: > What's the status of these 30 scsi patches from akpm? I'll be re-re-re-re-re-sending them in the next day or two. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL

Re: [patch 26/30] scsi: fix sense key MEDIUM ERROR processing and retry

2006-12-15 Thread James Bottomley
On Mon, 2006-12-04 at 15:18 -0800, [EMAIL PROTECTED] wrote: > From: Luben Tuikov <[EMAIL PROTECTED]> > > - If the device reports an uncorrectable MEDIUM ERROR, such as SK MEDIUM > ERROR, ASC UNRECOVERED READ ERR, AMNF DATA FIELD or RECORD NOT FOUND, > then: In scsi_check_sense() return SUCCESS

Re: [patch 17/30] scsi: fix uaccess handling

2006-12-15 Thread James Bottomley
On Mon, 2006-12-04 at 15:18 -0800, [EMAIL PROTECTED] wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > > Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> No in current form ... an update is on the list. James - To unsubscribe from this list

Re: [patch 28/30] aic79xx: wrong max memory at driver init

2006-12-15 Thread James Bottomley
On Mon, 2006-12-04 at 15:18 -0800, [EMAIL PROTECTED] wrote: > From: Frederic TEMPORELLI <[EMAIL PROTECTED]> No: wrong API used - update requested. James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 0/3] SG v4 support

2006-12-15 Thread James Bottomley
On Fri, 2006-12-15 at 19:57 +0100, Jens Axboe wrote: > Good start! Just one comment before I look over this and merge it - > I'd > prefer keeping this out of sg.c. One of the problems we have right now > are dual pieces of code for sg v3, and I think it would be silly to > continue down this path.

[PATCH 0/3] SG v4 support

2006-12-15 Thread FUJITA Tomonori
The following patches add SG v4 support to bsg. They are over Jens' bsg branch. I just replaced bsg's SG v3 support with SG v4 and haven't added anything new yet. So it can only handle SCSI commands. I've uploaded simple programs to just read/write by using SG v4: http://www.kernel.org/pub/linux

Re: [PATCH 0/3] SG v4 support

2006-12-15 Thread Jens Axboe
On Sat, Dec 16 2006, FUJITA Tomonori wrote: > The following patches add SG v4 support to bsg. They are over Jens' > bsg branch. > > I just replaced bsg's SG v3 support with SG v4 and haven't added > anything new yet. So it can only handle SCSI commands. Good start! Just one comment before I look

Re: [PATCH 3/3] Import fw-sbp2 driver.

2006-12-15 Thread Stefan Richter
(added Cc: lsml) Kristian Høgsberg wrote at lkml: > I saw that the stack [the FireWire stack] > creates a struct device per LUN, which is kinda gross in my opinion. If you mean regular "unit directories" here, not SCSI LUs, then one device per unit makes sense. Different units of a node may imple

Re: aic79xx - wrong max memory at driver init

2006-12-15 Thread James Bottomley
On Thu, 2006-12-14 at 11:37 +0100, Hannes Reinecke wrote: > Frederic TEMPORELLI wrote: > > Hello Hannes, > > > > Aic79xx driver for Adaptec 39320 supports 64-bit addressing, but the > > initialization code of the driver is wrong: it tests the available > > memory size instead of testing the maximu

Re: [patch 01/30] drivers/scsi/: small cleanups

2006-12-15 Thread Randy Dunlap
On Mon, 04 Dec 2006 15:18:20 -0800 [EMAIL PROTECTED] wrote: Hi, What's the status of these 30 scsi patches from akpm? Thanks. > From: Adrian Bunk <[EMAIL PROTECTED]> > > This patch contains the following cleanups: > - make needlessly global functions static > - every file should #include the he

Re: [patch 5/5] scsi: fix uaccess handling

2006-12-15 Thread James Bottomley
On Sun, 2006-10-29 at 22:39 +0100, Heiko Carstens wrote: > > While not your fault I'd suggest to fix the __put_user abuse at the same > > time, as in the untested patch below for scsi_ioctl.c: > > Makes sense. Even though the whole SCSI_IOCTL_GET_IDLUN ioctl interface > is pretty pointless. > It s

Re: [PATCH 1/5] Update Documentation/pci.txt

2006-12-15 Thread Greg KH
On Sun, Dec 10, 2006 at 12:25:08AM -0700, Grant Grundler wrote: > On Tue, Dec 05, 2006 at 11:26:51PM -0800, Greg KH wrote: > ... > > I do have a few minor comments: > ... > > > Please mark the initialization and cleanup functions where appropriate > > > (the corresponding macros are defined in ): >

Re: [2.6 patch] remove the broken SCSI_SEAGATE driver

2006-12-15 Thread James Bottomley
On Fri, 2006-12-15 at 14:34 +0100, Krzysztof Halasa wrote: > Adrian Bunk <[EMAIL PROTECTED]> writes: > > > There must have been a compile error that has since been fixed, but I > > don't remember the details of this specific driver and I don't have > > such old compile logs anymore. > > I wonde

Re: [2.6 patch] remove the broken SCSI_SEAGATE driver

2006-12-15 Thread Oliver Neukum
Am Freitag, 15. Dezember 2006 14:34 schrieb Krzysztof Halasa: > I find it really hard to believe there are still users of things like > CDU-31A CDs, XT MFM disk controllers, or NCR5380 SCSI host adapters > (especially the real ones, not DOMEX etc. clones bundled with scanner > just ~ 10 years ago).

Re: [2.6 patch] remove the broken SCSI_SEAGATE driver

2006-12-15 Thread Krzysztof Halasa
Adrian Bunk <[EMAIL PROTECTED]> writes: > There must have been a compile error that has since been fixed, but I > don't remember the details of this specific driver and I don't have > such old compile logs anymore. I wonder if we could gather some usage statistics, especially WRT really old har