Re: [repost][PATCH 1/8] stex: fix biosparam calculation

2006-12-04 Thread Jeff Garzik
Ed Lin wrote: Fix biosparam calculation. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> ACK patches 1-8 - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[repost][PATCH 7/8] stex: change wait loop code

2006-12-04 Thread Ed Lin
The original wait loop may be much longer than intended time. Use more accurate timer_after for it. Also adjust wait value to avoid unnecessary long waiting. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index bfd7983..7edbcc9 100644 --- a/dr

[repost][PATCH 8/8] stex: version update

2006-12-04 Thread Ed Lin
Update version to 3.1.0.1 Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 7edbcc9..ba6bcda 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -11,8 +11,6 @@ * Written By: * Ed Lin <[EMAIL PROTECTED]> * - *

[repost][PATCH 5/8] stex: update device id info

2006-12-04 Thread Ed Lin
- add comments for various devices - remove unused device ids(0xf350, 0x4301, 0x8301, 0x8302) - add new device id(0xe350) - fix vendor id of st_vsc - modify Kconfig help info Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 1b4bfaa..6956

[repost][PATCH 3/8] stex: add value check in hard reset routine

2006-12-04 Thread Ed Lin
During hard reset, an all-1 value from PCI_COMMAND should be invalid. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index ea0d824..92dbac0 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -1041,7 +1041,7 @@ static void stex_hard_

[repost][PATCH 1/8] stex: fix biosparam calculation

2006-12-04 Thread Ed Lin
Fix biosparam calculation. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 185c270..91d484c 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -1100,18 +1100,18 @@ static int stex_reset(struct scsi_cmnd * static int stex_biosp

[repost][PATCH 4/8] stex: adjust default queue length

2006-12-04 Thread Ed Lin
Firmware of new version may adjust default queue length. It is backward compatible. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 92dbac0..a20cbd9 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -78,6 +78,7 @@ enum {

[repost][PATCH 6/8] stex: add new device type support

2006-12-04 Thread Ed Lin
Add support for st_vsc1 type device (st_vsc is ok because it does not require extra buffer). Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 0fd115c..bfd7983 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -121,7 +121,8 @@ e

[repost][PATCH 2/8] stex: fix controller_info command handling

2006-12-04 Thread Ed Lin
This command needs information from both firmware and driver. First copy information from firmware to buffer, then fill in driver information. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 91d484c..ea0d824 100644 --- a/drivers/scsi/stex

Re: [patch 23/30] iscsi: fix crypto_alloc_hash() error check

2006-12-04 Thread Mike Christie
[EMAIL PROTECTED] wrote: > From: Akinobu Mita <[EMAIL PROTECTED]> > > The return value of crypto_alloc_hash() should be checked by > IS_ERR(). Looks good to me. Signed-off-by: Mike Christie <[EMAIL PROTECTED]> Either James can merge it or Andrew can forward it or if when I send my update it is

[PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices

2006-12-04 Thread Darrick J. Wong
The Quantum GoVault SATAPI removable disk device returns ATA_ERR in response to a REPORT LUNS packet. If this happens to an ATAPI device that is attached to a SAS controller (this is the case with sas_ata), the device does not load because SCSI won't touch a "SCSI device" that won't report its LUN

[patch 22/30] make qla2x00_reg_remote_port() static

2006-12-04 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Andrew Vasquez <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/qla2xxx/qla_gbl.h |1 drivers/scsi/qla2xxx/qla_init.c | 68 +++--- 2

[patch 29/30] drivers/scsi/wd33c93.c: cleanups

2006-12-04 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - #include for getting the prototypes of {dis,en}able_irq() - make the needlessly global wd33c93_setup() static Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/wd33c93.c |4 +++- 1 file

[patch 12/30] drivers/scsi/dpt_i2o.c: remove dead code

2006-12-04 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> The Coverity checker spotted this dead code introduced by commit a07f353701acae77e023f6270e8af353b37af7c4. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/dpt_i2o.c |2 -- 1 file changed,

[patch 19/30] drivers/scsi/aic7xxx/: make functions static

2006-12-04 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/aic7xxx/aic79xx_osm.c |6 -- drivers/scsi/aic7xxx/aic79xx_osm.h |2 -- drivers/scsi/aic7xxx/aic7xxx.h |5 - drivers/sc

[patch 24/30] scsi: sic7xxx stray bracket fix

2006-12-04 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Fix broken-but-unused macro. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/aic7xxx/aic79xx_pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/scsi/

[patch 13/30] MPT fusion: handle PCI layer error on resume

2006-12-04 Thread akpm
From: Jeff Garzik <[EMAIL PROTECTED]> In the unlikely event of pci_enable_device() failure during resume, we do the minimalist solution and simply exit, rather than continuing to enable the hardware. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Cc: "Moore, Eric Dean" <[EMAIL PROTECTED]> Cc: Jam

[patch 15/30] drivers/scsi/megaraid.c: Replacing yield() with a better alternative

2006-12-04 Thread akpm
From: Amol Lad <[EMAIL PROTECTED]> For this driver cond_resched() seems to be a better alternative Signed-off-by: Amol Lad <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN drive

[patch 01/30] drivers/scsi/: small cleanups

2006-12-04 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> This patch contains the following cleanups: - make needlessly global functions static - every file should #include the headers containing the prototypes for it's global functions Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PRO

[patch 2/2] aic94xx: Don't call pci_map_sg for already-mapped scatterlists

2006-12-04 Thread akpm
From: "Darrick J. Wong" <[EMAIL PROTECTED]> It turns out that libata has already dma_map_sg'd the scatterlist entries that go with an ata_queued_cmd by the time it calls sas_ata_qc_issue. sas_ata_qc_issue passes this scatterlist to aic94xx. Unfortunately, aic94xx assumes that any scatterlist pas

[patch 09/30] Fix scsi/scsi_transport.h compile error

2006-12-04 Thread akpm
From: Rolf Eike Beer <[EMAIL PROTECTED]> scsi_transport.h defines the inline function scsi_transport_device_data() that dereferences a pointer of "struct scsi_device *". Since the struct is not known by the header this might break compilation. Include scsi/scsi_device.h to not rely on users doin

[patch 10/30] pci_module_init() convertion in the legacy megaraid driver

2006-12-04 Thread akpm
From: Henrik Kretzschmar <[EMAIL PROTECTED]> pci_module_init() convertion in the legacy megaraid driver. Signed-off-by: Henrik Kretzschmar <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[patch 07/30] scsi: remove unnecessary check in drivers/scsi/sg.c

2006-12-04 Thread akpm
From: Eric Sesterhenn <[EMAIL PROTECTED]> coverity spotted this (cid #758). All callers dereference sfp, so we dont need this check. In addition to this, we dereference it earlier in the function. Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]> Cc: Douglas Gilbert <[EMAIL PROTECTED]> Cc: Jam

[patch 21/30] scsi: in2000 scsi_cmnd convertion

2006-12-04 Thread akpm
From: Henrik Kretzschmar <[EMAIL PROTECTED]> Changes the obsolete Scsi_Cmnd to struct scsi_cmnd and replace some whitespaces. [EMAIL PROTECTED]: cleanups] Signed-off-by: Henrik Kretzschmar <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/in2000.c | 99

[patch 30/30] SCSI/megaraid: fix MMIO casts

2006-12-04 Thread akpm
From: Jeff Garzik <[EMAIL PROTECTED]> megaraid's MMIO RD*/WR* macros directly call readl() and writel() with an 'unsigned long' argument. This throws a warning, but is otherwise OK because the 'unsigned long' is really the result of ioremap(). This setup is also OK because the variable can hold

[patch 16/30] scsi: whitespace cleanup in the dpt driver

2006-12-04 Thread akpm
From: Henne <[EMAIL PROTECTED]> Remove some trailing whitespaces and some replace whitespaces with tabs. Signed-off-by: Henrik Kretzschmar <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/dpt/dpti_i2o.h | 48 drivers/scsi

[patch 11/30] pci_module_init() convertion in tmscsim.c

2006-12-04 Thread akpm
From: Henrik Kretzschmar <[EMAIL PROTECTED]> pci_module_init() convertion in tmscsim.c Signed-off-by: Henrik Kretzschmar <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/tmscsim.c |6 -- 1 file changed, 4 insert

[patch 1/2] git-sas Kconfig fix

2006-12-04 Thread akpm
From: "Darrick J. Wong" <[EMAIL PROTECTED]> Andrew Morton wrote: > WARNING: "ata_sas_slave_configure" [drivers/scsi/libsas/libsas.ko] undefined! > WARNING: "ata_port_disable" [drivers/scsi/libsas/libsas.ko] undefined! > WARNING: "ata_sas_port_init" [drivers/scsi/libsas/libsas.ko] undefined! > WAR

[patch 04/30] drivers/scsi/advansys.c: cleanups

2006-12-04 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> - remove the unneeded advansys.h - remove the unused advansys_setup() - make needlessly global functions static Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/advansys.c | 101 +++---

[patch 05/30] megaraid: fix warnings when CONFIG_PROC_FS=n

2006-12-04 Thread akpm
From: walter harms <[EMAIL PROTECTED]> Signed-off-by: walter harms <[EMAIL PROTECTED]> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Cc: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/megaraid.c | 17 +++-- drivers/scsi/megara

[patch 27/30] sym53c8xx_2 claims cpqarray device

2006-12-04 Thread akpm
From: Chip Coldwell <[EMAIL PROTECTED]> Apropos this thread http://marc.theaimsgroup.com/?l=linux-scsi&m=115591706804045&w=2 which led to this patch http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-rc-fixes-2.6.git;a=commit;h=b2b3c121076961333977f485f0d54c22121df920 do we not also need

[patch 26/30] scsi: fix sense key MEDIUM ERROR processing and retry

2006-12-04 Thread akpm
From: Luben Tuikov <[EMAIL PROTECTED]> - If the device reports an uncorrectable MEDIUM ERROR, such as SK MEDIUM ERROR, ASC UNRECOVERED READ ERR, AMNF DATA FIELD or RECORD NOT FOUND, then: In scsi_check_sense() return SUCCESS so as to not retry -- the error is uncorrectable -- this speeds up

[patch 28/30] aic79xx: wrong max memory at driver init

2006-12-04 Thread akpm
From: Frederic TEMPORELLI <[EMAIL PROTECTED]> Aic79xx driver for Adaptec 39320 supports 64-bit addressing, but the initialization code of the driver is wrong: it tests the available memory size instead of testing the maximum available memory address. This is necessary to support servers that prov

[patch 03/30] scsi: clean up warnings in Advansys driver

2006-12-04 Thread akpm
From: Ken Witherow <[EMAIL PROTECTED]> Fix typecast warnings and switch from check_region to request_region (akpm: Ken and Jeffrey Phillips Freeman <[EMAIL PROTECTED]> are possible advansys testers) Signed-off-by: Ken Witherow <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>

[patch 06/30] drivers/scsi/pcmcia/nsp_cs.h: removal of old scsi code

2006-12-04 Thread akpm
From: Michal Piotrowski <[EMAIL PROTECTED]> Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/pcmcia/nsp_cs.h | 66 - 1 file changed, 66 deletions(-) diff -puN drivers/scsi/pcmcia/nsp_cs.h~dr

[patch 08/30] remove extra newline from info message

2006-12-04 Thread akpm
From: Rolf Eike Beer <[EMAIL PROTECTED]> remove extra newline from info message This extra newline character introduces a completely empty line in dmesg as the calling function itself adds a newline. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed

[patch 20/30] SCSI: advansys, wrap PCI table inside ifdef CONFIG_PCI

2006-12-04 Thread akpm
From: Randy Dunlap <[EMAIL PROTECTED]> The Advansys ISA/EISA/PCI driver has a compile error when CONFIG_PCI=n, so wrap the pci_device_id table inside ifdef CONFIG_PCI. drivers/scsi/advansys.c: At top level: drivers/scsi/advansys.c:18219: error: array type has incomplete element type drivers/scsi/

[patch 23/30] iscsi: fix crypto_alloc_hash() error check

2006-12-04 Thread akpm
From: Akinobu Mita <[EMAIL PROTECTED]> The return value of crypto_alloc_hash() should be checked by IS_ERR(). Cc: Dmitry Yusupov <[EMAIL PROTECTED]> Cc: Alex Aizman <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Signed-off-by: Andrew Mo

[patch 17/30] scsi: fix uaccess handling

2006-12-04 Thread akpm
From: Heiko Carstens <[EMAIL PROTECTED]> Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/scsi_ioctl.c | 17 +++-- drivers/scsi/sg.c | 47 +++- 2 files changed, 35 insertions(+)

[patch 18/30] drivers/scsi/mca_53c9x.c : save_flags()/cli() removal

2006-12-04 Thread akpm
From: Amol Lad <[EMAIL PROTECTED]> Replaced save_flags()/cli() with spin_lock alternatives [EMAIL PROTECTED]: no longer BROKEN_ON_SMP] Signed-off-by: Amol Lad <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Cc: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTE

[patch 14/30] drivers/scsi/NCR5380.c: Replacing yield() with a better alternative

2006-12-04 Thread akpm
From: Amol Lad <[EMAIL PROTECTED]> Replaced yield() with cond_resched() Signed-off-by: Amol Lad <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/NCR5380.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[patch 02/30] drivers/scsi/aic7xxx/aic79xx_core.c: make ahd_match_scb() static

2006-12-04 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> Acked-by: Hannes Reinecke <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/aic7xxx/aic79xx.h |3 --- drivers/scsi/aic7xxx/aic

[patch 25/30] scsi: 53c7xx brackets fix

2006-12-04 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/scsi/53c7xx.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/scsi/53c7xx.c~scsi-53c7xx-brackets-fix drive

Re: libata: Simulate REPORT LUNS for ATAPI devices when not supported

2006-12-04 Thread Jeff Garzik
Darrick J. Wong wrote: The Quantum GoVault SATAPI removable disk device returns ATA_ERR in response to a REPORT LUNS packet. If this happens to an ATAPI device that is attached to a SAS controller (this is the case with sas_ata), the device does not load because SCSI won't touch a "SCSI device"

libata: Simulate REPORT LUNS for ATAPI devices when not supported

2006-12-04 Thread Darrick J. Wong
The Quantum GoVault SATAPI removable disk device returns ATA_ERR in response to a REPORT LUNS packet. If this happens to an ATAPI device that is attached to a SAS controller (this is the case with sas_ata), the device does not load because SCSI won't touch a "SCSI device" that won't report its LUN

[PATCH] convert sg dio to use blk functions

2006-12-04 Thread FUJITA Tomonori
This patch makes sg dio use the block layer functions (calls blk_rq_map_user and blk_execute_rq_nowait). It doesn't break any existing features. So sg dio uses the block layer functions and sg mmap and indirectio use scsi_execute_async. This isn't for merging. I would like to discuss how to conve

Re: [Bug 7026] CD/DVD burning with USB writer doesn't work

2006-12-04 Thread James Bottomley
On Mon, 2006-12-04 at 15:11 -0500, Alan Stern wrote: > Can you please take a look at this entry in Bugzilla: > > http://bugzilla.kernel.org/show_bug.cgi?id=7026 > > The important part starts at Comment 21; in particular the last two > comments from Joerg Schilling and me are relevant to th

[Bug 7026] CD/DVD burning with USB writer doesn't work

2006-12-04 Thread Alan Stern
Doug: Can you please take a look at this entry in Bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=7026 The important part starts at Comment 21; in particular the last two comments from Joerg Schilling and me are relevant to the SG driver. Alan Stern - To unsubscribe from this lis

Re: [PATCH 5/8] stex: update device id info

2006-12-04 Thread Ed Lin
>-Original Message- >From: Jeff Garzik [mailto:[EMAIL PROTECTED] >Sent: Friday, December 01, 2006 9:10 PM >To: Ed Lin >Cc: linux-scsi; James.Bottomley; Promise_Linux >Subject: Re: [PATCH 5/8] stex: update device id info > > >Ed Lin wrote: >> Update pci device id and Kconfig help informati

[2.4 PATCH] scsi aic7xxx parenthesis fix

2006-12-04 Thread Mariusz Kozlowski
Hello, This patch adds missing parenthesis in SUBID_9005_SEEPTYPE() macro code. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]>  drivers/scsi/aic7xxx/aic79xx_pci.c |    2 +-  1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.4.34-pre6-a/drivers/scsi/aic7xxx/aic79xx_pci.c

[2.4 PATCH] scsi 53c7,8xx parenthesis fix

2006-12-04 Thread Mariusz Kozlowski
Hello, This patch removes an extra parenthesis in debugger_fn_bs() code. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]>  drivers/scsi/53c7,8xx.c |    2 +-  1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.4.34-pre6-a/drivers/scsi/53c7,8xx.c 2004-11-17 12:54:21.0

[2.4 PATCH] scsi 53c7xx parenthesis fix

2006-12-04 Thread Mariusz Kozlowski
Hello, Tis patch removes an extra parenthesis in abort_connected() code. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]>  drivers/scsi/53c7xx.c |    2 +-  1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.4.34-pre6-a/drivers/scsi/53c7xx.c 2004-02-18 14:36:31.0 +0