Re: Symbios problems in recent -mm trees?

2005-08-04 Thread Andrew Morton
"Martin J. Bligh" <[EMAIL PROTECTED]> wrote: > > If you look on http://test.kernel.org/, you'll see in the rightmost > column there's a yellow box under elm3b70 for 2.6.13-rc4-mm1, but > current mainline kernels are all green (ie no problems). That means > one test failed, in this case making an fs

Re: [ANNOUNCE 4/7] open-iscsi/linux-iscsi-5 Initiator: open-iscsi-netlink.patch

2005-08-04 Thread Randy.Dunlap
On Thu, 04 Aug 2005 22:22:33 -0500 James Bottomley wrote: > On Thu, 2005-08-04 at 19:31 -0700, Alex Aizman wrote: > > +#define NETLINK_ISCSI 31 /* iSCSI Open Interface */ > > This isn't exactly what Dave Miller said to do last time. This one > can't go in until he OK's it. Ale

Re: [ANNOUNCE 4/7] open-iscsi/linux-iscsi-5 Initiator: open-iscsi-netlink.patch

2005-08-04 Thread James Bottomley
On Thu, 2005-08-04 at 19:31 -0700, Alex Aizman wrote: > +#define NETLINK_ISCSI31 /* iSCSI Open Interface */ This isn't exactly what Dave Miller said to do last time. This one can't go in until he OK's it. James - To unsubscribe from this list: send the line "unsubscribe li

[ANNOUNCE 6/7] open-iscsi/linux-iscsi-5 Initiator: open-iscsi-transport.patch

2005-08-04 Thread Alex Aizman
open-iscsi-transport.patch - iscsi transport class (drivers/scsi/scsi_transport_iscsi.c) Signed-off-by: Alex Aizman <[EMAIL PROTECTED]> Signed-off-by: Dmitry Yusupov <[EMAIL PROTECTED]> Signed-off-by: Mike Christie <[EMAIL PROTECTED]> diff --git a/drivers/scsi/sc

[ANNOUNCE 4/7] open-iscsi/linux-iscsi-5 Initiator: open-iscsi-netlink.patch

2005-08-04 Thread Alex Aizman
open-iscsi-netlink.patch - include/linux/netlink.h changes (added NETLINK_ISCSI). Signed-off-by: Alex Aizman <[EMAIL PROTECTED]> Signed-off-by: Dmitry Yusupov <[EMAIL PROTECTED]> Signed-off-by: Mike Christie <[EMAIL PROTECTED]> diff --git a/include/linux/netlink.

[ANNOUNCE 3/7] open-iscsi/linux-iscsi-5 Initiator: open-iscsi-headers.patch

2005-08-04 Thread Alex Aizman
open-iscsi-headers.patch - common header files: - iscsi_if.h (user/kernel #defines and user/kernel events); - iscsi_proto.h (RFC3720 #defines and types); - scsi_transport_iscsi.h (transport API, transport #defines and types). Signed-off-by: Alex Aizman <[EM

[ANNOUNCE 2/7] open-iscsi/linux-iscsi-5 Initiator: open-iscsi-tcp.h.patch

2005-08-04 Thread Alex Aizman
open-iscsi-tcp.h.patch - drivers/scsi/iscsi_tcp.h, header file. Signed-off-by: Alex Aizman <[EMAIL PROTECTED]> Signed-off-by: Dmitry Yusupov <[EMAIL PROTECTED]> Signed-off-by: Mike Christie <[EMAIL PROTECTED]> diff --git a/drivers/scsi/iscsi_tcp.h b/drivers/scsi/i

[ANNOUNCE 0/7] open-iscsi/linux-iscsi-5 Initiator

2005-08-04 Thread Alex Aizman
Open-iSCSI/Linux-iSCSI-5 Initiator: Data Path and Transport Class == This submission contains 7 patches for 2.6.13 (today's git repository). The same 7 patches can be downloaded at: http://www.open-iscsi.org/bits/submission-08042005/ This submission co

calling scsi_adjust_queue_depth() during I/O...

2005-08-04 Thread Andrew Vasquez
All, While adding support for the new change_queue_depth/type() callbacks, static int qla2x00_change_queue_depth(struct scsi_device *sdev, int qdepth) { scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), qdepth); return sdev->queue_depth

[PATCH] aic7xxx: upport all sequencer and core fixes from adaptec version 6.3.9

2005-08-04 Thread James Bottomley
This patch upports all relevant code fixes and bumps the driver version to 7.0 to signify starting a new tree. James diff --git a/Documentation/scsi/aic7xxx.txt b/Documentation/scsi/aic7xxx.txt --- a/Documentation/scsi/aic7xxx.txt +++ b/Documentation/scsi/aic7xxx.txt @@ -1,5 +1,5 @@

Documentation/ioctl-mess.txt and ida_ioctl() review (was Re: [PATCH 2/3] cpqarray: ioctl support to configure LUNs dynamically)

2005-08-04 Thread Alexey Dobriyan
On Thu, Aug 04, 2005 at 10:15:29AM +0530, Saripalli, Venkata Ramanamurthy (STSD) wrote: > Patch 2 of 3 > This patch adds support for IDAREGNEWDISK, IDADEREGDISK, IDAGETLOGINFO > ioctls required > to configure LUNs dynamically on SA4200 controller using ACU. drivers/block/cpqarray.c: 1131 stat

[GIT PATCH] scsi bug fixes for 2.6.13

2005-08-04 Thread James Bottomley
This is my (hopefully final) collection of safe driver updates and bug fixes for 2.6.13. The tree is available from rsync://rsync.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-for- linus-2.6.git The short changelog is Andrew Morton: o fc4 warning fix Jack Hammer: o ServeRAID V7.12.02 Jame

[PATCH] fix aic7xxx performance issues since 2.6.12-rc2

2005-08-04 Thread James Bottomley
Several people noticed we dropped quite a bit on benchmark figures. OK, it was my fault but unfortunately I discovered I ran out of brown paper bags a while ago and forgot to reorder them. The issue is that a construct introduced in the conversion keyed off whether the block request was tagged or

Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

2005-08-04 Thread Dave Jones
On Thu, Aug 04, 2005 at 07:11:38PM +0200, Rolf Eike Beer wrote: > >It's pointless to fix this, without fixing also CpqTsGetSFQEntry() > At least half of the file should be rewritten. Just half ? You're such an optimist :-) > > > No, ulDestPtr ist ULONG* so we increase it by sizeof(ULONG)*16 wh

Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

2005-08-04 Thread Dave Jones
On Thu, Aug 04, 2005 at 05:56:14PM +0200, Rolf Eike Beer wrote: > Am Donnerstag, 4. August 2005 17:40 schrieb Dave Jones: > >On Thu, Aug 04, 2005 at 11:38:30AM +0200, Rolf Eike Beer wrote: > > > >+ ulFibreFrame = kmalloc((2048/4), GFP_KERNEL); > > > > > > The size bug was already found

Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

2005-08-04 Thread Rolf Eike Beer
Dave Jones wrote: >On Thu, Aug 04, 2005 at 05:56:14PM +0200, Rolf Eike Beer wrote: > > Am Donnerstag, 4. August 2005 17:40 schrieb Dave Jones: > > >On Thu, Aug 04, 2005 at 11:38:30AM +0200, Rolf Eike Beer wrote: > > > > >+ulFibreFrame = kmalloc((2048/4), GFP_KERNEL); > > > > > > > > The siz

Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

2005-08-04 Thread Rolf Eike Beer
Am Donnerstag, 4. August 2005 17:40 schrieb Dave Jones: >On Thu, Aug 04, 2005 at 11:38:30AM +0200, Rolf Eike Beer wrote: > > >+ulFibreFrame = kmalloc((2048/4), GFP_KERNEL); > > > > The size bug was already found by Dave Jones. This never should be > > written this way (not your fault). The arra

Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

2005-08-04 Thread Dave Jones
On Thu, Aug 04, 2005 at 11:38:30AM +0200, Rolf Eike Beer wrote: > > >+ ulFibreFrame = kmalloc((2048/4), GFP_KERNEL); > The size bug was already found by Dave Jones. This never should be written > this way (not your fault). The array should have been [2048/sizeof(ULONG)]. wasteful. We onl

Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

2005-08-04 Thread Jesper Juhl
On 8/4/05, Saripalli, Venkata Ramanamurthy (STSD) <[EMAIL PROTECTED]> wrote: > Patch 1 of 2 > > This patch fixes the "#error this is too much stack" in 2.6 kernel. > Using kmalloc to allocate memory to ulFibreFrame. > [snip] >if( fchs->pl[0] == ELS_LILP_FRAME) > { > +

RE: [PATCH 6/7] aacraid: unlock around kfree

2005-08-04 Thread Arjan van de Ven
On Thu, 2005-08-04 at 08:04 -0400, Salyzyn, Mark wrote: > Cool! Thanks for the information! Sounds like the patch will be > necessary. However, I have never seen the issue bite us, but who knows, > it may be the contributor to a system lockup after 8000 hours of uptime > ... I'd prefer the paranoid

Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

2005-08-04 Thread Denis Vlasenko
On Thursday 04 August 2005 12:38, Rolf Eike Beer wrote: > Saripalli, Venkata Ramanamurthy (STSD) wrote: > >Patch 1 of 2 > > > >This patch fixes the "#error this is too much stack" in 2.6 kernel. > >Using kmalloc to allocate memory to ulFibreFrame. > > Good idea. > > >Please consider this for incl

RE: [PATCH 6/7] aacraid: unlock around kfree

2005-08-04 Thread Salyzyn, Mark
Cool! Thanks for the information! Sounds like the patch will be necessary. However, I have never seen the issue bite us, but who knows, it may be the contributor to a system lockup after 8000 hours of uptime ... I'd prefer the paranoid delusion and a stable system! As for the GFP_ATOMIC, the inten

RE: [PATCH 6/7] aacraid: unlock around kfree

2005-08-04 Thread Arjan van de Ven
On Thu, 2005-08-04 at 07:33 -0400, Salyzyn, Mark wrote: > Good to know. I went through one too many code reviews and had no > defense against the request. > > There is a follow-up to this one not yet submitted to MarkH where I > endeavor to pre-allocate with kmalloc(,GFP_ATOMIC|GFP_KERNEL) a pool

RE: [PATCH 7/7] aacraid: sgraw command support

2005-08-04 Thread Salyzyn, Mark
In these cases, the 'addr' is an u64, so is it necessary to perform this modification? I will do a critical analysis of the remaining code in the driver for any values that are, or have a risk of being on some platforms, a 32 bit entity and undergo this kind of shift action. Sincerely -- Mark Sal

RE: [PATCH 6/7] aacraid: unlock around kfree

2005-08-04 Thread Salyzyn, Mark
Good to know. I went through one too many code reviews and had no defense against the request. There is a follow-up to this one not yet submitted to MarkH where I endeavor to pre-allocate with kmalloc(,GFP_ATOMIC|GFP_KERNEL) a pool before entering a locked list traversal rather than risking making

Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

2005-08-04 Thread Rolf Eike Beer
Saripalli, Venkata Ramanamurthy (STSD) wrote: >Patch 1 of 2 > >This patch fixes the "#error this is too much stack" in 2.6 kernel. >Using kmalloc to allocate memory to ulFibreFrame. Good idea. >Please consider this for inclusion Your patch is line-wrapped and can't be applied. Your second patch

Re: [PATCH 2/3] cpqarray: ioctl support to configure LUNs dynamically

2005-08-04 Thread Arjan van de Ven
On Thu, 2005-08-04 at 10:15 +0530, Saripalli, Venkata Ramanamurthy (STSD) wrote: > Patch 2 of 3 > This patch adds support for IDAREGNEWDISK, IDADEREGDISK, IDAGETLOGINFO > ioctls required > to configure LUNs dynamically on SA4200 controller using ACU. I don't think it's a good idea to add new ioct

Re: [PATCH 7/7] aacraid: sgraw command support

2005-08-04 Thread Arjan van de Ven
On Wed, 2005-08-03 at 15:39 -0700, Mark Haverkamp wrote: > + psg->sg[0].addr[1] = cpu_to_le32((u32)(addr>>32)); this is very risky code; if addr is a 32 bit entity, then this is undefined behavior (which due to the vagities of x86 asm might get optimized out entirely). It is a lot sa

[PATCH] aic79xx: fixup DT setting

2005-08-04 Thread Hannes Reinecke
Hi James, this patch is just a cross-port of your fixup for aic7xxx DT settings. As the same restrictions apply for aic79xx also (DT requires wide transfers) the dt setting routine should be modified equivalently. And an invalid period setting will be catched by ahd_find_syncrate() anyway. Cheers