Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Ben Collins
On Sat, Jul 09, 2005 at 11:29:14PM -0400, Jeff Garzik wrote: > On Sat, Jul 09, 2005 at 07:31:38PM -0400, Ben Collins wrote: > > Thing is, these don't seem to be working for SBP2. I assume these > > conversions came from libata > > Incorrect. > > > > (since that's the only other user of them). >

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Ben Collins
> > My question is, why were the conversions all removed? The conversions, as > > far as I know, are related to SBP protocol, and not SCSI, so why would the > > SCSI maintainers feel the need to rip out an important part of the SBP2 > > driver? > > It's a standard conversion that we've been rippin

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread James Bottomley
On Sat, 2005-07-09 at 19:06 -0400, Ben Collins wrote: > Alright, I need some explanation on these changes to sbp2. Lots of things > ripped out. The patch seems reasonably explanatory: http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=631e8a1398ce4cfef8b30678d51daf0c6

Re: Fw: Kernel panic with dc395x in 2.6.12.2

2005-07-09 Thread randy_dunlap
On Sun, 10 Jul 2005 03:49:08 +0200 Pierre Ossman wrote: | randy_dunlap wrote: | | >Pierre, | > | >Can you capture the complete panic message using serial console or | >netconsole? or at least use a smaller font on the console so that | >we can see the entire panic message, as some critical parts

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Jeff Garzik
On Sat, Jul 09, 2005 at 07:06:56PM -0400, Ben Collins wrote: > I can understand that TYPE_RDC is what we had as TYPE_SDAD. Now, in our > tree for TYPE_RDC, we converted it to TYPE_DISK. We also did a lot of mode > conversions for DISK/RDC/ROM types. This isn't correct. RBC is a separate, valid di

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Jeff Garzik
On Sat, Jul 09, 2005 at 07:31:38PM -0400, Ben Collins wrote: > Thing is, these don't seem to be working for SBP2. I assume these > conversions came from libata Incorrect. > (since that's the only other user of them). Incorrect. > Was the logic compared to the SBP2 conversions before > being m

Re: Fw: Kernel panic with dc395x in 2.6.12.2

2005-07-09 Thread Pierre Ossman
randy_dunlap wrote: >Pierre, > >Can you capture the complete panic message using serial console or >netconsole? or at least use a smaller font on the console so that >we can see the entire panic message, as some critical parts of it >have scrolled off the top of the screen. > > > Hmm... I made

Fw: Kernel panic with dc395x in 2.6.12.2

2005-07-09 Thread randy_dunlap
Pierre, Can you capture the complete panic message using serial console or netconsole? or at least use a smaller font on the console so that we can see the entire panic message, as some critical parts of it have scrolled off the top of the screen. ~Randy Begin forwarded message: Date: Sat,

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Ben Collins
Ok, I see that the rw and ms 10byte conversions are in the scsi lib now. Thing is, these don't seem to be working for SBP2. I assume these conversions came from libata (since that's the only other user of them). Is that correct? Was the logic compared to the SBP2 conversions before being moved ove

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Ben Collins
Alright, I need some explanation on these changes to sbp2. Lots of things ripped out. I can understand that TYPE_RDC is what we had as TYPE_SDAD. Now, in our tree for TYPE_RDC, we converted it to TYPE_DISK. We also did a lot of mode conversions for DISK/RDC/ROM types. My question is, why were the

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Ben Collins
On Sat, Jul 09, 2005 at 01:41:20PM -0500, James Bottomley wrote: > On Sat, 2005-07-09 at 13:49 -0400, Ben Collins wrote: > > It's not the lock change that is breaking things, it's the RBC changes. > > SBP2 simply doesn't work (incorrect information read from the driver, > > which I assume is bad tr

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread James Bottomley
On Sat, 2005-07-09 at 13:49 -0400, Ben Collins wrote: > It's not the lock change that is breaking things, it's the RBC changes. > SBP2 simply doesn't work (incorrect information read from the driver, > which I assume is bad translation of the scsi commands caused by the > changes). The RBC changes

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread James Bottomley
On Sat, 2005-07-09 at 12:27 -0400, Ben Collins wrote: > If it was orphaned it was done so mistakenly. I maintain that code, and > linux1394. Well, it's becoming hard to interrogate BK about ancient changes now that Larry has stopped all the tools from working. However, with a bit of patience and

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Ben Collins
On Sat, Jul 09, 2005 at 07:57:29PM +0200, Arjan van de Ven wrote: > On Sat, 2005-07-09 at 13:51 -0400, Ben Collins wrote: > > On Sat, Jul 09, 2005 at 07:00:52PM +0200, Stefan Richter wrote: > > > On 9 Jul, Ben Collins wrote: > > > > If it was orphaned it was done so mistakenly. I maintain that cod

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Arjan van de Ven
On Sat, 2005-07-09 at 13:51 -0400, Ben Collins wrote: > On Sat, Jul 09, 2005 at 07:00:52PM +0200, Stefan Richter wrote: > > On 9 Jul, Ben Collins wrote: > > > If it was orphaned it was done so mistakenly. I maintain that code, and > > > linux1394. > > > > sbp2 and eth1394 have been listed as orph

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Ben Collins
On Sat, Jul 09, 2005 at 06:37:10PM +0200, Arjan van de Ven wrote: > On Sat, 2005-07-09 at 12:27 -0400, Ben Collins wrote: > > If it was orphaned it was done so mistakenly. I maintain that code, and > > linux1394. > > > > Aside from that, the the change was pushed into the mainstream kernel > > wit

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Ben Collins
On Sat, Jul 09, 2005 at 07:00:52PM +0200, Stefan Richter wrote: > On 9 Jul, Ben Collins wrote: > > If it was orphaned it was done so mistakenly. I maintain that code, and > > linux1394. > > sbp2 and eth1394 have been listed as orphan since linux-2.6.12. Can't see how the most used driver in our

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Ben Collins
On Sat, Jul 09, 2005 at 11:35:01AM -0500, James Bottomley wrote: > On Sat, 2005-07-09 at 12:27 -0400, Ben Collins wrote: > > THese changes break sbp2, and we'll need to revert them in the main stream > > kernel until the patch is tested and fixed in our tree. > > They cannot be simply reverted. T

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread James Bottomley
On Sat, 2005-07-09 at 18:56 +0200, Stefan Richter wrote: > -- bad inquiry with TYPE_RBC patch -- > ieee1394: sbp2: Logged into SBP-2 device > ieee1394: Node 0-00:1023: Max speed [S400] - Max payload [2048] > Vendor: ST316002 Model: 1ARev: 3.06 > Type: Unknown

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Stefan Richter
On 9 Jul, Ben Collins wrote: > If it was orphaned it was done so mistakenly. I maintain that code, and > linux1394. sbp2 and eth1394 have been listed as orphan since linux-2.6.12. -- Stefan Richter -=-=-=-= -=== -=--= http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "un

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Stefan Richter
On 9 Jul, James Bottomley wrote: > On Sat, 2005-07-09 at 12:27 -0400, Ben Collins wrote: >> THese changes break sbp2, and we'll need to revert them in the main stream >> kernel until the patch is tested and fixed in our tree. > > They cannot be simply reverted. The API has changed from the EH >

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Arjan van de Ven
On Sat, 2005-07-09 at 12:27 -0400, Ben Collins wrote: > If it was orphaned it was done so mistakenly. I maintain that code, and > linux1394. > > Aside from that, the the change was pushed into the mainstream kernel > without going through our repository, which means it would have been > caught bef

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread James Bottomley
On Sat, 2005-07-09 at 12:27 -0400, Ben Collins wrote: > THese changes break sbp2, and we'll need to revert them in the main stream > kernel until the patch is tested and fixed in our tree. They cannot be simply reverted. The API has changed from the EH routines being called with the host lock hel

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Ben Collins
If it was orphaned it was done so mistakenly. I maintain that code, and linux1394. Aside from that, the the change was pushed into the mainstream kernel without going through our repository, which means it would have been caught before going to all of our users (most of users of ieee1394 on linux

Re: changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread James Bottomley
On Sat, 2005-07-09 at 14:37 +0200, Stefan Richter wrote: > there are a few changes to sbp2 in linux-2.6.13 (-rc2) that were not > merged back into the linux1394.org repository (and were not tested by > linux1394 maintainers as far as I have heard). Most of these changes > deal with TYPE_RBC devices

changes to ieee1394/sbp2 outside of linux1394.org

2005-07-09 Thread Stefan Richter
Hi linux-scsi people and linux1394 people, there are a few changes to sbp2 in linux-2.6.13 (-rc2) that were not merged back into the linux1394.org repository (and were not tested by linux1394 maintainers as far as I have heard). Most of these changes deal with TYPE_RBC devices. Previous discussio

Re: [PATCH] 2.6 aacraid: Fix for controller load based timeouts

2005-07-09 Thread Mark Overmeer
* Martin Drab ([EMAIL PROTECTED]) [050708 20:19]: > > On Fri, 2005-07-08 at 10:36 -0700, Mark Haverkamp wrote: > > > Martin Drab found that he could get aacraid timeouts with high load on > > > his controller / disk drive combinations. After some experimentation > > > Mark Salyzyn has come up with