Re: PATCH [2/5] qla2xxx: add remote port codes...

2005-04-18 Thread Andrew Vasquez
On Wed, 13 Apr 2005, Christoph Hellwig wrote: > > > +struct scsi_transport_template * > > +qla2x00_alloc_transport_tmpl(void) > > +{ > > + return (fc_attach_transport(&qla2xxx_transport_functions)); > > +} > > I don't see much of a point in this function vs just making > qla2xxx_transport_func

RE: Fibre Channel state of the union

2005-04-18 Thread James . Smart
Christoph, FYI - Emulex is committed to completing the effort for creating a vendor-agnostic open-source hbaapi library for linux, including the thornier issues of performing CT passthru and RNID functionality. As soon as the library exists, an open-source SMI-S provider would become available

Re: SCSI trees, merges and git status

2005-04-18 Thread Linus Torvalds
On Mon, 18 Apr 2005, James Bottomley wrote: > > Fair enough. If you pull from > > rsync://www.parisc-linux.org/~jejb/scsi-misc-2.6.git Thanks. Pulled and pushed out. > Doing this exposed two bugs in your merge script: > > 1) It doesn't like a completely new directory (the misc tree contains

Re: SCSI trees, merges and git status

2005-04-18 Thread James Bottomley
On Mon, 2005-04-18 at 17:29 -0700, Linus Torvalds wrote: > 2.6.12 is some time away, if for no other reason than the fact that this > SCM thing has obviously eaten two weeks of my time. So I'd be inclined to > chalk this up as a "learning experience" with git, and just go forward. Fair enough.

Re: SCSI trees, merges and git status

2005-04-18 Thread Linus Torvalds
On Mon, 18 Apr 2005, James Bottomley wrote: > > Then the git-pull... script actually does the merge and the resulting > tree checks out against BK So? What do you intend to do with all the other stuff I've already put on top? Yes, I can undo my tree, but my tree has had more stuff in it since

Re: [RFC 1 of 9] patches to add diskdump functionality to block layer

2005-04-18 Thread Marcelo Tosatti
On Mon, Apr 18, 2005 at 12:14:06PM -0500, Miller, Mike (OS Dev) wrote: > > From: Christoph Hellwig [mailto:[EMAIL PROTECTED] > > > > This looks like a patch for Linux 2.4. Such major changes for the > > 2.4 tree don't make sense anymore, especially for > > functionality not even in Linux 2.6. >

Re: SCSI trees, merges and git status

2005-04-18 Thread James Bottomley
On Mon, 2005-04-18 at 17:03 -0700, Linus Torvalds wrote: > The patches from you I have in my tree are: > > scsi: add DID_REQUEUE to the error handling > zfcp: add point-2-point support > [PATCH] Convert i2o to compat_ioctl > [PATCH] kill old EH constants > [PATCH] scs

Re: SCSI trees, merges and git status

2005-04-18 Thread Linus Torvalds
On Mon, 18 Apr 2005, James Bottomley wrote: > > It looks like the merge tree has contamination from the scsi-misc-2.6 > tree ... possibly because the hosting system got the merged objects when > I pushed. Nope, the way I merge, if I get a few objects it shouldn't matter at all. I'll just look

Re: [PATCH scsi-misc-2.6 02/07] scsi: make scsi_send_eh_cmnd use its own timer instead of scmd->eh_timeout

2005-04-18 Thread Tejun Heo
James Bottomley wrote: > On Tue, 2005-04-19 at 07:31 +0900, Tejun Heo wrote: > >> The original code also uses timer pending status as a signal that >>command completed normally in scsi_eh_done() function, and the same >>race also exists in the original code, no matter what we do, unless we >>make

Re: SCSI trees, merges and git status

2005-04-18 Thread James Bottomley
On Mon, 2005-04-18 at 14:39 -0700, Linus Torvalds wrote: > > Linus, the rc-fixes repo is ready for applying ... it's the same one I > > announced on linux-scsi and lkml a while ago just with the git date > > information updated to be correct (the misc one should wait until after > > 2.6.12 is final

Re: [PATCH scsi-misc-2.6 02/07] scsi: make scsi_send_eh_cmnd use its own timer instead of scmd->eh_timeout

2005-04-18 Thread James Bottomley
On Tue, 2005-04-19 at 07:31 +0900, Tejun Heo wrote: > The original code also uses timer pending status as a signal that > command completed normally in scsi_eh_done() function, and the same > race also exists in the original code, no matter what we do, unless we > make timer expiration and removal

Re: [PATCH scsi-misc-2.6 02/07] scsi: make scsi_send_eh_cmnd use its own timer instead of scmd->eh_timeout

2005-04-18 Thread Tejun Heo
Hello, James. On Mon, Apr 18, 2005 at 10:33:21AM -0500, James Bottomley wrote: > On Mon, 2005-04-11 at 03:45 +0900, Tejun Heo wrote: > > scmd->eh_timeout is used to resolve the race between command > > completion and timeout. However, during error handling, > > scsi_send_eh_cmnd uses

Re: SCSI trees, merges and git status

2005-04-18 Thread Linus Torvalds
On Mon, 18 Apr 2005, James Bottomley wrote: > > As of today, I have two SCSI git trees operational: > > rsync://www.parisc-linux.org/~jejb/scsi-rc-fixes-2.6.git Merged. Here's the command line history: ~/git/git-pull-script rsync://www.parisc-linux.org/~jejb/scsi-rc-fixes-2.6.git

SCSI trees, merges and git status

2005-04-18 Thread James Bottomley
As of today, I have two SCSI git trees operational: rsync://www.parisc-linux.org/~jejb/scsi-rc-fixes-2.6.git and rsync://www.parisc-linux.org/~jejb/scsi-misc-2.6.git The latter has a non trivial merge in it because of a conflict in scsi_device.h, so merges actually do work ... The trees are ex

Re: [ANNOUNCE] sdparm 0.90

2005-04-18 Thread folkert
oh wait, 2.6 yes? then forget my bugreport (running 2.4.26-NANO) On Mon, Apr 18, 2005 at 11:26:03PM +1000, Douglas Gilbert wrote: > sdparm is a new command line utility designed to get and set > SCSI disk parameters (cf hdparm for ATA disks). More generally > it gets and sets mode page information

Re: [ANNOUNCE] sdparm 0.90

2005-04-18 Thread folkert
keetweej:/usr/src# sdparm -a /dev/sda SG_IO (inquiry) error: Invalid argument SCSI INQUIRY command failed on /dev/sda keetweej:/usr/src# sdparm /dev/sda SG_IO (inquiry) error: Invalid argument SCSI INQUIRY command failed on /dev/sda Feb 21 12:58:10 keetweej kernel: SCSI subsystem driver Revisio

Re: [RFC 1 of 9] patches to add diskdump functionality to block layer

2005-04-18 Thread Marcelo Tosatti
On Mon, Apr 18, 2005 at 04:42:26PM +0100, Christoph Hellwig wrote: > This looks like a patch for Linux 2.4. Such major changes for the > 2.4 tree don't make sense anymore, especially for functionality not > even in Linux 2.6. Agreed. - To unsubscribe from this list: send the line "unsubscribe li

Re: SYM8xx_2 driver ignores certain EEPROM settings

2005-04-18 Thread Peter Missel
Hello? > Back to the original topic ... do you have any news with regard to putting > the code back into the sym8xx driver that reads the user configured > channel/device negotiation settings (transfer speed and width limits, > timeouts, disconnect, etc. etc.) from the EEPROM? This is really causi

Re: [ANNOUNCE] sdparm 0.90

2005-04-18 Thread Jeff Garzik
Douglas Gilbert wrote: sdparm is a new command line utility designed to get and set SCSI disk parameters (cf hdparm for ATA disks). More generally it gets and sets mode page information on SCSI devices or devices that use a SCSI command set (e.g. CD/DVD drives (any transport) and SCSI tape drives).

RE: [RFC 1 of 9] patches to add diskdump functionality to block layer

2005-04-18 Thread Miller, Mike (OS Dev)
> From: Christoph Hellwig [mailto:[EMAIL PROTECTED] > > This looks like a patch for Linux 2.4. Such major changes for the > 2.4 tree don't make sense anymore, especially for > functionality not even in Linux 2.6. > This is for 2.4, I should have specified that in the Subject line. We did this

[RFC 2 of 9] patches to add diskdump to block layer

2005-04-18 Thread mike . miller
Please review this patch and provide comments or feedback. Patch 2 of 9 Thanks, mikem cciss_diskdump.c | 236 +++ 1 files changed, 236 insertions(+) Description: T

Re: [RFC 1 of 9] patches to add diskdump functionality to block layer

2005-04-18 Thread Arjan van de Ven
On Mon, 2005-04-18 at 10:36 -0500, [EMAIL PROTECTED] wrote: > + > +/* > + * Extended block operations for dump for preserving binary compatibility. > + */ > +struct block_dump_ops { > + int (*sanity_check)(void *device); > + int (*rw_block)(void *device, int rw, unsigned long dump_block_nr,

Re: [RFC 1 of 9] patches to add diskdump functionality to block layer

2005-04-18 Thread Arjan van de Ven
On Mon, 2005-04-18 at 10:36 -0500, [EMAIL PROTECTED] wrote: > Please review the following patches and provide any comments or feedback. > Patch 1 of 9 what diskdump do you use? Why do we even look at disk dump when kexec based dump can dump to disk too and is otherwise more flexible and superior?

Re: [RFC 1 of 9] patches to add diskdump functionality to block layer

2005-04-18 Thread Christoph Hellwig
This looks like a patch for Linux 2.4. Such major changes for the 2.4 tree don't make sense anymore, especially for functionality not even in Linux 2.6. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at ht

Fibre Channel state of the union

2005-04-18 Thread Christoph Hellwig
With the upcoming merge of the current SCSI development branch (probably after the 2.6.12 release), Linux will have more advanced Fibre Channel support than any currently available operating system. The new Fibre Channel (FC) transport class offers two major advantages over traditional standalone

[RFC 1 of 9] patches to add diskdump functionality to block layer

2005-04-18 Thread mike . miller
Please review the following patches and provide any comments or feedback. Patch 1 of 9 Thanks, mikem block_dump.c | 202 +++ block_dump.h | 29 2 files changed, 231 insertions(+) -

Re: [PATCH scsi-misc-2.6 02/07] scsi: make scsi_send_eh_cmnd use its own timer instead of scmd->eh_timeout

2005-04-18 Thread James Bottomley
On Mon, 2005-04-11 at 03:45 +0900, Tejun Heo wrote: > scmd->eh_timeout is used to resolve the race between command > completion and timeout. However, during error handling, > scsi_send_eh_cmnd uses scmd->eh_timeout. This creates a race > condition between eh and normal com

Re: Regarding posted scsi midlyaer patchsets

2005-04-18 Thread Tejun Heo
Hello, James. Hello, Jens. James Bottomley wrote: > On Mon, 2005-04-18 at 07:41 +0900, Tejun Heo wrote: > >> As it's been almost a week since I posted scsi midlayer patchsets and >>haven't heard anything yet, I've been wondering what's going on. Are >>they under review or all dropped? If they

Re: increasing scsi_max_sg / max_segments for scsi writes/reads

2005-04-18 Thread James Bottomley
On Sun, 2005-04-17 at 23:17 -0700, sai narasimhamurthy wrote: > I tried working on scsi_malloc to increase burst size > , but to no avail ..all I got was hanged system every > time I started data transfers! > Has anyone worked on scsi_malloc , I am still trying > to figure out what changes were ma

[ANNOUNCE] sdparm 0.90

2005-04-18 Thread Douglas Gilbert
sdparm is a new command line utility designed to get and set SCSI disk parameters (cf hdparm for ATA disks). More generally it gets and sets mode page information on SCSI devices or devices that use a SCSI command set (e.g. CD/DVD drives (any transport) and SCSI tape drives). The elements within mo

[PATCH] remove some dead code in qla2xxx

2005-04-18 Thread Christoph Hellwig
= drivers/scsi/qla2xxx/qla_dbg.c 1.12 vs edited = --- 1.12/drivers/scsi/qla2xxx/qla_dbg.c 2005-04-13 17:45:53 +02:00 +++ edited/drivers/scsi/qla2xxx/qla_dbg.c 2005-04-18 16:22:48 +02:00 @@ -1063,8 +1063,7 @@ return; printk(" sp flags=0x%x\n", sp->flags); -