On Wed, Mar 23 2005, Tejun Heo wrote:
> Hi,
>
> James Bottomley wrote:
> >On Wed, 2005-03-23 at 11:14 +0900, Tejun Heo wrote:
> >
> >>When hot-unplugging using scsi_remove_host() function (as usb
> >>does), scsi_forget_host() used to be called before
> >>scsi_host_cancel(). So, the d
Hello, James.
James Bottomley wrote:
On Wed, 2005-03-23 at 11:14 +0900, Tejun Heo wrote:
01_scsi_remove_scsi_release_buffers.patch
Buffer bouncing hasn't been done inside the scsi midlayer for
quite sometime now, but bounce-buffer release paths are still
around. This patch
Hello, guys.
On Tue, Mar 22, 2005 at 11:22:23PM -0500, Jeff Garzik wrote:
> James Bottomley wrote:
> >On Wed, 2005-03-23 at 11:14 +0900, Tejun Heo wrote:
> >
> >>scsi_device->device_busy, Scsi_Host->host_busy and
> >>->host_failed have volatile qualifiers, but the qualifiers
> >>don't
Hi,
James Bottomley wrote:
On Wed, 2005-03-23 at 11:14 +0900, Tejun Heo wrote:
When hot-unplugging using scsi_remove_host() function (as usb
does), scsi_forget_host() used to be called before
scsi_host_cancel(). So, the device gets removed first without
request cle
James Bottomley wrote:
On Wed, 2005-03-23 at 11:14 +0900, Tejun Heo wrote:
scsi_device->device_busy, Scsi_Host->host_busy and
->host_failed have volatile qualifiers, but the qualifiers
don't serve any purpose. Kill them. While at it, protect
->host_failed update in
On Wed, 2005-03-23 at 11:14 +0900, Tejun Heo wrote:
> So, basically, SCSI high-level object (scsi_disk) and
> mid-level object (scsi_device) are reference counted by users,
> not the requests they submit. Reference count cannot go zero
> with active users and users cannot a
On Wed, 2005-03-23 at 11:14 +0900, Tejun Heo wrote:
> scsi_device->device_busy, Scsi_Host->host_busy and
> ->host_failed have volatile qualifiers, but the qualifiers
> don't serve any purpose. Kill them. While at it, protect
> ->host_failed update in scsi_error for consist
On Wed, 2005-03-23 at 11:14 +0900, Tejun Heo wrote:
> When hot-unplugging using scsi_remove_host() function (as usb
> does), scsi_forget_host() used to be called before
> scsi_host_cancel(). So, the device gets removed first without
> request cleanup and scsi_host_cancel()
On Tue, 2005-03-22 at 13:35 -0700, Moore, Eric Dean wrote:
> I still wonder if the SPI transport layer will work for RAID volumes.
> Do you know if the spi transport layer supports dv on hidden devices in a
> raid volume?
> Meaning these hidden physical disks will not been seen by the block laye
On Wed, 2005-03-23 at 11:14 +0900, Tejun Heo wrote:
> 01_scsi_remove_scsi_release_buffers.patch
>
> Buffer bouncing hasn't been done inside the scsi midlayer for
> quite sometime now, but bounce-buffer release paths are still
> around. This patch removes these unused paths.
Yes
Yum Rayan wrote:
Attempt to reduce stack usage in sg.c.
Used checkstack.pl script to measure stack usage and noted follows:
Before patch:
sg_ioctl - 412
sg_read - 200
After patch:
sg_ioctl - 92
sg_read - 96
Thanks,
Rayan
Signed-off-by: Yum Rayan <[EMAIL PROTECTED]>
Mostly looks OK to me. However,
02_scsi_no_special_on_requeue.patch
blk_insert_request() has 'reinsert' argument, which, when set,
turns on REQ_SPECIAL and REQ_SOFTBARRIER and requeues the
request. SCSI midlayer was the only user of this feature and
all requeued requests become special requests d
07_scsi_refcnt_cleanup.patch
SCSI request submission paths can be categorized like the
following.
* through high-level driver (sd, st, sg...)
+ requests (fs / pc)
+ ioctls
+ flushes (issue_flush / barrier rqs)
05_scsi_timer_cleanup.patch
scsi_queue_insert() has four callers. Three callers call with
timer disabled and one (the second invocation in
scsi_dispatch_cmd()) calls with timer activated.
scsi_queue_insert() used to always call scsi_delete_timer()
and ignor
04_scsi_remove_volatile.patch
scsi_device->device_busy, Scsi_Host->host_busy and
->host_failed have volatile qualifiers, but the qualifiers
don't serve any purpose. Kill them. While at it, protect
->host_failed update in scsi_error for consistency and clarity.
Si
06_scsi_remove_serial_number_at_timeout.patch
scsi_cmnd->serial_number_at_timeout doesn't serve any purpose
anymore. All serial_number == serial_number_at_timeout tests
are always true in abort callbacks. Kill the field. Also, as
->pid always equals ->serial_numb
08_scsi_hot_unplug_fix.patch
When hot-unplugging using scsi_remove_host() function (as usb
does), scsi_forget_host() used to be called before
scsi_host_cancel(). So, the device gets removed first without
request cleanup and scsi_host_cancel() never gets to call
03_scsi_remove_internal_timeout.patch
scsi_cmnd->internal_timeout field doesn't have any meaning
anymore. Kill the field.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
drivers/scsi/advansys.c |2 --
drivers/scsi/pci2000.c|4 ++--
drivers/scsi/scsi.c |1 -
01_scsi_remove_scsi_release_buffers.patch
Buffer bouncing hasn't been done inside the scsi midlayer for
quite sometime now, but bounce-buffer release paths are still
around. This patch removes these unused paths.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
scsi_lib.c |
Hello, James.
Hello, Jens.
These are series of small fixes & cleanups. The last two patches
deal with reference counting and hot unplugging oops. Patches are
against scsi-misc-2.6 tree (this is the devel tree, right?).
Jens, please try #08 and tell me if you still get oops. AFAICT,
referen
On Sat, Mar 19, 2005 at 04:17:51PM -0600, Matt Domsch wrote:
> OK, then how's this for review? Compiles clean, can't test it myself
> for a few days.
>
> - int high = 0, mmu;
> - if (((unsigned long)virt_to_bus(memory) + size) > 0xUL)
> - high =
Thanks to both the Coverity checker and GNU gcc, it was found that this
variable is completely unused.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
--- linux-2.6.12-rc1-mm1-full/drivers/scsi/osst.c.old 2005-03-22
21:04:36.0 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/scsi/osst.c
On 03/22/2005 09:28:07 AM, Adrian Bunk wrote:
> This patch makes needlessly global code static.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
James, I agree with this, can you put it in BK, please?
Signed-off-by: Willem Riede <[EMAIL PROTECTED]>
> ---
>
> This patch was already sent on:
On Tuesday, March 22, 2005 12:05 PM, James Bottomley wrote:
> On Tue, 2005-03-22 at 11:40 -0700, Moore, Eric Dean wrote:
> > History on this:
> > Between the 3.01.16 and 3.01.18, we introduced new method
> > to passing command line options to the driver. Some of the
> > command line options are us
> #if defined(CONFIG_FOO) || (defined(MODULE) &&
defined(CONFIG_FOO_MODULE))
>
>is a good way to express that driver bar can use functionality of driver
>foo if it's available.
We need a way for a module to dynamically link itself, to whatever other
modules it wants to use, and to be able to d
On Tue, 2005-03-22 at 11:40 -0700, Moore, Eric Dean wrote:
> History on this:
> Between the 3.01.16 and 3.01.18, we introduced new method
> to passing command line options to the driver. Some of the
> command line options are used for fine tuning dv(domain
> validation) in the driver. By accident
Here is a patch for mpt fusion drivers, which
fix's issue of poor performance when driver compiled
built-in to the kernel.
Thanks to Chen, Kenneth W.
History on this:
Between the 3.01.16 and 3.01.18, we introduced new method
to passing command line options to the driver. Some of the
command line
On Mon, Mar 21, 2005 at 05:10:28PM -0600, Linas Vepstas wrote:
> My current hardware will halt all i/o to/from the symbios controller
> upon detection of a PCI error. The recovery proceedure that I am
> currently using is to call system firmware (aka 'bios') to raise
> and then lower the #RST pci
Christoph Hellwig said:
> We're not going to add new procfs handler for scsi HBA drivers.
And that was the answer to the question, thanks for answering it. Isn't
it nice to ask for guidance and get such direct answers?
Christoph Hellwig then goes on a tirade:
> Unfortunately this problems shows o
Linas Vepstas wrote:
> Hi,
>
> There has been a running thread for a while on several mailing lists
> concerning PCI bus error recovery. Very breifly, some architectures
> have PCI error recovery mechanisms built into them (e.g. IBM PowerPC,
> also new PCI-Express chips from Intel (and other ven
Hi list,
Tracing the kernel 2.6.8 code I found that scsi_mod maintains separate
request queues for each SCSI device. It uses the block layer queuing
facility to do this. What I could not find out was that once a request is
queued into a queue (for a particular device), WHEN and HOW is the strate
Christoph Hellwig said:
> On Thu, Mar 17, 2005 at 08:41:18AM -0500, Salyzyn, Mark wrote:
>> We are pressuring our management application folks to switch to /sys as
>> well, has not happened yet. In part because changes have to work for all
>> tested releases and operating systems, our testing depa
Hi list,
Tracing the kernel 2.6.8 code I found that scsi_mod maintains separate
request queues for each SCSI device. It uses the block layer queuing
facility to do this. What I could not find out was that once a request is
queued into a queue (for a particular device), WHEN and HOW is the strateg
On Mon, Mar 21, 2005 at 04:58:57PM +0800, erich wrote:
> Hi Dear All
Hi,
> I had modify arcmsr_iop_ioctlcmd data buffer allocations from the stack
> issue.
>...
thanks, but an additional stack issue is still present (it's a bit more
hidden):
- cmdioctlfld uses 1060 bytes from the stack
> Bes
On Tue, 2005-03-22 at 12:17 +0100, Jens Axboe wrote:
> You need to have io in progress. The one ref problem with
> scsi_allocate_request() is easy to trigger, if you just open/close the
> device repeatedly while inserting and removing it.
OK, this is the python program I've been using:
>>> while
This patch contains the following cleanups:
- make needlessly global code static
- remove or #if 0 the following unused finctions:
- tul_pop_pend_scb
- tul_device_reset
- tul_reset_scsi_bus
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch was already sent on:
- 28 Feb 2005
d
This patch makes needlessly global code static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch was already sent on:
- 28 Feb 2005
drivers/scsi/osst.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.11-rc4-mm1-full/drivers/scsi/osst.c.old 2005-02-28
This patch makes needlessly global code static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch was already sent on:
- 28 Feb 2005
drivers/scsi/pas16.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.11-rc4-mm1-full/drivers/scsi/pas16.c.old 2005-02
On Tue, 22 Mar 2005, Chen, Kenneth W wrote:
On Mon, 21 Mar 2005, Andrew Morton wrote:
Holger, this problem remains unresolved, does it not? Have you done any
more experimentation?
I must say that something funny seems to be happening here. I have two
MPT-based Dell machines, neither of which is u
On Sunday, March 20, 2005 8:14 AM, Tobias wrote:
> The previous patch did not compile cleanly on all architectures so
> here's a fixed one.
>
> Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when calling
> pci_set_dma_mask() or pci_set_consistent_dma_mask()
> This patch includes dma-mapp
On Tuesday 22 March 2005 01:08, Andrew Morton wrote:
>
> Sergey, I'm assuming this is a bug in the megaraid driver.
Sorry for a slow response.
>
> Can you confirm that it's still happening in 2.6.12-rc1?
Unfortunately I'm not shure I remember well the exact sequence
of operations I performed in n
>
> And there are places where it's actually useful:
>
> #if defined(CONFIG_FOO) || (defined(MODULE) && defined(CONFIG_FOO_MODULE))
>
> is a good way to express that driver bar can use functionality of driver
> foo if it's available.
a good way? I'd disagree with that :)
-
To unsubscribe
On Tue, Mar 22, 2005 at 11:52:22AM +0100, Arjan van de Ven wrote:
> On Tue, 2005-03-22 at 02:29 -0800, Chen, Kenneth W wrote:
>
> > Before:
> > /dev/sdc:
> > Timing buffered disk reads: 92 MB in 3.03 seconds = 30.32 MB/sec
> >
> > After:
> > /dev/sdc:
> > Timing buffered disk reads: 174 MB
On Tue, Mar 22 2005, Tejun Heo wrote:
> Hello, Jens.
> Hello, James.
>
> On Mon, Mar 21, 2005 at 05:57:52PM +0100, Jens Axboe wrote:
> > On Mon, Mar 21 2005, James Bottomley wrote:
> > > On Mon, 2005-03-21 at 14:26 +0100, Jens Axboe wrote:
> > > > scsi_allocate_request() doesn't hold a reference
On Tue, 2005-03-22 at 02:29 -0800, Chen, Kenneth W wrote:
> Before:
> /dev/sdc:
> Timing buffered disk reads: 92 MB in 3.03 seconds = 30.32 MB/sec
>
> After:
> /dev/sdc:
> Timing buffered disk reads: 174 MB in 3.02 seconds = 57.61 MB/sec
nice!
More proof that #ifdef MODULE is consider
"Chen, Kenneth W" <[EMAIL PROTECTED]> wrote:
>
> On Mon, 21 Mar 2005, Andrew Morton wrote:
> > Holger, this problem remains unresolved, does it not? Have you done any
> > more experimentation?
> >
> > I must say that something funny seems to be happening here. I have two
> > MPT-based Dell machin
On Mon, 21 Mar 2005, Andrew Morton wrote:
> Holger, this problem remains unresolved, does it not? Have you done any
> more experimentation?
>
> I must say that something funny seems to be happening here. I have two
> MPT-based Dell machines, neither of which is using a modular driver:
>
> akpm:/u
On Mon, 21 Mar 2005, Andrew Morton wrote:
Holger Kiehl <[EMAIL PROTECTED]> wrote:
Hello
On a four CPU Opteron compiling the Fusion-MPT as module gives much better
performance when compiling it in, here some bonnie++ results:
Version 1.03 --Sequential Output-- --Sequential Input- --Ra
Attempt to reduce stack usage in sg.c.
Used checkstack.pl script to measure stack usage and noted follows:
Before patch:
sg_ioctl - 412
sg_read - 200
After patch:
sg_ioctl - 92
sg_read - 96
Thanks,
Rayan
Signed-off-by: Yum Rayan <[EMAIL PROTECTED]>
diff -Nur linux-2.6.11.5.orig/drivers/scsi/
49 matches
Mail list logo
