Re: [v8] media: imx: add mem2mem device

2019-05-29 Thread Sven Van Asbroeck
Thank you all (and especially Philipp) for this amazing work ! One of the main uses for the VPU scaler is to convert from video file resolution to display resolution. E.g. the source video is 1080p, but the display videomode is only 720p. Unfortunately when I connect CODA/h264 decode to the VPU s

Re: [v8] media: imx: add mem2mem device

2019-05-29 Thread Sven Van Asbroeck
Hi Fabio, On Wed, May 29, 2019 at 12:53 PM Fabio Estevam wrote: > > Does this patch from Philipp fix the problem? > https://git.pengutronix.de/cgit/pza/linux/commit/?h=imx-drm/fixes&id=137caa702f2308f7ef03876e164b0d0f3300712a Thank you so much for the suggestion ! It does like a really good cand

Re: [v8] media: imx: add mem2mem device

2019-05-29 Thread Sven Van Asbroeck
Philipp and Fabio, On Wed, May 29, 2019 at 12:53 PM Fabio Estevam wrote: > > Does this patch from Philipp fix the problem? > https://git.pengutronix.de/cgit/pza/linux/commit/?h=imx-drm/fixes&id=137caa702f2308f7ef03876e164b0d0f3300712a I am now running 5.2-rc2 with Philipp's non-plus imx6q patch.

Re: [v8] media: imx: add mem2mem device

2019-05-30 Thread Sven Van Asbroeck
Nicholas and Fabio, thank you so much for your help ! On Thu, May 30, 2019 at 5:09 PM Nicolas Dufresne wrote: > > Just for your information, I tested with this pipeline, with kernel > "5.2.0-rc2-00024-gbec7550cca10": > > Execution ended after 0:00:12.860395248 I noticed that my mainline kernel w

Re: [v8] media: imx: add mem2mem device

2019-05-30 Thread Sven Van Asbroeck
On Thu, May 30, 2019 at 6:18 PM Fabio Estevam wrote: > > Please start a new thread in linux-arm-kernel on this topic and also > copy Robin and the folks from > ./scripts/get_maintainer.pl -f drivers/dma/imx-sdma.c Thank you, I will post a bug report once I locate the commit which introduces the i

Re: [v8] media: imx: add mem2mem device

2019-05-31 Thread Sven Van Asbroeck
Hello Nicholas, thank you so much for investigating. On Fri, May 31, 2019 at 11:34 AM Nicolas Dufresne wrote: > > Now, if that pipeline was live, this would be a problem. This is where my gstreamer knowledge gets really hazy. What does it mean for a pipeline to be 'live' ? Would this be a proble

Re: [v8] media: imx: add mem2mem device

2019-05-31 Thread Sven Van Asbroeck
Hello Nicholas and Fabio, The sdma firmware turned out to be a non-issue: adding "qos=0" to kmssink (as suggested by Nicholas) is what fixed kmssink performance, unrelated to sdma. (Although I still see an sdma issue, unrelated to this thread - I will talk to Robin about it outside of the thread)

Re: [v8] media: imx: add mem2mem device

2019-05-31 Thread Sven Van Asbroeck
Hi Robin, On Thu, May 30, 2019 at 8:26 PM Robin Gong wrote: > What's soc chip and board you used? Could you post log? The mainline kernel we've been using does not have any sdma firmware, and as a result we get this in the log: # uname -a Linux Chimera 5.2.0-rc2-00041-g22a1787e8f40 #66

Re: [v8] media: imx: add mem2mem device

2019-06-04 Thread Sven Van Asbroeck
Hi Robin, On Tue, Jun 4, 2019 at 4:51 AM Robin Gong wrote: > > Hi Sven, > I saw similar kernel crash issue on the latest linux-next during > kernel boot up, but not on > the 'Linux 5.2-rc1 ' tag. Will do bisect later. But v5.0 should be okay, > could you help double check? Of course. M

Re: [v8] media: imx: add mem2mem device

2019-06-05 Thread Sven Van Asbroeck
On Wed, Jun 5, 2019 at 6:08 AM Robin Gong wrote: > > Hi Sven, > I met below crash on v5.2-rc1 and found it's related with commit > 728e0fbf263e, after googled, the latest > Linux-next should fix the issue, please check > https://lkml.org/lkml/2019/6/3/1405. > After I rebased to the late

Re: [v8] media: imx: add mem2mem device

2019-06-06 Thread Sven Van Asbroeck
On Wed, Jun 5, 2019 at 10:32 PM Robin Gong wrote: > > So that's another issue that I can't reproduce. How do you switch between > sdma ROM/RAM firmware load? Just keep or remove > sdma-imx6q.bin in your ramfs(seems you used)? I add the sdma firmware to the kernel image, by adding the following t

Re: [v8] media: imx: add mem2mem device

2019-06-10 Thread Sven Van Asbroeck
On Mon, Jun 10, 2019 at 5:09 AM Robin Gong wrote: > > I can reproduce once enable your config to build firmware in kernel, but no > such issue > if load sdma firmware from rootfs as imx_v6_v7_defconfig. Maybe firmware > built in function > broken by some patches. Could you try with the default f

Re: [v8] media: imx: add mem2mem device

2019-06-11 Thread Sven Van Asbroeck
On Tue, Jun 11, 2019 at 5:09 AM Robin Gong wrote: > > Sven, no any dependency from sdma driver view. The only difference between > directly loading firmware > from kernel and rootfs is the former spend more time during kernel boot and > such timing may cause > the crash. The issue is not 100% in

Re: [v8] media: imx: add mem2mem device

2019-06-13 Thread Sven Van Asbroeck
On Thu, Jun 13, 2019 at 4:52 AM Robin Gong wrote: > > Thank Sven, please have a try with the below patch. I'll send it to > review later. That's awesome, we are cooking with gas :) Actually I patched only the sdma_load_script() function (not _context()) and the crash no longer happens. Cc me on