[PATCH] [media] m2m-deinterlace: Fix error print during probe

2016-08-23 Thread Peter Ujfalusi
v4l2_err() can not be used for printing error for missing interleaved support in DMA as this point the pcdev->v4l2_dev is not valid. Signed-off-by: Peter Ujfalusi --- drivers/media/platform/m2m-deinterlace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/me

Re: [PATCH] [media] v4l: omap_vout: vrfb: Convert to dmaengine

2016-09-06 Thread Peter Ujfalusi
Hi, On 08/18/16 13:22, Peter Ujfalusi wrote: > The dmaengine driver for sDMA now have support for interleaved transfer. > This trasnfer type was open coded with the legacy omap-dma API, but now > we can move it to dmaengine. > > Signed-off-by: Peter Ujfalusi > --- > The

[PATCH] media: v4l: omap_vout: vrfb: Use the wrapper for prep_interleaved_dma()

2018-01-19 Thread Peter Ujfalusi
Instead of directly accessing to dmadev->device_prep_interleaved_dma() use the dmaengine_prep_interleaved_dma() wrapper instead. Signed-off-by: Peter Ujfalusi --- drivers/media/platform/omap/omap_vout_vrfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/me

Re: [PATCH] omap-dma/omap_vout_vrfb: fix off-by-one fi value

2019-07-31 Thread Peter Ujfalusi
Beagle XM board to check that > the '+ 1' in omap_vout_vrfb.c was indeed a workaround for the omap-dma > bug. Thanks for catching it. I have implemented the interleaved support based on the omap_vout_vrfb driver's behavior and hence I have missed the + 1 in the omap-dma. Acked-

[PATCH] media: omap3isp: Use dma_request_chan() to requesting DMA channel

2016-04-29 Thread Peter Ujfalusi
With the new dma_request_chan() the client driver does not need to look for the DMA resource and it does not need to pass filter_fn anymore. By switching to the new API the driver can now support deferred probing against DMA. Signed-off-by: Peter Ujfalusi CC: Laurent Pinchart CC: Mauro Carvalho

Re: [PATCH] [BUGREPORT] media: v4l: omap_vout: vrfb: initialize DMA flags

2017-07-17 Thread Peter Ujfalusi
6a1560ecaa8c ("media: v4l: omap_vout: vrfb: Convert to dmaengine") > Signed-off-by: Arnd Bergmann Acked-by: Peter Ujfalusi > --- > drivers/media/platform/omap/omap_vout_vrfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/me

Re: [PATCH] media: v4l: omap_vout: vrfb: remove an unused variable

2018-03-13 Thread Peter Ujfalusi
: error: unused variable > 'dmadev' [-Werror=unused-variable] > > Fixes: 8f0aa38292f2 ("media: v4l: omap_vout: vrfb: Use the wrapper for > prep_interleaved_dma()") > Signed-off-by: Arnd Bergmann Reviewed-by: Peter Ujfalusi > --- > drivers/media/platform/

[RESEND v2 PATCH] v4l: omap_vout: vrfb: Convert to dmaengine

2017-05-03 Thread Peter Ujfalusi
The dmaengine driver for sDMA now have support for interleaved transfer. This trasnfer type was open coded with the legacy omap-dma API, but now we can move it to dmaengine. Signed-off-by: Peter Ujfalusi --- Hi, changes since RESEND (27.10.2016): - rebased on next-20170503 I can not test it on

Re: [RESEND v2 PATCH] v4l: omap_vout: vrfb: Convert to dmaengine

2017-05-03 Thread Peter Ujfalusi
On 2017-05-03 14:08, Peter Ujfalusi wrote: The dmaengine driver for sDMA now have support for interleaved transfer. This trasnfer type was open coded with the legacy omap-dma API, but now we can move it to dmaengine. Signed-off-by: Peter Ujfalusi --- Hi, changes since RESEND (27.10.2016

Re: [alsa-devel] WL1273 FM Radio driver...

2011-02-08 Thread Peter Ujfalusi
Hi, On 02/07/11 18:00, ext Mauro Carvalho Chehab wrote: > We don't need any brand names or specific details, but it would be good to > have an overview, in general lines, about the architecture, in order to help > you to map how this would fit. In particular, the architecturre of > things that

Re: [alsa-devel] WL1273 FM Radio driver...

2011-02-08 Thread Peter Ujfalusi
On 02/08/11 12:09, ext Bensaid, Selma wrote: > 2 Digital interfaces are possible for FM WL1273: > - the external connection: the I2S lines are used for the FM PCM samples > - the internal connection: the BT PCM interface is used for the FM PCM samples Yes, that is correct, I just did not wanted to

[PATCH RESEND] media: omap3isp: Use dma_request_chan() to requesting DMA channel

2016-11-02 Thread Peter Ujfalusi
With the new dma_request_chan() the client driver does not need to look for the DMA resource and it does not need to pass filter_fn anymore. By switching to the new API the driver can now support deferred probing against DMA. Signed-off-by: Peter Ujfalusi CC: Laurent Pinchart CC: Mauro Carvalho

Re: [PATCH RESEND] media: omap3isp: Use dma_request_chan() to requesting DMA channel

2016-11-03 Thread Peter Ujfalusi
On 11/02/2016 11:19 PM, Laurent Pinchart wrote: > Hi Peter, > > Thank you for the patch. > > On Wednesday 02 Nov 2016 14:39:59 Peter Ujfalusi wrote: >> With the new dma_request_chan() the client driver does not need to look for >> the DMA resource and it does not nee

Re: [PATCH RESEND] media: omap3isp: Use dma_request_chan() to requesting DMA channel

2016-11-03 Thread Peter Ujfalusi
On 11/03/2016 11:23 AM, Peter Ujfalusi wrote: > > On 11/02/2016 11:19 PM, Laurent Pinchart wrote: >> > Hi Peter, >> > >> > Thank you for the patch. >> > >> > On Wednesday 02 Nov 2016 14:39:59 Peter Ujfalusi wrote: >>> >> With

[PATCH v2] media: omap3isp: Use dma_request_chan_by_mask() to request the DMA channel

2016-11-04 Thread Peter Ujfalusi
misleading use of the DMAengine API - implying that the omap3isp does need to have DMA resource or valid dma binding in DT. Signed-off-by: Peter Ujfalusi CC: Laurent Pinchart CC: Mauro Carvalho Chehab --- Hi, Changes sicne v1: - use dma_request_chan_by_mask() to request the channel as for the

Re: [PATCH RESEND] media: omap3isp: Use dma_request_chan() to requesting DMA channel

2016-11-04 Thread Peter Ujfalusi
Hi Laurent, On 11/03/2016 05:12 PM, Laurent Pinchart wrote: >> It is a bit misleading that it used dma_request_slave_channel_compat() >> for getting the channel. >> >> I think what would be correct is: >> dma_cap_mask_t mask; >> >> dma_cap_zero(mask); >> dma_cap_set(DMA_SLAVE, mask); >> hist->dma_

[PATCH] [media] v4l: omap_vout: vrfb: Convert to dmaengine

2016-08-18 Thread Peter Ujfalusi
The dmaengine driver for sDMA now have support for interleaved transfer. This trasnfer type was open coded with the legacy omap-dma API, but now we can move it to dmaengine. Signed-off-by: Peter Ujfalusi --- The dmaengine driver for sDMA now have support for interleaved transfer. This trasnfer

Re: [PATCH 12/13] [media] omap3isp: Support for deferred probing when requesting DMA channel

2015-11-09 Thread Peter Ujfalusi
ew series in the coming weeks. Thanks, Péter > > On Tuesday 26 May 2015 16:26:07 Peter Ujfalusi wrote: >> Switch to use ma_request_slave_channel_compat_reason() to request the DMA >> channel. Only fall back to pio mode if the error code returned is not >> -EPROBE_DEFER

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-11-18 Thread Peter Ujfalusi
Hi Vinod, bringing this old thread back to life as I just started to work on this. On 06/24/2015 07:24 PM, Vinod Koul wrote: >> We would end up with the following APIs, all returning with error code on >> failure: >> dma_request_slave_channel(dev, name); >> dma_request_channel_legacy(mask, fn,

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-11-18 Thread Peter Ujfalusi
On 11/18/2015 04:29 PM, Arnd Bergmann wrote: > On Wednesday 18 November 2015 16:21:26 Peter Ujfalusi wrote: >> 2. non slave channel requests, where only the functionality matters, like >> memcpy, interleaved, memset, etc. >> We could have a simple: >> dma_request_chann

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-11-19 Thread Peter Ujfalusi
On 11/18/2015 05:07 PM, Arnd Bergmann wrote: > On Wednesday 18 November 2015 16:41:35 Peter Ujfalusi wrote: >> On 11/18/2015 04:29 PM, Arnd Bergmann wrote: >>> On Wednesday 18 November 2015 16:21:26 Peter Ujfalusi wrote: >>>> 2. non slave channel requests, where

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-11-19 Thread Peter Ujfalusi
On 11/18/2015 05:46 PM, Andy Shevchenko wrote: > On Wed, Nov 18, 2015 at 4:21 PM, Peter Ujfalusi wrote: >> Hi Vinod, >> >> bringing this old thread back to life as I just started to work on this. > > What I remember we need to convert drivers to use new API meanwhile i

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-11-20 Thread Peter Ujfalusi
On 11/19/2015 01:25 PM, Arnd Bergmann wrote: >> If we have two main APIs, one to request slave channels and one to get any >> channel with given capability >> dma_request_slave_channel(NULL, NULL, &mask, fn, fn_param); /* Legacy slave >> */ >> dma_request_slave_channel(dev, name, NULL, NULL, NULL)

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-11-20 Thread Peter Ujfalusi
On 11/20/2015 02:24 PM, Andy Shevchenko wrote: > On Fri, Nov 20, 2015 at 12:58 PM, Arnd Bergmann wrote: >> On Friday 20 November 2015 12:25:06 Peter Ujfalusi wrote: >>> On 11/19/2015 01:25 PM, Arnd Bergmann wrote: > >> Another idea would be to remove the filter functi

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-11-20 Thread Peter Ujfalusi
On 11/20/2015 12:58 PM, Arnd Bergmann wrote: >>> That way the vast majority of drivers can use one of the two nice interfaces >>> and the rest can be converted to use __dma_request_chan(). >>> >>> On a related topic, we had in the past considered providing a way for >>> platform code to register a

[PATCH 06/13] mmc: omap: Support for deferred probing when requesting DMA channels

2015-05-26 Thread Peter Ujfalusi
Switch to use ma_request_slave_channel_compat_reason() to request the DMA channels. Only fall back to pio mode if the error code returned is not -EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER. Signed-off-by: Peter Ujfalusi CC: Ulf Hansson CC: Jarkko Nikula --- drivers

[PATCH 03/13] serial: 8250_dma: Support for deferred probing when requesting DMA channels

2015-05-26 Thread Peter Ujfalusi
Switch to use ma_request_slave_channel_compat_reason() to request the DMA channels. In case of error, return the error code we received including -EPROBE_DEFER Signed-off-by: Peter Ujfalusi CC: Greg Kroah-Hartman --- drivers/tty/serial/8250/8250_dma.c | 18 -- 1 file changed, 8

[PATCH 13/13] ASoC: omap-pcm: Switch to use dma_request_slave_channel_compat_reason()

2015-05-26 Thread Peter Ujfalusi
dmaengine provides a wrapper function to handle DT and non DT boots when requesting DMA channel. Use that instead of checking for of_node in the platform driver. Signed-off-by: Peter Ujfalusi CC: Mark Brown CC: Jarkko Nikula CC: Liam Girdwood --- sound/soc/omap/omap-pcm.c | 16

[PATCH 10/13] crypto: omap-sham - Support for deferred probing when requesting DMA channel

2015-05-26 Thread Peter Ujfalusi
Switch to use ma_request_slave_channel_compat_reason() to request the DMA channel. Only fall back to polling mode if the error code returned is not -EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER. Signed-off-by: Peter Ujfalusi CC: Herbert Xu CC: David S. Miller CC: Lokesh

[PATCH 08/13] crypto: omap-aes - Support for deferred probing when requesting DMA channels

2015-05-26 Thread Peter Ujfalusi
Switch to use ma_request_slave_channel_compat_reason() to request the DMA channels. Only fall back to pio mode if the error code returned is not -EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER. Signed-off-by: Peter Ujfalusi CC: Herbert Xu CC: David S. Miller CC: Lokesh

[PATCH 11/13] spi: omap2-mcspi: Support for deferred probing when requesting DMA channels

2015-05-26 Thread Peter Ujfalusi
Switch to use ma_request_slave_channel_compat_reason() to request the DMA channels. Only fall back to pio mode if the error code returned is not -EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER. Signed-off-by: Peter Ujfalusi CC: Mark Brown --- drivers/spi/spi-omap2-mcspi.c

[PATCH 12/13] [media] omap3isp: Support for deferred probing when requesting DMA channel

2015-05-26 Thread Peter Ujfalusi
Switch to use ma_request_slave_channel_compat_reason() to request the DMA channel. Only fall back to pio mode if the error code returned is not -EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER. Signed-off-by: Peter Ujfalusi CC: Laurent Pinchart CC: Mauro Carvalho Chehab

[PATCH 09/13] crypto: omap-des - Support for deferred probing when requesting DMA channels

2015-05-26 Thread Peter Ujfalusi
Switch to use ma_request_slave_channel_compat_reason() to request the DMA channels. Only fall back to pio mode if the error code returned is not -EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER. Signed-off-by: Peter Ujfalusi CC: Herbert Xu CC: David S. Miller CC: Lokesh

[PATCH 07/13] mmc: davinci_mmc: Support for deferred probing when requesting DMA channels

2015-05-26 Thread Peter Ujfalusi
Switch to use ma_request_slave_channel_compat_reason() to request the DMA channels. Only fall back to pio mode if the error code returned is not -EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER. Signed-off-by: Peter Ujfalusi CC: Ulf Hansson --- drivers/mmc/host

[PATCH 01/13] dmaengine: of_dma: Correct return code for of_dma_request_slave_channel in case !CONFIG_OF

2015-05-26 Thread Peter Ujfalusi
of_dma_request_slave_channel should return either pointer for valid dma_chan or ERR_PTR() error code, NULL is not expected to be returned. Signed-off-by: Peter Ujfalusi CC: Grant Likely CC: Rob Herring --- include/linux/of_dma.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 05/13] mmc: omap_hsmmc: Support for deferred probing when requesting DMA channels

2015-05-26 Thread Peter Ujfalusi
Switch to use ma_request_slave_channel_compat_reason() to request the DMA channels. In case of error, return the error code we received including -EPROBE_DEFER Signed-off-by: Peter Ujfalusi CC: Ulf Hansson --- drivers/mmc/host/omap_hsmmc.c | 22 ++ 1 file changed, 10

[PATCH 04/13] mmc: omap_hsmmc: No need to check DMA channel validity at module remove

2015-05-26 Thread Peter Ujfalusi
The driver will not probe without valid DMA channels so no need to check if they are valid when the module is removed. Signed-off-by: Peter Ujfalusi CC: Ulf Hansson --- drivers/mmc/host/omap_hsmmc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host

[PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-05-26 Thread Peter Ujfalusi
the caller in case dma_request_slave_channel_reason() returned with it. Signed-off-by: Peter Ujfalusi --- include/linux/dmaengine.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index abf63ceabef9..6c777394835c 10

[PATCH 00/13] dmaengine + omap drivers: support fro deferred probing

2015-05-26 Thread Peter Ujfalusi
deferred by missing regulator so 480b4000.mmc got registered first. In case 2 both deferring because of DMA and at the end 4809c000.mmc get registered first. So far I have not found a way to bind mmcblk0/1 to a specific node... Regards, Peter --- Peter Ujfalusi (13): dmaengine: of_dma: Correct

Re: [PATCH 03/13] serial: 8250_dma: Support for deferred probing when requesting DMA channels

2015-05-27 Thread Peter Ujfalusi
On 05/26/2015 05:44 PM, Greg Kroah-Hartman wrote: > On Tue, May 26, 2015 at 04:25:58PM +0300, Peter Ujfalusi wrote: >> Switch to use ma_request_slave_channel_compat_reason() to request the DMA >> channels. In case of error, return the error code we received including >> -EPRO

Re: [PATCH 03/13] serial: 8250_dma: Support for deferred probing when requesting DMA channels

2015-05-27 Thread Peter Ujfalusi
On 05/27/2015 01:41 PM, Peter Ujfalusi wrote: > On 05/26/2015 05:44 PM, Greg Kroah-Hartman wrote: >> On Tue, May 26, 2015 at 04:25:58PM +0300, Peter Ujfalusi wrote: >>> Switch to use ma_request_slave_channel_compat_reason() to request the DMA >>> channels. In case of e

Re: [PATCH 03/13] serial: 8250_dma: Support for deferred probing when requesting DMA channels

2015-05-27 Thread Peter Ujfalusi
On 05/26/2015 06:08 PM, Tony Lindgren wrote: > * Peter Ujfalusi [150526 06:28]: >> Switch to use ma_request_slave_channel_compat_reason() to request the DMA >> channels. In case of error, return the error code we received including >> -EPROBE_DEFER >> >> Signed-of

Re: [PATCH 11/13] spi: omap2-mcspi: Support for deferred probing when requesting DMA channels

2015-05-27 Thread Peter Ujfalusi
Mark, On 05/26/2015 06:27 PM, Mark Brown wrote: > On Tue, May 26, 2015 at 04:26:06PM +0300, Peter Ujfalusi wrote: > >> Switch to use ma_request_slave_channel_compat_reason() to request the DMA >> channels. Only fall back to pio mode if the error code returned is not >>

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-05-29 Thread Peter Ujfalusi
On 05/29/2015 01:18 PM, Vinod Koul wrote: > On Fri, May 29, 2015 at 11:42:27AM +0200, Geert Uytterhoeven wrote: >> On Fri, May 29, 2015 at 11:33 AM, Vinod Koul wrote: >>> On Tue, May 26, 2015 at 04:25:57PM +0300, Peter Ujfalusi wrote: >>>> dma_request_slave_channel_c

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-06-04 Thread Peter Ujfalusi
Vinod, On 06/02/2015 03:55 PM, Vinod Koul wrote: > On Fri, May 29, 2015 at 05:32:50PM +0300, Peter Ujfalusi wrote: >> On 05/29/2015 01:18 PM, Vinod Koul wrote: >>> On Fri, May 29, 2015 at 11:42:27AM +0200, Geert Uytterhoeven wrote: >>>> On Fri, May 29, 2015

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

2015-06-22 Thread Peter Ujfalusi
On 06/12/2015 03:58 PM, Vinod Koul wrote: > Sorry this slipped thru I was away for a week anyways ;) > Thinking about it again, I think we should coverge to two APIs and mark the > legacy depracuated and look to convert folks and phase that out Currently, w/o this series we have these APIs: /* t