Hi Mauro,
thanks for your feedback.
On 18-07-30 15:00, Mauro Carvalho Chehab wrote:
> Em Thu, 28 Jun 2018 18:20:45 +0200
> Marco Felsch escreveu:
>
> > From: Philipp Zabel
> >
> > To avoid short frames on stream start, keep output pins at high impedance
> >
Hi Mauro,
On 18-07-30 15:18, Mauro Carvalho Chehab wrote:
> Em Thu, 28 Jun 2018 18:20:50 +0200
> Marco Felsch escreveu:
>
> > From: Javier Martinez Canillas
> >
> > Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support")
> > added
;
> >> On 07/30/2018 08:18 PM, Mauro Carvalho Chehab wrote:
> >>> Em Thu, 28 Jun 2018 18:20:50 +0200
> >>> Marco Felsch escreveu:
> >>>
> >>>> From: Javier Martinez Canillas
> >>>>
> >>>> Commit f7b4b54e6
Hi Javier,
On 18-07-31 14:52, Javier Martinez Canillas wrote:
> Hi Marco,
>
> On 07/31/2018 02:36 PM, Marco Felsch wrote:
>
> [snip]
>
> >>
> >> Yes, another thing that patch 19/22 should take into account is DTs that
> >> don't have input
Hi Mauro,
On 18-07-31 16:56, Mauro Carvalho Chehab wrote:
> Em Tue, 31 Jul 2018 15:30:56 +0200
> Marco Felsch escreveu:
>
> > Hi Javier,
> >
> > On 18-07-31 14:52, Javier Martinez Canillas wrote:
> > > Hi Marco,
> > >
> > > On 07/31
Hi Mauro,
On 18-07-30 15:09, Mauro Carvalho Chehab wrote:
> Em Thu, 28 Jun 2018 18:20:48 +0200
> Marco Felsch escreveu:
>
> > From: Philipp Zabel
> >
> > Add the querystd video_op and make it return V4L2_STD_UNKNOWN while the
> > TVP5150 is not locked to
Hi Mauro,
On 18-08-01 11:22, Mauro Carvalho Chehab wrote:
> Em Wed, 1 Aug 2018 15:21:25 +0200
> Marco Felsch escreveu:
>
> > Hi Mauro,
> >
> > On 18-07-30 15:09, Mauro Carvalho Chehab wrote:
> > > Em Thu, 28 Jun 2018 18:20:48 +0200
> > > Marco Fel
Hi Javier,
On 18-07-31 15:30, Marco Felsch wrote:
> Hi Javier,
>
> On 18-07-31 14:52, Javier Martinez Canillas wrote:
> > Hi Marco,
> >
> > On 07/31/2018 02:36 PM, Marco Felsch wrote:
> >
> > [snip]
> >
> > >>
> > >> Yes
Hi Mauro,
On 18-08-01 12:50, Mauro Carvalho Chehab wrote:
> Em Wed, 1 Aug 2018 16:49:26 +0200
> Marco Felsch escreveu:
>
> > Hi Mauro,
> >
> > On 18-08-01 11:22, Mauro Carvalho Chehab wrote:
> > > Em Wed, 1 Aug 2018 15:21:25 +0200
> > > Marc
Hi Mauro,
On 18-08-02 06:49, Mauro Carvalho Chehab wrote:
> Em Thu, 2 Aug 2018 10:01:01 +0200
> Marco Felsch escreveu:
>
> > Hi Mauro,
> >
> > On 18-08-01 12:50, Mauro Carvalho Chehab wrote:
> > > Em Wed, 1 Aug 2018 16:49:26 +0200
> > > Marc
Hi Ian,
On 18-08-02 11:54, Ian Arkver wrote:
> On 02/08/18 10:49, Mauro Carvalho Chehab wrote:
> > Em Thu, 2 Aug 2018 10:01:01 +0200
> > Marco Felsch escreveu:
> >
> > > Hi Mauro,
> > >
> > > On 18-08-01 12:50, Mauro Carvalho Chehab
Hi Rob,
first of all, thanks for the review. After some discussion with the
media guys I have a question about the dt-bindings.
On 18-07-03 17:23, Rob Herring wrote:
> On Thu, Jun 28, 2018 at 06:20:52PM +0200, Marco Felsch wrote:
> > The TVP5150/1 decoders support different video inpu
Hi Mauro,
On 18-08-03 14:30, Mauro Carvalho Chehab wrote:
> Em Fri, 3 Aug 2018 09:29:53 +0200
> Marco Felsch escreveu:
>
> > Hi Rob,
> >
> > first of all, thanks for the review. After some discussion with the
> > media guys I have a question about the dt-bin
://www.spinics.net/lists/linux-media/msg138545.html
[2] https://www.spinics.net/lists/linux-media/msg138546.html
On 18-07-30 15:29, Mauro Carvalho Chehab wrote:
> Em Thu, 28 Jun 2018 18:20:51 +0200
> Marco Felsch escreveu:
>
> > The currrent driver layout had the f
Hi Mauro,
On 18-08-08 15:52, Mauro Carvalho Chehab wrote:
> Em Wed, 8 Aug 2018 17:29:49 +0200
> Marco Felsch escreveu:
>
> > Hi Mauro,
> >
> > the discussion about the correct binding was spread around some patches.
> > So I will try use the correct thread fo
attached both inline as an RFC, can give me your feedback?
I removed the devicetree guys to aviod noise.
On 18-07-30 21:01, Mauro Carvalho Chehab wrote:
> Em Thu, 28 Jun 2018 18:20:38 +0200
> Marco Felsch escreveu:
>
> > Since commit 10d5509c8d50 ("[media] v4l2: remove g/s
Hi Mauro,
Thanks for your feedback.
On 18-08-09 10:36, Mauro Carvalho Chehab wrote:
> Em Thu, 9 Aug 2018 14:55:07 +0200
> Marco Felsch escreveu:
>
> > Hi Mauro,
> >
> > On 18-08-08 15:52, Mauro Carvalho Chehab wrote:
> > > Em Wed, 8 Aug 2018 17:29:4
Hi Mauro,
On 18-08-09 13:04, Mauro Carvalho Chehab wrote:
> Em Thu, 9 Aug 2018 16:35:20 +0200
> Marco Felsch escreveu:
>
> > Hi Mauro,
> >
> > Thanks for your feedback.
>
> > > > > > + dev_dbg(sd->dev, "link setup '%s':%d-&
s approach is less error prone too.
Signed-off-by: Marco Felsch
---
include/media/v4l2-subdev.h | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index 9102d6ca566e..ce48f1fcf295 100644
--- a/include/
ile handle or
driver state) which will be set/returned.
The TVP5150 AVID will be updated if the 'which' field is FORMAT_ACTIVE
and the requested selection rectangle differs from the already set one.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 109 ++
() callback ensures that only one
connector is active.
[1] https://www.spinics.net/lists/linux-media/msg138545.html
[2] https://www.spinics.net/lists/linux-media/msg138546.html
Signed-off-by: Marco Felsch
---
Changelog:
v2:
- adapt commit message
- unify ifdef switches
- rename
AIP1A and AIP1B respectively.
This patch extends the device tree bindings documentation to describe
how the input connectors for these devices should be defined in a DT.
Signed-off-by: Marco Felsch
---
Changelog:
v2:
- adapt port layout in accordance with
https://www.spinics.net/lists/linux
These helpers make us of the media-controller entity which is only
available if the CONFIG_MEDIA_CONTROLLER is enabled.
Signed-off-by: Marco Felsch
---
include/media/v4l2-subdev.h | 100 ++--
1 file changed, 50 insertions(+), 50 deletions(-)
diff --git a/include
elcome :)
[1] https://www.spinics.net/lists/devicetree/msg236650.html
[2] https://git.linuxtv.org/mchehab/experimental.git/log/?h=tvp5150-3
[3] https://www.spinics.net/lists/devicetree/msg243181.html
[4] https://www.spinics.net/lists/devicetree/msg243840.html
Regards,
Marco
Marco Felsch (6):
[medi
-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 825dcf3a9d83..e736f609fecd 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
Don't en-/disable the interrupts during s_stream because someone can
disable the stream but wants to get informed if the stream is locked
again. So keep the interrupts enabled the whole time the pipeline is
opened.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c
On 18-08-13 15:41, Rob Herring wrote:
> On Mon, Aug 13, 2018 at 11:25:03AM +0200, Marco Felsch wrote:
> > The TVP5150/1 decoders support different video input sources to their
> > AIP1A/B pins.
> >
> > Possible configurations are as follows:
> > - Analog Co
Hi,
since I sent this series I only got feedback from Rob.
Regards,
Marco
On 18-08-13 11:25, Marco Felsch wrote:
> Hi,
>
> this is my v2 with the integrated reviews from my v1 [1]. Since Mauro
> applied the most patches from my v1 to his experimental/tvp5150-3
> branch [2], t
On 18-09-13 18:36, Mauro Carvalho Chehab wrote:
> The parameters of v4l2_ctrl_new_std_menu_items() are tricky: instead of
> the number of possible values, it requires the number of the maximum
> value. In other words, the ARRAY_SIZE() value should be decremented,
> otherwise it will go past the arr
Hi Sakari,
thanks for the review.
On 18-09-14 16:31, Sakari Ailus wrote:
> Hi Marco,
>
> On Mon, Aug 13, 2018 at 11:25:02AM +0200, Marco Felsch wrote:
> ...
> > +static void tvp5150_dt_cleanup(struct tvp5150 *decoder)
> > +{
> > + unsigned int i;
> > +
>
Hi Sakari,
On 18-09-14 16:25, Sakari Ailus wrote:
> Hi Marco,
>
> On Mon, Aug 13, 2018 at 11:25:05AM +0200, Marco Felsch wrote:
> > These helpers make us of the media-controller entity which is only
> > available if the CONFIG_MEDIA_CONTROLLER is enabled.
> >
>
Hi Sakari,
On 18-09-14 16:23, Sakari Ailus wrote:
> Hi Marco,
>
> On Mon, Aug 13, 2018 at 11:25:08AM +0200, Marco Felsch wrote:
> > Don't en-/disable the interrupts during s_stream because someone can
> > disable the stream but wants to get informed if the stream is loc
Hi,
On 18-09-14 15:57, Mauro Carvalho Chehab wrote:
> Em Fri, 14 Sep 2018 20:20:46 +0200
> Marco Felsch escreveu:
>
> > Hi Sakari,
> >
> > On 18-09-14 16:23, Sakari Ailus wrote:
> > > Hi Marco,
> > >
> > > On Mon, Aug 13, 2018 at 11
s approach is less error prone too.
Signed-off-by: Marco Felsch
---
include/media/v4l2-subdev.h | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index 9102d6ca566e..ce48f1fcf295 100644
--- a/include/
() callback ensures that only one
connector is active.
[1] https://www.spinics.net/lists/linux-media/msg138545.html
[2] https://www.spinics.net/lists/linux-media/msg138546.html
Signed-off-by: Marco Felsch
---
Changelog:
v3:
- probe(): s/err/err_free_v4l2_ctrls
- drop MC dependency for tvp5150_pads
AIP1A and AIP1B respectively.
This patch extends the device tree bindings documentation to describe
how the input connectors for these devices should be defined in a DT.
Signed-off-by: Marco Felsch
---
Changelog:
v3:
- remove examples for one and two inputs
- replace space by tabs
v2:
- adapt
Commit 37c65802e76a ("media: tvp5150: Add sync lock interrupt handling")
introduced the interrupt handling. But we have to free the
v4l2_ctrl_handler before we can return the error code.
Fixes: 37c65802e76a ("media: tvp5150: Add sync lock interrupt handling")
Signed-
mental.git/log/?h=tvp5150-4
Javier Martinez Canillas (1):
partial revert of "[media] tvp5150: add HW input connectors support"
Marco Felsch (7):
media: tvp5150: fix irq_request error path during probe
media: tvp5150: add input source selection of_graph support
media: dt-bindings: t
allowing the commit to be reverted cleanly anymore. But all the code
related to the DT parsing logic and input entities creation are removed.
Suggested-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
Acked-by: Laurent Pinchart
[m.fel...@pengutronix.de: rm TVP5150_INPUT_NUM define]
Si
Don't en-/disable the interrupts during s_stream because someone can
disable the stream but wants to get informed if the stream is locked
again. So keep the interrupts enabled the whole time the pipeline is
opened.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c
-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index b34d0e883c06..535e97c7b266 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
These helpers make us of the media-controller entity which is only
available if the CONFIG_MEDIA_CONTROLLER is enabled.
Signed-off-by: Marco Felsch
---
Changelog:
v3:
- add CONFIG_MEDIA_CONTROLLER switch instead of moving the
v4l2_subdev_get_try_* APIs into the existing one.
v2:
- Initial
ile handle or
driver state) which will be set/returned.
The TVP5150 AVID will be updated if the 'which' field is FORMAT_ACTIVE
and the requested selection rectangle differs from the already set one.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 109 ++
Hi Sakari,
On 18-09-19 13:45, Sakari Ailus wrote:
> Hi Marco,
>
> On Tue, Sep 18, 2018 at 03:14:50PM +0200, Marco Felsch wrote:
> > These helpers make us of the media-controller entity which is only
> > available if the CONFIG_MEDIA_CONTROLLER is enabled.
> >
>
Signed-off-by: Marco Felsch
---
drivers/media/i2c/mt9m111.c | 156
1 file changed, 156 insertions(+)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
index d060075a670b..13080c6c1ba3 100644
--- a/drivers/media/i2c/mt9m111.c
+++ b/drivers
Add callback to check if we are already streaming. Now other callbacks
can check the state and return -EBUSY if we already streaming.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/mt9m111.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers
igned-off-by: Marco Felsch
Reviewed-by: Philipp Zabel
---
drivers/media/i2c/mt9m111.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
index 78d08a81e0e2..d060075a670b 100644
--- a/drivers/media/i2c/mt9m111.c
+++ b/drivers/media/i2c/mt
: mt9m111: allow to setup pixclk polarity
Marco Felsch (1):
media: mt9m111: add s_stream callback
Michael Grzeschik (2):
media: mt9m111: add streaming check to set_fmt
media: mt9m111: add support to select formats and fps for {Q,SXGA}
drivers/media/i2c/mt9m111.c | 221
function)
(m.fel...@pengutronix.de: adapt commit msg)
Signed-off-by: Marco Felsch
Reviewed-by: Philipp Zabel
---
drivers/media/i2c/mt9m111.c | 52 -
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c
Hi Sakari,
On 18-10-20 00:24, Sakari Ailus wrote:
> Hi Marco,
>
> Thanks for the patchset.
>
> On Fri, Oct 19, 2018 at 05:50:27PM +0200, Marco Felsch wrote:
> > From: Enrico Scholz
> >
> > The chip can be configured to output data transitions on the
>
www.spinics.net/lists/linux-media/msg141975.html
[2] https://www.spinics.net/lists/linux-media/msg141987.html
Regards,
Marco
Enrico Scholz (1):
media: mt9m111: allow to setup pixclk polarity
Marco Felsch (3):
media: mt9m111: add s_stream callback
dt-bindings: media: mt9m111: adapt documenta
Replace the vague binding by a more verbose. Remove the remote property
from the example since the driver don't support such a property. Also
remove the bus-width property from the endpoint since the driver don't
take care of it.
Signed-off-by: Marco Felsch
---
.../devicetree/bindings
Signed-off-by: Marco Felsch
---
Changelog
v2:
- fix updating read mode register, use mt9m111_reg_mask() to update the
relevant bits only. For this purpose add reg_mask field to
struct mt9m111_mode_info.
drivers/media/i2c/mt9m111.c | 163
1 file changed
Add the pclk-sample property to the list of optional properties
for the mt9m111 camera sensor.
Signed-off-by: Marco Felsch
---
Documentation/devicetree/bindings/media/i2c/mt9m111.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/mt9m111.txt
function)
(m.fel...@pengutronix.de: adapt commit msg)
Signed-off-by: Marco Felsch
---
Changelog:
v2:
- make use of fwnode_*() to drop OF dependency and ifdef's
- mt9m111_g_mbus_config: fix pclk_sample logic which I made due the
conversion from Enrico's patch.
drivers/media/i2c/mt9m
Add callback to check if we are already streaming. Now other callbacks
can check the state and return -EBUSY if we already streaming.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/mt9m111.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers
igned-off-by: Marco Felsch
Reviewed-by: Philipp Zabel
---
drivers/media/i2c/mt9m111.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
index e0ac5aa6ea64..1f8789fe28af 100644
--- a/drivers/media/i2c/mt9m111.c
+++ b/drivers/media/i2c/mt
Hi Mauro,
just a reminder, Rob already added his ack/rev-by tags.
Thanks,
Marco
On 18-09-18 15:14, Marco Felsch wrote:
> Hi,
>
> this is my v3 with the integrated reviews from my v2 [1]. This serie
> applies to Mauro's experimental.git [2].
>
> @Mauro:
> P
Hi Mauro,
I don't want to spam you. Can you give me some feedback? I know the
merge window is a busy time, so maybe you have some time now.
Regards,
Marco
On 18-10-29 19:41, Marco Felsch wrote:
> Hi Mauro,
>
> just a reminder, Rob already added his ack/rev-by tags.
>
> Tha
Hi Sakari,
On 18-11-16 15:32, Sakari Ailus wrote:
> Hi Marco, Enrico,
>
> On Mon, Oct 29, 2018 at 07:24:08PM +0100, Marco Felsch wrote:
> > From: Enrico Scholz
> >
> > The chip can be configured to output data transitions on the
> > rising or falling
Hi Sakari, Hans,
On 18-11-16 15:33, Sakari Ailus wrote:
> Hi Hans,
>
> On Fri, Nov 16, 2018 at 02:31:01PM +0100, Hans Verkuil wrote:
> > On 11/16/2018 02:26 PM, Sakari Ailus wrote:
> > > Hi Marco, Michael,
> > >
> > > On Mon, Oct 29, 2018 at 07:24:0
to setup pixclk polarity
Marco Felsch (3):
media: mt9m111: add s_stream callback
dt-bindings: media: mt9m111: adapt documentation to be more clear
dt-bindings: media: mt9m111: add pclk-sample property
Michael Grzeschik (2):
media: mt9m111: add streaming check to set_fmt
media: mt9m111
Add the pclk-sample property to the list of optional properties
for the mt9m111 camera sensor.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
---
Documentation/devicetree/bindings/media/i2c/mt9m111.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree
Signed-off-by: Marco Felsch
---
Changelog
v3:
- check if sensor window size is set to default and return if not
- check if requested fps is supported by image size and do not update
the image size if requested fps is not supported by selected image
size
- update fps mode only if a mode was
igned-off-by: Marco Felsch
Reviewed-by: Philipp Zabel
---
drivers/media/i2c/mt9m111.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
index 03559669de9f..9b0a3689fa98 100644
--- a/drivers/media/i2c/mt9m111.c
+++ b/drivers/media/i2c/mt
function)
(m.fel...@pengutronix.de: adapt commit msg)
Signed-off-by: Marco Felsch
---
Changelog:
v3:
- call mt9m111_probe_fw() before v4l2_clk_get() to avoid error handling
v2:
- make use of fwnode_*() to drop OF dependency and ifdef's
- mt9m111_g_mbus_config: fix pclk_sample logic which I
Add callback to check if we are already streaming. Now other callbacks
can check the state and return -EBUSY if we already streaming.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/mt9m111.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers
Replace the vague binding by a more verbose. Remove the remote property
from the example since the driver don't support such a property. Also
remove the bus-width property from the endpoint since the driver don't
take care of it.
Signed-off-by: Marco Felsch
Reviewed-by: R
Hi Sakari,
On 18-11-27 15:19, Sakari Ailus wrote:
> Hi Marco,
>
> On Tue, Nov 27, 2018 at 11:02:53AM +0100, Marco Felsch wrote:
> > From: Enrico Scholz
> >
> > The chip can be configured to output data transitions on the
> > rising or falling edge of PIXCLK (D
Hi Sakari,
On 18-11-27 15:13, Sakari Ailus wrote:
> Hi Marco,
>
> On Tue, Nov 27, 2018 at 11:02:52AM +0100, Marco Felsch wrote:
> > Add the pclk-sample property to the list of optional properties
> > for the mt9m111 camera sensor.
> >
> > Signed-off-by: M
On 18-11-27 23:15, Sakari Ailus wrote:
> On Tue, Nov 27, 2018 at 11:02:53AM +0100, Marco Felsch wrote:
> > From: Enrico Scholz
> >
> > The chip can be configured to output data transitions on the
> > rising or falling edge of PIXCLK (Datasheet R58:1[9]), default
Add corresponding dt-bindings for the Toshiba tc358746 device.
Signed-off-by: Marco Felsch
---
.../bindings/media/i2c/toshiba,tc358746.txt | 80 +++
1 file changed, 80 insertions(+)
create mode 100644
Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.txt
diff
orted)
Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK (Not Supported)
test VIDIOC_EXPBUF: OK (Not Supported)
Total: 54, Succeeded: 53, Failed: 1, Warnings: 0
8<--
Marco Felsch (3):
media: dt-bindings:
Add me as partial maintainer, others are welcome too.
Signed-off-by: Marco Felsch
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 546f8d936589..f97dedbe545c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15230,6 +15230,13 @@ S
lk on GPIO[0]
- Sending pictures from the host to a parallel display
- v4l_event support
Signed-off-by: Marco Felsch
---
drivers/media/i2c/Kconfig | 12 +
drivers/media/i2c/Makefile|1 +
drivers/media/i2c/tc358746.c | 1847 +
drivers/medi
--
Isn't this right?
Can you cc me the other patches too, so I can keep track of it easier?
Regards,
Marco
>
> Fixes: 98480d65c48c ("media: mt9m111: allow to setup pixclk polarity")
> Cc: Enrico Scholz
> Cc: Michael Grzeschik
> Cc: Mar
On 18-12-30 02:07, Akinobu Mita wrote:
> The VIDIOC_SUBDEV_G_FMT ioctl for this driver doesn't recognize
> V4L2_SUBDEV_FORMAT_TRY and always works as if V4L2_SUBDEV_FORMAT_ACTIVE
> is specified.
>
> Cc: Sakari Ailus
> Cc: Mauro Carvalho Chehab
> Signed-off-by: Akinobu Mita
> ---
> drivers/medi
On 19-01-01 02:07, Akinobu Mita wrote:
> 2018年12月31日(月) 19:54 Marco Felsch :
> >
> > On 18-12-30 02:07, Akinobu Mita wrote:
> > > The VIDIOC_SUBDEV_G_FMT ioctl for this driver doesn't recognize
> > > V4L2_SUBDEV_FORMAT_TRY and always works as if V4L2_S
Hi,
Just a ping.
The kbuilder reports some warning which I will fix in a v2 but I still
waiting for feedback from you.
Regards,
Marco
On 18-12-18 15:12, Marco Felsch wrote:
> Hi,
>
> this patch set adds the support for the Toshiba TC358746 Parallel
> MIPI-CSI2 bridge device.
&
Michael Grzeschik
> Cc: Marco Felsch
> Cc: Sakari Ailus
> Cc: Mauro Carvalho Chehab
> Signed-off-by: Akinobu Mita
> ---
> * v3
> - Set initial try format with default configuration instead of
> current one.
>
> drivers/media/i2c/mt9m111.c | 30 ++
() callback ensures that only one
connector is active.
[1] https://www.spinics.net/lists/linux-media/msg138545.html
[2] https://www.spinics.net/lists/linux-media/msg138546.html
Signed-off-by: Marco Felsch
---
Changelog:
v4:
- rebase on top of media_tree/master, fix merge conflict due to commit
s approach is less error prone too.
Signed-off-by: Marco Felsch
---
include/media/v4l2-subdev.h | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index 47af609dc8f1..90c9a301d72a 100644
--- a/include/
ile handle or
driver state) which will be set/returned.
The TVP5150 AVID will be updated if the 'which' field is FORMAT_ACTIVE
and the requested selection rectangle differs from the already set one.
Signed-off-by: Marco Felsch
---
Changelog:
v4:
- fix merge conflict due to reba
-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 83b976aa4492..e4f2efadd1aa 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
AIP1A and AIP1B respectively.
This patch extends the device tree bindings documentation to describe
how the input connectors for these devices should be defined in a DT.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
---
Changelog:
v3:
- remove examples for one and two inputs
- replace
allowing the commit to be reverted cleanly anymore. But all the code
related to the DT parsing logic and input entities creation are removed.
Suggested-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
Acked-by: Laurent Pinchart
[m.fel...@pengutronix.de: rm TVP5150_INPUT_NUM define]
Si
Don't en-/disable the interrupts during s_stream because someone can
disable the stream but wants to get informed if the stream is locked
again. So keep the interrupts enabled the whole time the pipeline is
opened.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c
Martinez Canillas (1):
partial revert of "[media] tvp5150: add HW input connectors support"
Marco Felsch (5):
media: tvp5150: add input source selection of_graph support
media: dt-bindings: tvp5150: Add input port connectors DT bindings
media: v4l2-subdev: add stubs for v4l2_subdev_g
Hi Rob,
sorry instead of adding you to To you was on Cc.
Do you have any preferences about the below discussion?
Regards,
Marco
On 19-04-16 12:45, Marco Felsch wrote:
> Hi Rob,
>
> gentle ping.
>
> Regards,
> Marco
>
> On 19-03-05 19:14, Marco Felsch wrote:
>
Hi Mauro,
I know you are busy but can you have a look on it?
Regards,
Marco
On 19-04-15 14:44, Marco Felsch wrote:
> Hi,
>
> many thanks to Hans and Jacopo for the feedack :) this v6 address the
> comments both made on my v5 [1].
>
> In short this is round fixes just
Hi Mauro,
On 19-05-14 17:20, Mauro Carvalho Chehab wrote:
> Em Tue, 14 May 2019 14:18:24 -0300
> Mauro Carvalho Chehab escreveu:
>
> > Em Mon, 6 May 2019 07:47:13 +0200
> > Marco Felsch escreveu:
> >
> > > Hi Mauro,
> > >
> >
Add corresponding dt-bindings for the Toshiba tc358746 device and update
the MAINTAINERS file too.
Signed-off-by: Marco Felsch
---
Hi Rob,
I droped your reviewed-by tag since there where several changes.
Changes
v2:
- use the Documentation/devicetree/bindings/media/ti,omap3isp.txt
er so there should be no
conflicts.
Regards,
Marco
[1] https://patchwork.ozlabs.org/cover/1015381/
Marco Felsch (2):
media: dt-bindings: add bindings for Toshiba TC358746
media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver
.../bindings/media/i2c/toshiba,tc358746.txt |
lk on GPIO[0]
- Sending pictures from the host to a parallel display
- v4l_event support
Signed-off-by: Marco Felsch
---
Changes
v2:
- adapt Kconfig symbole description
- reorder includes alphabetical
- drop refclk input-clock is named 'refclk'
- fix module license to GPL v2
- use u
, 13 insertions(+), 5 deletions(-)
Looks good feel free to add
Reviewed-by: Marco Felsch
Regards,
Marco
> diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
> index bb19f8c346cb..593ebe5e2cb6 100644
> --- a/drivers/media/i2c/mt9m111.c
> +++ b/drivers/media/i2c/mt9m111
--
> 1 file changed, 4 insertions(+), 7 deletions(-)
Looks good feel free to add my
Reviewed-by: Marco Felsch
Regards,
Marco
> diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
> index 746d1345b505..bb19f8c346cb 100644
> --- a/drivers/media/i2c/mt9m111.c
Hi Sakari,
On 19-06-25 15:27, Sakari Ailus wrote:
> Hi Marco,
>
> Thanks for the set.
>
> Looks quite good to me in general; a few minor comments below.
Sorry for the delayed response.
> On Wed, Jun 19, 2019 at 05:28:38PM +0200, Marco Felsch wrote:
> > Adding support
The patch adds three macros to bundle the mbus_framefmt default
values and a helper function to set the the default crop and
mbus_framefmt values.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 42 ++---
1 file changed, 25 insertions(+), 17
From: Philipp Zabel
To avoid short frames on stream start, keep output pins at high impedance
while we are not properly locked onto the input signal.
Signed-off-by: Philipp Zabel
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 39 ++---
1 file
From: Philipp Zabel
Signed-off-by: Philipp Zabel
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 6296c68ac816..99d887936ea0 100644
--- a/drivers/media/i2c/tvp5150
1 - 100 of 294 matches
Mail list logo
