Re: [PATCH v5 0/6] Add Meson 8b / GXBB support to the IR driver

2016-08-29 Thread Kevin Hilman
Martin Blumenstingl writes: > Newer Amlogic platforms (Meson 8b and GXBB) use a slightly different > register layout for their Infrared Remoete Controller. The decoder mode > is now configured in another register. Without the changes to the > meson-ir driver we are simply getting incorrect "durat

Re: [PATCH 3/5] [media] rc: meson-ir: Fix module autoload

2016-10-17 Thread Kevin Hilman
bb-irC* > alias: of:N*T*Camlogic,meson-gxbb-ir > alias: of:N*T*Camlogic,meson8b-irC* > alias: of:N*T*Camlogic,meson8b-ir > alias: of:N*T*Camlogic,meson6-irC* > alias: of:N*T*Camlogic,meson6-ir > > Signed-off-by: Javier Martinez Canill

[PATCH v2 0/4] [media] davinci: vpif_capture: raw camera support

2017-06-06 Thread Kevin Hilman
=0virtualkey0virtualkeyMT9V032C12STCH-GEVB Kevin Hilman (4): [media] davinci: vpif_capture: drop compliance hack [media] davinci: vpif_capture: get subdevs from DT when available [media] davinci: vpif_capture: cleanup raw camera support [media] davinci: vpif: adaptions for DT support drivers/media

[PATCH v2 2/4] [media] davinci: vpif_capture: get subdevs from DT when available

2017-06-06 Thread Kevin Hilman
Enable getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 126 +- drivers/media/platform/davinci

[PATCH v2 1/4] [media] davinci: vpif_capture: drop compliance hack

2017-06-06 Thread Kevin Hilman
a real fix. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index 128e92d1dd5a..fc5c7622660c 100644 --- a/dri

[PATCH v2 3/4] [media] davinci: vpif_capture: cleanup raw camera support

2017-06-06 Thread Kevin Hilman
, and also tested that composite video input still works from ti,tvp514x decoder. Both tests done on the da850-evm board with the add-on UI board. NOTE: Will need further testing for other sensors with different bus formats. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci

[PATCH v2 4/4] [media] davinci: vpif: adaptions for DT support

2017-06-06 Thread Kevin Hilman
platform_devices for the display and capture platform_drivers. [1] Documentation/devicetree/bindings/media/ti,da850-vpif.txt Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 49 ++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH 0/4] [media] davinci: vpif_capture: raw camera support

2017-06-06 Thread Kevin Hilman
On Tue, Jun 6, 2017 at 1:34 PM, Hans Verkuil wrote: > Hi Kevin, > > On 02/06/17 23:34, Kevin Hilman wrote: >> This series fixes/updates the support for raw camera input to the VPIF. >> >> Tested on da850-evm boards using the add-on UI board. Tested with >> bot

Re: [PATCH v2 2/4] [media] davinci: vpif_capture: get subdevs from DT when available

2017-06-08 Thread Kevin Hilman
On Wed, Jun 7, 2017 at 11:29 PM, Hans Verkuil wrote: > On 07/06/17 01:37, Kevin Hilman wrote: >> Enable getting of subdevs from DT ports and endpoints. >> >> The _get_pdata() function was larely inspired by (i.e. stolen from) >> am437x-vpfe.c >> >> Signed-o

[PATCH v2] [media] davinci: vpif: adaptions for DT support

2017-06-09 Thread Kevin Hilman
platform_devices for the display and capture platform_drivers. [1] Documentation/devicetree/bindings/media/ti,da850-vpif.txt Signed-off-by: Kevin Hilman --- Changes since v1: - added proper error checking to kzalloc calls - rebased onto media/master drivers/media/platform/davinci/vpif.c | 57

Re: [PATCH v2] [media] davinci: vpif: adaptions for DT support

2017-06-15 Thread Kevin Hilman
Hi Hans, Mauro, On Fri, Jun 9, 2017 at 9:10 AM, Kevin Hilman wrote: > The davinci VPIF is a single hardware block, but the existing driver > is broken up into a common library (vpif.c), output (vpif_display.c) and > intput (vpif_capture.c). > > When migrating to DT, to better mod

Re: [PATCH v2] [media] davinci: vpif: adaptions for DT support

2017-06-16 Thread Kevin Hilman
Sakari Ailus writes: > Hi Kevin, > > On Fri, Jun 09, 2017 at 09:10:26AM -0700, Kevin Hilman wrote: >> The davinci VPIF is a single hardware block, but the existing driver >> is broken up into a common library (vpif.c), output (vpif_display.c) and >> intput (vpif_captur

[PATCH] [media] davinci: vpif_capture: fix potential NULL deref

2017-07-11 Thread Kevin Hilman
Fix potential NULL pointer dereference in the error path of memory allocation failure. Reported-by: Dan Carpenter Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform

Re: [bug report] [media] davinci: vpif_capture: get subdevs from DT when available

2017-07-11 Thread Kevin Hilman
Dan Carpenter writes: > Hello Kevin Hilman, > > The patch 4a5f8ae50b66: "[media] davinci: vpif_capture: get subdevs > from DT when available" from Jun 6, 2017, leads to the following > static checker warning: > > drivers/media/platform/davinci/vpif_capture.c

Re: [PATCH v6 1/5] [media] davinci: VPIF: fix module loading, init errors

2016-12-16 Thread Kevin Hilman
Hans Verkuil writes: > On 07/12/16 19:30, Kevin Hilman wrote: >> Fix problems with automatic module loading by adding MODULE_ALIAS. Also >> fix various load-time errors cause by incorrect or not present >> platform_data. >> >> Signed-off-by: Kevin Hilman

[PATCH v6.1 1/5] [media] davinci: VPIF: fix module loading, init errors

2016-12-16 Thread Kevin Hilman
Fix problems with automatic module loading by adding MODULE_ALIAS. Also fix various load-time errors cause by incorrect or not present platform_data. Acked-by: Sakari Ailus Signed-off-by: Kevin Hilman --- Minor tweaks since v6 - added ack from Sakari - droped an extraneous change for NULL

Re: [PATCH v6 0/5] davinci: VPIF: add DT support

2016-12-16 Thread Kevin Hilman
Hans Verkuil writes: > On 07/12/16 19:30, Kevin Hilman wrote: >> Prepare the groundwork for adding DT support for davinci VPIF drivers. >> This series does some fixups/cleanups and then adds the DT binding and >> DT compatible string matching for DT probing. >> >

Re: [PATCH v6 0/5] davinci: VPIF: add DT support

2017-01-27 Thread Kevin Hilman
On Fri, Dec 16, 2016 at 4:49 PM, Kevin Hilman wrote: > Hans Verkuil writes: > >> On 07/12/16 19:30, Kevin Hilman wrote: >>> Prepare the groundwork for adding DT support for davinci VPIF drivers. >>> This series does some fixups/cleanups and then adds the DT bindin

Re: [PATCH 09/10] media: vpif: use a configurable i2c_adapter_id for vpif display

2017-02-07 Thread Kevin Hilman
szewski Acked-by: Kevin Hilman > --- > arch/arm/mach-davinci/board-da850-evm.c | 1 + > drivers/media/platform/davinci/vpif_display.c | 2 +- > include/media/davinci/vpif_types.h| 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/m

Re: [PATCH 10/10] ARM: davinci: add pdata-quirks for da850-evm vpif display

2017-02-07 Thread Kevin Hilman
;t currently a way to define the output_routing in the V4L2 drivers (c.f. s_routing) via DT. > Signed-off-by: Bartosz Golaszewski minor nit below, otherwise Reviewed-by: Kevin Hilman > --- > arch/arm/mach-davinci/pdata-quirks.c | 86 > +++- >

Re: [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm

2017-02-07 Thread Kevin Hilman
i2c adapter 1 (not default: zero) */ > - if (of_machine_is_compatible("ti,da850-evm")) > - da850_vpif_capture_config.i2c_adapter_id = 1; > - oops, my bad. Acked-by: Kevin Hilman > ret = da850_register_vpif_capture(&da850_vpif_capture_config); >

Re: [PATCH 10/10] ARM: davinci: add pdata-quirks for da850-evm vpif display

2017-02-10 Thread Kevin Hilman
Hi Bartosz, Bartosz Golaszewski writes: > Similarly to vpif capture: we need to register the vpif display driver > and the corresponding adv7343 encoder in pdata-quirks as the DT > support is not complete. > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm/mach-davinci/pdata-quirks.c | 86

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

2017-02-13 Thread Kevin Hilman
Bartosz Golaszewski writes: > Signed-off-by: Bartosz Golaszewski Acked-by: Kevin Hilman > --- > arch/arm/boot/dts/da850-evm.dts | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da8

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

2017-02-13 Thread Kevin Hilman
Bartosz Golaszewski writes: > Signed-off-by: Bartosz Golaszewski I'll fold this one into the original since it's not yet merged. Kevin > --- > arch/arm/boot/dts/da850-evm.dts | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/da850-evm.dts b

Re: [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm

2017-02-13 Thread Kevin Hilman
Sekhar Nori writes: > On Tuesday 07 February 2017 11:51 PM, Kevin Hilman wrote: >> Bartosz Golaszewski writes: >> >>> When we enable vpif capture on the da850-evm we hit a BUG_ON() because >>> the i2c adapter can't be found. The board file boot uses i2c

Re: [PATCH 07/10] ARM: davinci: fix a whitespace error

2017-02-13 Thread Kevin Hilman
Bartosz Golaszewski writes: > There's a stray tab in da850_vpif_legacy_init(). Remove it. > > Signed-off-by: Bartosz Golaszewski Folding into the original, Kevin > --- > arch/arm/mach-davinci/pdata-quirks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mac

Re: [PATCH 07/10] ARM: davinci: fix a whitespace error

2017-02-13 Thread Kevin Hilman
Kevin Hilman writes: > Bartosz Golaszewski writes: > >> There's a stray tab in da850_vpif_legacy_init(). Remove it. >> >> Signed-off-by: Bartosz Golaszewski > > Folding into the original, Looks like the version in Sekhar's v4.11/soc branch already has this fixed. Kevin

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

2017-02-13 Thread Kevin Hilman
Kevin Hilman writes: > Bartosz Golaszewski writes: > >> Signed-off-by: Bartosz Golaszewski > > I'll fold this one into the original since it's not yet merged. Oops, Sekhar has already merged this one to his v4.11/dt branch, so he can apply it (or fold it in.) Kevin

Re: [PATCH] ARM64: defconfig: enable IR core, decoders and Meson IR device

2017-05-19 Thread Kevin Hilman
Neil Armstrong writes: > This patch enables the MEDIA Infrared RC Decoders and Meson Infrared > decoder for ARM64 defconfig. > These drivers are selected as modules by default. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/configs/defconfig | 5 + > 1 file changed, 5 insertions(+) >

Re: [PATCH] davinci: vpif_capture: fix default pixel format for BT.656/BT.1120 video

2017-05-26 Thread Kevin Hilman
ical Reference Manual, SPRUH77A. > > The VPIF driver incorrectly sets the default format > to V4L2_PIX_FMT_YUV422P. Fix it. > > Reported-by: Alejandro Hernandez > Signed-off-by: Sekhar Nori Acked-by: Kevin Hilman

[PATCH 0/4] [media] davinci: vpif_capture: raw camera support

2017-06-02 Thread Kevin Hilman
only camera board with the right connector for the da850-evm UI board. Verified that composite video capture is still working well after these updates. [1] http://www.mouser.com/search/ProductDetail.aspx?R=0virtualkey0virtualkeyMT9V032C12STCH-GEVB Kevin Hilman (4): [media] davinci

[PATCH 4/4] [media] davinci: vpif: adaptions for DT support

2017-06-02 Thread Kevin Hilman
platform_devices for the display and capture platform_drivers. [1] Documentation/devicetree/bindings/media/ti,da850-vpif.txt Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 49 ++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 1/4] [media] davinci: vpif_capture: drop compliance hack

2017-06-02 Thread Kevin Hilman
a real fix. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index 128e92d1dd5a..fc5c7622660c 100644 --- a/dri

[PATCH 3/4] [media] davinci: vpif_capture: cleanup raw camera support

2017-06-02 Thread Kevin Hilman
, and also tested that composite video input still works from ti,tvp514x decoder. Both tests done on the da850-evm board with the add-on UI board. NOTE: Will need further testing for other sensors with different bus formats. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci

[PATCH 2/4] [media] davinci: vpif_capture: get subdevs from DT when available

2017-06-02 Thread Kevin Hilman
Enable getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 126 +- drivers/media/platform/davinci

Re: [PATCH v16 1/3] davinci vpbe: changes to common files

2011-01-18 Thread Kevin Hilman
Manjunath Hadli writes: > Implemented a common and single mapping for DAVINCI_SYSTEM_MODULE_BASE > to be used by all davinci platforms. Please use a more descriptive subject. This patch hs nothing to do with VPBE, so please send it as a standalone patch. Thanks, Kevin > Signed-off-by: Man

Re: [PATCH v16 2/3] davinci vpbe: platform specific additions

2011-01-18 Thread Kevin Hilman
Manjunath Hadli writes: > This patch implements the overall device creation for the Video > display driver, initializes the platform variables and implements > platform functions including setting video clocks. This is dm644x specific. Please use 'davinci: dm644x: VPBE' as subject prefix. Kevi

Re: architecture part of video driver patch

2009-12-07 Thread Kevin Hilman
"Karicheri, Muralidharan" writes: > Kevin, > > Following patch merged to v4l-dvb linux-next has an architectural > part as attached. If you have not merged it to your next branch > for linux-davinci tree, please do so at your earliest convenience > so that they are in sync. OK, applying to davi

Re: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-09 Thread Kevin Hilman
m-kariche...@ti.com writes: > From: Muralidharan Karicheri > > v1 - updated based on comments from Vaibhav Hiremath. > > On DM365 we use only vpss master clock, where as on DM355 and > DM6446, we use vpss master and slave clocks for vpfe capture and AM3517 > we use internal clock and pixel clock

Re: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-10 Thread Kevin Hilman
"Karicheri, Muralidharan" writes: > Kevin, > >>> +/** >>> + * vpfe_disable_clock() - Disable clocks for vpfe capture driver >>> + * @vpfe_dev - ptr to vpfe capture device >>> + * >>> + * Disables clocks defined in vpfe configuration. >>> + */ >>> static void vpfe_disable_clock(struct vpfe_device

Re: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-10 Thread Kevin Hilman
"Karicheri, Muralidharan" writes: > Kevin, > > I think I have figured it out... > > First issue was that I was adding my entry at the end of dm644x_clks[] > array. I need to add it before the CLK(NULL, NULL, NULL) > > secondly, your suggestion didn't work as is. This is what I had to > do to get

Re: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

2009-12-11 Thread Kevin Hilman
"Karicheri, Muralidharan" writes: >>> Kevin, >>> >>> I think I have figured it out... >>> >>> First issue was that I was adding my entry at the end of dm644x_clks[] >>> array. I need to add it before the CLK(NULL, NULL, NULL) >>> >>> secondly, your suggestion didn't work as is. This is what I had

Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver

2010-01-05 Thread Kevin Hilman
; and "slave" are defined > for ccdc driver > as per comments from Kevin Hilman. > > This adds platform code for ccdc driver on DM355 and DM6446. > > Reviewed-by: Vaibhav Hiremath > Reviewed-by: Kevin Hilman > > Signed-off-by: Muralidharan Karicheri > ---

Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver

2010-01-06 Thread Kevin Hilman
"Karicheri, Muralidharan" writes: >>> CLK(NULL, "rto", &rto_clk), >>> CLK(NULL, "usb", &usb_clk), >>> + CLK("dm355_ccdc", "master", &vpss_master_clk), >>> + CLK("dm355_ccdc", "slave", &vpss_slave_clk), >> >>I still don't understand why you have to add new entries here and >>can't simp

Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver

2010-01-06 Thread Kevin Hilman
In the future, please do not top-post. Inline replies are preferred so context can be followed. I've moved your reply into context below with some more comments... "Karicheri, Muralidharan" writes: >>-Original Message- >>From: Kevin Hilman [mailto:khil...@

Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver

2010-01-07 Thread Kevin Hilman
"Karicheri, Muralidharan" writes: > Kevin, > >> >>OK, I'm not extremely familar with the whole video architecture here, >>but are all of these drivers expected to be doing clk_get() and >>clk_enable()? >> > > [MK]Many IPs on DaVinci VPFE would require vpss master clock. So > it is better to do th

Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver

2010-01-07 Thread Kevin Hilman
"Karicheri, Muralidharan" writes: > Can I remove it through a separate patch? This patch is already merged in > Hans tree. Hmm, arch patches should not be merged yet as I have not ack'd them. Kevin >>-Original Message- >>From: Kevin Hilman [mailto:kh

Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver

2010-01-08 Thread Kevin Hilman
"Hiremath, Vaibhav" writes: >> > [Hiremath, Vaibhav] Hi Kevin and Murali, > > Sorry for jumping into this discussion so late, > > Can we use clk_add_alias() function exported by clkdev.c file here? > With this board specific file can define aliases for all required > platform_data keeping CLK()

Re: [PATCH - v4 4/4] DaVinci-vpfe-capture-converting-ccdc-drivers-to-platform-drivers

2010-01-11 Thread Kevin Hilman
t; This combines the two patches sent earlier to change the clock configuration > and converting ccdc drivers to platform drivers. This has updated comments > against v2 of these patches. Two new clocks "master" and "slave" are defined > for ccdc driver > as per

Re: [PATCH - v4 2/4] V4L-vpfe-capture-converting dm355 ccdc driver to a platform driver

2010-01-11 Thread Kevin Hilman
; the driver for the same IP across different SoCs. > > Following are the changes done:- > 1) clocks are configured using generic clock names > 2) converting the driver to a platform driver > 3) cleanup - consolidate all static variables inside a structure, > ccd

Re: [PATCH - v4 1/4] V4L-vpfe_capture-remove-clock and platform code

2010-01-11 Thread Kevin Hilman
and descriptive changelog is extremely importanty. For the benefit of reading the git history later, and also for those of us less familiar with the details of these drivers, we rely heavily on a good changelog. Kevin > Reviewed-by: Vaibhav Hiremath > Reviewed-by: Kevin Hilman > Reviewed-b

Re: [PATCH - v4 2/4] V4L-vpfe-capture-converting dm355 ccdc driver to a platform driver

2010-01-11 Thread Kevin Hilman
driver to a platform driver > 3) cleanup - consolidate all static variables inside a structure, > ccdc_cfg > > Reviewed-by: Kevin Hilman > Reviewed-by: Vaibhav Hiremath > Reviewed-by: Hans Verkuil > > Signed-off-by: Hans Verkuil > Signed-off-by: Muralidharan Karicher

Re: [PATCH - v4 4/4] DaVinci-vpfe-capture-converting-ccdc-drivers-to-platform-drivers

2010-01-11 Thread Kevin Hilman
he '---' as well. Thanks. > This combines the two patches sent earlier to change the clock configuration > and converting ccdc drivers to platform drivers. This has updated comments > against v2 of these patches. Two new clocks "master" and "slave" are defined &

Re: [PATCH - v4 1/4] V4L-vpfe_capture-remove-clock and platform code

2010-01-12 Thread Kevin Hilman
"Karicheri, Muralidharan" writes: [...] >> >>Also, this doesn't accuratly reflect the changes done in the patch. >> >>Here the clock configuration isn't moved, it's removed. You should >>mention it being removed here and added to platform-specific code in >>subsequent patches. >> >>Sorry to be

Re: [PATCH - v4 1/4] V4L - vpfe_capture-remove clock and platform code

2010-01-14 Thread Kevin Hilman
are done in this patch:- >> 1) removed the platform code and clk configuration. They are now >> part of ccdc driver (part of the ccdc patches and platform >>patches 2-4) >> 2) Added proper error codes for ccdc register function >> >

Re: [PATCH 3/9] dm355 ccdc module for vpfe capture driver

2009-06-01 Thread Kevin Hilman
"Karicheri, Muralidharan" writes: > Laurent, > > Thanks for reviewing this. I have not gone through all of your comments, but > would like to respond to the following one first. I will respond to the rest > as I do the rework. > >>I've had a quick look at the DM355 and DM6446 datasheets. The CC

Re: [PATCH 9/10 - v2] remove outdated video driver files of dm6446

2009-06-11 Thread Kevin Hilman
m-kariche...@ti.com writes: > From: Muralidharan Karicheri > > Remove outdated driver files from davinci git tree Can you add another patch that removes the old Kconfig/Makfile entries as well (of course, this only applied to davinci git and not mainline.) Also, can't we drop the Kconfig/Makefi

Re: [PATCH 0/11 - v3] ARM: DaVinci: Video: DM355/DM6446 VPFE Capture driver

2009-06-19 Thread Kevin Hilman
C) from tvp5146 decoder. > Displayed using fbdev device driver available on davinci git tree > 2) Tested with driver built statically and dynamically > > Muralidhara Karicheri > > Reviewed by: Hans Verkuil > Revi

Re: [PATCH] Subject: [PATCH v3 1/4] ARM: DaVinci: DM646x Video: Platform and board specific setup

2009-06-26 Thread Kevin Hilman
Hans Verkuil writes: > On Monday 22 June 2009 10:14:30 chaithrika wrote: >> Kevin, >> >> I think this patch has to be taken into DaVinci tree so that it >> can be submitted upstream. This patch has to be present in the Linux >> tree for Hans to prepare a pull request for DM646x display driver

Re: [PATCH] Subject: [PATCH v3 1/4] ARM: DaVinci: DM646x Video: Platform and board specific setup

2009-06-26 Thread Kevin Hilman
Chaithrika U S writes: > Platform specific display device setup for DM646x EVM > > Add platform device and resource structures. Also define a platform specific > clock setup function that can be accessed by the driver to configure the clock > and CPLD. > > This patch is dependent on a patch submi

Re: [PATCH] Subject: [PATCH v3 1/4] ARM: DaVinci: DM646x Video: Platform and board specific setup

2009-06-26 Thread Kevin Hilman
Kevin Hilman writes: > Chaithrika U S writes: > >> Platform specific display device setup for DM646x EVM >> >> Add platform device and resource structures. Also define a platform specific >> clock setup function that can be accessed by the driver to confi

[PATCH] V4L/DVB: dm646x: fix DMA_nnBIT_MASK

2009-07-23 Thread Kevin Hilman
Fix deprecated use of DMA_nnBIT_MASK which now gives a compiler warning. Signed-off-by: Kevin Hilman --- This compiler warning patch is on top of the master branch of Mauro's linux-next tree. arch/arm/mach-davinci/dm646x.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [PATCH v4] ARM: DaVinci: DM646x Video: Platform and board specific setup

2009-08-07 Thread Kevin Hilman
the driver to configure the > clock >> and CPLD. >> >> Signed-off-by: Manjunath Hadli >> Signed-off-by: Brijesh Jadav >> Signed-off-by: Chaithrika U S >> Signed-off-by: Kevin Hilman >> --- >> Applies to Davinci GIT tree. Minor updates like cha

Re: [PATCH v4] ARM: DaVinci: DM646x Video: Platform and board specific setup

2009-08-07 Thread Kevin Hilman
Kevin Hilman writes: > "chaithrika" writes: > >> Russell, >> >> Requesting your ack on this patch. >> > > Chaithrika, Mauro, > > We don't need Russell's ack on this. You've incorporated his comments > and my signoff is

Re: [PATCH] V4L/DVB: dm646x: fix DMA_nnBIT_MASK

2009-08-10 Thread Kevin Hilman
Kevin Hilman writes: > Fix deprecated use of DMA_nnBIT_MASK which now gives a compiler > warning. > > Signed-off-by: Kevin Hilman > --- > This compiler warning patch is on top of the master branch of Mauro's > linux-next tree. Ping. This is needed on top of the DaV

Re: [PATCH v0 1/5] DaVinci - re-structuring code to support vpif capture driver

2009-08-10 Thread Kevin Hilman
reating this patch. So this is only for > review. Final patch to be merged will be created later > > Mandatory reviewers : Hans Verkuil > Kevin Hilman > > Signed-off-by: Muralidharan Karicheri Looks mostly OK, some minor nits... &g

Re: Embedded Linux Conference

2009-03-16 Thread Kevin Hilman
Hans Verkuil writes: > Just FYI: > > I'll be attending the Embedded Linux Conference in San Francisco, April > 6th-8th (http://www.embeddedlinuxconference.com/elc_2009). > > This might be a good opportunity to discuss omap and davinci V4L2 issues > face-to-face. Let me know if you are intereste

Re: Embedded Linux Conference

2009-03-17 Thread Kevin Hilman
Hans Verkuil wrote: On Tuesday 17 March 2009 01:14:28 Steve Sakoman wrote: On Mon, Mar 16, 2009 at 3:56 PM, Tony Lindgren wrote: * Kevin Hilman [090316 15:52]: Hans Verkuil writes: Just FYI: I'll be attending the Embedded Linux Conference in San Francisco, April 6th-8th

Re: [RFC 1/7] ARM: DaVinci: DM646x Video: Platform and board specific setup

2009-03-19 Thread Kevin Hilman
chaithr...@ti.com writes: > From: Chaithrika U S > > Add pin mux definitions, display device setup, clock setup functions > > Add pin mux related code for the display device, also add platform device > and resource structures. Also define a platform specific clock setup function > that can be acc

Re: [PATCH v3 6/6] DaVinci - Adding platform & board changes for vpfe capture on DM365

2010-02-04 Thread Kevin Hilman
es for the devices listed under 2) > 4) defines clock aliase for isif driver > 5) adding setup_pinmux() for isif > > Reviewed-by: Kevin Hilman > Signed-off-by: Murali Karicheri Signed-off-by: Kevin Hilman Mauro, please go ahead and merge this via your tree along wit

Re: [PATCH v4 0/6] davinci vpbe: dm6446 v4l2 driver

2010-12-10 Thread Kevin Hilman
"Hans Verkuil" writes: >> version4 : addressed Hans's comments >> on: >> 1. replaced mutex_lock_interruptible() with mutex_lock() >> 2. replaced ntsc and pal macros with new equivalent macros >> 3. simplifying the code in the if-else condition >> 4. minor code corrections > > For the whole patch

Re: [PATCH v9 5/8] davinci vpbe: platform specific additions

2010-12-22 Thread Kevin Hilman
Manjunath Hadli writes: > This patch implements the overall device creation for the Video > display driver > > Signed-off-by: Manjunath Hadli > Acked-by: Muralidharan Karicheri > Acked-by: Hans Verkuil This one still conflicts with other changes in davinci-next queued for 2.6.38. Please sepa

[RFC PATCH 0/6] media: davinci: VPIF: add DT support

2016-10-25 Thread Kevin Hilman
s are, the rest are just prep work to ge there. Tested on da850-lcdk and was able to do basic frame capture from the composite input. Series applies on v4.9-rc1 Kevin Hilman (6): [media] davinci: add support for DT init ARM: davinci: da8xx: VPIF: enable DT init ARM: dts: davinci: da850:

[RFC PATCH 1/6] [media] davinci: add support for DT init

2016-10-25 Thread Kevin Hilman
Add basic support for initialization via DT. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/media/platform/davinci/vpif.c b

[RFC PATCH 5/6] [media] davinci: vpif_capture: don't lock over s_stream

2016-10-25 Thread Kevin Hilman
Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/davinci

[RFC PATCH 3/6] ARM: dts: davinci: da850: add VPIF

2016-10-25 Thread Kevin Hilman
Add VPIF and VPIF capture nodes to da850. Note that these are separate nodes because the current media drivers have two separate drivers for vpif and vpif_capture. Signed-off-by: Kevin Hilman --- arch/arm/boot/dts/da850.dtsi | 28 1 file changed, 28 insertions

[RFC PATCH 6/6] [media] davinci: vpif_capture: get subdevs from DT

2016-10-25 Thread Kevin Hilman
o be done via DT? Not-Yet-Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 132 +- include/media/davinci/vpif_types.h| 9 +- 2 files changed, 134 insertions(+), 7 deletions(-) diff --git a/drivers/media/platform/dav

[RFC PATCH 4/6] ARM: dts: davinci: da850-lcdk: enable VPIF capture

2016-10-25 Thread Kevin Hilman
Enable video capture via the on-board TVP5147 decoder hooked up to ch0 one of the VPIF capture input. Signed-off-by: Kevin Hilman --- arch/arm/boot/dts/da850-lcdk.dts | 30 ++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm

[RFC PATCH 2/6] ARM: davinci: da8xx: VPIF: enable DT init

2016-10-25 Thread Kevin Hilman
Add basic support for DT initializaion of VPIF (capture) via DT. Clocks and mux still need to happen in this file until there are real clock and pinctrl drivers, but the video nodes and subdevs can all come from DT. Signed-off-by: Kevin Hilman --- arch/arm/mach-davinci/da8xx-dt.c | 17

Re: [RFC PATCH 0/6] media: davinci: VPIF: add DT support

2016-10-28 Thread Kevin Hilman
Kevin Hilman writes: > This series attempts to add DT support to the davinci VPIF capture > driver. > > I'm not sure I've completely grasped the proper use of the ports and > endpoints stuff, so this RFC is primarily to get input on whether I'm > on the right tra

Re: [RFC PATCH 0/6] media: davinci: VPIF: add DT support

2016-11-11 Thread Kevin Hilman
Hans Verkuil writes: > Hi Kevin, > > On 10/26/2016 01:55 AM, Kevin Hilman wrote: >> This series attempts to add DT support to the davinci VPIF capture >> driver. >> >> I'm not sure I've completely grasped the proper use of the ports and >> endpo

[PATCH 1/4] [media] davinci: add support for DT init

2016-11-18 Thread Kevin Hilman
Add basic support for initialization via DT. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/media/platform/davinci/vpif.c b

[PATCH 2/4] [media] davinci: vpif_capture: don't lock over s_stream

2016-11-18 Thread Kevin Hilman
Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/davinci

[PATCH 4/4] [media] dt-bindings: add TI VPIF documentation

2016-11-18 Thread Kevin Hilman
Cc: Rob Herring Signed-off-by: Kevin Hilman --- .../devicetree/bindings/media/ti,vpif-capture.txt | 65 ++ .../devicetree/bindings/media/ti,vpif.txt | 8 +++ 2 files changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/ti,vpif

[PATCH 3/4] [media] davinci: vpif_capture: get subdevs from DT

2016-11-18 Thread Kevin Hilman
Allow getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 130 +- include/media/davinci/vpif_types.h

Re: [PATCH 4/4] [media] dt-bindings: add TI VPIF documentation

2016-11-21 Thread Kevin Hilman
Arnd Bergmann writes: > On Friday, November 18, 2016 4:32:08 PM CET Kevin Hilman wrote: >> + >> +Required properties: >> +- compatible: must be "ti,vpif-capture" >> +- reg: physical base address and length of the registers set for the device; >> +-

Re: [PATCH 2/4] [media] davinci: vpif_capture: don't lock over s_stream

2016-11-21 Thread Kevin Hilman
Hans Verkuil writes: > On 19/11/16 01:32, Kevin Hilman wrote: >> Video capture subdevs may be over I2C and may sleep during xfer, so we >> cannot do IRQ-disabled locking when calling the subdev. >> >> Signed-off-by: Kevin Hilman >> --- >> drivers/me

[PATCH v2 2/4] [media] davinci: vpif_capture: don't lock over s_stream

2016-11-21 Thread Kevin Hilman
Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/davinci

[PATCH v2 0/4] [media] davinci: VPIF: add DT support

2016-11-21 Thread Kevin Hilman
Add DT support, including getting subdevs from DT ports/endpoints. Changes since v1: - more specific compatible strings, based on SoC: ti,da850-vpif* - fix locking bug when unlocking over subdev s_stream Kevin Hilman (4): [media] davinci: add support for DT init [media] davinci: vpif_capture

[PATCH v2 1/4] [media] davinci: add support for DT init

2016-11-21 Thread Kevin Hilman
Add basic support for initialization via DT. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/media/platform/davinci/vpif.c b

[PATCH v2 3/4] [media] davinci: vpif_capture: get subdevs from DT

2016-11-21 Thread Kevin Hilman
Allow getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 130 +- include/media/davinci/vpif_types.h

[PATCH v2 4/4] [media] dt-bindings: add TI VPIF documentation

2016-11-21 Thread Kevin Hilman
Cc: Rob Herring Signed-off-by: Kevin Hilman --- .../bindings/media/ti,da850-vpif-capture.txt | 65 ++ .../devicetree/bindings/media/ti,da850-vpif.txt| 8 +++ 2 files changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/ti,da850

Re: [PATCH v2 4/4] [media] dt-bindings: add TI VPIF documentation

2016-11-22 Thread Kevin Hilman
Hans Verkuil writes: > On 22/11/16 02:44, Kevin Hilman wrote: >> Cc: Rob Herring >> Signed-off-by: Kevin Hilman >> --- >> .../bindings/media/ti,da850-vpif-capture.txt | 65 >> ++ >> .../devicetree/bindings/media/ti,da850-vpif.

[PATCH v3 1/4] [media] davinci: add support for DT init

2016-11-22 Thread Kevin Hilman
Add basic support for initialization via DT. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/media/platform/davinci/vpif.c b

[PATCH v3 0/4] [media] davinci: VPIF: add DT support

2016-11-22 Thread Kevin Hilman
Add DT support, including getting subdevs from DT ports/endpoints. Changes since v2: - DT binding doc: fix example to use correct compatible Changes since v1: - more specific compatible strings, based on SoC: ti,da850-vpif* - fix locking bug when unlocking over subdev s_stream Kevin Hilman (4

[PATCH v3 2/4] [media] davinci: vpif_capture: don't lock over s_stream

2016-11-22 Thread Kevin Hilman
Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/davinci

[PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation

2016-11-22 Thread Kevin Hilman
Signed-off-by: Kevin Hilman --- .../bindings/media/ti,da850-vpif-capture.txt | 65 ++ .../devicetree/bindings/media/ti,da850-vpif.txt| 8 +++ 2 files changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt

[PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

2016-11-22 Thread Kevin Hilman
Allow getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman --- drivers/media/platform/davinci/vpif_capture.c | 130 +- include/media/davinci/vpif_types.h

Re: [PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

2016-11-23 Thread Kevin Hilman
Hi Sakari, Sakari Ailus writes: > On Tue, Nov 22, 2016 at 07:52:43AM -0800, Kevin Hilman wrote: >> Allow getting of subdevs from DT ports and endpoints. >> >> The _get_pdata() function was larely inspired by (i.e. stolen from) > > vpif_capture_get_pdata and "la

Re: [PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

2016-11-23 Thread Kevin Hilman
Hi Sakari, Sakari Ailus writes: > On Tue, Nov 22, 2016 at 07:52:43AM -0800, Kevin Hilman wrote: >> Allow getting of subdevs from DT ports and endpoints. >> >> The _get_pdata() function was larely inspired by (i.e. stolen from) > > vpif_capture_get_pdata and "la

  1   2   >