Hi All,
I am writing a very simple v4l2 driver for HDMI video capturing
and I have a question regarding the DV timings. I have
implemented {g/s/query}_dv_timings in my driver but these ioctls
are not called when I try to use mplayer. If I grep mplayer code
I don't find any reference to these funct
Hi,
On 17-10-2016 12:37, Hans Verkuil wrote:
> Report of the V4L2 brainstorm meeting October 10-11 2016, Berlin
[snip]
> 4.4 Streamon and streamoff
>
> - How to handle STREAMON/OFF?
> - Pipelines without video nodes?
> - Buffer size may change. Need to reallocate buffers, which is
From: Hans Verkuil
Date: Aug/16/2019, 09:06:30 (UTC+00:00)
> Rather then discussing topics for a meeting under the subject 'Lisbon'
> let's start a new thread referring to the right place :-)
>
> I will try to organize a room, either during the ELCE or (if that doesn't
> work) perhaps on the Thu
some sources might not be
very stable at sending the video (i.e. we must react
accordingly).
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Changes from RFC:
- Added support for HDCP 1.4
- Fixup HDMI_VIC not being p
Add a entry for Synopsys Designware HDMI Receivers drivers
and phys.
Signed-off-by: Jose Abreu
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 053c3bd..e798040 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11294,6 +11294,13 @@ L
.
configuration functions) and the controller must provide read/write
callbacks, as well as other specific functions.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Changes from RFC:
- Remove a bunch of functions that can be collapsed into
a
Document the bindings for the Synopsys Designware HDMI RX.
Signed-off-by: Jose Abreu
Cc: Rob Herring
---
.../devicetree/bindings/media/snps,dw-hdmi-rx.txt | 41 ++
1 file changed, 41 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/snps,dw-hdmi
several audio
output interfaces).
Jose Abreu (4):
[media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver
[media] platform: Add Synopsys Designware HDMI RX Controller Driver
MAINTAINERS: Add entry for Synopsys Designware HDMI drivers
dt-bindings: media: Document Synopsys Designware
Hi Hans,
On 13-06-2017 11:01, Jose Abreu wrote:
[snip]
> Changes from RFC:
> - Added support for HDCP 1.4
[snip]
> +
> +/* HDCP 1.4 */
> +#define DW_HDMI_HDCP14_BKSV_SIZE 2
> +#define DW_HDMI_HDCP14_KEYS_SIZE (2 * 40)
> +
> +struct dw_hdmi_hdcp1
On 13-06-2017 11:54, Hans Verkuil wrote:
> On 06/13/17 12:31, Hans Verkuil wrote:
>> On 06/13/17 12:06, Jose Abreu wrote:
>>> Hi Hans,
>>>
>>>
>>> On 13-06-2017 11:01, Jose Abreu wrote:
>>>
>>> [snip]
>>>> Changes from RF
some sources might not be
very stable at sending the video (i.e. we must react
accordingly).
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Changes from v1:
- Added support for CEC
- Correct typo errors
- Corr
Document the bindings for the Synopsys Designware HDMI RX.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Rob Herring
Cc: Mark Rutland
Cc: Mauro Carvalho Chehab
---
.../devicetree/bindings/media/snps,dw-hdmi-rx.txt | 41 ++
1 file changed, 41 insertions(+)
create
.
configuration functions) and the controller must provide read/write
callbacks, as well as other specific functions.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Changes from RFC:
- Remove a bunch of functions that can be collapsed into
a
Add a entry for Synopsys Designware HDMI Receivers drivers
and phys.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 053c3bd..e798040 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11294,6
several audio
output interfaces).
Version 2 is just a respin of the previous version with some minor bug fixes in
the controller driver and I also added CEC support.
This series was tested in a FPGA platform.
Jose Abreu (4):
[media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver
[media
Hi Hans,
On 16-06-2017 13:38, Hans Verkuil wrote:
> Hi Jose,
>
> Just a quick review of the new CEC code:
Thanks!
>
> On 06/16/17 12:07, Jose Abreu wrote:
>> This is an initial submission for the Synopsys Designware HDMI RX
>> Controller Driver. This driver interact
Hi Hans,
On 16-06-2017 14:44, Hans Verkuil wrote:
>
>>>
>>>
+ /* CEC */
+ dw_dev->cec_adap = cec_allocate_adapter(&dw_hdmi_cec_adap_ops,
+ dw_dev, dev_name(dev), CEC_CAP_TRANSMIT |
+ CEC_CAP_PHYS_ADDR | CEC_CAP_LOG_ADDRS,
>>> Add CEC_CAP_RC
Document the bindings for the Synopsys Designware HDMI RX.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Rob Herring
Cc: Mark Rutland
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Changes from v2:
- Document edid-phandle property
---
.../devicetree/bindings/media/snps,dw-hdmi
some sources might not be
very stable at sending the video (i.e. we must react
accordingly).
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Changes from v2:
- Address review comments from Hans regarding CEC
- Use CEC not
Add a entry for Synopsys Designware HDMI Receivers drivers
and phys.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 053c3bd..e798040 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11294,6
.
configuration functions) and the controller must provide read/write
callbacks, as well as other specific functions.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Changes from RFC:
- Remove a bunch of functions that can be collapsed into
a
several audio
output interfaces).
Version 3 addresses review comments from Hans Verkuil regarding CEC and also
uses a CEC notifier so that userspace does not have to manually set the CEC
physical address. SCDC support was also implemented.
This series was tested in a FPGA platform.
Jose Abreu (4
Hi Sylwester,
Thanks for the feedback!
On 18-06-2017 18:34, Sylwester Nawrocki wrote:
> Hi Jose,
>
> On 06/16/2017 06:38 PM, Jose Abreu wrote:
>> Document the bindings for the Synopsys Designware HDMI RX.
>>
>> Signed-off-by: Jose Abreu
>> new file mode
Hi Sylwester,
Thanks again for the feedback!
On 18-06-2017 19:04, Sylwester Nawrocki wrote:
> On 06/16/2017 06:38 PM, Jose Abreu wrote:
>> This is an initial submission for the Synopsys Designware HDMI RX
>> Controller Driver. This driver interacts with a phy driver so that
>
Hi Sylwester,
On 19-06-2017 22:18, Sylwester Nawrocki wrote:
> On 06/19/2017 11:01 AM, Jose Abreu wrote:
>> Using fixed-clock was already in my todo list. Regarding phy I
>> need to pass pdata so that the callbacks between controller and
>> phy are established. I also need
HI Sylwester,
On 19-06-2017 23:10, Sylwester Nawrocki wrote:
> On 06/19/2017 11:33 AM, Jose Abreu wrote:
>> On 18-06-2017 19:04, Sylwester Nawrocki wrote:
>>> On 06/16/2017 06:38 PM, Jose Abreu wrote:
>>>> This is an initial submission for the Synopsys Designware
Document the bindings for the Synopsys Designware HDMI RX.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Rob Herring
Cc: Mark Rutland
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Sylwester Nawrocki
Changes from v3:
- Document the new DT bindings suggested by Sylwester
some sources might not be
very stable at sending the video (i.e. we must react
accordingly).
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Sylwester Nawrocki
Changes from v3:
- Use v4l2 async API (Sylwester)
- D
Add a entry for Synopsys Designware HDMI Receivers drivers
and phys.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c4be6d4..7ebc6dd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11354,6
.
configuration functions) and the controller must provide read/write
callbacks, as well as other specific functions.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Sylwester Nawrocki
Changes from v3:
- Use v4l2 async API (Sylwester)
- Use
tform.
Jose Abreu (4):
[media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver
[media] platform: Add Synopsys Designware HDMI RX Controller Driver
MAINTAINERS: Add entry for Synopsys Designware HDMI drivers
dt-bindings: media: Document Synopsys Designware HDMI RX
Cc: Carlos Palminh
Hi Rob,
On 23-06-2017 22:58, Rob Herring wrote:
> On Tue, Jun 20, 2017 at 06:26:12PM +0100, Jose Abreu wrote:
>> Document the bindings for the Synopsys Designware HDMI RX.
>>
>> Signed-off-by: Jose Abreu
>> Cc: Carlos Palminha
>> Cc: Rob Herring
>>
Hi Sylwester,
On 25-06-2017 22:13, Sylwester Nawrocki wrote:
> Hi Jose,
>
> Thank you for addressing my review comments. Couple more suggestions below.
>
> On 06/20/2017 07:26 PM, Jose Abreu wrote:
>> This adds support for the Synopsys Designware HDMI RX PHY e405. Thi
Hi Sylwester,
On 25-06-2017 22:13, Sylwester Nawrocki wrote:
> On 06/20/2017 07:26 PM, Jose Abreu wrote:
>> This is an initial submission for the Synopsys Designware HDMI RX
>> Controller Driver. This driver interacts with a phy driver so that
>> a communication between
Hi Sylwester,
On 27-06-2017 21:34, Sylwester Nawrocki wrote:
> Hi Jose,
>
> On 06/27/2017 10:43 AM, Jose Abreu wrote:
>> On 25-06-2017 22:13, Sylwester Nawrocki wrote:
>>> On 06/20/2017 07:26 PM, Jose Abreu wrote:
>>>> This is an initial submission
Add a entry for Synopsys Designware HDMI Receivers drivers
and phys.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c4be6d4..7ebc6dd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11354,6
tested in a FPGA platform.
Jose Abreu (4):
[media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver
[media] platform: Add Synopsys Designware HDMI RX Controller Driver
MAINTAINERS: Add entry for Synopsys Designware HDMI drivers
dt-bindings: media: Document Synopsys Designware HDMI
Document the bindings for the Synopsys Designware HDMI RX.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Rob Herring
Cc: Mark Rutland
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Sylwester Nawrocki
Cc: devicet...@vger.kernel.org
Changes from v4:
- Use "cfg" inste
some sources might not be
very stable at sending the video (i.e. we must react
accordingly).
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Sylwester Nawrocki
Changes from v4:
- Add flag V4L2_SUBDEV_FL_HAS_DEVNODE (Sylw
.
configuration functions) and the controller must provide read/write
callbacks, as well as other specific functions.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Sylwester Nawrocki
Changes from v4:
- Use usleep_range (Sylwester)
- Remove
Hi Hans,
On 03-07-2017 10:27, Hans Verkuil wrote:
> On 06/29/2017 12:46 PM, Jose Abreu wrote:
>> This is an initial submission for the Synopsys Designware HDMI RX
>> Controller Driver. This driver interacts with a phy driver so
>> that
>> a communication between
Hi Hans,
On 03-07-2017 11:33, Hans Verkuil wrote:
> On 07/03/2017 11:53 AM, Jose Abreu wrote:
>> Hi Hans,
>>
>>
>> On 03-07-2017 10:27, Hans Verkuil wrote:
>>> On 06/29/2017 12:46 PM, Jose Abreu wrote:
>>>> This is an initial submission for the
On 04-07-2017 10:39, Hans Verkuil wrote:
>
>> +static const struct v4l2_subdev_video_ops
>> dw_hdmi_sd_video_ops = {
>> +.s_routing = dw_hdmi_s_routing,
>> +.g_input_status = dw_hdmi_g_input_status,
>> +.g_parm = dw_hdmi_g_parm,
>> +.g_dv_timings = dw_hdmi_
On 04-07-2017 14:02, Hans Verkuil wrote:
> On 07/04/17 14:33, Jose Abreu wrote:
>>
>> On 04-07-2017 10:39, Hans Verkuil wrote:
>>>>>>>> +static const struct v4l2_subdev_video_ops
>>>>>>>> dw_hdmi_sd_video_ops = {
>>>
Add a entry for Synopsys Designware HDMI Receivers drivers
and phys.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c4be6d4..7ebc6dd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11354,6
some sources might not be
very stable at sending the video (i.e. we must react
accordingly).
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Sylwester Nawrocki
Changes from v5:
- Removed HDCP 1.4 support (Hans)
- Re
.
configuration functions) and the controller must provide read/write
callbacks, as well as other specific functions.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Sylwester Nawrocki
Changes from v4:
- Use usleep_range (Sylwester)
- Remove
Document the bindings for the Synopsys Designware HDMI RX.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Rob Herring
Cc: Mark Rutland
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Sylwester Nawrocki
Cc: devicet...@vger.kernel.org
Changes from v4:
- Use "cfg" inste
platform called
ARC AXS101.
Jose Abreu (4):
[media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver
[media] platform: Add Synopsys Designware HDMI RX Controller Driver
MAINTAINERS: Add entry for Synopsys Designware HDMI drivers
dt-bindings: media: Document Synopsys Designware
Hi Sylwester,
On 05-07-2017 21:52, Sylwester Nawrocki wrote:
> On 07/04/2017 04:11 PM, Jose Abreu wrote:
>> Document the bindings for the Synopsys Designware HDMI RX.
>>
>> Signed-off-by: Jose Abreu
>> ---
>> .../devicetree/binding
On 06-07-2017 21:30, Sylwester Nawrocki wrote:
> On 07/06/2017 12:24 PM, Jose Abreu wrote:
>>>> +- edid-phandle: phandle to the EDID handler block.
>>> Could you make this property optional and when it is missing assume that
>>> device
>>> correspondi
On 06-07-2017 21:52, kbuild test robot wrote:
>drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_registered':
>>> drivers/media//platform/dwc/dw-hdmi-rx.c:1452:9: error: implicit
>>> declaration of function 'v4l2_async_subnotifier_register'
>>> [-Werror=implicit-function-declarat
Add a new stub function for cec_register_cec_notifier() so that
we can still call this function when CONFIG_CEC_NOTIFIER and
CONFIG_CEC_CORE are not set.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Hans Verkuil
---
include/media/cec.h | 7 +++
1 file changed, 7 insertions(+)
diff
aration of notifier
structure.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Hans Verkuil
---
include/media/cec-notifier.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/media/cec-notifier.h b/include/media/cec-notifier.h
index 298f996..84f9376 100644
---
some sources might not be
very stable at sending the video (i.e. we must react
accordingly).
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Sylwester Nawrocki
Changes from v6:
- edid-phandle now also looks for parent
.
Jose Abreu (6):
[media] cec.h: Add stub function for cec_register_cec_notifier()
[media] cec-notifier.h: Prevent build warnings using forward
declaration
dt-bindings: media: Document Synopsys Designware HDMI RX
MAINTAINERS: Add entry for Synopsys Designware HDMI drivers
[media] platform
.
configuration functions) and the controller must provide read/write
callbacks, as well as other specific functions.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Sylwester Nawrocki
Changes from v4:
- Use usleep_range (Sylwester)
- Remove
Document the bindings for the Synopsys Designware HDMI RX.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Rob Herring
Cc: Mark Rutland
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Sylwester Nawrocki
Cc: devicet...@vger.kernel.org
Changes from v6:
- Document which properties
Add a entry for Synopsys Designware HDMI Receivers drivers
and phys.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c4be6d4..7ebc6dd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11354,6
Hi Hans,
On 07-07-2017 12:16, Hans Verkuil wrote:
> On 07/07/17 13:08, Jose Abreu wrote:
>> When CONFIC_CEC_NOTIFIER is not set and we only include cec-notifier.h
>> we can get build warnings like these ones:
>>
>> "warning: ‘struct cec_notifier’ declared insi
Add a new stub function for cec_register_cec_notifier() so that
we can still call this function when CONFIG_CEC_NOTIFIER and
CONFIG_CEC_CORE are not set.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Hans Verkuil
---
include/media/cec.h | 8
1 file changed, 8 insertions(+)
diff
some sources might not be
very stable at sending the video (i.e. we must react
accordingly).
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Sylwester Nawrocki
Changes from v6:
- edid-phandle now also looks for parent
.
configuration functions) and the controller must provide read/write
callbacks, as well as other specific functions.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Sylwester Nawrocki
Changes from v4:
- Use usleep_range (Sylwester)
- Remove
Add a entry for Synopsys Designware HDMI Receivers drivers
and phys.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c4be6d4..7ebc6dd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11354,6
Document the bindings for the Synopsys Designware HDMI RX.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Rob Herring
Cc: Mark Rutland
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Sylwester Nawrocki
Cc: devicet...@vger.kernel.org
Changes from v7:
- Remove SoC specific
platform called
ARC AXS101.
Jose Abreu (5):
[media] cec.h: Add stub function for cec_register_cec_notifier()
dt-bindings: media: Document Synopsys Designware HDMI RX
MAINTAINERS: Add entry for Synopsys Designware HDMI drivers
[media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver
Add a new stub function for cec_register_cec_notifier() so that
we can still call this function when CONFIG_CEC_NOTIFIER and
CONFIG_CEC_CORE are not set.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Hans Verkuil
---
include/media/cec.h | 8
1 file changed, 8 insertions(+)
diff
Hi Rob,
On 10-07-2017 16:24, Rob Herring wrote:
> On Mon, Jun 26, 2017 at 11:42 AM, Jose Abreu wrote:
>> Hi Rob,
>>
>>
>> On 23-06-2017 22:58, Rob Herring wrote:
>>> On Tue, Jun 20, 2017 at 06:26:12PM +0100, Jose Abreu wrote:
>>>> Document
Hi Hans,
I'm writing to you in order to get more details about current CEC
implementation status. I've seen the code and it appears you have
already support for CEC 2.0, right? I've also seen the
implementation in adv7511 of CEC and I've extracted the following
sequence:
1) Call cec_allocate
n the pixel clock value.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Charles-Antoine Couret
Cc: linux-media@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
---
drivers/media/v4l2-core/v4l2-dv-timings.c | 29 +
include/
Hi Neil,
On 07-03-2017 16:42, Neil Armstrong wrote:
> From: Laurent Pinchart
>
> In preparation for adding PHY operations to handle RX SENSE and HPD,
> group all the PHY interrupt setup code in a single location and extract
> it to a separate function.
>
> Signed-off-by: Laurent Pinchart
> Sign
Hi Neil,
On 07-03-2017 16:42, Neil Armstrong wrote:
> Some display pipelines can only provide non-RBG input pixels to the HDMI TX
> Controller, this patch takes the pixel format from the plat_data if provided.
>
> Signed-off-by: Neil Armstrong
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c |
gned-off-by: Neil Armstrong
Looks nice!
Reviewed-by: Jose Abreu
Best regards,
Jose Miguel Abreu
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 135
> ++
> include/drm/bridge/dw_hdmi.h | 5 ++
> 2 files changed, 86 insertions(+), 54 deleti
Hi Neil,
On 08-03-2017 12:12, Neil Armstrong wrote:
>
> Hi Jose,
>
> It seems here that we only have the RGB444<->YUV444 8bit tables, from the
> Amlogic
> source I have the following for 10bit, 12bit and 16bit for itu601 :
>
> static const u16 csc_coeff_rgb_out_eitu601_10b[3][4] = {
> { 0x
Hi Hans,
Thanks for the review!
On 09-03-2017 12:29, Hans Verkuil wrote:
> On 07/03/17 17:48, Jose Abreu wrote:
>> HDMI Receivers receive video modes which, according to
>> CEA specification, can have different frames per second
>> (fps) values.
>>
>> This patc
Hi Neil,
On 09-03-2017 14:27, Jose Abreu wrote:
> Hi Neil,
>
>
> On 08-03-2017 12:12, Neil Armstrong wrote:
>> Hi Jose,
>>
>> It seems here that we only have the RGB444<->YUV444 8bit tables, from the
>> Amlogic
>> source I have the following for
Hi Hans,
On 09-03-2017 15:40, Hans Verkuil wrote:
> On 09/03/17 16:15, Jose Abreu wrote:
>> Hi Hans,
>>
>>
>> Thanks for the review!
>>
>>
>> On 09-03-2017 12:29, Hans Verkuil wrote:
>>> On 07/03/17 17:48, Jose Abreu wrote:
>>>&g
Hi Hans,
On 14-03-2017 07:24, Hans Verkuil wrote:
>> Right, I was forgetting about this ...
>>
>> So:
>> 1) Most of HDMI receivers do not have the expected precision in
>> measuring pixel clock value;
> s/Most/Some/
>
> Newer HDMI receivers tend to have better precision.
>
> However, the 1000/100
Currently, cobalt driver always returns 60fps in g_parm.
This patch uses the new v4l2_calc_timeperframe helper to
calculate the time per frame value.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: linux-media@vger.kernel.org
Cc: linux-ker
Add a new flag to UAPI for DV timings which, whenever set,
indicates that hardware can detect the difference between
regular FPS and 1000/1001 FPS.
This is specific to HDMI receivers. Also, it is only valid
when V4L2_DV_FL_CAN_REDUCE_FPS is set.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc
/vertical values.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: linux-media@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
---
drivers/media/v4l2-core/v4l2-dv-timings.c | 39 +++
include/media/v4l2-dv-timings.h
se Miguel Abreu
Cc: Carlos Palminha
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: linux-media@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Jose Abreu (3):
[media] videodev2.h: Add new DV flag CAN_DETECT_REDUCED_FPS
[media] v4l2-dv-timings: Introduce v4l2_calc_timeperframe helper
[m
-by: Laurent Pinchart
> Signed-off-by: Neil Armstrong
Reviewed-by: Jose Abreu
Maybe if you submit a next version we could get rid of
"dw_hdmi_fb_registered" totally and move the remaining setup code
to a new "dw_hdmi_setup_i2c" function.
Best regards,
Jose Miguel Abreu
> -
>
> Reviewed-by: Archit Taneja
> Signed-off-by: Neil Armstrong
Reviewed-by: Jose Abreu
Best regards,
Jose Miguel Abreu
> ---
> include/uapi/linux/media-bus-format.h | 13 +++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/lin
test this on your platform which has
non RGB in input and the CSC worked correctly, right?
Reviewed-by: Jose Abreu
Best regards,
Jose Miguel Abreu
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 326
> +-
> include/drm/bridge/dw_hdmi.h |
Hi Hans,
On 21-03-2017 11:49, Jose Abreu wrote:
> Hi all,
>
> This is a follow up patch from this discussion [1]. It should be
> seen more as a starting point to introduce better handling of
> time per frame in v4l2. Quoting Hans Verkuil from [1]:
>
Hi Hans,
>> Can you please review this series, when possible? And if you
>> could test it on cobalt it would be great :)
> Hopefully next week.
Thanks :)
> Did you have some real-world numbers w.r.t. measured
> pixelclock frequencies and 60 vs 59.94 Hz and 24 vs 23.976 Hz?
I did make some mea
Hi Hans,
On 24-03-2017 12:12, Hans Verkuil wrote:
> On 03/24/17 12:52, Jose Abreu wrote:
>> Hi Hans,
>>
>>
>>>> Can you please review this series, when possible? And if you
>>>> could test it on cobalt it would be great :)
>>> Hopefully
Add a helper function to get driver private data from CEC
adapter. This helps the readability a little bit and allows
to change the 'priv' field name to something else without
needing to touch all drivers.
Signed-off-by: Jose Abreu
Cc: Hans Verkuil
---
include/media/cec.h | 5 +++
Use helper function to get driver private data from CEC
adapter.
Signed-off-by: Jose Abreu
Cc: Hans Verkuil
---
drivers/media/platform/vivid/vivid-cec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/vivid/vivid-cec.c
b/drivers/media/platform
Use helper function to get driver private data from CEC
adapter.
Signed-off-by: Jose Abreu
Cc: Hans Verkuil
---
drivers/media/usb/pulse8-cec/pulse8-cec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/usb/pulse8-cec/pulse8-cec.c
b/drivers/media/usb
Use helper function to get driver private data from CEC
adapter.
Signed-off-by: Jose Abreu
Cc: Hans Verkuil
---
drivers/media/i2c/adv7842.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.c
index 2d61f0c..303effd
Use helper function to get driver private data from CEC
adapter.
Signed-off-by: Jose Abreu
Cc: Kamil Debski
---
drivers/staging/media/s5p-cec/s5p_cec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/s5p-cec/s5p_cec.c
b/drivers/staging/media/s5p
Use helper function to get driver private data from CEC
adapter.
Signed-off-by: Jose Abreu
Cc: Hans Verkuil
---
drivers/media/i2c/adv7511.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/adv7511.c b/drivers/media/i2c/adv7511.c
index 8c9e289..ccc4786
Use helper function to get driver private data from CEC
adapter.
Signed-off-by: Jose Abreu
Cc: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
index d8bf435..f1fa9ce
Use helper function to get driver private data from CEC
adapter.
Signed-off-by: Jose Abreu
Cc: Benjamin Gaignard
---
drivers/staging/media/st-cec/stih-cec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/st-cec/stih-cec.c
b/drivers/staging
Hi,
This series introduces a new helper function called cec_get_drvdata() which
returns the adapter private data and can be used by drivers that use CEC.
Best regards,
Jose Miguel Abreu
Jose Abreu (8):
[media] cec: Add cec_get_drvdata()
[media] staging: st-cec: Use cec_get_drvdata
Hi Hans,
Thanks! I totally forgot about the documentation update.
On 27-03-2017 10:53, Hans Verkuil wrote:
> Document the new cec_get_drvdata() helper function.
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Jose Abreu
Best regards,
Jose Miguel Abreu
> ---
> diff --git a/Docu
Hi Hans,
On 24-03-2017 12:28, Hans Verkuil wrote:
> On 03/24/17 13:21, Jose Abreu wrote:
>> Hi Hans,
>>
>>
>> On 24-03-2017 12:12, Hans Verkuil wrote:
>>> On 03/24/17 12:52, Jose Abreu wrote:
>>>> Hi Hans,
>>>>
>>>>
>>
Hi Hans,
On 28-03-2017 11:07, Hans Verkuil wrote:
> On 27/03/17 13:58, Jose Abreu wrote:
>> Hi Hans,
>>
>>
>> On 24-03-2017 12:28, Hans Verkuil wrote:
>>> On 03/24/17 13:21, Jose Abreu wrote:
>>>> Hi Hans,
>>>>
>>>>
>
1 - 100 of 135 matches
Mail list logo
