|2 +-
> drivers/media/platform/soc_camera/rcar_vin.c |2 +-
> drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c |2 +-
For this driver:
> drivers/media/platform/sti/bdisp/bdisp-v4l2.c|2 +-
Reviewed-by: Fabien Dessenne
> dri
Hi Wei,
Thank you for the patch.
On 09/21/2016 05:09 PM, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Fix to return error code -EINVAL from the platform_get_resource() error
> handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun
R
Hi
On 12/12/17 14:47, Jia-Ju Bai wrote:
> The driver may sleep under a spinlock.
> The function call path is:
> bdisp_device_run (acquire the spinlock)
>bdisp_hw_reset
> msleep --> may sleep
>
> To fix it, msleep is replaced with mdelay.
May I suggest you to use readl_poll_timeout_atomic
y sleep
>
> To fix it, GFP_KERNEL is replaced with GFP_ATOMIC.
>
> This bug is found by my static analysis tool(DSAC) and checked by my code
> review.
>
> Signed-off-by: Jia-Ju Bai
Reviewed-by: Fabien Dessenne
> ---
> drivers/media/platform/sti/bdisp/bdisp-hw.c |2 +
On 16/12/17 15:14, Mauro Carvalho Chehab wrote:
> Em Sat, 16 Dec 2017 19:53:55 +0800
> Jia-Ju Bai escreveu:
>
>> Hi,
>>
>> On 2017/12/15 22:51, Fabien DESSENNE wrote:
>>> Hi
>>>
>>> On 12/12/17 14:47, Jia-Ju Bai wrote:
>>>> The
Hi,
On 16/12/17 12:54, Jia-Ju Bai wrote:
> The driver may sleep under a spinlock.
> The function call path is:
> bdisp_device_run (acquire the spinlock)
>bdisp_hw_reset
> msleep --> may sleep
>
> To fix it, readl_poll_timeout_atomic is used to replace msleep.
>
> This bug is found by my
Hi,
It's almost good!
You have to fix these checkpatch Warning/Check:
WARNING: Block comments use a trailing */ on a separate line
#36: FILE: drivers/media/platform/sti/bdisp/bdisp-hw.c:383:
+ * needing any delays */
CHECK: Alignment should match open parenthesis
#38: FILE: drivers/media/p
Hi,
The patch itself is OK, but the commit talks about bdisp & hva while the
patch is also for fimc-is.
Could you please update the commit header & messages?
BR
Fabien
On 02/12/2018 3:04 AM, Yangtao Li wrote:
> We already have the DEFINE_SHOW_ATTRIBUTE.There is no need to define
> bdisp_dbg_de
-by: Yangtao Li
Reviewed-by: Fabien Dessenne
> ---
> .../media/platform/sti/bdisp/bdisp-debug.c| 34 ++
> drivers/media/platform/sti/hva/hva-debugfs.c | 36 +++
> 2 files changed, 23 insertions(+), 47 deletions(-)
>
> diff --git a/drive
are.
>
> Signed-off-by: Hans Verkuil
> Cc: Fabien Dessenne
Reviewed-by: Fabien Dessenne
> ---
> drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.
On 07/05/18 17:19, Mauro Carvalho Chehab wrote:
> Em Mon, 07 May 2018 16:26:08 +0300
> Laurent Pinchart escreveu:
>
>> Hi Mauro,
>>
>> On Saturday, 5 May 2018 19:08:15 EEST Mauro Carvalho Chehab wrote:
>>> There was a recent discussion about the use/abuse of GFP_DMA flag when
>>> allocating memo
On 14/05/18 12:39, Mauro Carvalho Chehab wrote:
> Em Mon, 14 May 2018 07:35:03 -0300
> Mauro Carvalho Chehab escreveu:
>
>> Hi Fabien,
>>
>> Em Mon, 14 May 2018 08:00:37 +
>> Fabien DESSENNE escreveu:
>>
>>> On 07/05/18 17:19, Mauro Carvalho
Set the DMA_MASK and stop using the GFP_DMA flag
Signed-off-by: Fabien Dessenne
---
drivers/media/platform/sti/hva/hva-mem.c | 2 +-
drivers/media/platform/sti/hva/hva-v4l2.c | 4
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/sti/hva/hva-mem.c
b
Set the DMA_MASK and stop using the GFP_DMA flag
Signed-off-by: Fabien Dessenne
---
drivers/media/platform/sti/bdisp/bdisp-hw.c | 2 +-
drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 4
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/sti/bdisp/bdisp
Hi Thibault
On 13/02/17 20:08, Thibault Saunier wrote:
> From: Javier Martinez Canillas
>
> The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace
> should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV. But drivers
> don't agree on the display resolution that should be
e clang warning:
>
> drivers/media/platform/sti/bdisp/bdisp-v4l2.c:726:26: warning: Value
> stored to 'pix' during its initialization is never read
>
> Signed-off-by: Colin Ian King
Reviewed-by: Fabien Dessenne
> ---
> drivers/media/platform/sti/bdisp/bdisp-v4l2.
On 05/12/17 15:52, Benjamin Gaignard wrote:
> Add SPDX identifiers to files under sti directory
>
> Signed-off-by: Benjamin Gaignard
For the bdisp part:
Reviewed-by: Fabien Dessenne
> ---
> drivers/media/platform/sti/bdisp/bdisp-debug.c | 2 +-
> drivers/media/
__maybe_unused bdisp_filter_h_spec bdisp_h_spec[] = {
> ^
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Fabien Dessenne
> ---
> drivers/media/platform/sti/bdisp/bdisp-filter.h | 304
>
On 06/27/2016 03:31 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Stop using alloc_ctx and just fill in the device pointer.
>
> Signed-off-by: Hans Verkuil
> Cc: Fabien Dessenne
> Acked-by: Benoit Parrot
> Reviewed-by: Laurent Pinchart
> ---
> drivers/
Support the composing (at VIDEO_CAPTURE) with the _selection API.
v4l2-compliance successfully run ("test Composing: OK")
Signed-off-by: Fabien Dessenne
---
drivers/media/platform/sti/bdisp/bdisp-hw.c | 8 +--
drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 76 ++--
Add this missing debug information
Signed-off-by: Fabien Dessenne
---
drivers/media/platform/sti/bdisp/bdisp-debug.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/media/platform/sti/bdisp/bdisp-debug.c
b/drivers/media/platform/sti/bdisp/bdisp-debug.c
index 18282a0
bdisp_dev->dbg.copy_node shall be a copy of (and not point to)
bdisp_ctx->node, since this resource is freed upon driver release.
Signed-off-by: Fabien Dessenne
---
drivers/media/platform/sti/bdisp/bdisp-hw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
Hi
"4:x:y" refers to chroma subsampling, details here:
https://en.wikipedia.org/wiki/Chroma_subsampling. With "YUV 4:4:4" each
pixel has 1 Luma information and 1 Chroma information: 1 Y + 1 Cb + 1 Cr
= 24 bits per pixel.
In top of that, each of the three components (Y, Cb, Cr) can be stored
Hi Shailendra
Thank you for the patch.
Could you please update the subject line (try to have it as short as
possible):
- there is no need for the 'platform' keyword. This remark applies to
your other patches.
- write all keywords in lower case (Bdisp -> bdisp). This remark applies
also to
Hi Shailendra,
Thank you for the patch, it's good for me.
On 12/02/2016 05:48 AM, Shailendra Verma wrote:
> The File handle is not yet added in the vdev list.So no need to call
> v4l2_fh_del(&ctx->fh)if it fails to create control.
>
> Signed-off-by: Shailendra Ver
Hi Ran,
On 12/10/2015 10:46 PM, Ran Shalit wrote:
> On Sun, Dec 6, 2015 at 2:23 AM, Nicolas Dufresne
> wrote:
>> Le dimanche 06 décembre 2015 à 00:00 +0200, Ran Shalit a écrit :
>>> Hello,
>>>
>>> I would like to ask a general question regarding methods to debug a
>>> v4l2 device driver.
>>> Sinc
This adds DT binding documentation for STMicroelectronics bdisp driver.
Signed-off-by: Fabien Dessenne
---
.../devicetree/bindings/media/st,stih4xx.txt | 32 ++
1 file changed, 32 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/st,stih4xx.txt
are implemented in bdisp-hw.c.
The additional bdisp-debug.c file manages some debugfs entries.
Fabien Dessenne (3):
[media] bdisp: add DT bindings documentation
[media] bdisp: 2D blitter driver using v4l2 mem2mem framework
[media] bdisp: add debug file system
.../devicetree/bindings/media/st
Creates 5 debugfs entries to dump the last HW request, the last HW node
(=command), the HW registers and the recent HW performance (time & fps)
Signed-off-by: Fabien Dessenne
---
drivers/media/platform/bdisp/Makefile | 2 +-
drivers/media/platform/bdisp/bdisp-debug.c |
-off-by: Fabien Dessenne
---
drivers/media/platform/Kconfig | 10 +
drivers/media/platform/Makefile |2 +
drivers/media/platform/bdisp/Kconfig|9 +
drivers/media/platform/bdisp/Makefile |3 +
drivers/media/platform/bdisp/bdisp-filter.h | 346
d
let you know about the detailed status.
BR
Fabien
> -Original Message-
> From: Hans Verkuil [mailto:hverk...@xs4all.nl]
> Sent: lundi 27 avril 2015 18:26
> To: Fabien DESSENNE; linux-media@vger.kernel.org
> Cc: Benjamin Gaignard
> Subject: Re: [PATCH 0/3] Add media bdi
implemented in bdisp-hw.c.
The additional bdisp-debug.c file manages some debugfs entries.
Fabien Dessenne (3):
[media] bdisp: add DT bindings documentation
[media] bdisp: 2D blitter driver using v4l2 mem2mem framework
[media] bdisp: add debug file system
.../devicetree/bindings/media/st
This adds DT binding documentation for STMicroelectronics bdisp driver.
Signed-off-by: Fabien Dessenne
---
.../devicetree/bindings/media/st,stih4xx.txt | 32 ++
1 file changed, 32 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/st,stih4xx.txt
Creates 5 debugfs entries to dump the last HW request, the last HW node
(=command), the HW registers and the recent HW performance (time & fps)
Signed-off-by: Fabien Dessenne
---
drivers/media/platform/sti/bdisp/Makefile | 2 +-
drivers/media/platform/sti/bdisp/bdisp-debug.c |
-off-by: Fabien Dessenne
---
drivers/media/platform/Kconfig | 10 +
drivers/media/platform/Makefile |2 +
drivers/media/platform/sti/bdisp/Kconfig|9 +
drivers/media/platform/sti/bdisp/Makefile |3 +
drivers/media/platform/sti/bdisp/bdisp
testBasicSelection defines which of capture and output supports crop
(resp. compose).
testBasicCrop (resp. testBasicCompose) shall be run only for the
supported buf_type.
Change-Id: I0a81e826eb7bc8a318a9d833426d802fedce46c9
Signed-off-by: Fabien Dessenne
---
utils/v4l2-compliance/v4l2-test
EXPBUF: OK
Test input 0:
Stream using all formats:
Not supported for M2M devices
Total: 42, Succeeded: 42, Failed: 0, Warnings: 12
root@st:~#
Fabien Dessenne (3):
[media] bdisp: add DT bindings documentation
[media] bdisp: 2D blitter driver using v4l2 mem2mem framework
[media]
-off-by: Fabien Dessenne
---
drivers/media/platform/Kconfig | 10 +
drivers/media/platform/Makefile |2 +
drivers/media/platform/sti/bdisp/Kconfig|9 +
drivers/media/platform/sti/bdisp/Makefile |3 +
drivers/media/platform/sti/bdisp/bdisp
This adds DT binding documentation for STMicroelectronics bdisp driver.
Signed-off-by: Fabien Dessenne
---
.../devicetree/bindings/media/st,stih4xx.txt | 32 ++
1 file changed, 32 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/st,stih4xx.txt
Creates 5 debugfs entries to dump the last HW request, the last HW node
(=command), the HW registers and the recent HW performance (time & fps)
Signed-off-by: Fabien Dessenne
---
drivers/media/platform/sti/bdisp/Makefile | 2 +-
drivers/media/platform/sti/bdisp/bdisp-debug.c |
> From: Mauro Carvalho Chehab [mailto:mche...@osg.samsung.com]
> Sent: samedi 6 juin 2015 12:43
> To: Fabien DESSENNE
> Cc: linux-media@vger.kernel.org; Benjamin Gaignard; Hugues FRUCHET
> Subject: Re: [PATCH v3 2/3] [media] bdisp: 2D blitter driver using v4l2
> mem2mem framew
OK, I will take care of this new driver.
> -Original Message-
> From: Hans Verkuil [mailto:hverk...@xs4all.nl]
> Sent: lundi 8 juin 2015 14:24
> To: Linux Media Mailing List; Fabien DESSENNE
> Subject: [PATCH] bdisp: update MAINTAINERS
>
> Add entry for th
OK,
Acked-by: Fabien Dessenne
> -Original Message-
> From: Hans Verkuil [mailto:hverk...@xs4all.nl]
> Sent: lundi 8 juin 2015 16:33
> To: Fabien DESSENNE; Linux Media Mailing List
> Subject: Re: [PATCH] bdisp: update MAINTAINERS
>
> On 06/08/2015 03:36 PM, Fabien D
ss than zero.
Indeed, width and height are unsigned.
Signed-off-by: Fabien Dessenne
---
drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
in
Acked-by: Fabien Dessenne
> -Original Message-
> From: linux-media-ow...@vger.kernel.org [mailto:linux-media-
> ow...@vger.kernel.org] On Behalf Of Mauro Carvalho Chehab
> Sent: mercredi 10 juin 2015 17:35
> To: Linux Media Mailing List
> Cc: Mauro Carvalho Chehab; Mau
alho Chehab; Mauro Carvalho Chehab; Fabien DESSENNE
> Subject: [PATCH 2/2] [media] bdisp-debug: don't try to divide by s64
>
> There are several warnings there, on some architectures, related to dividing
> a s32 by a s64 value:
>
> drivers/media/platform/sti/bdisp/bdisp-debug
Acked-by: Fabien Dessenne
> -Original Message-
> From: Mauro Carvalho Chehab [mailto:mche...@osg.samsung.com]
> Sent: jeudi 11 juin 2015 12:37
> To: Fabien DESSENNE
> Cc: Linux Media Mailing List; Mauro Carvalho Chehab
> Subject: Re: [PATCH 2/2] [media] bdisp-debug: d
47 matches
Mail list logo
