Replace calls to `printk` with the appropriate `pr_*`
macro.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8
drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c | 14 ++
drivers/media/usb/pvrusb2/pvrusb2-main.c | 4 ++--
drivers/media
RGB24 format. Can't proceed."
I tried it on both kernel and modules 4.19.0-rc4+ compiled from
https://git.linuxtv.org/linux.git
and kenel and modules 4.19.0-rc1+ compiled from git://linuxtv.org/media_tree.git
Any idea what is the problem or how to investigate ?
Thanks,
Dafna Hirschfeld
Replace calls to `printk` with the appropriate `pr_*`
macro.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/usb/pvrusb2/pvrusb2-debug.h| 2 +-
drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8 +++---
drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c | 28 +---
drivers/media
Replace hardcoded function names with `__func__`
in debug prints.
Signed-off-by: Dafna Hirschfeld
---
.../staging/media/davinci_vpfe/dm365_ipipe.c | 6 +-
.../media/davinci_vpfe/dm365_resizer.c| 2 +-
.../media/davinci_vpfe/vpfe_mc_capture.c | 8 +--
.../staging/media
decoded
- allocate maximal space for the V4L2_PIX_FMT_FWHT format
with the test 'flags & FWHT_FL_COMPONENTS_NUM_BIT[01]'
Dafna Hirschfeld (3):
media: vicodec: prepare support for various number of planes
media: vicodec: Add support of greyscale format
media: vicodec: Add suppor
Add support for single plane greyscale format V4L2_PIX_FMT_GREY.
Also change the header of the encoded file to include the number
of components.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 56 +++
drivers/media/platform/vicodec/codec
Add fields to the structs `fwht_raw_frame`, `v4l2_fwht_pixfmts`
to support various number of planes - formats
with alpha channel that have 4 planes and greyscale formats
that have 1 plane.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 2 +-
drivers/media
Add support for formats with 4 planes: V4L2_PIX_FMT_ABGR32,
V4L2_PIX_FMT_ARGB32.
Also add alpha plane related flags to the header of the encoded file.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 15 +
drivers/media/platform/vicodec/codec-fwht.h
Change variables names in vicodec-core.c to *_src *_dst
to improve readability
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 94 ++-
1 file changed, 48 insertions(+), 46 deletions(-)
diff --git a/drivers/media/platform/vicodec/vicodec
In the function fwht_encode_frame, 'encoding = encode_plane'
should be replaced with 'encoding |= encode_plane'
so existing flags won't be overwrriten.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 2 +-
1 file changed, 1 insertio
Add support for the selection api for the crop target.
The driver rounds up the width and height such that
all planes dimesnsions are multiple of 8.
The userspace client should also read and write
the raw frames according the padding.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform
-- Forwarded message -
From: Dafna Hirschfeld
Date: Mon, Dec 17, 2018 at 7:23 PM
Subject: Re: [PATCH] media: vicodec: add support for CROP selection
To: Hans Verkuil
Cc: Linux Media Mailing List ,
On Sun, Dec 16, 2018 at 2:24 PM Hans Verkuil wrote:
>
> On 12/15/18 12
In the fwht_encode_frame, 'encoding = encode_plane'
should be replaced with 'encoding |= encode_plane'
so existing flags won't be overwrriten.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 8
1 file changed, 4 insertions
Add support for crop in the selection api for m2m encoder.
This includes reading and writing raw frames with padding.
Signed-off-by: Dafna Hirschfeld
---
Tested with the jellyfish video, with this script:
https://github.com/kamomil/outreachy/blob/master/test-v4l2-utils-with-jelly.sh
Tested on
On Tue, Dec 18, 2018 at 2:43 PM Hans Verkuil wrote:
>
> On 12/18/18 12:11 PM, Dafna Hirschfeld wrote:
> > Add support for crop in the selection api for m2m encoder.
> > This includes reading and writing raw frames with padding.
> >
> > Signed-off-by: Dafna Hirschfel
Add support for the selection api for the crop target in the encoder.
The driver rounds up the coded width and height such that
all planes dimensions are multiple of 8.
Signed-off-by: Dafna Hirschfeld
---
Changes from v1:
Renaming fields to be more descriptive.
Setting default values to
On Wed, Dec 19, 2018 at 12:03 PM Hans Verkuil wrote:
>
> On 12/19/18 9:34 AM, Dafna Hirschfeld wrote:
> >>> +bool is_m2m_enc = false;
> >>
> >> This should be static.
> >>
> >> I'm assuming that in a future patch we'll get a is_
On Thu, Dec 20, 2018 at 12:20 PM Hans Verkuil wrote:
>
> On 12/19/18 1:18 PM, Dafna Hirschfeld wrote:
> > Add support for the selection api for the crop target in the encoder.
> > The driver rounds up the coded width and height such that
> > all planes dimensions are multi
On Wed, Dec 19, 2018 at 12:03 PM Hans Verkuil wrote:
>
> On 12/19/18 9:34 AM, Dafna Hirschfeld wrote:
> >>> +bool is_m2m_enc = false;
> >>
> >> This should be static.
> >>
> >> I'm assuming that in a future patch we'll get a is_
Add support for the selection api for the crop and compose targets.
The driver rounds up the coded width and height such that
all planes dimensions are multiple of 8.
Signed-off-by: Dafna Hirschfeld
---
Main Changes from v2:
Add support for compose selection.
Rename the width/height fields of
Add support for the selection api for the crop and compose targets.
The driver rounds up the coded width and height such that
all planes dimensions are multiple of 8.
Signed-off-by: Dafna Hirschfeld
---
Changes from v3:
In v3 mistakenly renamed some stride variables in codec-fwht.c
to
Add support for the selection api for the crop and compose targets.
The driver rounds up the coded width and height such that
all planes dimensions are multiple of 8.
Signed-off-by: Dafna Hirschfeld
---
Main changes from v4:
In s/g_selection, check buffer type according to 'multiplanar'
Move the code that deals with reading from file in
'do_handle_cap' to a new function 'write_buffer_to_file'
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 139 +-
1 file changed, 72 insertions(+), 67 deletions(-)
diff --
Add the field 'num_planes' to 'v4l2_fwht_pixfmt_info' struct.
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.c | 48 +--
.../media/platform/vicodec/codec-v4l2-fwht.h | 1 +
drivers/media/platform/vicodec/vicodec-core.c | 2
Support crop and compose selection.
If the driver supports crop/compose then the raw frame is arranged
inside a padded buffer.
Signed-off-by: Dafna Hirschfeld
---
utils/common/codec-fwht.patch | 8 +-
utils/common/v4l-stream.c | 14 +--
utils/common/v4l-stream.h
On Wed, Jan 2, 2019 at 12:22 PM Hans Verkuil wrote:
>
> On 12/30/2018 02:48 PM, Dafna Hirschfeld wrote:
> >
> >
> > On Sun, Dec 30, 2018 at 2:22 PM Hans Verkuil > <mailto:hverk...@xs4all.nl>> wrote:
> >
> > On 12/29/2018 04:20 PM, Dafna
Add support for the selection api for the crop and compose targets.
The driver rounds up the coded width and height such that
all planes dimensions are multiple of 8.
Signed-off-by: Dafna Hirschfeld
---
This patch temporarily dysfunction vicoded since it does not
allow setting the visible
Support crop and compose selection.
If the driver supports crop/compose then the raw frame is arranged
inside a padded buffer.
Signed-off-by: Dafna Hirschfeld
---
Chnages from v2:
1. cleanups
2. change the code of read_write_padded_frame to use bytesperline as
a stride
utils/common/codec
In the fwht_encode_frame, 'encoding = encode_plane'
should be replaced with 'encoding |= encode_plane'
so existing flags won't be overwrriten.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 8
1 file changed, 4 insertions
The decoder gets the resolution information from the
headers of the compressed frames and starts a
'Dynamic Resolution Change' according to the decoder spec
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.h | 5 +
.../media/platform/vicodec/codec-v
Add the field 'num_planes' to 'v4l2_fwht_pixfmt_info' struct.
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.c | 48 +--
.../media/platform/vicodec/codec-v4l2-fwht.h | 1 +
drivers/media/platform/vicodec/vicodec-core.c | 2
Add support for the selection api for the crop and compose targets.
The driver rounds up the coded width and height such that
all planes dimensions are multiple of 8.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 80 +++--
drivers/media/platform/vicodec
In the fwht_encode_frame, 'encoding = encode_plane'
should be replaced with 'encoding |= encode_plane'
so existing flags won't be overwrriten.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 8
1 file changed, 4 insertions
Main changes from v1:
split the last patch to 3 patches:
1. add pixel encoding flags
2. read the compressed frame header to a different field than the
frame data
3. add support for source change event
Dafna Hirschfeld (6):
media: vicodec: bugfix - replace '=' with '|='
Add the field 'num_planes' to 'v4l2_fwht_pixfmt_info' struct.
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.c | 48 +--
.../media/platform/vicodec/codec-v4l2-fwht.h | 1 +
drivers/media/platform/vicodec/vicodec-core.c | 2
Add support for the selection api for the crop and compose targets.
The driver rounds up the coded width and height such that
all planes dimensions are multiple of 8.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 80 +++--
drivers/media/platform/vicodec
Keep the fwht header in separated field from the data.
Refactor job_ready to use a new function 'get_next_header'
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.c | 24 ++--
.../media/platform/vicodec/codec-v4l2-fwht.h | 1 +
drivers/media/platfo
Add flags indicating the pixel encoding - yuv/rgb/hsv to
fwht header and to the pixel info. Use it to enumerate
the supported pixel formats.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.h | 5 ++
.../media/platform/vicodec/codec-v4l2-fwht.c | 76
If the the queues are not streaming then the first resolution
change is handled in the buf_queue callback.
The following resolution change events are handled in job_ready.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 381 ++
1 file changed
Add the field 'num_planes' to 'v4l2_fwht_pixfmt_info' struct.
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.c | 48 +--
.../media/platform/vicodec/codec-v4l2-fwht.h | 1 +
drivers/media/platform/vicodec/vicodec-core.c | 2
Main changes from v2:
1. bugfix in patch "add support for CROP" (pix instead of pix_mp)
in vidioc_try_fmt
2. using bits 18-20 for the pixel encoding so that 0 means previous version
3. some refactoring
Dafna Hirschfeld (6):
media: vicodec: bugfix - replace '=' with '
In the fwht_encode_frame, 'encoding = encode_plane'
should be replaced with 'encoding |= encode_plane'
so existing flags won't be overwrriten.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 8
1 file changed, 4 insertions
Add support for the selection api for the crop and compose targets.
The driver rounds up the coded width and height such that
all planes dimensions are multiple of 8.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 80 +++--
drivers/media/platform/vicodec
Keep the fwht header in separated field from the data.
Refactor job_ready to use a new function 'get_next_header'
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.c | 24 ++--
.../media/platform/vicodec/codec-v4l2-fwht.h | 1 +
drivers/media/platfo
If the the queues are not streaming then the first resolution
change is handled in the buf_queue callback.
The following resolution change events are handled in job_ready.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 355 ++
1 file changed
Add flags indicating the pixel encoding - yuv/rgb/hsv to
fwht header and to the pixel info. Use it to enumerate
the supported pixel formats.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.h | 5 ++
.../media/platform/vicodec/codec-v4l2-fwht.c | 76
Changes from v3:
1. bugfix in stop_sreaming callback, ctx->max_comp_size should
initialize when the ref_fram is freed.
2. added patch - use 3 bits for the number of components in the
fwht header.
3. remove the first patch: "bugfix - replace '=' with '|='"
s
Add the field 'num_planes' to 'v4l2_fwht_pixfmt_info' struct.
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.c | 48 +--
.../media/platform/vicodec/codec-v4l2-fwht.h | 1 +
drivers/media/platform/vicodec/vicodec-core.c | 2
Add flags indicating the pixel encoding - yuv/rgb/hsv to
fwht header and to the pixel info. Use it to enumerate
the supported pixel formats.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.h | 6 ++
.../media/platform/vicodec/codec-v4l2-fwht.c | 76
Add support for the selection api for the crop and compose targets.
The driver rounds up the coded width and height such that
all planes dimensions are multiple of 8.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 80 +++--
drivers/media/platform/vicodec
Keep the fwht header in separated field from the data.
Refactor job_ready to use a new function 'get_next_header'
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.c | 24 ++--
.../media/platform/vicodec/codec-v4l2-fwht.h | 1 +
drivers/media/platfo
Use 3 bits for the number of components mask in the fwht
header flags
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vicodec/codec-fwht.h
b/drivers/media/platform/vicodec
If the the queues are not streaming then the first resolution
change is handled in the buf_queue callback.
The following resolution change events are handled in job_ready.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 355 ++
1 file changed
Support crop and compose selection.
If the driver supports crop/compose then the raw frame is arranged
inside a padded buffer.
Signed-off-by: Dafna Hirschfeld
---
utils/common/codec-fwht.patch | 8 +-
utils/common/v4l-stream.c | 14 +--
utils/common/v4l-stream.h
Add function get_codec_type that returns the type
of codec NOT_CODEC/ENCODER/DEOCDER.
Move the functions get_cap_compose/crop_rect
to the start of the file.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 126 ++
1 file changed, 88 insertions
1. The first patch "Add support for crop and compose selection in streaming"
was already reviewed.
2. The actual support is added in the patch
"Add support for source change event for m2m decoder"
3. The last patch is only a suggestion for adding a new option
in the command lin
Add function capture_setup that implements the
capture setup sequence.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 58 +++
1 file changed, 50 insertions(+), 8 deletions(-)
diff --git a/utils/v4l2-ctl/v4l2-ctl-streaming.cpp
b/utils/v4l2
This option sets the capture pixelformat in the
capture setup sequence.
If the format is not supported decoding will stop.
If the option is not given then the default is to set
the first supported format.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 29
test the excpetion fds first in the select loop
in streaming_set_m2m. This is needed in the next patch
in order to dequeue a source change event before its
coresponding last buffer.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 26 +-
1 file
Subscribe to source change event.
The capture setup sequence is executed only due to a
change event.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 90 ++-
1 file changed, 76 insertions(+), 14 deletions(-)
diff --git a/utils/v4l2-ctl/v4l2
Keep the fwht header in separated field from the data.
Refactor job_ready to use a new function 'get_next_header'
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.c | 24 ++--
.../media/platform/vicodec/codec-v4l2-fwht.h | 1 +
drivers/media/platfo
comp_frame_size was set only
when the full header is dound in job_ready
Dafna Hirschfeld (6):
media: vicodec: Add num_planes field to v4l2_fwht_pixfmt_info
media: vicodec: add support for CROP and COMPOSE selection
media: vicodec: use 3 bits for the number of components
media: vicodec: Add pixel
Add the field 'num_planes' to 'v4l2_fwht_pixfmt_info' struct.
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.c | 48 +--
.../media/platform/vicodec/codec-v4l2-fwht.h | 1 +
drivers/media/platform/vicodec/vicodec-core.c | 2
Add flags indicating the pixel encoding - yuv/rgb/hsv to
fwht header and to the pixel info. Use it to enumerate
the supported pixel formats.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.h | 6 ++
.../media/platform/vicodec/codec-v4l2-fwht.c | 76
Add support for the selection api for the crop and compose targets.
The driver rounds up the coded width and height such that
all planes dimensions are multiple of 8.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 80 +++--
drivers/media/platform/vicodec
Use 3 bits for the number of components mask in the fwht
header flags
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vicodec/codec-fwht.h
b/drivers/media/platform/vicodec
If the the queues are not streaming then the first resolution
change is handled in the buf_queue callback.
The following resolution change events are handled in job_ready.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 358 ++
1 file changed
Add flags indicating the pixel encoding - yuv/rgb/hsv to
fwht header and to the pixel info. Use it to enumerate
the supported pixel formats.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.h | 6 ++
.../media/platform/vicodec/codec-v4l2-fwht.c | 77
Add support for the selection api for the crop and compose targets.
The driver rounds up the coded width and height such that
all planes dimensions are multiple of 8.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 83 +++--
drivers/media/platform/vicodec
Keep the fwht header in separated field from the data.
Refactor job_ready to use a new function 'get_next_header'
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.c | 24 ++--
.../media/platform/vicodec/codec-v4l2-fwht.h | 1 +
drivers/media/platfo
Use 3 bits for the number of components mask in the fwht
header flags
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vicodec/codec-fwht.h
b/drivers/media/platform/vicodec
If the the queues are not streaming then the first resolution
change is handled in the buf_queue callback.
The following resolution change events are handled in job_ready.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 361 ++
1 file changed
Changes from v5
cleanups of 'line too long' warnings'
Dafna Hirschfeld (5):
media: vicodec: add support for CROP and COMPOSE selection
media: vicodec: use 3 bits for the number of components
media: vicodec: Add pixel encoding flags to fwht header
media: vicodec: Separate f
Subscribe to source change event.
The capture setup sequence is executed only due to a
change event.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 112 +++---
1 file changed, 85 insertions(+), 27 deletions(-)
diff --git a/utils/v4l2-ctl/v4l2
This option sets the capture pixelformat in the
capture setup sequence.
If the format is not supported decoding will stop.
If the option is not given then the default is to set
the first supported format.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 37
Add function capture_setup that implements the
capture setup sequence.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 46 ++-
1 file changed, 38 insertions(+), 8 deletions(-)
diff --git a/utils/v4l2-ctl/v4l2-ctl-streaming.cpp
b/utils/v4l2
Support crop and compose selection.
If the driver supports crop/compose then the raw frame is arranged
inside a padded buffer.
Signed-off-by: Dafna Hirschfeld
---
utils/common/codec-fwht.patch | 8 +-
utils/common/v4l-stream.c | 14 +--
utils/common/v4l-stream.h
t in "Introduce capture_setup" patch
Dafna Hirschfeld (5):
v4l2-ctl: Add support for crop and compose selection in streaming
v4l2-ctl: Add function get_codec_type
v4l2-ctl: Introduce capture_setup
v4l2-ctl: Add support for source change event for m2m decoder
v4l2-ctl: Add --stream
Add function get_codec_type that returns the type
of codec NOT_CODEC/ENCODER/DEOCDER.
Move the functions get_cap_compose/crop_rect
to the start of the file.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 123 ++
1 file changed, 85 insertions
Make sure that the pointer to the compressed frame does not
get out of the buffer.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 73 +--
drivers/media/platform/vicodec/codec-fwht.h | 8 +-
.../media/platform/vicodec/codec-v4l2-fwht.c
Make sure that the pointer to the compressed frame does not
get out of the buffer.
Signed-off-by: Dafna Hirschfeld
---
Changes from v1:
set OVERFLOW_BIT in derlc return val to indicate overflow.
fix return value type from s16 to u16
drivers/media/platform/vicodec/codec-fwht.c | 71
Add stateless decoder instance field to the dev struct and
register another node for the statelsess decoder.
The stateless API for the node will be implemented in further patches.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 56 +--
1 file
Add struct 'vicodec_dev_instance' for the fields in vicodec_dev
that have have both decoder and encoder versions.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 175 +-
1 file changed, 89 insertions(+), 86 deletions(-)
diff --git
Add structs and definitions needed to implement stateless
decoder for fwht.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 12
drivers/media/v4l2-core/v4l2-ctrls.c | 6 ++
include/uapi/linux/v4l2-controls.h| 10
Patches to prepare for the implementation of the statless
decoder api in vicodec
Dafna Hirschfeld (3):
media: vicodec: add struct for encoder/decoder instance
media: vicodec: Introducing stateless fwht defs and structs
media: vicodec: Register another node for stateless decoder
drivers
On Tue, Jan 22, 2019 at 8:27 AM Alexandre Courbot wrote:
>
> Documents the protocol that user-space should follow when
> communicating with stateless video decoders.
>
> The stateless video decoding API makes use of the new request and tags
> APIs. While it has been implemented with the Cedrus dri
add a function vidcap_get_and_update_fmt to set
the format from cmd params. Use it in capture_setup.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 13 +++
utils/v4l2-ctl/v4l2-ctl-vidcap.cpp| 140 ++
utils/v4l2-ctl/v4l2-ctl.h
add a function vidcap_get_and_update_fmt to set
the format from cmd params. Use it in capture_setup.
Signed-off-by: Dafna Hirschfeld
---
Changes from v1:
change the order of vidcap_get_and_update_fmt and vidcap_set
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 13 +++
utils/v4l2-ctl/v4l2-ctl
commit 84219e2b5d013709ee5259621715966c46eec746
Author: Hans Verkuil
Date: Sat Mar 30 14:16:25 2019 +0100
v4l2-ctl: get fmt after source change
When a source change event arrives during decoding get the new
format at that point instead of after restarting streaming.
If there i
I loaded the vivid module with contiguous DMA and ran streaming with
it with large image dimensions
here are the commans:
$ uname -a
Linux ubuntu 5.2.0-rc5+ #1 SMP Mon Jul 1 10:17:46 PDT 2019 x86_64
x86_64 x86_64 GNU/Linux
$ sudo modprobe -v vivid
allocators=1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1
On Mon, 2019-07-22 at 08:38 -0300, Mauro Carvalho Chehab wrote:
> Em Mon, 22 Jul 2019 13:21:00 +0200
> Dafna Hirschfeld escreveu:
>
> > I loaded the vivid module with contiguous DMA and ran streaming
> > with
> > it with large image dimensions
> > [ 306.4373
On Tue, 2019-07-23 at 14:05 +, Hans Verkuil (hansverk) wrote:
> On 7/23/19 3:14 PM, Dafna Hirschfeld wrote:
> > On Mon, 2019-07-22 at 08:38 -0300, Mauro Carvalho Chehab wrote:
> > > Em Mon, 22 Jul 2019 13:21:00 +0200
> > > Dafna Hirschfeld escreveu:
> > >
add a function vidcap_get_and_update_fmt to set
the format from cmd params. Use it in capture_setup.
Signed-off-by: Dafna Hirschfeld
---
Changes from v2:
move get_cap_compose_rect to after s_fmt in capture_setup
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 15 ++-
utils/v4l2-ctl/v4l2-ctl
In the decoder, save the inner reference frame in the same
format as the capture buffer.
The decoder writes directly to the capture buffer and then
the capture buffer is copied to the reference buffer.
This will simplify the stateless decoder.
Signed-off-by: Dafna Hirschfeld
---
drivers/media
Introduce 'prepare_raw_frame' function that fills the values
of a raw frame struct according to the format.
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.c | 140 ++
1 file changed, 75 insertions(+), 65 deletions(-)
diff --git a/dri
Add the field 'buf' to fwht_raw_frame to indicate
the start of the raw frame buffer.
This field will be used to copy the capture buffer
to the reference buffer in the next patch.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.h | 1 +
drivers/medi
o_ref'
Patches 4-6 - fixes according to the code review.
Patch 5 (Introducing stateless fwht defs and struct):
-
add width,height fields to v4l2_ctrl_fwht_params
Patches 7-9 are new
Dafna Hirschfeld (9):
media: vicodec: Move raw frame p
Add the function 'vb2_find_timestamp_buf' that returns
the vb2 buffer that matches the given timestamp
Signed-off-by: Dafna Hirschfeld
---
drivers/media/common/videobuf2/videobuf2-v4l2.c | 14 ++
include/media/videobuf2-v4l2.h | 3 +++
2 files c
Add the field 'buf' to fwht_raw_frame to indicate
the start of the raw frame buffer.
This field will be used to copy the capture buffer
to the reference buffer in the next patch.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.h | 1 +
drivers/medi
In the decoder, save the inner reference frame in the same
format as the capture buffer.
The decoder writes directly to the capture buffer and then
the capture buffer is copied to the reference buffer.
This will simplify the stateless decoder.
Signed-off-by: Dafna Hirschfeld
---
drivers/media
1 - 100 of 309 matches
Mail list logo
