On Tue, 19 Dec 2017 22:37:01 +0200
Andy Shevchenko wrote:
> On Tue, 2017-12-19 at 14:00 +0200, Sakari Ailus wrote:
> > Cc Alan and Andy.
> >
> > On Sat, Dec 16, 2017 at 04:50:04PM +0100, Kristian Beilke wrote:
> > > Dear all,
> > >
> > > I am trying to get the cameras in a Lenovo IdeaPad Miix
> AFAIR Alan has CHT hardware he is developing / testing on.
I have a loaned board from the company Vincent (who did the intial
patches) works for. At the moment it's loading firmware, finding cameras
doing power management but not transferring images.
Unfortunately because of the design of the d
> Patch 0003-atomisp_gmin_platform-tweak-to-drive-axp288.patch gives a
> little confusion.
> The PMIC driver should work via ACPI OpRegion macro (and should be
> enabled in kernel configuration). That's how it supposed to work.
> The patch seems redundant.
I am fairly sure it is meant to work that
On Mon, 8 Jan 2018 11:08:36 +0100
Peter Zijlstra wrote:
> On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote:
> > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman
> > wrote:
> > > In at least one place (mpls) you are patching a fast path. Compile out
> > > or don't load mpls by al
On Mon, 8 Jan 2018 16:21:21 +0200
Sakari Ailus wrote:
> Hi Mauro,
>
> On Thu, Jan 04, 2018 at 02:44:41PM -0500, Mauro Carvalho Chehab wrote:
> > There are lots of bad whitespaces at atomisp driver.
> >
> > Fix them.
> >
> > Signed-off-by: Mauro Carvalho Chehab
> > ---
> >
> > Sakari/Alan,
>
> Maybe we need start over, i.e. find a (presumable old) kernel with
> driver _and_ corresponding firmware _and_ hardware it supports to
> start
> with...
You can do that with Intel aero and then in theory port the relevant
headers into the updated driver. I've actually been closely comparing
the
On Fri, 2018-05-11 at 17:09 +0200, Julia Lawall wrote:
>
> On Fri, 11 May 2018, Christophe JAILLET wrote:
>
> > The use of 'fail1' and 'fail2' is not correct. Reorder these calls
> > to
> > branch at the right place of the error handling path.
>
> Maybe it would be good to improve the names at t
I think this is going to be the best option. When I started cleaning up
the atomisp code I had time to work on it. Then spectre/meltdown
happened (which btw is why the updating suddenly and mysteriously stopped
last summer).
I no longer have time to work on it and it's becoming evident that the
w
> > + struct ipu3_mmu *mmu = to_ipu3_mmu(dev);
> > + dma_addr_t daddr = iommu_iova_to_phys(mmu->domain, dma_handle);
> > +
> > + clflush_cache_range(phys_to_virt(daddr), size);
>
> You might need to consider another IOMMU on the way here. Generally,
> given that daddr is your M
> +
> +10-bit Bayer formats
> +
> +Description
> +===
> +
> +These four pixel formats are used by Intel IPU3 driver,
Are the same formats present in IPUv2, will they ever be present in other
hardware.
If so (and I think it is so...) then it's not a good idea to encode ipu3
in the name. So
On Tue, 13 Jun 2017 15:17:14 -0500
Yong Zhi wrote:
> Add IPU3 specific formats:
>
> V4L2_PIX_FMT_IPU3_SBGGR10
> V4L2_PIX_FMT_IPU3_SGBRG10
> V4L2_PIX_FMT_IPU3_SGRBG10
> V4L2_PIX_FMT_IPU3_SRGGB10
As I said before these are just more bitpacked bayer formats with no
reason t
}
>
> -static struct acpi_device_id gc0310_acpi_match[] = {
> +static const struct acpi_device_id gc0310_acpi_match[] = {
> {"XXGC0310"},
> {},
> };
(All four)
Acked-by: Alan Cox
On Fri, 2017-07-07 at 17:20 +0530, Hari Prasath wrote:
> kmemdup can be used to replace kmalloc followed by a memcpy.This was
> pointed out by the coccinelle tool.
And kstrdup could do the job even better I think ?
Alan
ner field if calls are used which set it automatically
> >
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > CC: Alan Cox
> > Signed-off-by: Fengguang Wu
>
>
> May I ask which repository this patch is based on?
It's a major
The two drivers were originally merged by tools, and the tools didn't always
spot white space only changes. Fix a few of them found by zero-day and clean
up some more by hand.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c | 29 ---
.../media/atomis
Certain combinations of compiler and compiler options product an imx.o that
calls compiler helpers for a u64 divide. Use the do_div() call instead.
Signed-off-by: Alan Cox
---
drivers/staging/media/atomisp/i2c/imx/imx.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
From: xingzhen
commit:2a1f062a4acf move sigpending method fatal_signal_pending from
into cause the build issue,fix it.
Signed-off-by: xingzhen
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/hmm/hmm_bo.c|2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
> Before moving firmware-dependent drivers out of staging, please send
the
> firmware files to linux-firmware ML.
The firmware files come with the system. They may have system dependant
components and it's also not clear that they can be put in linux-
firmware for licensing reasons. They are howev
This is another define which is never used and references a header that doesn't
exist, so consider it dead. Our memcpy is pretty smart anyway.
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/hmm/hmm.c | 32 +---
1 file changed, 1 insertion(+), 31 dele
KLOCWORK is never defined so we can remove the workarounds for this in the
code.
Signed-off-by: Alan Cox
---
.../css2400/hive_isp_css_include/assert_support.h | 11 ---
.../atomisp2/css2400/runtime/rmgr/src/rmgr_vbuf.c | 32 +---
2 files changed, 1 insertion(+), 42
We are not going to be building for anything but Linux so the code bracketed
by C_RUN is not used and not needed.
Signed-off-by: Alan Cox
---
.../css_2400_system/hrt/isp2400_mamoiada_params.h |4 --
.../pci/atomisp2/css2400/css_2400_system/hrt/var.h | 25 --
.../css2400
We are only going to be building for Linux with gcc, so we can lose bits of
material related to other build targets.
Signed-off-by: Alan Cox
---
.../css2400/hive_isp_css_common/dma_global.h | 52
.../css2400/hive_isp_css_include/assert_support.h |9
This is not used on either Baytrail or Cherrytrail so can simply be deleted
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/Makefile|2
.../css2400/isp/kernels/pdaf/ia_css_pdaf.host.c| 84
.../css2400/isp/kernels/pdaf/ia_css_pdaf.host.h
The FWNAME define is never used so can be removed. The option to skip firmware
loading isn't really Cherrytrail specific so remove this and complete the
merging of the two driver versions for this file.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_v4l2.c |
We can do this because the only thing it is used for is identifying the
platform for power management purposes. The driver only supports Baytrail
and Cherrytrail and both of those always need the IPU to be power managed
directly not via PCI D3 states.
Signed-off-by: Alan Cox
---
.../media
These are not relevant to an upstream kernel driver.
Signed-off-by: Alan Cox
---
.../host/hive_isp_css_hrt_modified.h | 16
1 file changed, 16 deletions(-)
diff --git
a/drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host
On Mon, 2017-03-13 at 15:34 +0300, Dan Carpenter wrote:
> md_type is an enum. On my tests, GCC treats it as unsigned but
> according to the C standard it's an implementation dependant thing so
> we
> should check for negatives.
Can do but the kernel assumes GNU C everywhere else
On Mon, 2017-03-13 at 19:54 +0900, Daeseok Youn wrote:
> If the atomisp_kernel_zalloc() has "true" as a second parameter, it
> tries to allocate zeroing memory from kmalloc(vmalloc) and memset.
> But using kzalloc is rather than kmalloc followed by memset with 0.
> (vzalloc is for same reason with
> 674
> 675 /* To avoid owerflows when calling the efivar API */
> 676 if (*out_len > ULONG_MAX)
>
> This is impossible. Was UINT_MAX intended?
I am really not sure. The only case I can imagine is 32bit EFI on a
64bit system, b
While this is included and the headers pulled in nothing actually uses this
functionality in the driver, so remove it.
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/Makefile|3
.../ia_css_isp_params.c|1
.../ia_css_isp_states.h
We don't need this layer of indirection and the debugging information is not
used. With
this removed we can then go on to try and remove the abstraction layer entirely.
Signed-off-by: Alan Cox
---
.../memory_access/memory_access.h | 80 +++-
.../pci/ato
The aa kernel is used but it consists of nothing more than a set of wrappers
for a memset and an assignment. Replace these at the calling points with the
memset and assignment.
Keep the structures for now - those should disappear as the next layer up
gets unwrapped.
Signed-off-by: Alan Cox
of code so
remove this
second layer of wrappers and call the hrt methods directly. In time we can
remove this layer
of indirection as well.
Signed-off-by: Alan Cox
---
.../atomisp/pci/atomisp2/atomisp_compat_css20.c| 66
.../ia_css_isp_states.h
ning. This seems
safe as PCI config space accessors should always return something
when PCI is enabled.
Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Arnd Bergmann
Signed-off-by: Alan Cox
---
drivers/staging/media/atomisp/Kconfig |2 +-
9d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Arnd Bergmann
Signed-off-by: Alan Cox
---
drivers/staging/media/atomisp/i2c/ov2680.c | 37 ++--
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/media/a
From: Dan Carpenter
There are some error paths in atomisp_css_frame_allocate() which don't
initialize "res" so it could lead us to try release random memory.
Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Dan Carpenter
From: Dan Carpenter
We call this function with the lock held and should also return with the
lock held as well. This one error path is not-consistent because we
should return without the lock held.
Signed-off-by: Dan Carpenter
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/hmm
misp: Add support for the Intel IPU v2")
Signed-off-by: Arnd Bergmann
Signed-off-by: Alan Cox
---
drivers/staging/media/atomisp/pci/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/Kconfig
b/drivers/staging/media/atomisp/pci/
pe 'struct acpi_device'
We could work around that in the code, but since we already have a hard
dependency on x86, adding the ACPI dependency seems to be the easiest
solution.
Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Arnd Ber
x27;me' set but not used [-Werror=unused-but-set-parameter]
It turns out that not only the parameter is unused but the entire function has
no
caller. Let's just remove it.
Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Arn
The first of these checks the PCI identifier in order to decide what to do so
needs no
ifdef. The other is simply a variation on what is dumped for debug - so favour
dumping the
most.
Signed-off-by Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c |7 ---
.../atomisp/pci
2_plat_clk_remove':
platform/clock/vlv2_plat_clock.c:209:2: error: implicit declaration of function
'iounmap' [-Werror=implicit-function-declaration]
This includes the required header file.
Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Si
built-in.o: In function `gmin_get_config_var':
(.text+0xe062b): undefined reference to `efivar_entry_get'
Signed-off-by: Jérémy Lefaure
Signed-off-by: Alan Cox
---
drivers/staging/media/atomisp/Kconfig|2 +-
drivers/staging/media/atomisp/i2c/ov5693/Kconfig |2 +-
2 f
:6:
error: old-style function definition [-Werror=old-style-definition]
This adds a 'void' keywork to silence the warning.
Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Arnd Bergmann
Signed-off-by: Alan Cox
---
.../atomisp/pci/at
From: Daeseok Youn
It doesn't need to have else statement after return.
Signed-off-by: Daeseok Youn
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomis
Instead of logging this just report ERANGE as an error, which will give
something close to the
right user space report.
The others of these were already removed by Dan Carpenter's patch.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_drvfs.c |4 +---
1 file ch
This is a do nothing function so we can replace it with nothing and eliminate
it entirely.
Signed-off-by: Alan Cox
---
.../ia_css_isp_params.c|6 --
.../ia_css_isp_params.c|6 --
.../ia_css_isp_params.c
From: Daeseok Youn
The V4L2_FIELD_ANY is zero, so the (!field) is same meaning
with (field == V4L2_FIELD_ANY) in if-statement.
Signed-off-by: Daeseok Youn
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c | 22 +---
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
index 0a2df3d
It's commented out in the tree with a note saying to remove it. So let's remove
it.
Signed-off-by: Alan Cox
---
drivers/staging/media/atomisp/i2c/ov5693/ov5693.c | 23 -
1 file changed, 23 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/ov5693/o
We don't need an ifdef for the sake of 8-12 bytes. This undoes the ifdef added
by
fde469701c7efabebf885e785edf367bfb1a8f3f. Instead turn it into a single const
string
array at a fixed location thereby saving even more memory.
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/ato
From: Jérémy Lefaure
REGMAP_I2C should be enabled to build the driver ap1302 because it uses
regmap functions.
Signed-off-by: Jérémy Lefaure
Signed-off-by: Alan Cox
---
drivers/staging/media/atomisp/i2c/Kconfig |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media
This was reported by Dan Carpenter. When we error with an IMX 227 we don't
release
the lock and the sensor would then hang.
Signed-off-by: Alan Cox
---
drivers/staging/media/atomisp/i2c/imx/imx.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/
On Thu, 2017-03-23 at 21:12 +0800, Geliang Tang wrote:
> Fix the following build error:
>
> CC drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.o
> drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c:52:2:
> error: excess elements in array initializer [-Werror]
> "i", /* ion */
> ^~
> > 2 --
> > 1 file changed, 2 deletions(-)
>
> Ugh, Alan, what's going on here, I thought you fixed this?
I sent you a patch that removed the arrays entirely and turned it into
a single string as well as removing the define. Not quite sure what
happened but I've resynched to -next and I'll send
HAS_SEC_ISP is never defined so we can scrub all the code that is within the
defines for it.
Signed-off-by: Alan Cox
---
.../atomisp2/css2400/runtime/spctrl/src/spctrl.c |5 -
.../media/atomisp/pci/atomisp2/css2400/sh_css.c| 110
.../atomisp/pci/atomisp2/css2400
From: Derek Robson
Changed permissions to octal style
Found using checkpatch
Signed-off-by: Derek Robson
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_drvfs.c |9 +++--
.../staging/media/atomisp/pci/atomisp2/hmm/hmm.c |8
2 files changed, 7
HAS_TNR3 is never defined so we can remove it.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css_sp.c |4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c
b/drivers/staging/media/atomisp/pci/atomisp2
From: Pushkar Jambhlekar
Removing hardcoded function name as code is already using __func__
Signed-off-by: Pushkar Jambhlekar
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/hmm/hmm_bo.c|2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
We don't need an ifdef for the sake of 8-12 bytes. Avoid the ifdef added by
fde469701c7efabebf885e785edf367bfb1a8f3f. Instead turn it into a single const
string array at a fixed location thereby saving even more memory.
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp
On Wed, 2017-03-29 at 09:57 -0700, Daniel Cashman wrote:
> From: Dan Cashman
>
> Signed-off-by: Dan Cashman
As the TODO asks - please no whitespace cleanups yet. They make it
harder to keep other cleanups that fix (or mostly remove) code
applying.
Nothing wrong with the patch otherwise - but
On Thu, 2017-03-30 at 15:24 +0900, Daeseok Youn wrote:
> The condition line in if-statement is needed to be shorthen to
> improve readability.
>
> Signed-off-by: Daeseok Youn
> ---
How about a define for ATOMISP_IS_CHT(isp) instead - as we will need
these tests in other places where there are IS
On Fri, 2017-04-07 at 14:56 +0900, Daeseok Youn wrote:
> Enable/Disable ISP irq is switched with "enable" parameter of
> enable_isp_irq(). It would be better splited to two such as
> enable_isp_irq()/disable_isp_irq().
>
> But the enable_isp_irq() is no use in atomisp_cmd.c file.
> So remove the e
On Mon, 11 Sep 2017 20:49:27 +0200
Vincent Hervieux wrote:
> Currently atomisp module supports Intel's Baytrail SoC and contains
> some compilation switches to support Intel's Cherrytrail SoC instead.
> The patchset aims to :
> - 1/2: activate ATOMISP2400 or ATOMISP2401 from the menu.
> - 2/2: fi
> Would it make sense to first get the other drivers to upstream and
> then see what's the status of atomisp?
Agreed
> the board specific information from firmware is conveyed to the
> sensor drivers will change to what the rest of the sensor drivers are
> using. I think a most straightforward w
On Mon, 2017-08-07 at 21:44 +0800, Geliang Tang wrote:
> Use kvmalloc()/kvzalloc() instead of atomisp_kernel_malloc()
> /atomisp_kernel_zalloc().
>
> Signed-off-by: Geliang Tang
Definitely better now we have kvmalloc/kvzalloc.
Thanks
Alan
From: Colin Ian King
trivial fix to spelling mistake in dev_err error message
Signed-off-by: Colin Ian King
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/hmm/hmm_bo_dev.c|2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci
From: Daeseok Youn
Define new local variable to reduce the number of reference.
The new local variable is added to save the addess of dfs
and used in atomisp_freq_scaling() function.
Signed-off-by: Daeseok Youn
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c
on and add
disable_isp_irq function only.
Signed-off-by: Daeseok Youn
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c | 36 +---
1 file changed, 9 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
b/drive
From: Daeseok Youn
The address of isp->asd[i] is already assigned to
local "asd" variable. "&isp->asd[i]" would be replaced with
just "asd".
Signed-off-by: Daeseok Youn
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c |
From: Daeseok Youn
The line which is initializing mipi_info variable is too long
to read. It would be placed in next line.
Signed-off-by: Daeseok Youn
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c |8 +---
1 file changed, 5 insertions(+), 3 deletions
We are not using these for debugging or debug logging so remove the defines,
trim and rename the functions.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css.c| 15 +++
.../atomisp/pci/atomisp2/css2400/sh_css_internal.h | 17 -
2 files
thing
Signed-off-by: Alan Cox
---
.../pci/atomisp2/css2400/ia_css_memory_access.c| 31 ++--
.../atomisp/pci/atomisp2/hrt/hive_isp_css_mm_hrt.c | 11 ---
.../atomisp/pci/atomisp2/hrt/hive_isp_css_mm_hrt.h |3 --
.../media/atomisp/pci/atomisp2/hrt/memory_access.c |
We have one hard coded set of behaviour so unpick the indirection and function
pointers. This isn't the whole story. A lot of the callers are known sizes and
use cases so we can switch them directly to kmalloc later on.
Signed-off-by: Alan Cox
---
.../atomisp/pci/atomisp2/atomisp_compat_cs
Where we know the buffer size is reasonably constrained we can just use kmalloc,
and where it will be large vmalloc. This still leaves a pile in the middle.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css.c| 92 ++--
.../atomisp/pci/atomisp2
They can be replaced by kmalloc. There are a few that do need to pick kmalloc
or vmalloc. Those we leave for the moment.
Signed-off-by: Alan Cox
---
.../atomisp/pci/atomisp2/atomisp_compat_css20.c|4 --
.../media/atomisp/pci/atomisp2/hmm/hmm_bo.c| 34
This isn't used so it can go in the bitbucket.
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/Makefile|1 -
.../css2400/isp/kernels/satm/ia_css_satm.host.c| 27 ---
.../css2400/isp/kernels/satm/ia_css_satm.host.h|
This is a whole pile of code that wraps a single assignment. Remove it and
put the assignment in the caller. Once we have the kernels sorted we should
revisit these and remove all the pointless 1 item structs that go with it.
Signed-off-by: Alan Cox
---
.../ia_css_isp_params.c
These are not used in the driver so can go away.
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/Makefile|4 -
.../kernels/xnr/xnr3_0_11/ia_css_xnr3_0_11.host.c | 155
.../kernels/xnr/xnr3_0_11/ia_css_xnr3_0_11.host.h | 58
UDS is another layer which actually boils down to some trivial assignments so
remove it so inline the code.
Signed-off-by: Alan Cox
---
.../ia_css_isp_params.c| 12 ---
.../ia_css_isp_params.c| 12 ---
.../ia_css_isp_params.c
> I'm pretty sure we want this code to be built as a module, so maybe a
> Kconfig change would resolve the issue instead?
>
> Alan, any thoughts?
It's a tiny chunk of platform helper code. It probably ultimately
belongs in arch/x86 somewhere or folded into the driver. At the moment
it won't build
Currently the code handles this in the abstraction above. We want to remove
that abstraction so begin by pushing down the sanity check. Unfortunately
at this point we can't simply fix the init order.
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/hmm/hmm.c |5 +++
This is just another wrapper layer around hmm_free that servers no purpose
in this driver.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_acc.c |6 +++---
.../atomisp2/css2400/base/refcount/src/refcount.c |8
.../memory_access/memory_access.h
We don't need any of these indirections as we only support one MMU type. Start
by getting rid of the init/clear/free ones. The init ordering check we already
pushed down in a previous patch.
The allocation side is more complicated so leave it for now.
Signed-off-by: Alan Cox
---
.../
We have a layer of un-needed wrapping here that can go. In addition there are
some functions that don't exist and one that isn't used which can also go.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c |4 +--
.../media/atomisp/pci/atomisp2/atom
clude-dirs]
Fixes: 184f8e0981ef ("atomisp: remove satm kernel")
Signed-off-by: Arnd Bergmann
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/Makefile|1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/Makefile
b/d
The extra list contains some which are used and some which are not. At this
point I think we can safely remove those that are simply not used.
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/Makefile| 11 -
.../media/atomisp/pci/atomisp2/hmm/hmm_bo_dev.c| 333
by: Fabian Frederick
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/hmm/hmm.c | 19 ++-
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
b/drivers/staging/media/atomisp/pci/atomisp2/hmm
d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Arnd Bergmann
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_v4l2.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/media/atomisp/pc
On Wed, 2017-05-17 at 21:48 -0400, Manny Vindiola wrote:
> This is a patch to the atomisp_tpg.c file that fixes up a missing
> blank line warning found by the checkpatch.pl tool
>
> Signed-off-by: Manny Vindiola
> ---
> drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 1 +
> 1 file cha
On Thu, 2017-05-18 at 11:10 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 18 May 2017 15:50:09 +0200
> Greg Kroah-Hartman escreveu:
>
> >
> > Hi Mauro,
> >
> > Here's the set of accumulated atomisp staging patches that I had in
> > my
> > to-review mailbox. After this, my queue is empty, the d
Kill off the HAS_BL define and the code and includes it brackets. We never
define HAS_BL or use that functionality.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css.c| 101
.../atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 19
With the removal of the HAS_BL bootloader code the value of NUM_OF_BLS is an
invariant zero. So let's get rid of it.
Signed-off-by: Alan Cox
---
.../atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
a/drivers/st
HRT_UNSCHED is never defined or set in the driver, so this is dead code that
can be retired, simplifying the code a bit further.
Signed-off-by: Alan Cox
---
.../css2400/runtime/debug/src/ia_css_debug.c |7 ---
.../atomisp2/css2400/runtime/spctrl/src/spctrl.c |8
The two drivers were machine merged and in this case the machine output was to
say the least not optimal.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css.c| 26
1 file changed, 5 insertions(+), 21 deletions(-)
diff --git a/drivers/staging
The code attempts to check for out of range calibration. What it forgets to do
is check for the 0 bitrate case. As a result the range check itself oopses the
kernel.
Found by Andrey Konovalov using Syzkaller.
Signed-off-by: Alan Cox
---
drivers/net/hamradio/hdlcdrv.c |2 +-
1 file changed
Kill off the HAS_BL define and the code and includes it brackets. We never
define HAS_BL or use that functionality.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css.c| 101
.../atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 19
With the removal of the HAS_BL bootloader code the value of NUM_OF_BLS is an
invariant zero. So let's get rid of it.
Signed-off-by: Alan Cox
---
.../atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
a/drivers/st
HRT_UNSCHED is never defined or set in the driver, so this is dead code that
can be retired, simplifying the code a bit further.
Signed-off-by: Alan Cox
---
.../css2400/runtime/debug/src/ia_css_debug.c |7 ---
.../atomisp2/css2400/runtime/spctrl/src/spctrl.c |8
t so we will end up returning -EINVAL a few lines later
because the .camera pointer is NULL.
Signed-off-by: Dan Carpenter
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_ioctl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media
1 - 100 of 181 matches
Mail list logo
