...
[60153.264064] mceusb 1-1.1.2:1.0: nonsensical irdata 00 with duration 0
...
due to reception of ambient IR noise.
Change these warning messages to debug messages.
Signed-off-by: A Sun
---
drivers/media/rc/mceusb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
rror message.
Clean extraneous "\n" in dev_dbg messages.
Signed-off-by: A Sun
---
drivers/media/rc/mceusb.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c
index 0cd8f6f57..efffb1795 10064
also be necessary to prevent halt/clear-halt loops.
Unresolved for now, deadlock complications occur if mceusb's worker
thread, mceusb_deferred_kevent(), calls usb_reset_device(),
which calls mceusb_dev_disconnect(), which calls cancel_work_sync(),
which waits on the still active worker thre
Several error message and error reporting revisions for mceusb.c
proposed patches applicable to mceusb.c version
https://github.com/torvalds/linux/blob/master/drivers/media/rc/mceusb.c
Mar 1, 2019 commit 04ad30112aec61004f994d8f51461ec06e208e54
Test platform:
Raspberry Pi 3B+
Linux raspberrypi
Reset ..." message. I say "possible" because I'm running
into
multiple issues invoking usb_reset_device() from within mceusb.
I'll also mention the difficulty obtaining even a single fault replication
(~ 1/month) and test cycle.
Additional comments below... ..A Sun
On 6/6/
ually) will be my
patch
resolution for the mceusb stuck halt bug for some time.
In the meantime, I'll try and test (harder part) use of usb_queue_reset_device
for a future patch to automate the USB reset procedure.
Thanks again, ..A Sun
rror message.
Clean extraneous "\n" in dev_dbg messages.
Signed-off-by: A Sun
---
drivers/media/rc/mceusb.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c
index 0cd8f6f57..efffb1795 10064
...
[60153.264064] mceusb 1-1.1.2:1.0: nonsensical irdata 00 with duration 0
...
due to reception of ambient IR noise.
Change these warning messages to debug messages.
Signed-off-by: A Sun
---
drivers/media/rc/mceusb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
n(), were all
unsuccessful.
Signed-off-by: A Sun
---
drivers/media/rc/mceusb.c | 27 +--
1 file changed, 21 insertions(+), 6 deletions(-)
diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c
index efffb1795..fffd826c6 100644
--- a/drivers/media/rc/mceus
patch v2 revisions:
. limit patch to message changes only in part 3/3
Several error message revisions for mceusb.c
proposed patches applicable to mceusb.c version
https://github.com/torvalds/linux/blob/master/drivers/media/rc/mceusb.c
Mar 1, 2019 commit 04ad30112aec61004f994d8f51461ec06e208e5
Hi,
On 6/25/2019 6:51 AM, Sean Young wrote:
> On Wed, Jun 19, 2019 at 03:54:21AM -0400, A Sun wrote:
>>
>> -dev_err(ir->dev, "Error: request urb status = %d (TX HALT)",
>> +dev_err(ir->dev, "Error: tx urb status = %d (TX HA
Hi again,
On 6/25/2019 12:12 PM, Sean Young wrote:
> Hello,
>
> On Tue, Jun 25, 2019 at 11:01:32AM -0400, A Sun wrote:
>> On 6/25/2019 6:51 AM, Sean Young wrote:
>>> On Wed, Jun 19, 2019 at 03:54:21AM -0400, A Sun wrote:
>>>>
>>
>>>> -
or case by itself.
This is the same sequence of messages when manually invoking
the ./usbreset command line utility with an unpatched mceusb driver.
Signed-off-by: A Sun
---
drivers/media/rc/mceusb.c | 67 ++-
1 file changed, 55 insertions(+), 12 deletion
This patch is superseded by
[PATCH v1] [media] mceusb: USB reset device following USB clear halt error
Hi again,
On 7/15/2019 8:28 AM, Sean Young wrote:
> Hi,
>
> On Tue, Jun 25, 2019 at 05:29:02PM -0400, A Sun wrote:
>> In a quick look though other USB drivers, here are some other possibilities:
>>
>> Endpoint-in / Endpoint-out (not concise)
>> ep-in / ep-
.3:1.0: tx done status = 11 (wait = 98, expire = 100
(1000ms), urb->actual_length = 11, urb->status = 0)
Hex dumps limited to 64 bytes.
0x81 is MCE minimum time pulse, 0x01 is MCE minimum time space.
TX IR part 3 sz=11 shows 20msec I/O blocking delay
(100expire - 98wait = 2jiffies)
Sign
.
Signed-off-by: A Sun
---
drivers/media/rc/mceusb.c | 141 --
1 file changed, 98 insertions(+), 43 deletions(-)
diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c
index f9ed855e2..9c1cf53b0 100644
--- a/drivers/media/rc/mceusb.c
+++ b/
600
pulse 550
space 600
pulse 600
space 600
pulse 650
carrier 38803
space 16777215
^C
pi@raspberrypi:~ $ exit
Signed-off-by: A Sun
---
drivers/media/rc/mceusb.c | 90 ++-
1 file changed, 82 insertions(+), 8 deletions(-)
diff --git a/drivers/media/rc
Hi Sean,
Thanks again for your review and notes. I'm forwarding PATCH v2 after this
note. Please also see my notes below. ..A Sun
On 3/13/2018 6:38 AM, Sean Young wrote:
> Hi,
>
> On Sun, Mar 11, 2018 at 05:40:28AM -0400, A Sun wrote:
>>
>>
>> Add mceusb dr
errypi:~ $ ir-ctl -m -r
...
pulse 650
space 550
pulse 650
space 600
pulse 600
space 600
pulse 1200
space 600
pulse 650
space 550
pulse 650
space 600
pulse 600
space 600
pulse 550
carrier 40004
space 16777215
^C
pi@raspberrypi:~ $ exit
Signed-off-by: A Sun
---
drivers/med
tl -V
IR raw version 1.12.3
pi@raspberrypi:~ $ ir-ctl -m -r
...
pulse 650
space 550
pulse 650
space 600
pulse 600
space 600
pulse 1200
space 600
pulse 650
space 550
pulse 650
space 600
pulse 600
space 600
pulse 550
carrier 40004
space 16777215
^C
pi@raspberrypi:~ $ exit
Signed-off-by: A Sun
---
drive
Hi Sean,
Thanks again for your review and notes. I'm forwarding PATCH v3 after this
note. Please also see my notes below. ..A Sun
On 3/15/2018 8:46 AM, Sean Young wrote:
> On Wed, Mar 14, 2018 at 03:32:02PM -0400, A Sun wrote:
>> patch v2 revisions:
>> . Carrier frequency
commit
https://github.com/asunxx/linux/commit/e557c1d737462961f2aadfbfb0836ffa3c778518
Author: A Sun
Date: Sat Mar 25 02:42:03 2017 -0400
[PATCH] mceusb RX -EPIPE fault and more
Patch for mceusb driver tested with
[8.627769] mceusb 1-1.2:1.0: Registered Pinnacle Systems PCTV Remote USB
edia] mceusb: RX -EPIPE (urb status = -32) lockup failure fix
[PATCH 2/3] [media] mceusb: sporadic RX truncation corruption fix
[PATCH 3/3] [media] mceusb: fix inaccurate debug buffer dumps and
misleading debug messages
Thanks again. ..A Sun
commit
https://github.com/asunxx/linux/commit/17fe3b51f4ad5202a876ea4c92b5d99d4e166823
Author: A Sun
Date: Sun, 26 Mar 2017 13:24:18 -0400
Bug:
RX -EPIPE failure with infinite loop and flooding of
Mar 20 22:24:56 raspberrypi kernel: [ 2851.966506] mceusb 1-1.2:1.0: Error: urb
status = -32
commit
https://github.com/asunxx/linux/commit/d71c609e99cabc0a92a4d0b225486cbc09bbd8bd
Author: A Sun
Date: Sun, 26 Mar 2017 14:11:49 -0400
Bug:
Intermittent RX truncation and loss of IR received data.
This resulted in receive stream synchronization errors where driver attempted
to
commit
https://github.com/asunxx/linux/commit/14cae79824739ae03caa3b1c4f66cbdf73654bde
Author: A Sun
Date: Sun, 26 Mar 2017 14:55:31 -0400
Bug:
Some dev_dbg messages are misleading.
Some dev_dbg messages have inconsistent formatting.
mceusb_dev_printdata() prints incorrect range of bytes (0
On 3/26/2017 4:31 PM, Sean Young wrote:
> On Sun, Mar 26, 2017 at 02:28:08PM -0400, A Sun wrote:
>> commit
>> https://github.com/asunxx/linux/commit/17fe3b51f4ad5202a876ea4c92b5d99d4e166823
>> Author: A Sun
>> Date: Sun, 26 Mar 2017 13:24:18 -0400
>
Mar 22 12:16:36 raspberrypi kernel: [ 4864.648331] mceusb 1-1.2:1.0: rx data:
90 0b 8d 0b 8d 7f 7f 7f 72 b0 0c 98 0c 8c 0c 98 0c (length=17)
...
Thanks, ..A Sun
t a new patch proposal separate, and likely dependent, on this one.
My main obstacle at the moment, is I'm looking for a way to get mceusb device
to respond with a USB TX error halt/stall (rather than the typical ACK and NAK)
on a TX endpoint, in order to test halt/stall error detection and recovery for
TX. ..A Sun
On 3/30/2017 3:12 AM, Sean Young wrote:
> On Wed, Mar 29, 2017 at 06:04:58PM -0400, A Sun wrote:
>> On 3/29/2017 5:06 PM, Sean Young wrote:
>>
>>>
>>> Anyway, you're right and this patch looks ok. It would be nice to have the
>>> tx c
necessary to restore this device to working state.
Certain mceusb devices may require device specific recovery procedure for TX
halt conditions, which this patch does not address.
Signed-off-by: A Sun
---
drivers/media/rc/mceusb.c | 89 +--
1 fi
vocations cease, and there are no other error
indications from usb_submit_urb() or anywhere else.
An escalating USB reset was necessary to restore this device to working state.
Certain mceusb devices may require device specific recovery procedure for TX
halt conditions, which this patch does not address.
eview comments.
On 4/27/2017 4:54 PM, Sean Young wrote:
> On Thu, Apr 13, 2017 at 04:06:47AM -0400, A Sun wrote:
>> @@ -1220,16 +1221,28 @@ static void mceusb_deferred_kevent(struct
>> work_struct *work)
>> if (status < 0) {
>> dev_e
Cosmetic updates to recent code revisions for better compliance with
https://www.kernel.org/doc/html/latest/process/coding-style.html
This patch depends on an earlier (marked accepted) patch:
[PATCH v2] [media] mceusb: TX -EPIPE (urb status = -32) lockup fix
Signed-off-by: A Sun
---
drivers
35 matches
Mail list logo
