Re: [PATCH 0/4] Enable Hantro G1 post-processor

2019-09-09 Thread Tomasz Figa
Hi Ezequiel, On Wed, Sep 4, 2019 at 3:17 AM Ezequiel Garcia wrote: > > Hi all, > > This series enables the post-processor support available > on the Hantro G1 VPU. The post-processor block can be > pipelined with the decoder hardware, allowing to perform > operations such as color conversion, sca

Re: [PATCH 1/2] media: uapi: h264: Add num_ref_idx_active_override_flag

2019-09-09 Thread Tomasz Figa
On Thu, Sep 5, 2019 at 11:17 PM Nicolas Dufresne wrote: > > Le jeudi 05 septembre 2019 à 12:39 +0200, Philipp Zabel a écrit : > > On Thu, 2019-09-05 at 19:31 +0900, Tomasz Figa wrote: > > > On Thu, Sep 5, 2019 at 7:15 PM Philipp Zabel > > > wrote: > > > > This flag tells the kernel whether the s

[PATCH] v4l2-dv-timings.c: fix format string

2019-09-09 Thread Hans Verkuil
It should be "%u.%02u" instead of "%u.%u". Signed-off-by: Hans Verkuil Reported-by: Bard Winther --- diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c b/drivers/media/v4l2-core/v4l2-dv-timings.c index 4f23e939ead0..0607a5d0d051 100644 --- a/drivers/media/v4l2-core/v4l2-dv-timings.c +++ b/d

[PATCH 3/3] media: hantro: h264: Fix the frame_num wraparound case

2019-09-09 Thread Boris Brezillon
Step '8.2.4.1 Decoding process for picture numbers' was missing in the reflist creation logic, leading to invalid P reflists when a ->frame_num wraparound happens. Fixes: a9471e25629b ("media: hantro: Add core bits to support H264 decoding") Reported-by: Francois Buergisser Signed-off-by: Boris B

[PATCH 1/3] media: hantro: h264: Fix a comment in b1_ref_list_cmp()

2019-09-09 Thread Boris Brezillon
So it matches the code and the spec. Signed-off-by: Boris Brezillon --- drivers/staging/media/hantro/hantro_h264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/hantro/hantro_h264.c b/drivers/staging/media/hantro/hantro_h264.c index 0d758e0c0f99..f070

[PATCH 2/3] media: hantro: h264: Rename POC_CMP() into HANTRO_CMP()

2019-09-09 Thread Boris Brezillon
And use it for all native type comparisons, even if it's not strictly required. By doing that we make the code more consistent and prevent from potential incorrect results in case of overflow or when the the values being compared are both negative. Signed-off-by: Boris Brezillon --- drivers/stag

Re: [PATCH 1/2] media: uapi: h264: Add num_ref_idx_active_override_flag

2019-09-09 Thread Philipp Zabel
On Mon, 2019-09-09 at 16:09 +0900, Tomasz Figa wrote: > On Thu, Sep 5, 2019 at 11:17 PM Nicolas Dufresne > wrote: > > > > Le jeudi 05 septembre 2019 à 12:39 +0200, Philipp Zabel a écrit : > > > On Thu, 2019-09-05 at 19:31 +0900, Tomasz Figa wrote: > > > > On Thu, Sep 5, 2019 at 7:15 PM Philipp Za

Re: [PATCH 3/3] media: hantro: h264: Fix the frame_num wraparound case

2019-09-09 Thread Boris Brezillon
On Mon, 9 Sep 2019 09:28:15 +0200 Boris Brezillon wrote: > Step '8.2.4.1 Decoding process for picture numbers' was missing in the > reflist creation logic, leading to invalid P reflists when a > ->frame_num wraparound happens. > > Fixes: a9471e25629b ("media: hantro: Add core bits to support

Re: [PATCH] cec-compliance: system information give features

2019-09-09 Thread Hans Verkuil
On 9/6/19 6:44 PM, Jiunn Chang wrote: > For devices on a HDMI ARC link, sinks can only support transmitter > devices and sources can only support receiver devices. > > Add two checks: > - Playback devices can only have has_arc_rx > - TVs can only have has_arc_tx > > Signed-off-by: Jiunn Chang

Re: [V1, 2/2] media: i2c: Add more sensor mode for ov8856 camera sensor

2019-09-09 Thread Dongchun Zhu
Hi Sakari, On Thu, 2019-08-08 at 16:53 +0300, Sakari Ailus wrote: > Hi Dongchun, > > Thanks for the patch. > > On Thu, Aug 08, 2019 at 05:22:15PM +0800, dongchun@mediatek.com wrote: > > From: Dongchun Zhu > > > > This patch mainly adds two more sensor modes for OV8856 image sensor. > > The

Re: [PATCH 3/3] media: hantro: h264: Fix the frame_num wraparound case

2019-09-09 Thread Philipp Zabel
Hi Boris, On Mon, 2019-09-09 at 09:28 +0200, Boris Brezillon wrote: > Step '8.2.4.1 Decoding process for picture numbers' was missing in the > reflist creation logic, leading to invalid P reflists when a > ->frame_num wraparound happens. > > Fixes: a9471e25629b ("media: hantro: Add core bits to s

[PATCH] vivid: Set vid_cap_streaming and vid_out_streaming to true

2019-09-09 Thread Vandana BN
when vbi/meta stream is started, followed by video streaming, the vid_cap_streaming and vid_out_streaming were not being set to true, which would cause the video stream to stop when vbi/meta stream is stopped. This patch allows to set vid_cap_streaming and vid_out_streaming to true. Signed-off-by:

Re: [PATCH] vivid: Set vid_cap_streaming and vid_out_streaming to true

2019-09-09 Thread Hans Verkuil
Hi Vandana, The patch is right, but the commit log can be improved: On 9/9/19 11:11 AM, Vandana BN wrote: > when vbi/meta stream is started, followed by video streaming, Since this patch will be applied before the patch that adds metadata, you can't refer to meta yet. Just stick to vbi. Also: '

Re: [V1, 2/2] media: i2c: Add more sensor mode for ov8856 camera sensor

2019-09-09 Thread Dongchun Zhu
Hi Tomasz, On Fri, 2019-08-23 at 19:01 +0900, Tomasz Figa wrote: > Hi Dongchun, > > On Thu, Aug 08, 2019 at 05:22:15PM +0800, dongchun@mediatek.com wrote: > > From: Dongchun Zhu > > > > This patch mainly adds two more sensor modes for OV8856 image sensor. > > The OV8856 driver currently sup

Re: [PATCH 1/2] media: uapi: h264: Add num_ref_idx_active_override_flag

2019-09-09 Thread Tomasz Figa
On Mon, Sep 9, 2019 at 4:30 PM Philipp Zabel wrote: > > On Mon, 2019-09-09 at 16:09 +0900, Tomasz Figa wrote: > > On Thu, Sep 5, 2019 at 11:17 PM Nicolas Dufresne > > wrote: > > > > > > Le jeudi 05 septembre 2019 à 12:39 +0200, Philipp Zabel a écrit : > > > > On Thu, 2019-09-05 at 19:31 +0900, To

[PATCH v2] vivid: Set vid_cap_streaming and vid_out_streaming to true

2019-09-09 Thread Vandana BN
When vbi stream is started, followed by video streaming, the vid_cap_streaming and vid_out_streaming were not being set to true, which would cause the video stream to stop when vbi stream is stopped. This patch allows to set vid_cap_streaming and vid_out_streaming to true. According to Hans Verkuil

Re: [V4, 1/2] media: dt-bindings: media: i2c: Add bindings for OV02A10

2019-09-09 Thread Andy Shevchenko
On Sat, Sep 07, 2019 at 05:27:27PM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > This patch adds device tree bindings documentation for OV02A10 camera sensor. > > Signed-off-by: Dongchun Zhu > --- > .../devicetree/bindings/media/i2c/ov02a10.txt | 54 > +

[PATCH v3] vivid: Add metadata capture support

2019-09-09 Thread Vandana BN
This patch adds meatadata capture support in vivid driver. Added new files for metadata capture. Signed-off-by: Vandana BN --- v2 Add UVC metadata structure. v3 Use correct metadata size. drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c | 90

Re: [V4, 1/2] media: dt-bindings: media: i2c: Add bindings for OV02A10

2019-09-09 Thread Sakari Ailus
Hi Andy, On Mon, Sep 09, 2019 at 12:45:01PM +0300, Andy Shevchenko wrote: > On Sat, Sep 07, 2019 at 05:27:27PM +0800, dongchun@mediatek.com wrote: > > From: Dongchun Zhu > > > > This patch adds device tree bindings documentation for OV02A10 camera > > sensor. > > > > Signed-off-by: Dongchu

Re: [V1, 2/2] media: i2c: Add more sensor mode for ov8856 camera sensor

2019-09-09 Thread Sakari Ailus
Hi Dongchun, On Mon, Sep 09, 2019 at 04:46:15PM +0800, Dongchun Zhu wrote: > Hi Sakari, > > On Thu, 2019-08-08 at 16:53 +0300, Sakari Ailus wrote: > > Hi Dongchun, > > > > Thanks for the patch. > > > > On Thu, Aug 08, 2019 at 05:22:15PM +0800, dongchun@mediatek.com wrote: > > > From: Dongch

Re: [V4, 1/2] media: dt-bindings: media: i2c: Add bindings for OV02A10

2019-09-09 Thread Andy Shevchenko
On Mon, Sep 09, 2019 at 12:57:15PM +0300, Sakari Ailus wrote: > Hi Andy, > > On Mon, Sep 09, 2019 at 12:45:01PM +0300, Andy Shevchenko wrote: > > On Sat, Sep 07, 2019 at 05:27:27PM +0800, dongchun@mediatek.com wrote: > > > From: Dongchun Zhu > > > > > > This patch adds device tree bindings d

Re: [PATCH 4/4] media: hantro: Support color conversion via post-processing

2019-09-09 Thread Hans Verkuil
On 9/3/19 8:17 PM, Ezequiel Garcia wrote: > The Hantro G1 decoder is able to enable a post-processor > on the decoding pipeline, which can be used to perform > scaling and color conversion. > > The post-processor is integrated to the decoder, and it's > possible to use it in a way that is complete

Re: [PATCH] media: uapi: h264: clarify num_ref_idx_l[01]_(default_)active fields

2019-09-09 Thread Hans Verkuil
On 9/5/19 1:42 PM, Philipp Zabel wrote: > To explain why num_ref_idx_active_override_flag is not part of the API, > describe how the num_ref_idx_l[01]_active_minus1 fields and the > num_ref_idx_l[01]_default_active_minus1 fields are used, depending on > whether the decoder parses slice headers itse

Re: [PATCH] media: uapi: h264: clarify num_ref_idx_l[01]_(default_)active fields

2019-09-09 Thread Philipp Zabel
On Mon, 2019-09-09 at 14:09 +0200, Hans Verkuil wrote: > On 9/5/19 1:42 PM, Philipp Zabel wrote: > > To explain why num_ref_idx_active_override_flag is not part of the API, > > describe how the num_ref_idx_l[01]_active_minus1 fields and the > > num_ref_idx_l[01]_default_active_minus1 fields are use

Re: [PATCH] media: uapi: h264: clarify num_ref_idx_l[01]_(default_)active fields

2019-09-09 Thread Hans Verkuil
On 9/9/19 2:27 PM, Philipp Zabel wrote: > On Mon, 2019-09-09 at 14:09 +0200, Hans Verkuil wrote: >> On 9/5/19 1:42 PM, Philipp Zabel wrote: >>> To explain why num_ref_idx_active_override_flag is not part of the API, >>> describe how the num_ref_idx_l[01]_active_minus1 fields and the >>> num_ref_idx

Re: [PATCH] media: uapi: h264: clarify num_ref_idx_l[01]_(default_)active fields

2019-09-09 Thread Philipp Zabel
On Mon, 2019-09-09 at 14:43 +0200, Hans Verkuil wrote: > On 9/9/19 2:27 PM, Philipp Zabel wrote: > > On Mon, 2019-09-09 at 14:09 +0200, Hans Verkuil wrote: > > > On 9/5/19 1:42 PM, Philipp Zabel wrote: [...] > > > > @@ -1820,10 +1820,14 @@ enum > > > > v4l2_mpeg_video_h264_hierarchical_coding_type

Re: [PATCH] media: uapi: h264: clarify num_ref_idx_l[01]_(default_)active fields

2019-09-09 Thread Hans Verkuil
On 9/9/19 3:36 PM, Philipp Zabel wrote: > On Mon, 2019-09-09 at 14:43 +0200, Hans Verkuil wrote: >> On 9/9/19 2:27 PM, Philipp Zabel wrote: >>> On Mon, 2019-09-09 at 14:09 +0200, Hans Verkuil wrote: On 9/5/19 1:42 PM, Philipp Zabel wrote: > [...] > @@ -1820,10 +1820,14 @@ enum > v4l2_

[PATCH] cec-compliance: rename has_arc_rx, has_arc_tx

2019-09-09 Thread Jiunn Chang
Renaming has_arc_rx and has_arc_tx to better match the macros defined in cec.h: - CEC_OP_FEAT_DEV_SOURCE_HAS_ARC_RX - CEC_OP_FEAT_DEV_SINK_HAS_ARC_TX For devices on a HDMI ARC link, sources can only support receiver devices and sinks can only support transmitter devices. Signed-off-by: Jiunn Chan

Re: [PATCH] cec-compliance: rename has_arc_rx, has_arc_tx

2019-09-09 Thread Hans Verkuil
On 9/9/19 4:26 PM, Jiunn Chang wrote: > Renaming has_arc_rx and has_arc_tx to better match the macros defined in > cec.h: > - CEC_OP_FEAT_DEV_SOURCE_HAS_ARC_RX > - CEC_OP_FEAT_DEV_SINK_HAS_ARC_TX > > For devices on a HDMI ARC link, sources can only support receiver devices > and sinks can only sup

[PATCH] cec-compliance: system information give features

2019-09-09 Thread Jiunn Chang
For devices on a HDMI ARC link, sources can only receive ARC and sinks can only transmit ARC. Add two checks: - Playback devices can only receive ARC, i.e. source_has_arc_rx - TVs can only transmit ARC, i.e. sink_has_arc_tx Signed-off-by: Jiunn Chang --- utils/cec-compliance/cec-test.cpp | 4

[dtv-scan-tables] Update dvb-s/Turksat-42.0E

2019-09-09 Thread Olcay Korkmaz
Hi, dvb-s/Trksat-3A-42.0E and dvb-s/Trksat-4A-42.0E are transmitting from same position 3A and 4A transponder lists merged to Turksat-42.0E fetched from https://git.linuxtv.org/dtv-scan-tables.git/commit/dvb-s/Trksat-3A-42.0E?id=13fe49b3be2b64ae63d65fe73d2da4f4deb33eda fetched from https://git.l

[RFC PATCH V3 2/5] dts: arm64: mt8183: Add DIP nodes

2019-09-09 Thread frederic.chen
From: Frederic Chen This patch adds nodes for Digital Image Processing (DIP). DIP is embedded in Mediatek SoCs and works with the co-processor to adjust image content according to tuning input data. It also provides image format conversion, resizing, and rotation features. Signed-off-by: Frederi

[RFC PATCH V3 5/5] media: platform: mtk-mdp3: Add struct tuning_addr and img_sw_buffer

2019-09-09 Thread frederic.chen
From: Frederic Chen We added a struct tuning_addr which contains a field "present" so that the driver can tell the firmware if we have user tuning dataor not. The strcut img_sw_buffer is also added. This struct has no cpu address field and uses a handle instead so that we don't pass a cpu addres

[RFC PATCH V3 3/5] media: platform: Add Mediatek DIP driver KConfig

2019-09-09 Thread frederic.chen
From: Frederic Chen This patch adds KConfig for Mediatek Digital Image Processing driver(DIP). DIP is embedded in Mediatek SoCs. It provides image format conversion, resizing, and rotation function. Signed-off-by: Frederic Chen --- drivers/media/platform/Kconfig | 2 ++ drivers/media/

[RFC PATCH V3 1/5] dt-bindings: mt8183: Added DIP dt-bindings

2019-09-09 Thread frederic.chen
From: Frederic Chen This patch adds DT binding documentation for the Digital Image Processing (DIP) unit of camera ISP system on Mediatek's SoCs. It depends on the SCP and MDP 3 patch as following: 1. dt-bindings: Add a binding for Mediatek SCP https://patchwork.kernel.org/patch/11027247/ 2.

[RFC PATCH V3 4/5] platform: mtk-isp: Add Mediatek DIP driver

2019-09-09 Thread frederic.chen
From: Frederic Chen This patch adds the driver of Digital Image Processing (DIP) unit in Mediatek ISP system, providing image format conversion, resizing, and rotation features. The mtk-isp directory will contain drivers for multiple IP blocks found in Mediatek ISP system. It will include ISP Pa

[PATCH] cec-compliance: system audio control

2019-09-09 Thread Jiunn Chang
Add comment block documenting tests not included from section 13.15 of the HDMI CEC 1.4b specification. This section outlines the System Audio Control feature. Signed-off-by: Jiunn Chang --- utils/cec-compliance/cec-test-audio.cpp | 30 + 1 file changed, 30 insertions(+)

Re: [PATCH] rcar-vin: Do not enumerate unsupported pixel formats

2019-09-09 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Fri, Sep 06, 2019 at 04:35:00PM +0200, Niklas Söderlund wrote: > If a pixel format is not supported by the hardware NULL is returned by > rvin_format_from_pixel() for that fourcc. Verify that the pixel format > is supported using this or skip it when enumera

cron job: media_tree daily build: OK

2019-09-09 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Sep 10 05:00:10 CEST 2019 media-tree git hash:6f51fdfd8229d5358c2d6e272cf73478866e8ddc media_build gi

Re: [PATCH] cec-compliance: system audio control

2019-09-09 Thread Hans Verkuil
On 9/9/19 10:20 PM, Jiunn Chang wrote: > Add comment block documenting tests not included from section 13.15 of > the HDMI CEC 1.4b specification. This section outlines the System Audio > Control feature. > > Signed-off-by: Jiunn Chang > --- > utils/cec-compliance/cec-test-audio.cpp | 30 ++