Re: [RFC,v3 9/9] media: platform: Add Mediatek ISP P1 shared memory device

2019-07-01 Thread Tomasz Figa
Hi Jungo, On Tue, Jun 11, 2019 at 11:53:44AM +0800, Jungo Lin wrote: > The purpose of this child device is to provide shared > memory management for exchanging tuning data between co-processor > and the Pass 1 unit of the camera ISP system, including cache > buffer handling. > Looks like we have

Re: [PATCH 01/16] am437x/davinci: set device_caps in struct video_device

2019-07-01 Thread Lad, Prabhakar
Hi Hans, Thank you for the patch. On Wed, Jun 26, 2019 at 8:44 AM Hans Verkuil wrote: > > Instead of filling in the struct v4l2_capability device_caps > field, fill in the struct video_device device_caps field. > > That way the V4L2 core knows what the capabilities of the > video device are. > >

Re: [PATCH 5/5] media/platform: don't set description in ENUM_FMT

2019-07-01 Thread Lad, Prabhakar
Hi Hans, Thank you for the patch. On Wed, Jun 26, 2019 at 12:27 PM Hans Verkuil wrote: > > The V4L2 core sets the format description and flags for the driver in order > to ensure consistent naming. > > So drop the strscpy of the description in drivers. Also remove any > description strings in d

Re: [PATCH for v5.3] v4l2-subdev: fix regression in check_pad()

2019-07-01 Thread Sakari Ailus
Hi Hans, On Sat, Jun 29, 2019 at 03:08:23PM +0200, Hans Verkuil wrote: > On 6/29/19 2:57 PM, Hans Verkuil wrote: > > On 6/29/19 2:06 PM, Janusz Krzysztofik wrote: > >> Hi Hans, > >> > >> On Saturday, June 29, 2019 12:00:24 P.M. CEST Hans Verkuil wrote: > >>> sd->entity.graph_obj.mdev can be NULL w

Re: [PATCH 2/2] media: i2c: isl7998x: Add driver for Intersil ISL7998x

2019-07-01 Thread Jacopo Mondi
Hello Marek, long time due review, sorry about this. On Mon, May 20, 2019 at 10:18:12PM +0200, Marek Vasut wrote: > Add driver for the Intersil ISL7998x BT656-to-MIPI-CSI2 video decoder. analog to CSI-2 or analog to BT.656 if you want to support both chip versions. > This chip supports 1/2/4

Re: [PATCH 1/2] media: dt-bindings: Add Intersil ISL7998x DT bindings

2019-07-01 Thread Sakari Ailus
Hi Marek, On Mon, May 20, 2019 at 10:18:11PM +0200, Marek Vasut wrote: > Add bindings for the Intersil ISL7998x BT656-to-MIPI-CSI2 decoder. > > Signed-off-by: Marek Vasut > Cc: Sakari Ailus > Cc: Mauro Carvalho Chehab > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > To: linux-media@vger.k

[PATCH 0/5] cec: convert remaining drivers to the new notifier API

2019-07-01 Thread Dariusz Marcinkiewicz
This series updates remaining drivers in DRM to use new CEC notifier API. Those complement the "cec: improve notifier support, add connector info" patch series and also replace 2 following patches from there: - [PATCHv8 09/13] dw-hdmi: use cec_notifier_conn_(un)register - [PATCHv9 12/13] tda998x:

[PATCH 3/5] drm: tegra: use cec_notifier_conn_(un)register

2019-07-01 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/tegra/output.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff

[PATCH 1/5] drm: tda998x: use cec_notifier_conn_(un)register

2019-07-01 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/i2c/tda998x_drv.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletio

[PATCH 4/5] drm: dw-hdmi: use cec_notifier_conn_(un)register

2019-07-01 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 32 ++- 1 file changed, 19 insertions(+), 13 de

[PATCH 2/5] drm: sti: use cec_notifier_conn_(un)register

2019-07-01 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/sti/sti_hdmi.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) dif

[PATCH 5/5] drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register

2019-07-01 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/exynos/exynos_hdmi.c | 33 +--- 1 file changed, 20 insertions(+), 13 de

Re: [PATCH 2/2] media: i2c: isl7998x: Add driver for Intersil ISL7998x

2019-07-01 Thread Sakari Ailus
Hi Marek, Thank you for the patchset --- and my apologies for reviewing it so late. On Mon, May 20, 2019 at 10:18:12PM +0200, Marek Vasut wrote: > Add driver for the Intersil ISL7998x BT656-to-MIPI-CSI2 video decoder. > This chip supports 1/2/4 analog video inputs and converts them into > 1/2/4 V

Re: [ANN] Media summit in Lisbon at September

2019-07-01 Thread Sean Young
Hi Mauro, On Sun, Jun 30, 2019 at 01:44:04PM -0300, Mauro Carvalho Chehab wrote: > Hi all, > > We are organizing a media mini-summit in Lisbon to happen in September, > at the same week as the Linux Plumber Conference and the Kernel Summit. > > We're still discussing the details about that. > >

Re: Setting up the links for imx7-mipi-csis

2019-07-01 Thread Rui Miguel Silva
Hi Guys, On Sat 29 Jun 2019 at 12:42, Fabio Estevam wrote: > Hi Sakari, > > On Sat, Jun 29, 2019 at 6:13 AM Sakari Ailus wrote: > >> What does media-ctp -p say? > > Thanks for this hint! > > I managed to fix the media-ctl failure by looking at media-ctl -p output. > > Documentation/media/v4l-drive

Re: [PATCH] media: imx7.rst: Fix the references to the CSI multiplexer

2019-07-01 Thread Rui Miguel Silva
Oi Fabio, On Sat 29 Jun 2019 at 13:16, Fabio Estevam wrote: > In imx7s.dtsi the node name for the CSI multiplexer is "csi-mux", not > "csi_mux", so fix all the references in the document. > > This fixes the following error when the instructions are followed: > > # media-ctl -l "'imx7-mipi-csis.0':1

Re: [PATCH 2/2] media: i2c: isl7998x: Add driver for Intersil ISL7998x

2019-07-01 Thread Sakari Ailus
One more comment... On Mon, May 20, 2019 at 10:18:12PM +0200, Marek Vasut wrote: ... > +static int isl7998x_set_fmt(struct v4l2_subdev *sd, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_format *format) > +{ > + struct isl7998x *isl7998x = sd_to_isl7998x

regarding commit "v4l2-ctl: get fmt after source change" in v4l-utils repository

2019-07-01 Thread Dafna Hirschfeld
commit 84219e2b5d013709ee5259621715966c46eec746 Author: Hans Verkuil Date: Sat Mar 30 14:16:25 2019 +0100 v4l2-ctl: get fmt after source change When a source change event arrives during decoding get the new format at that point instead of after restarting streaming. If there i

Re: [PATCH v3] keytable: Add keymap test

2019-07-01 Thread Sean Young
On Fri, Jun 28, 2019 at 11:45:29AM +0200, Bastien Nocera wrote: > This new test will try to parse all the ".toml" files in the directory > path passed to it, error'ing out on the first parsing problem. > > Run as "make check" in the keytable directory. > > Signed-off-by: Bastien Nocera > --- > C

Re: [PATCH v3] keytable: Add keymap test

2019-07-01 Thread Bastien Nocera
On Mon, 2019-07-01 at 12:28 +0100, Sean Young wrote: > On Fri, Jun 28, 2019 at 11:45:29AM +0200, Bastien Nocera wrote: > > This new test will try to parse all the ".toml" files in the > > directory > > path passed to it, error'ing out on the first parsing problem. > > > > Run as "make check" in th

Re: [PATCH v2] keytable: Add keymap test

2019-07-01 Thread Bastien Nocera
On Thu, 2019-06-27 at 20:33 +0100, Sean Young wrote: > On Thu, Jun 27, 2019 at 10:13:56AM +0200, Bastien Nocera wrote: > > This new test will try to parse all the ".toml" files in the > > directory > > path passed to it, error'ing out on the first parsing problem. > > > > Run as "make check" in th

[PATCH v2 2/5] drm: sti: use cec_notifier_conn_(un)register

2019-07-01 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/sti/sti_hdmi.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) dif

[PATCH v2 1/5] drm: tda998x: use cec_notifier_conn_(un)register

2019-07-01 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Changes since v1: Add memory barrier to make sure that the notifier becomes visible to the irq thread once it is fully constructed

[PATCH v2 0/5] cec: convert remaining drivers to the new notifier API

2019-07-01 Thread Dariusz Marcinkiewicz
This series updates remaining drivers in DRM to use new CEC notifier API. Those complement the "cec: improve notifier support, add connector info" patch series and also replace 2 following patches from there: - [PATCHv8 09/13] dw-hdmi: use cec_notifier_conn_(un)register - [PATCHv9 12/13] tda998x:

[PATCH v2 4/5] drm: dw-hdmi: use cec_notifier_conn_(un)register

2019-07-01 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Changes since v1: Add memory barrier to make sure that the notifier becomes visible to the irq thread once it is fully constructed

[PATCH v2 3/5] drm: tegra: use cec_notifier_conn_(un)register

2019-07-01 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/tegra/output.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff

[PATCH v2 5/5] drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register

2019-07-01 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/exynos/exynos_hdmi.c | 33 +--- 1 file changed, 20 insertions(+), 13 de

[PATCH 1/2] keytable: Add source information in generated keymaps

2019-07-01 Thread Bastien Nocera
Add comments to mention that keymap files are generated, and that they shouldn't be modified by hand. Also list which tool was used to generate them and the kernel source filename. Signed-off-by: Bastien Nocera --- utils/keytable/gen_keytables.pl | 9 - 1 file changed, 8 insertions(+), 1

[PATCH 2/2] keytable: Remove comments before processing keymaps

2019-07-01 Thread Bastien Nocera
Do our best to remove comments from each line we process from the keymap sources, so as to avoid commented duplicates and false positives sneaking in to the keymap definitions. Signed-off-by: Bastien Nocera --- utils/keytable/gen_keytables.pl | 3 +++ 1 file changed, 3 insertions(+) diff --git

Keymap with duplicate entries

2019-07-01 Thread Bastien Nocera
Hey Aapo, There seems to be a problem in the keymap you provided for inclusion in the kernel. In drivers/media/usb/dvb-usb/m920x.c, 2 keys are triggered by the same keycode: 790 ↦ { 0x08, KEY_SUBTITLE },• 794 ↦ { 0x08, KEY_VIDEO },↦ ↦ /* A/V */• Could you please check what

Keymap with duplicate entries

2019-07-01 Thread Bastien Nocera
Hey Malcolm, There seems to be a problem in the keymap you provided for inclusion in the kernel. In media/rc/keymaps/rc-it913x-v2.c, 2 keys are triggered by the same keycode: 53 ↦ { 0x866b18, KEY_VOLUMEDOWN },• 55 ↦ { 0x866b18, KEY_CHANNELDOWN },• Could you please check what the c

Keymap with duplicate entries

2019-07-01 Thread Bastien Nocera
Hey Younian, There seems to be a problem in the keymap you provided for inclusion in the kernel. In drivers/media/rc/keymaps/rc-hisi-poplar.c, 2 keys are triggered by the same keycode: 27 ↦ { 0xb2c5, KEY_DELETE},• 34 ↦ { 0xb2c5, KEY_BACK},• Could you please check what the

Re: [PATCH v2] keytable: Add keymap test

2019-07-01 Thread Bastien Nocera
On Mon, 2019-07-01 at 16:27 +0200, Bastien Nocera wrote: > > That would be great. They have to be patched in the kernel tree, > > they > > are generated from there. > > It's customary to put a comment at the top of generated files > indicating that they shouldn't be modified and list the name and

Re: Keymap with duplicate entries

2019-07-01 Thread Bastien Nocera
On Mon, 2019-07-01 at 18:38 +0200, Bastien Nocera wrote: > Hey Aapo, > > There seems to be a problem in the keymap you provided for inclusion > in the kernel. > > In drivers/media/usb/dvb-usb/m920x.c, 2 keys are triggered by the > same > keycode: > 790 ↦ { 0x08, KEY_SUBTITLE },• > 794 ↦

Re: [PATCH for v5.3] v4l2-subdev: fix regression in check_pad()

2019-07-01 Thread Janusz Krzysztofik
Hi Sakari, On Monday, July 1, 2019 9:50:55 A.M. CEST Sakari Ailus wrote: > Hi Hans, > > On Sat, Jun 29, 2019 at 03:08:23PM +0200, Hans Verkuil wrote: > > On 6/29/19 2:57 PM, Hans Verkuil wrote: > > > On 6/29/19 2:06 PM, Janusz Krzysztofik wrote: > > >> Hi Hans, > > >> > > >> On Saturday, June 29

Re: [PATCH 2/2] media: ov5645: Use regulator_bulk() functions

2019-07-01 Thread Todor Tomov
Hello Fabio, On Thu, Jun 27, 2019 at 9:24 PM Fabio Estevam wrote: > > Hi Sakari, > > On Thu, Jun 27, 2019 at 1:27 PM Sakari Ailus wrote: > > > This appears to change the order in which the regulators are enabled. Is > > that intentional? Does the sensor support this order as well? > > Good catch

Analyze syzbot report technisat_usb2_rc_query KASAN

2019-07-01 Thread Phong Tran
Hello, I did a checking for this report of syzbot [1] From the call stack of dump log: There shows that a problem within technisat_usb2_get_ir() BUG: KASAN: slab-out-of-bounds in technisat_usb2_get_ir drivers/media/usb/dvb-usb/technisat-usb2.c:664 [inline] BUG: KASAN: slab-out-of-bounds in tec

[PATCH] rcar-vin: Clean up correct notifier in error path

2019-07-01 Thread Niklas Söderlund
When adding the v4l2_async_notifier_cleanup() callas the wrong notifier was cleaned up if the parallel notifier registration failed. Fix this by cleaning up the correct one. Fixes: 9863bc8695bc36e3 ("media: rcar-vin: Cleanup notifier in error path") Signed-off-by: Niklas Söderlund --- drivers/me

Re: [Linux-kernel-mentees] Analyze syzbot report technisat_usb2_rc_query KASAN

2019-07-01 Thread Greg KH
On Tue, Jul 02, 2019 at 07:49:26AM +0700, Phong Tran wrote: > Hello, > > I did a checking for this report of syzbot [1] > From the call stack of dump log: > > There shows that a problem within technisat_usb2_get_ir() > > BUG: KASAN: slab-out-of-bounds in technisat_usb2_get_ir > drivers/media/usb