Re: v4l2_device_register_subdev_nodes() clean_up code

2014-05-30 Thread Krzysztof Czarnowski
> One additional thing: I think sd->devnode should also be set as NULL since > sub-devices are no longer created by the driver owning the media device. Yes, I think you're right. But there are also other issues with v4l2_device_register_subdev_nodes(). I think after checking V4L2_SUBDEV_FL_HAS_DE

Re: v4l2_device_register_subdev_nodes() clean_up code

2014-05-30 Thread Sakari Ailus
On Fri, May 30, 2014 at 03:27:27PM +0200, Krzysztof Czarnowski wrote: > Sure, a moment :-) One additional thing: I think sd->devnode should also be set as NULL since sub-devices are no longer created by the driver owning the media device. This isn't done in the error path or in v4l2_device_unregi

Re: v4l2_device_register_subdev_nodes() clean_up code

2014-05-30 Thread Sakari Ailus
Hi Krzysztof, On Fri, May 30, 2014 at 02:44:26PM +0200, Krzysztof Czarnowski wrote: > Hi, > > In "clean_up:" section of v4l2_device_register_subdev_nodes() we have: > > if (!sd->devnode) > break; > > Maybe I miss something, but shouldn't it be rather "continue" instead > of "break"?

v4l2_device_register_subdev_nodes() clean_up code

2014-05-30 Thread Krzysztof Czarnowski
Hi, In "clean_up:" section of v4l2_device_register_subdev_nodes() we have: if (!sd->devnode) break; Maybe I miss something, but shouldn't it be rather "continue" instead of "break"? Regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the b