Re: tw686x driver (continued)

2019-07-27 Thread Ezequiel Garcia
Hi Mark, On Wed, 24 Jul 2019 at 09:25, Mark Balançian wrote: > > Hi Ezequiel, > > (sorry didn't include linux-media in first email) > I'm not sure yet if I have my supervisor's permission to declare our > tool as open source, but I'll tell you the possible code paths that I > think may be leading

Re: tw686x driver (continued)

2019-07-27 Thread Ezequiel Garcia
Hi Hans, On Wed, 24 Jul 2019 at 10:08, Hans Verkuil wrote: > > On 7/24/19 2:25 PM, Mark Balançian wrote: > > Hi Ezequiel, > > > > (sorry didn't include linux-media in first email) > > I'm not sure yet if I have my supervisor's permission to declare our > > tool as open source, but I'll tell you t

Re: tw686x driver (continued)

2019-07-24 Thread Hans Verkuil
On 7/24/19 3:31 PM, Mark Balançian wrote: > On Jul 24, 2019, at 6:08 AM, Hans Verkuil > wrote: >> >> What tw686x_video_free() does really should be done in the release function >> of the video_device: vdev->release is currently set to video_device_release, >> but that sh

Re: tw686x driver (continued)

2019-07-24 Thread Hans Verkuil
On 7/24/19 2:25 PM, Mark Balançian wrote: > Hi Ezequiel, > > (sorry didn't include linux-media in first email) > I'm not sure yet if I have my supervisor's permission to declare our > tool as open source, but I'll tell you the possible code paths that I > think may be leading our tool to think w

Re: tw686x driver (continued)

2019-07-24 Thread Mark Balançian
TBH though, I’m not sure about the tw686x_init going to the error: label though, so am curious as to your thoughts on this as well. It was just something I thought might be occurring due to the fact that the error trace in our tool ends in tw686x_memcpy_dma_free (i.e. dma_ops->free). Please se

Re: tw686x driver (continued)

2019-07-24 Thread Mark Balançian
Hi Ezequiel, (sorry didn't include linux-media in first email) I'm not sure yet if I have my supervisor's permission to declare our tool as open source, but I'll tell you the possible code paths that I think may be leading our tool to think what it's thinking. First off, it detects a write ac

Re: tw686x driver (continued)

2019-07-23 Thread Ezequiel Garcia
On Tue, 23 Jul 2019 at 12:55, Mark Balançian wrote: > > On Jul 23, 2019, at 8:17 AM, Ezequiel Garcia > wrote: > > > On Tue, 23 Jul 2019 at 12:02, Mark Balançian wrote: > > > I see. I guess then my issue would be help in seeing how > tw686x_memcpy_dma_free alone does any required interrupt hand

tw686x driver (continued)

2019-07-23 Thread Mark Balançian
Hi Ezequiel, I don’t know what top-posting is and I had to delete the continuation as linux-media kept flagging my email as a virus, but I take it that it means I should write my email below the previous? Anyways, I’m working with a linux driver verification team to detect race conditions in t