Re: sparse and anonymous unions

2014-04-03 Thread Christopher Li
On Mon, Mar 31, 2014 at 10:17 AM, Linus Torvalds wrote: > Chris, mind applying this one too? It removes more lines than it adds > while fixing things, by removing the helper function that isn't good > at anoymous unions, and using another one that does this all right.. The patch is applied. I add

Re: sparse and anonymous unions

2014-03-31 Thread Linus Torvalds
On Mon, Mar 31, 2014 at 12:51 AM, Hans Verkuil wrote: > > Here is a simple test case for this problem: > > == anon-union.c == > struct s { > union { > int val; > }; > }; > > static struct s foo = { .val = 5, }; Ok, this fixes the warning, but we seem to sti

Re: sparse and anonymous unions

2014-03-31 Thread Hans Verkuil
On 03/31/2014 09:51 AM, Hans Verkuil wrote: > On 03/15/2014 11:26 AM, Hans Verkuil wrote: >> Hi! >> >> I'm trying to cut down the list of sparse warnings and errors I get when >> compiling drivers/media. Most of them are obviously our problem, but there >> is one that seems to be a sparse bug: >> >

Re: sparse and anonymous unions

2014-03-31 Thread Hans Verkuil
On 03/15/2014 11:26 AM, Hans Verkuil wrote: > Hi! > > I'm trying to cut down the list of sparse warnings and errors I get when > compiling drivers/media. Most of them are obviously our problem, but there > is one that seems to be a sparse bug: > > drivers/media/v4l2-core/v4l2-dv-timings.c:30:9: e

Re: sparse and anonymous unions

2014-03-15 Thread Hans Verkuil
Just for the linux-media mailinglist: I'm patching include/uapi/linux/v4l2-dv-timings.h by adding ' || defined(__CHECKER__)' as described below during the sparse run of the daily build for now. This gets rid of all these errors until I know whether this should be a permanent patch or whether spa

sparse and anonymous unions

2014-03-15 Thread Hans Verkuil
Hi! I'm trying to cut down the list of sparse warnings and errors I get when compiling drivers/media. Most of them are obviously our problem, but there is one that seems to be a sparse bug: drivers/media/v4l2-core/v4l2-dv-timings.c:30:9: error: unknown field name in initializer This uses the v4