Re: null pointer access in error path of lgdt3305 driver

On Thu, Mar 12, 2009 at 7:04 AM, Matthias Schwarzott wrote: > Hi Michael! > > Looking at your new lgdt3305 driver, I noticed that the error path of > lgdt3305_attach, that is also jumped to kzalloc errors, sets > state->frontend.demodulator_priv to NULL. > > That will oops in case state is NULL. S

[PULL] Rhttp://linuxtv.org/hg/~mkrufky/lgdt3305 ( was - e: null pointer access in error path of lgdt3305 driver )

Matthias Schwarzott wrote: Hi Michael! Looking at your new lgdt3305 driver, I noticed that the error path of lgdt3305_attach, that is also jumped to kzalloc errors, sets state->frontend.demodulator_priv to NULL. That will oops in case state is NULL. So you either need two goto labels for f

null pointer access in error path of lgdt3305 driver

Hi Michael! Looking at your new lgdt3305 driver, I noticed that the error path of lgdt3305_attach, that is also jumped to kzalloc errors, sets state->frontend.demodulator_priv to NULL. That will oops in case state is NULL. So you either need two goto labels for failures or just return in case