(2013-09-17 13:07:03 +1000)
are available in the git repository at:
git://linuxtv.org/gliakhovetski/v4l-dvb.git 3.12-rc1-fixes
Dan Carpenter (2):
sh_vou: almost forever loop in sh_vou_try_fmt_vid_out()
mx3-camera: locking cleanup in mx3_videobuf_queue()
drivers/media/platform
Smatch complains about the locking here because we mix spin_lock_irq()
with spin_lock_irqsave() in an unusual way. According to Smatch, it's
not always clear if the IRQs are enabled or disabled when we return. It
turns out this function is always called with IRQs enabled and we can
just use spin_
On Sat, 24 Aug 2013, Dan Carpenter wrote:
> On Fri, Aug 23, 2013 at 11:16:51PM +0200, Guennadi Liakhovetski wrote:
> > Hi Dan,
> >
> > On Fri, 23 Aug 2013, Dan Carpenter wrote:
> >
> > > There is a return in the middle where we haven't restored the IRQs to
> > > their original state.
> > >
> >
On Fri, Aug 23, 2013 at 11:16:51PM +0200, Guennadi Liakhovetski wrote:
> Hi Dan,
>
> On Fri, 23 Aug 2013, Dan Carpenter wrote:
>
> > There is a return in the middle where we haven't restored the IRQs to
> > their original state.
> >
> > Signed-off-by: Dan Carpenter
> >
> > diff --git a/drivers
Hi Dan,
On Fri, 23 Aug 2013, Dan Carpenter wrote:
> There is a return in the middle where we haven't restored the IRQs to
> their original state.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/media/platform/soc_camera/mx3_camera.c
> b/drivers/media/platform/soc_camera/mx3_camera.c
There is a return in the middle where we haven't restored the IRQs to
their original state.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/platform/soc_camera/mx3_camera.c
b/drivers/media/platform/soc_camera/mx3_camera.c
index 1047e3e..4bae910 100644
--- a/drivers/media/platform/soc_ca
When adding and removing a client, the mx3-camera driver only activates
and deactivates its camera interface respectively, which doesn't include
any client-specific actions. Move this functionality into .clock_start()
and .clock_stop() callbacks.
Signed-off-by: Guennadi Liakhovetski
---
dr
When adding and removing a client, the mx3-camera driver only activates
and deactivates its camera interface respectively, which doesn't include
any client-specific actions. Move this functionality into .clock_start()
and .clock_stop() callbacks.
Signed-off-by: Guennadi Liakhovetski
---
dr
DEV;
- goto egetres;
- }
+ if (!res)
+ return -ENODEV;
+
+ if (!pdata)
+ return -EINVAL;
mx3_cam = vzalloc(sizeof(*mx3_cam));
if (!mx3_cam) {
dev_err(&pdev->dev, "Could not allocate mx3 camera object\n");
To support asynchronous subdevice registration we only have to pass a
subdevice descriptor array from driver platform data to soc-camera for
camera host driver registration.
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/platform/soc_camera/mx3_camera.c |6 ++
include/linux/platf
When adding and removing a client, the mx3-camera driver only activates
and deactivates its camera interface respectively, which doesn't include
any client-specific actions. Move this functionality into .clock_start()
and .clock_stop() callbacks.
Signed-off-by: Guennadi Liakhovetski
---
dr
From: Alex Gershgorin
Sent: Tuesday, March 06, 2012 3:22 PM
To: Guennadi Liakhovetski
Cc: linux-ker...@vger.kernel.org; Linux Media Mailing List; Sascha Hauer
Subject: RE: mx3-camera
Thanks Guennadi,
>Hi Alex
>(adding v4l and Sascha to CC)
>
3.0-rc6 version of the Linux
> > Kernel.
> > Here is my Kernel boot message
> >
> > "Linux video capture interface: v2.00
> > mx3-camera: probe of mx3-camera.0 failed with error -2"
> >
> > This error comes from probe function of mx3 camera host driv
On Tue, Mar 6, 2012 at 10:22 AM, Alex Gershgorin wrote:
> In i.MX35 (arch/arm/mach-imx/clock-imx35.c) it looks like this:
>
> _REGISTER_CLOCK(NULL, "csi", csi_clk)
Yes, I will submit a patch to fix this.
Regards,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-
nux video capture interface: v2.00
> mx3-camera: probe of mx3-camera.0 failed with error -2"
>
> This error comes from probe function of mx3 camera host driver.
> Precisely in this part of the code:
>
> mx3_cam->clk = clk_get(&pdev->dev, NULL);
> if (IS_ERR(mx3_cam
Hi Alex
(adding v4l and Sascha to CC)
On Tue, 6 Mar 2012, Alex Gershgorin wrote:
> Hi Guennadi,
>
> I'm working on I.MX35 PDK platform with use 3.3.0-rc6 version of the Linux
> Kernel.
> Here is my Kernel boot message
>
> "Linux video capture interface: v
videobuf_ops = {
.queue_setup = mx3_videobuf_setup,
- .buf_prepare= mx3_videobuf_prepare,
.buf_queue = mx3_videobuf_queue,
.buf_cleanup= mx3_videobuf_release,
.buf_init = mx3_videobuf_init,
@@ -516,6 +524,7 @@ static int mx3_camera_add_devic
lags);
@@ -432,7 +441,6 @@ static int mx3_stop_streaming(struct vb2_queue *q)
static struct vb2_ops mx3_videobuf_ops = {
.queue_setup = mx3_videobuf_setup,
- .buf_prepare= mx3_videobuf_prepare,
.buf_queue = mx3_videobuf_queue,
.buf_cleanup= mx3_videobuf_release,
.bu
On Thu, 25 Aug 2011, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Thursday 25 August 2011 18:46:03 Guennadi Liakhovetski wrote:
> > Prepare the mx3_camera friver to support the new VIDIOC_CREATE_BUFS and
> > VIDIOC_PREPARE_BUF ioctl()s. The .queue_setup() vb2 operation must be
> > able to handle
Hi Guennadi,
On Thursday 25 August 2011 18:46:03 Guennadi Liakhovetski wrote:
> Prepare the mx3_camera friver to support the new VIDIOC_CREATE_BUFS and
> VIDIOC_PREPARE_BUF ioctl()s. The .queue_setup() vb2 operation must be
> able to handle buffer sizes, provided by the caller, and the
> .buf_prep
_buffer_done(&buf->vb, VB2_BUF_STATE_ERROR);
}
spin_unlock_irqrestore(&mx3_cam->lock, flags);
@@ -432,7 +439,6 @@ static int mx3_stop_streaming(struct vb2_queue *q)
static struct vb2_ops mx3_videobuf_ops = {
.queue_setup= mx3_videobuf_setup,
- .
Guennadi Liakhovetski wrote:
On Wed, 1 Jul 2009, Valentin Longchamp wrote:
Guennadi Liakhovetski wrote:
While trying all possible skipping / binning combinations of mt9t031 I
came across a problem, that in some configurations the sensor produces
regular horizontal stripes. They depend on windo
On Wed, 1 Jul 2009, Valentin Longchamp wrote:
> Guennadi Liakhovetski wrote:
> >
> > While trying all possible skipping / binning combinations of mt9t031 I
> > came across a problem, that in some configurations the sensor produces
> > regular horizontal stripes. They depend on window geometry, wi
Guennadi Liakhovetski wrote:
This makes mx3-camera and mt9t031 S_CROP and S_FMT implementations V4L2
API compliant.
Signed-off-by: Guennadi Liakhovetski
---
This is definitely only an RFC, it only fixes one single configuration -
i.MX31 (mx3-camera) and MT9T031, and breaks the rest, so, other
On Tue, 30 Jun 2009, Guennadi Liakhovetski wrote:
> This makes mx3-camera and mt9t031 S_CROP and S_FMT implementations V4L2
> API compliant.
>
> Signed-off-by: Guennadi Liakhovetski
> ---
>
> This is definitely only an RFC, it only fixes one single configuration -
>
This makes mx3-camera and mt9t031 S_CROP and S_FMT implementations V4L2
API compliant.
Signed-off-by: Guennadi Liakhovetski
---
This is definitely only an RFC, it only fixes one single configuration -
i.MX31 (mx3-camera) and MT9T031, and breaks the rest, so, other soc-camera
drivers do not
On Fri, Apr 03, 2009 at 01:26:11PM +0200, Guennadi Liakhovetski wrote:
> With the i.MX31 transition to clkdev clock names have changed, but mistakenly
> the "mx3-camera.0" has been registered with a non-NULL connection ID, which is
> not necessary, since this is the only clock,
With the i.MX31 transition to clkdev clock names have changed, but mistakenly
the "mx3-camera.0" has been registered with a non-NULL connection ID, which is
not necessary, since this is the only clock, used by the capture interface
driver. Fix the clock definition and the driver to use
> - mx3_cam->clk = clk_get(&pdev->dev, "csi_clk");
> > > + mx3_cam->clk = clk_get(&pdev->dev, "csi");
> >
> > clk_get(&pdev->dev, NULL) please. The name is only for distinguishing
> > the clocks when there is more than
;
> clk_get(&pdev->dev, NULL) please. The name is only for distinguishing
> the clocks when there is more than one clock per device which isn't the
> case here.
>
> I just see that it's
>
> _REGISTER_CLOCK("mx3-camera.0", "csi", csi_clk)
&g
izeof(*mx3_cam));
>
> - mx3_cam->clk = clk_get(&pdev->dev, "csi_clk");
> + mx3_cam->clk = clk_get(&pdev->dev, "csi");
clk_get(&pdev->dev, NULL) please. The name is only for distinguishing
the clocks when there is more than one clock per devic
With the i.MX31 transition to clkdev clock names have changed, fix the
driver to use the new name.
Signed-off-by: Guennadi Liakhovetski
---
diff --git a/drivers/media/video/mx3_camera.c b/drivers/media/video/mx3_camera.c
index 70629e1..7e6b51d 100644
--- a/drivers/media/video/mx3_camera.c
+++ b/
USB and SDHC storage).
I am currently working on my soc-camera patch queue, which I shall clean
up, complete and push upstream. Then, on top of it, I'll update the
mx3-camera driver. My current version contains a few improvements and
fixes over the original version. You should be able to start wi
33 matches
Mail list logo
