Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-12 Thread Benjamin Larsson
On 11/11/2016 02:55 PM, Mauro Carvalho Chehab wrote: Em Thu, 10 Nov 2016 12:15:39 +0100 Benjamin, Could you please test it? Thanks! Mauro Hi, I the device is in use now. Can't test it with a new tree. I am using an old tree for it. MvH Benjamin Larsson -- To unsubscribe from this list: se

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-11 Thread Jörg Otte
/* rest of packet length low */ > @@ -890,7 +889,7 @@ static int af9005_rc_query(struct dvb_usb_device *d, u32 > * event, int *state) > } > > ret: > - mutex_unlock(&st->data_mutex); > + mutex_unlock(&d->data_mutex); > return ret; >

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-11 Thread Mauro Carvalho Chehab
- THIS_MODULE, &d, adapter_nr); - - if (ret < 0) - return ret; - - st = d->priv; - mutex_init(&st->data_mutex); - - return 0; + return dvb_usb_device_init(intf, &af9005_properties, +

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-10 Thread Jörg Otte
gt; 24 10 eb 1a 49 c7 44 24 08 02 00 00 00 c6 43 RIP [] > __mutex_lock_slowpath+0x6f/0x100 RSP > CR2: > > So, move it to the struct dvb_usb_device and initialize it > before calling the driver's callbacks. > > Reported-by: Jörg Otte > Signed-of

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-10 Thread Mauro Carvalho Chehab
CR2: So, move it to the struct dvb_usb_device and initialize it before calling the driver's callbacks. Reported-by: Jörg Otte Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/usb/dvb-usb/cinergyT2-core.c b/drivers/media/usb/dvb-usb/cinergyT2-core.c index

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-09 Thread Mauro Carvalho Chehab
Em Wed, 9 Nov 2016 19:57:58 + Malcolm Priestley escreveu: > > Yeah, I avoided serializing the logic that detects if the firmware is > > loaded, but forgot that the power control had the same issue. The > > newer dvb usb drivers use the dvb-usb-v2, so I didn't touch this > > code for a while.

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-09 Thread Mauro Carvalho Chehab
Em Wed, 9 Nov 2016 11:07:35 -0800 Linus Torvalds escreveu: > On Wed, Nov 9, 2016 at 3:09 AM, Jörg Otte wrote: > > > > Tried patch with no success. Again a NULL ptr dereferece. > > That patch was pure garbage, I think. Pretty much all the other > drivers that use the same approach will have th

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-09 Thread Malcolm Priestley
get following crash in dvb-usb-cinergyT2 module. Looks like it's commit 5ef8ed0e5608f ("[media] cinergyT2-core: don't do DMA on stack"), which movced the DMA data array from the stack to the "private" pointer. In the process it also added serialization in the form o

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-09 Thread Linus Torvalds
On Wed, Nov 9, 2016 at 3:09 AM, Jörg Otte wrote: > > Tried patch with no success. Again a NULL ptr dereferece. That patch was pure garbage, I think. Pretty much all the other drivers that use the same approach will have the same issue. Adding that init function just for the semaphore is crazy. I

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-09 Thread Jörg Otte
2016-11-08 21:22 GMT+01:00 Mauro Carvalho Chehab : > Em Tue, 8 Nov 2016 10:42:03 -0800 > Linus Torvalds escreveu: > >> On Sun, Nov 6, 2016 at 7:40 AM, Jörg Otte wrote: >> > Since v4.9-rc4 I get following crash in dvb-usb-cinergyT2 module. >> >> Looks lik

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Nov 2016 22:15:24 +0100 Benjamin Larsson escreveu: > On 11/08/2016 09:22 PM, Mauro Carvalho Chehab wrote: > > Em Tue, 8 Nov 2016 10:42:03 -0800 > > Linus Torvalds escreveu: > > > >> On Sun, Nov 6, 2016 at 7:40 AM, Jörg Otte wrote: > >>> Since

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-08 Thread Benjamin Larsson
On 11/08/2016 09:22 PM, Mauro Carvalho Chehab wrote: Em Tue, 8 Nov 2016 10:42:03 -0800 Linus Torvalds escreveu: On Sun, Nov 6, 2016 at 7:40 AM, Jörg Otte wrote: Since v4.9-rc4 I get following crash in dvb-usb-cinergyT2 module. Looks like it's commit 5ef8ed0e5608f ("[media] cine

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Nov 2016 10:42:03 -0800 Linus Torvalds escreveu: > On Sun, Nov 6, 2016 at 7:40 AM, Jörg Otte wrote: > > Since v4.9-rc4 I get following crash in dvb-usb-cinergyT2 module. > > Looks like it's commit 5ef8ed0e5608f ("[media] cinergyT2-core: don't > do

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-08 Thread Linus Torvalds
On Sun, Nov 6, 2016 at 7:40 AM, Jörg Otte wrote: > Since v4.9-rc4 I get following crash in dvb-usb-cinergyT2 module. Looks like it's commit 5ef8ed0e5608f ("[media] cinergyT2-core: don't do DMA on stack"), which movced the DMA data array from the stack to the "private

[v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-06 Thread Jörg Otte
Since v4.9-rc4 I get following crash in dvb-usb-cinergyT2 module. dvb-usb: found a 'TerraTec/qanu USB2.0 Highspeed DVB-T Receiver' in warm state. BUG: unable to handle kernel NULL pointer dereference at (null) IP: [] __mutex_lock_slowpath+0x6f/0x100 PGD 0 Oops: 0002 [#1] S

Re: [linux-review:Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-media-usb-drivers/20161011-182408 3/31] drivers/media/usb/dvb-usb/cinergyT2-core.c:174:2-8: preceding lock on line 169

2016-10-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Oct 2016 23:41:53 +0200 (CEST) Julia Lawall escreveu: > On Tue, 11 Oct 2016, Mauro Carvalho Chehab wrote: > > > Em Tue, 11 Oct 2016 15:16:24 +0200 (CEST) > > Julia Lawall escreveu: > > > > > On Tue, 11 Oct 2016, Julia Lawall wrote: > > > > > > > It looks like a lock may be needed

Re: [linux-review:Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-media-usb-drivers/20161011-182408 3/31] drivers/media/usb/dvb-usb/cinergyT2-core.c:174:2-8: preceding lock on line 169

2016-10-11 Thread Mauro Carvalho Chehab
.@01.org > > Cc: Julia Lawall > > Subject: > > > > [linux-review:Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-medi > > a-usb-drivers/20161011-182408 3/31] > > drivers/media/usb/dvb-usb/cinergyT2-core.c:174:2-8: preceding lock on &g

Re: [linux-review:Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-media-usb-drivers/20161011-182408 3/31] drivers/media/usb/dvb-usb/cinergyT2-core.c:174:2-8: preceding lock on line 169

2016-10-11 Thread Julia Lawall
> julia > > > > > > -- Forwarded message -- > > > Date: Tue, 11 Oct 2016 21:06:18 +0800 > > > From: kbuild test robot > > > To: kbu...@01.org > > > Cc: Julia Lawall > > > Subject: > > > > > >

Re: [linux-review:Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-media-usb-drivers/20161011-182408 3/31] drivers/media/usb/dvb-usb/cinergyT2-core.c:174:2-8: preceding lock on line 169

2016-10-11 Thread Julia Lawall
Cc: Julia Lawall > Subject: > > [linux-review:Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-medi > a-usb-drivers/20161011-182408 3/31] > drivers/media/usb/dvb-usb/cinergyT2-core.c:174:2-8: preceding lock on line > 169 > > CC: kbuild-...@01.org > TO: Ma

[linux-review:Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-media-usb-drivers/20161011-182408 3/31] drivers/media/usb/dvb-usb/cinergyT2-core.c:174:2-8: preceding lock on line 169

2016-10-11 Thread Julia Lawall
-drivers/20161011-182408 3/31] drivers/media/usb/dvb-usb/cinergyT2-core.c:174:2-8: preceding lock on line 169 CC: kbuild-...@01.org TO: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org CC: 0day robot tree: https://github.com/0day-ci/linux Mauro-Carvalho-Chehab/Don-t-use-stack-for

Re: dvb-usb-cinergyT2

2009-02-11 Thread Johannes Engel
Thierry Merle wrote: > another user has got the same problem, except that the led still lights up. > Can you tell us what it the firmware version in your device? > You can see it by doing lsusb -vvv, for the Cinergy T2 entry this is the > "bcdDevice" line. > I have the 1.06 firmware version and it

Re: dvb-usb-cinergyT2

2009-02-11 Thread Thierry Merle
Hello Johannes, Johannes Engel wrote: > Hello! > > Switching to the new kernel 2.6.28 including the new driver for my Terratec > Cinergy T² made the thing almost unusable. > Neither mplayer nor scan resp. w_scan is able to tune the card anymore, not > even the led lights up anymore. Sometimes t

dvb-usb-cinergyT2

2009-02-06 Thread Johannes Engel
Hello! Switching to the new kernel 2.6.28 including the new driver for my Terratec Cinergy T² made the thing almost unusable. Neither mplayer nor scan resp. w_scan is able to tune the card anymore, not even the led lights up anymore. Sometimes tzap manages to get out a proper signal, but not re