Re: USB: change interface to usb_lock_device_for_reset()

2009-01-09 Thread Trent Piepho
On Fri, 9 Jan 2009, Mauro Carvalho Chehab wrote: > On Thu, 8 Jan 2009 21:56:15 -0800 (PST) > Trent Piepho wrote: > > On Thu, 8 Jan 2009, Mike Isely wrote: > > > > Yes... Anyway, this is the real patch. I've added a small comment about > > > > this > > > > change... I'll commit this tomorrow, if y

Re: USB: change interface to usb_lock_device_for_reset()

2009-01-09 Thread Mike Isely
On Fri, 9 Jan 2009, Mauro Carvalho Chehab wrote: > On Thu, 8 Jan 2009 21:56:15 -0800 (PST) > Trent Piepho wrote: > > > On Thu, 8 Jan 2009, Mike Isely wrote: > > > > Yes... Anyway, this is the real patch. I've added a small comment about > > > > this > > > > change... I'll commit this tomorrow,

Re: USB: change interface to usb_lock_device_for_reset()

2009-01-09 Thread Mauro Carvalho Chehab
On Thu, 8 Jan 2009 21:56:15 -0800 (PST) Trent Piepho wrote: > On Thu, 8 Jan 2009, Mike Isely wrote: > > > Yes... Anyway, this is the real patch. I've added a small comment about > > > this > > > change... I'll commit this tomorrow, if you don't have a better > > > suggestion. > > > > Looks good

Re: USB: change interface to usb_lock_device_for_reset()

2009-01-08 Thread Mike Isely
Well that simplifies the ifdef and allows text editors to still see the braces as being balanced, at the expense of uglier code for all current kernel versions. On the other hand this clearly documents the backwards compatible change for all those kernels and won't affect anything going forwa

Re: USB: change interface to usb_lock_device_for_reset()

2009-01-08 Thread Trent Piepho
On Thu, 8 Jan 2009, Mike Isely wrote: > > Yes... Anyway, this is the real patch. I've added a small comment about this > > change... I'll commit this tomorrow, if you don't have a better suggestion. > > Looks good. Or maybe like this? diff -r f01b3897d141 linux/drivers/media/video/pvrusb2/pvrusb2

Re: USB: change interface to usb_lock_device_for_reset()

2009-01-08 Thread Mike Isely
On Fri, 9 Jan 2009, Mauro Carvalho Chehab wrote: > On Thu, 8 Jan 2009 22:42:41 -0600 (CST) > Mike Isely wrote: > > > On Fri, 9 Jan 2009, Mauro Carvalho Chehab wrote: > > > > > On Thu, 8 Jan 2009 22:28:18 -0600 (CST) > > > Mike Isely wrote: > > > > > > > On Thu, 8 Jan 2009, Mike Isely wrote: >

Re: USB: change interface to usb_lock_device_for_reset()

2009-01-08 Thread Mauro Carvalho Chehab
On Thu, 8 Jan 2009 22:42:41 -0600 (CST) Mike Isely wrote: > On Fri, 9 Jan 2009, Mauro Carvalho Chehab wrote: > > > On Thu, 8 Jan 2009 22:28:18 -0600 (CST) > > Mike Isely wrote: > > > > > On Thu, 8 Jan 2009, Mike Isely wrote: > > > > > > > > > > > > > > > On Thu, 8 Jan 2009, Mauro Carvalho C

Re: USB: change interface to usb_lock_device_for_reset()

2009-01-08 Thread Mike Isely
On Fri, 9 Jan 2009, Mauro Carvalho Chehab wrote: > On Thu, 8 Jan 2009 22:28:18 -0600 (CST) > Mike Isely wrote: > > > On Thu, 8 Jan 2009, Mike Isely wrote: > > > > > > > > > > > On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote: > > > > > > > Hi Mike, > > > > > > > > There were an upstream cha

Re: USB: change interface to usb_lock_device_for_reset()

2009-01-08 Thread Mauro Carvalho Chehab
On Thu, 8 Jan 2009 22:28:18 -0600 (CST) Mike Isely wrote: > On Thu, 8 Jan 2009, Mike Isely wrote: > > > > > > > On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote: > > > > > Hi Mike, > > > > > > There were an upstream change usb_lock_device_for_reset() that touched on > > > pvrusb2 driver. I di

Re: USB: change interface to usb_lock_device_for_reset()

2009-01-08 Thread Mike Isely
I expect this weekend to be working through a backlog of pvrusb2 issues > so you might hear more from me soon :-) > > -Mike > > > > > > commit 011b15df465745474e3ec85482633685933ed5a7 > > Author: Alan Stern > > Date: Tue Nov 4 11:29:

Re: USB: change interface to usb_lock_device_for_reset()

2009-01-08 Thread Mike Isely
85482633685933ed5a7 > Author: Alan Stern > Date: Tue Nov 4 11:29:27 2008 -0500 > > USB: change interface to usb_lock_device_for_reset() > > This patch (as1161) changes the interface to > usb_lock_device_for_reset(). The existing interface is apparently no

USB: change interface to usb_lock_device_for_reset()

2009-01-08 Thread Mauro Carvalho Chehab
ov 4 11:29:27 2008 -0500 USB: change interface to usb_lock_device_for_reset() This patch (as1161) changes the interface to usb_lock_device_for_reset(). The existing interface is apparently not very clear, judging from the fact that several of its callers don't use it