Hi Tomasz,
Thanks very much for your careful review.
Reply to the comments see belows.
Any missing please let me know.
On Wed, 2019-08-21 at 19:30 +0900, Tomasz Figa wrote:
> Hi Dongchun,
>
> On Mon, Aug 19, 2019 at 11:43:31AM +0800, dongchun@mediatek.com wrote:
> > From: Dongchun Zhu
> >
Hi Dongchun,
On Thu, Sep 05, 2019 at 05:41:05PM +0800, Dongchun Zhu wrote:
...
> > > + ret = regulator_bulk_enable(OV02A10_NUM_SUPPLIES, ov02a10->supplies);
> > > + if (ret < 0) {
> > > + dev_err(dev, "Failed to enable regulators\n");
> > > + goto disable_clk;
> > > + }
> > > + m
Hi Sakari,
On Mon, 2019-08-19 at 11:30 +0300, Sakari Ailus wrote:
> Hi Dongchun,
>
> Thanks for the update.
>
> On Mon, Aug 19, 2019 at 11:43:31AM +0800, dongchun@mediatek.com wrote:
> > From: Dongchun Zhu
> >
> > This patch adds a V4L2 sub-device driver for OV02A10 image sensor.
> > The O
Hi Tomasz,
On Wed, Aug 21, 2019 at 07:30:38PM +0900, Tomasz Figa wrote:
...
> > +
> > +/*
> > + * xvclk 24Mhz
>
> This seems to assume 24MHz, but the driver allows a range in probe. Is that
> correct?
I think it'd be better to check for an exact frequency: this is board
specific and its exact va
Hi Dongchun,
On Mon, Aug 19, 2019 at 11:43:31AM +0800, dongchun@mediatek.com wrote:
> From: Dongchun Zhu
>
> This patch adds a V4L2 sub-device driver for OV02A10 image sensor.
> The OV02A10 is a 1/5" CMOS sensor from Omnivision,
> which supports output format: 10-bit Raw.
> The OV02A10 has a
Hi Dongchun,
Thanks for the update.
On Mon, Aug 19, 2019 at 11:43:31AM +0800, dongchun@mediatek.com wrote:
> From: Dongchun Zhu
>
> This patch adds a V4L2 sub-device driver for OV02A10 image sensor.
> The OV02A10 is a 1/5" CMOS sensor from Omnivision,
> which supports output format: 10-bit
