Hi
On Tue, Aug 06, 2019 at 04:03:56PM +0200, Marek Vasut wrote:
> On 7/1/19 9:58 AM, Jacopo Mondi wrote:
>
> [...]
>
> >> +#define ISL7998x_REG_P5_H_LINE_CNT_1 ISL7998x_REG(5, 0x3a)
> >> +#define ISL7998x_REG_P5_H_LINE_CNT_2 ISL7998x_REG(5, 0x3b)
> >> +#define ISL7998x_RE
On 7/1/19 10:43 AM, Sakari Ailus wrote:
[...]
>> +{ ISL7998x_REG_P0_CLK_CTL_1, 0x1f },
>> +{ ISL7998x_REG_P0_CLK_CTL_2, 0x43 },
>> +{ ISL7998x_REG_P0_CLK_CTL_3, 0x4f },
>
> It'd be great to see what these magical numbers signify. How about some
> additional #defines for the bits? Same
On 7/1/19 9:58 AM, Jacopo Mondi wrote:
[...]
>> +#define ISL7998x_REG_P5_H_LINE_CNT_1ISL7998x_REG(5, 0x3a)
>> +#define ISL7998x_REG_P5_H_LINE_CNT_2ISL7998x_REG(5, 0x3b)
>> +#define ISL7998x_REG_P5_HIST_LINE_CNT_1 ISL7998x_REG(5, 0x3c)
>> +#define ISL799
One more comment...
On Mon, May 20, 2019 at 10:18:12PM +0200, Marek Vasut wrote:
...
> +static int isl7998x_set_fmt(struct v4l2_subdev *sd,
> + struct v4l2_subdev_pad_config *cfg,
> + struct v4l2_subdev_format *format)
> +{
> + struct isl7998x *isl7998x = sd_to_isl7998x
Hi Marek,
Thank you for the patchset --- and my apologies for reviewing it so late.
On Mon, May 20, 2019 at 10:18:12PM +0200, Marek Vasut wrote:
> Add driver for the Intersil ISL7998x BT656-to-MIPI-CSI2 video decoder.
> This chip supports 1/2/4 analog video inputs and converts them into
> 1/2/4 V
Hello Marek,
long time due review, sorry about this.
On Mon, May 20, 2019 at 10:18:12PM +0200, Marek Vasut wrote:
> Add driver for the Intersil ISL7998x BT656-to-MIPI-CSI2 video decoder.
analog to CSI-2 or analog to BT.656 if you want to support both chip
versions.
> This chip supports 1/2/4
