On Wednesday 18 March 2009 21:48:45 Trent Piepho wrote:
> On Sun, 15 Mar 2009, Hans Verkuil wrote:
> > On Sunday 15 March 2009 18:28:42 Trent Piepho wrote:
> > > On Sun, 15 Mar 2009, Hans Verkuil wrote:
> > > > On Sunday 15 March 2009 17:04:43 Trent Piepho wrote:
> > > > > On Sun, 15 Mar 2009, Hans
On Sun, 15 Mar 2009, Hans Verkuil wrote:
> On Sunday 15 March 2009 18:28:42 Trent Piepho wrote:
> > On Sun, 15 Mar 2009, Hans Verkuil wrote:
> > > On Sunday 15 March 2009 17:04:43 Trent Piepho wrote:
> > > > On Sun, 15 Mar 2009, Hans Verkuil wrote:
> > > > > Hi Mauro,
> > > > >
> > > > > Can you re
On Mon, 16 Mar 2009, Hans Verkuil wrote:
> >> +++ b/linux/drivers/media/video/bt8xx/bttvp.h Sun Mar 15 13:07:15 2009
> >> +0100
> >> @@ -331,6 +331,7 @@ struct bttv {
> >>unsigned int tuner_type; /* tuner chip type */
> >>unsigned int tda9887_conf;
> >>unsigned int svhs, dig;
> >>
> On Mon, 16 Mar 2009 14:04:19 +0100 (CET)
> "Hans Verkuil" wrote:
>
>>
>> >> > Based on this principle, IMO, the probing function should, by
>> default,
>> >> > probe
>> >> > for tvaudio, if it doesn't find another audio device. You may
>> >> eventually
>> >> > ask
>> >> > for people to report,
On Mon, 16 Mar 2009 14:04:19 +0100 (CET)
"Hans Verkuil" wrote:
>
> >> > Based on this principle, IMO, the probing function should, by default,
> >> > probe
> >> > for tvaudio, if it doesn't find another audio device. You may
> >> eventually
> >> > ask
> >> > for people to report, to warn us that
>> > Based on this principle, IMO, the probing function should, by default,
>> > probe
>> > for tvaudio, if it doesn't find another audio device. You may
>> eventually
>> > ask
>> > for people to report, to warn us that the board entry is broken, but
>> we
>> > shouln't intentionally break a devic
On Mon, 16 Mar 2009 13:16:06 +0100 (CET)
"Hans Verkuil" wrote:
> >>if (BTTV_BOARD_UNKNOWN == btv->c.type) {
> >>bttv_readee(btv,eeprom_data,0xa0);
> >> @@ -3502,8 +3501,13 @@ void __devinit bttv_init_card2(struct bt
> >>struct tuner_setup tun_setup;
> >>
> >>
> On Mon, 16 Mar 2009 08:09:44 -0300
> Mauro Carvalho Chehab wrote:
>
>> > >> > > > > Can you review my ~hverkuil/v4l-dvb-bttv2 tree?
>
> Ok, it was not that hard. It follows my comments.
>
>> --- a/linux/drivers/media/video/bt8xx/bttv-cards.c Sun Mar 15 10:53:32
>> 2009 +0100
>> +++ b/linux/dr
On Mon, 16 Mar 2009 08:09:44 -0300
Mauro Carvalho Chehab wrote:
> > >> > > > > Can you review my ~hverkuil/v4l-dvb-bttv2 tree?
Ok, it was not that hard. It follows my comments.
> --- a/linux/drivers/media/video/bt8xx/bttv-cards.cSun Mar 15 10:53:32
> 2009 +0100
> +++ b/linux/drivers/media/
On Mon, 16 Mar 2009 11:44:12 +0100 (CET)
"Hans Verkuil" wrote:
>
> > Hi Hans,
> >
> > On Sun, 15 Mar 2009 19:53:06 +0100
> > Hans Verkuil wrote:
> >
> >> On Sunday 15 March 2009 18:28:42 Trent Piepho wrote:
> >> > On Sun, 15 Mar 2009, Hans Verkuil wrote:
> >> > > On Sunday 15 March 2009 17:04:4
On Mon, 16 Mar 2009 11:44:12 +0100 (CET)
"Hans Verkuil" wrote:
> >> > What new module parameters did you add?
> >>
> >> tvaudio to override the 'needs_tvaudio' from the card definition.
> >
> > At least on the first kernel with the new driver, IMO, the default should
> > for
> > this option shoul
> On Sun, 15 Mar 2009 13:24:00 +0100
> Hans Verkuil wrote:
>
>> Hi Mauro,
>>
>> Can you review my ~hverkuil/v4l-dvb-bttv2 tree?
>>
>> It converts this driver to v4l2_subdev, and as far as I can see it works
>> and
>> should probe all the different audio devices in the correct and safe
>> order.
>
> Hi Hans,
>
> On Sun, 15 Mar 2009 19:53:06 +0100
> Hans Verkuil wrote:
>
>> On Sunday 15 March 2009 18:28:42 Trent Piepho wrote:
>> > On Sun, 15 Mar 2009, Hans Verkuil wrote:
>> > > On Sunday 15 March 2009 17:04:43 Trent Piepho wrote:
>> > > > On Sun, 15 Mar 2009, Hans Verkuil wrote:
>> > > > >
On Sun, 15 Mar 2009 13:24:00 +0100
Hans Verkuil wrote:
> Hi Mauro,
>
> Can you review my ~hverkuil/v4l-dvb-bttv2 tree?
>
> It converts this driver to v4l2_subdev, and as far as I can see it works and
> should probe all the different audio devices in the correct and safe order.
>
> I kept thin
Hi Hans,
On Sun, 15 Mar 2009 19:53:06 +0100
Hans Verkuil wrote:
> On Sunday 15 March 2009 18:28:42 Trent Piepho wrote:
> > On Sun, 15 Mar 2009, Hans Verkuil wrote:
> > > On Sunday 15 March 2009 17:04:43 Trent Piepho wrote:
> > > > On Sun, 15 Mar 2009, Hans Verkuil wrote:
> > > > > Hi Mauro,
> >
On Monday 16 March 2009 00:25:44 Trent Piepho wrote:
> On Sun, 15 Mar 2009, Andy Walls wrote:
> > On Sun, 2009-03-15 at 10:28 -0700, Trent Piepho wrote:
> > > Why are the i2c addresses from various i2c chips moved into the bttv
> > > driver? Doesn't it make more sense that the addresses for chip X
On Sun, 15 Mar 2009, Andy Walls wrote:
> On Sun, 2009-03-15 at 10:28 -0700, Trent Piepho wrote:
>
> > Why are the i2c addresses from various i2c chips moved into the bttv
> > driver? Doesn't it make more sense that the addresses for chip X should be
> > in the driver for chip X?
>
> One reason tha
On Sun, 2009-03-15 at 10:28 -0700, Trent Piepho wrote:
> Why are the i2c addresses from various i2c chips moved into the bttv
> driver? Doesn't it make more sense that the addresses for chip X should be
> in the driver for chip X?
One reason that this may be undesirable is that the devices can b
On Sunday 15 March 2009 18:28:42 Trent Piepho wrote:
> On Sun, 15 Mar 2009, Hans Verkuil wrote:
> > On Sunday 15 March 2009 17:04:43 Trent Piepho wrote:
> > > On Sun, 15 Mar 2009, Hans Verkuil wrote:
> > > > Hi Mauro,
> > > >
> > > > Can you review my ~hverkuil/v4l-dvb-bttv2 tree?
> > >
> > > It wo
On Sun, 15 Mar 2009, Hans Verkuil wrote:
> On Sunday 15 March 2009 17:04:43 Trent Piepho wrote:
> > On Sun, 15 Mar 2009, Hans Verkuil wrote:
> > > Hi Mauro,
> > >
> > > Can you review my ~hverkuil/v4l-dvb-bttv2 tree?
> >
> > It would be a lot easier if you would provide patch descriptions.
>
> Here
On Sunday 15 March 2009 17:04:43 Trent Piepho wrote:
> On Sun, 15 Mar 2009, Hans Verkuil wrote:
> > Hi Mauro,
> >
> > Can you review my ~hverkuil/v4l-dvb-bttv2 tree?
>
> It would be a lot easier if you would provide patch descriptions.
Here it is:
- bttv: convert to v4l2_subdev.
That's all it do
On Sun, 15 Mar 2009, Hans Verkuil wrote:
> Hi Mauro,
>
> Can you review my ~hverkuil/v4l-dvb-bttv2 tree?
It would be a lot easier if you would provide patch descriptions.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
Hi Mauro,
Can you review my ~hverkuil/v4l-dvb-bttv2 tree?
It converts this driver to v4l2_subdev, and as far as I can see it works and
should probe all the different audio devices in the correct and safe order.
I kept things as simple as possible in order to make a review easy.
There is only o
23 matches
Mail list logo
