Re: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-04-10 Thread Tomasz Figa
Hi Andy, On Wed, Apr 11, 2018 at 12:54 AM Yeh, Andy wrote: > Hi Jacopo, > Excuse for late reply, we were busy in past weeks for major milestone. Please kindly check the revised V7 which has been uploaded. > https://patchwork.linuxtv.org/patch/48589/ > Responded to your comments as below. > Cc

RE: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-04-10 Thread Yeh, Andy
Message- From: jacopo mondi [mailto:jac...@jmondi.org] Sent: Tuesday, March 20, 2018 6:28 PM To: Yeh, Andy Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; devicet...@vger.kernel.org; Chiang, AlanX Subject: Re: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver Hi Andy

RE: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-03-26 Thread Yeh, Andy
...@vger.kernel.org; Chiang, AlanX Subject: Re: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver Hi Andy, On Wed, Mar 21, 2018 at 03:58:42PM +, Yeh, Andy wrote: > Thanks for the comments. A quick question first. For the reset we need some > time to address. > > -Orig

Re: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-03-21 Thread sakari.ai...@linux.intel.com
6:28 PM > To: Yeh, Andy > Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; > devicet...@vger.kernel.org; Chiang, AlanX > Subject: Re: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver > > Hi Andy, >a few comments on you patch below... > > O

RE: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-03-21 Thread Yeh, Andy
...@vger.kernel.org; Chiang, AlanX Subject: Re: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver Hi Andy, a few comments on you patch below... On Sat, Mar 17, 2018 at 01:05:26AM +0800, Andy Yeh wrote: > From: Alan Chiang > a/drivers/media/i2c/dw9807.c b/drivers/media/i2c/dw9807.c ne

Re: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-03-20 Thread Sakari Ailus
Hi Jacopo, On Tue, Mar 20, 2018 at 11:28:17AM +0100, jacopo mondi wrote: ... > > +static int dw9807_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh) > > +{ > > + int rval; > > + > > + rval = pm_runtime_get_sync(sd->dev); > > + if (rval < 0) { > > + pm_runtime_put_noidle(sd->

Re: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-03-20 Thread jacopo mondi
Hi Andy, a few comments on you patch below... On Sat, Mar 17, 2018 at 01:05:26AM +0800, Andy Yeh wrote: > From: Alan Chiang > > DW9807 is a 10 bit DAC from Dongwoon, designed for linear > control of voice coil motor. > > This driver creates a V4L2 subdevice and > provides control to set the de

RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-03-16 Thread Andy Yeh
From: Alan Chiang DW9807 is a 10 bit DAC from Dongwoon, designed for linear control of voice coil motor. This driver creates a V4L2 subdevice and provides control to set the desired focus. Signed-off-by: Andy Yeh --- since v1: - changed author. since v2: - addressed outstanding comments. - ena