Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-10 Thread Hans Verkuil
> Hans Verkuil wrote: >>> Sergio has posted earlier a patchset containing a driver for using the >>> ISP to process images from memory to memory. The ISP driver is used >>> roughly the same way as with the omap34xxcam and real sensors. The >>> interface towards the userspace offered by the driver,

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-10 Thread Sakari Ailus
Hans Verkuil wrote: Sergio has posted earlier a patchset containing a driver for using the ISP to process images from memory to memory. The ISP driver is used roughly the same way as with the omap34xxcam and real sensors. The interface towards the userspace offered by the driver, however, is diff

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-05 Thread Hans Verkuil
On Thursday 05 March 2009 21:11:02 Sakari Ailus wrote: > Hans Verkuil wrote: > >> Situation 1 > >> - Instance1: Select sensor 1, and Do queue/dequeue of buffers. > >> - Instance2: If sensor 1 is currently selected, Begin loop requesting > >> internally collected OMAP3ISP statistics (with V4L2 pri

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-05 Thread Sakari Ailus
Hans Verkuil wrote: Situation 1 - Instance1: Select sensor 1, and Do queue/dequeue of buffers. - Instance2: If sensor 1 is currently selected, Begin loop requesting internally collected OMAP3ISP statistics (with V4L2 private based IOCTLs) for performing user-side Auto-exposure, Auto White Balan

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Hans Verkuil
...@maxwell.research.nokia.com; DongSoo(Nathaniel) Kim; > > Hiremath, Vaibhav; Toivonen Tuukka.O (Nokia-D/Oulu); linux- > > o...@vger.kernel.org; Nagalla, Hari; linux-media@vger.kernel.org > > Subject: Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver > > > > On Wednes

RE: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread hermann pitton
Am Mittwoch, den 04.03.2009, 15:42 -0800 schrieb Trent Piepho: > On Wed, 4 Mar 2009, Aguirre Rodriguez, Sergio Alberto wrote: > > As what I understand, we have 2 possible situations for multiple opens here: > > > > Situation 1 > > - Instance1: Select sensor 1, and Do queue/dequeue of buffers. > >

RE: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Trent Piepho
On Wed, 4 Mar 2009, Aguirre Rodriguez, Sergio Alberto wrote: > As what I understand, we have 2 possible situations for multiple opens here: > > Situation 1 > - Instance1: Select sensor 1, and Do queue/dequeue of buffers. > - Instance2: If sensor 1 is currently selected, Begin loop requesting > i

RE: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Aguirre Rodriguez, Sergio Alberto
/Oulu); linux- > o...@vger.kernel.org; Nagalla, Hari; linux-media@vger.kernel.org > Subject: Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver > > On Wednesday 04 March 2009 22:46:07 Aguirre Rodriguez, Sergio Alberto > wrote: > > > -Original Message- > >

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Hans Verkuil
ngSoo(Nathaniel) Kim; Hiremath, Vaibhav; Toivonen Tuukka.O > > (Nokia- D/Oulu); Aguirre Rodriguez, Sergio Alberto; > > linux-o...@vger.kernel.org; Nagalla, Hari; linux-media@vger.kernel.org > > Subject: Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver > > > > On Wednesday 0

RE: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Aguirre Rodriguez, Sergio Alberto
o Alberto; linux-o...@vger.kernel.org; > Nagalla, Hari; linux-media@vger.kernel.org > Subject: Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver > > On Wednesday 04 March 2009 20:22:04 Sakari Ailus wrote: > > Hans Verkuil wrote: > > > On Wednesday 04 March 2009 01:42:13 D

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Hans Verkuil
On Wednesday 04 March 2009 20:22:04 Sakari Ailus wrote: > Hans Verkuil wrote: > > On Wednesday 04 March 2009 01:42:13 DongSoo(Nathaniel) Kim wrote: > >> Thank you for your kind explanation Hans. > >> > >> Problem is omap3 camera subsystem is making device node for every int > >> device attached to

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Sakari Ailus
Hans Verkuil wrote: On Wednesday 04 March 2009 01:42:13 DongSoo(Nathaniel) Kim wrote: Thank you for your kind explanation Hans. Problem is omap3 camera subsystem is making device node for every int device attached to it. That's wrong. Multiple devices should only be created if they can all be

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Hans Verkuil
> On Wednesday 04 March 2009 09:39:48 ext Hans Verkuil wrote: >> BTW, do I understand correctly that e.g. lens drivers also get their >> own /dev/videoX node? Please tell me I'm mistaken! Since that would be >> so >> very wrong. > > You're mistaken :) > > With the v4l2-int-interface/omap34xxcam ca

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-03 Thread Tuukka.O Toivonen
On Wednesday 04 March 2009 09:39:48 ext Hans Verkuil wrote: > BTW, do I understand correctly that e.g. lens drivers also get their > own /dev/videoX node? Please tell me I'm mistaken! Since that would be so > very wrong. You're mistaken :) With the v4l2-int-interface/omap34xxcam camera driver o

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-03 Thread Hans Verkuil
..(Am I > >> right?) > >> Cheers, > >> > >> Nate > >> > >> On Tue, Mar 3, 2009 at 12:53 PM, Hiremath, Vaibhav > > > > wrote: > >> > Thanks, > >> > Vaibhav Hiremath > >> > > >> >> -

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-03 Thread DongSoo(Nathaniel) Kim
gt; -Original Message- >> >> From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- >> >> ow...@vger.kernel.org] On Behalf Of DongSoo(Nathaniel) Kim >> >> Sent: Tuesday, March 03, 2009 8:18 AM >> >> To: Tuukka.O Toivonen >> >> Cc:

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-02 Thread Sakari Ailus
DongSoo(Nathaniel) Kim wrote: This is quite confusing because in case of mine, I wanna make switchable between different cameras attached to omap camera interface. Currently the ISP doesn't have a very neat way of controlling its use. In the recent patches, there's a change that allows just on

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-02 Thread Hans Verkuil
Original Message- > >> From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > >> ow...@vger.kernel.org] On Behalf Of DongSoo(Nathaniel) Kim > >> Sent: Tuesday, March 03, 2009 8:18 AM > >> To: Tuukka.O Toivonen > >> Cc: Aguirre Rodriguez, Sergio A

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-02 Thread DongSoo(Nathaniel) Kim
inux-o...@vger.kernel.org; >> Ailus Sakari (Nokia-D/Helsinki); Nagalla, Hari >> Subject: Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver >> >> Hi Tuukka, >> >> I understand that it is a huge thing to support VIDIOC_S_INPUT. >> But without that, we don't have

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-13 Thread DongSoo(Nathaniel) Kim
Hi! Sakari. On Fri, Feb 13, 2009 at 7:02 PM, Sakari Ailus wrote: > DongSoo Kim wrote: >> >> Thank you for your comment. >> >> BTW, what should I do if I would rather use external ISP device than >> OMAP3 internal ISP feature? >> >> You said that you just have raw sensors by now, so you mean this

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-13 Thread DongSoo(Nathaniel) Kim
Hi Arun. I appreciate your helpful words! For the meantime, I need a concrete driver for my camera module first and I'm still working on it. I wish I could post my work as a patch ASAP :) Wish me luck! Cheers, Nate On Fri, Feb 13, 2009 at 6:31 PM, Arun KS wrote: > On Thu, Feb 12, 2009 at 1:22

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-13 Thread Sakari Ailus
DongSoo Kim wrote: Thank you for your comment. BTW, what should I do if I would rather use external ISP device than OMAP3 internal ISP feature? You said that you just have raw sensors by now, so you mean this patch is not verified working with some ISP modules? I haven't verified it myself. O

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-13 Thread Arun KS
On Thu, Feb 12, 2009 at 1:22 PM, DongSoo Kim wrote: > Thank you for your comment. > > BTW, what should I do if I would rather use external ISP device than > OMAP3 internal ISP feature? > > You said that you just have raw sensors by now, so you mean this patch > is not verified working with some IS

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-11 Thread DongSoo Kim
Thank you for your comment. BTW, what should I do if I would rather use external ISP device than OMAP3 internal ISP feature? You said that you just have raw sensors by now, so you mean this patch is not verified working with some ISP modules? I'm testing your patch on my own omap3 target board w

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-11 Thread Sakari Ailus
DongSoo Kim wrote: Hello. Hi, and thanks for the comments! +static int omap34xxcam_open(struct inode *inode, struct file *file) +{ + if (atomic_inc_return(&vdev->users) == 1) { + isp_get(); + if (omap34xxcam_slave_power_set(vdev, V4L2_POWER_ON, +

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-10 Thread DongSoo Kim
Hello. +static int omap34xxcam_open(struct inode *inode, struct file *file) +{ + if (atomic_inc_return(&vdev->users) == 1) { + isp_get(); + if (omap34xxcam_slave_power_set(vdev, V4L2_POWER_ON, + OMAP34XXCAM_SLAVE_PO

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-02-05 Thread DongSoo Kim
Hello. This could be something trivial. On Tue, Jan 13, 2009 at 11:03 AM, Aguirre Rodriguez, Sergio Alberto wrote: > +/** > + * struct omap34xxcam_hw_config - struct for vidioc_int_g_priv ioctl > + * @xclk: OMAP34XXCAM_XCLK_A or OMAP34XXCAM_XCLK_B > + * @sensor_isp: Is sensor smart/SOC or raw >

Re: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-01-12 Thread Hans Verkuil
On Tuesday 13 January 2009 03:03:34 Aguirre Rodriguez, Sergio Alberto wrote: > Signed-off-by: Sakari Ailus > Signed-off-by: Sergio Aguirre > --- > drivers/media/video/Kconfig |8 + > drivers/media/video/Makefile |2 + > drivers/media/video/omap34xxcam.c | 2017 > ++