Re: [PATCHv10 6/8] FMTx: si4713: Add files to handle si4713 i2c device

2009-07-25 Thread Eduardo Valentin
On Sat, Jul 25, 2009 at 04:39:18PM +0200, ext Hans Verkuil wrote: > On Saturday 25 July 2009 15:25:21 Eduardo Valentin wrote: > > On Sat, Jul 25, 2009 at 03:33:55PM +0200, ext Hans Verkuil wrote: > > > On Saturday 25 July 2009 15:29:38 ext-eero.nurkk...@nokia.com wrote: > > > > > > > > > I'm surpr

Re: [PATCHv10 6/8] FMTx: si4713: Add files to handle si4713 i2c device

2009-07-25 Thread Hans Verkuil
On Saturday 25 July 2009 15:25:21 Eduardo Valentin wrote: > On Sat, Jul 25, 2009 at 03:33:55PM +0200, ext Hans Verkuil wrote: > > On Saturday 25 July 2009 15:29:38 ext-eero.nurkk...@nokia.com wrote: > > > > > > > I'm surprised at these MAX string lengths. Looking at the RDS standard > > > > it >

Re: [PATCHv10 6/8] FMTx: si4713: Add files to handle si4713 i2c device

2009-07-25 Thread Eduardo Valentin
On Sat, Jul 25, 2009 at 03:33:55PM +0200, ext Hans Verkuil wrote: > On Saturday 25 July 2009 15:29:38 ext-eero.nurkk...@nokia.com wrote: > > > > > I'm surprised at these MAX string lengths. Looking at the RDS standard it > > > seems that the max length for the PS_NAME is 8 and for RADIO_TEXT it is

Re: [PATCHv10 6/8] FMTx: si4713: Add files to handle si4713 i2c device

2009-07-25 Thread Hans Verkuil
On Saturday 25 July 2009 15:29:38 ext-eero.nurkk...@nokia.com wrote: > > > I'm surprised at these MAX string lengths. Looking at the RDS standard it > > seems that the max length for the PS_NAME is 8 and for RADIO_TEXT it is > > either 32 (2A group) or 64 (2B group). I don't know which group the s

Re: [PATCHv10 6/8] FMTx: si4713: Add files to handle si4713 i2c device

2009-07-25 Thread Eduardo Valentin
On Sat, Jul 25, 2009 at 03:31:29PM +0200, ext Hans Verkuil wrote: > On Saturday 25 July 2009 15:15:24 Eduardo Valentin wrote: > > On Sat, Jul 25, 2009 at 03:20:53PM +0200, ext Hans Verkuil wrote: > > > > + switch (control->id) { > > > > + case V4L2_CID_RDS_TX_PS_NAME: > > > > +

Re: [PATCHv10 6/8] FMTx: si4713: Add files to handle si4713 i2c device

2009-07-25 Thread Hans Verkuil
On Saturday 25 July 2009 15:15:24 Eduardo Valentin wrote: > On Sat, Jul 25, 2009 at 03:20:53PM +0200, ext Hans Verkuil wrote: > > > + switch (control->id) { > > > + case V4L2_CID_RDS_TX_PS_NAME: > > > + if (strlen(sdev->rds_info.ps_name) + 1 > control->length) { > > > +

RE: [PATCHv10 6/8] FMTx: si4713: Add files to handle si4713 i2c device

2009-07-25 Thread ext-Eero.Nurkkala
> I'm surprised at these MAX string lengths. Looking at the RDS standard it > seems that the max length for the PS_NAME is 8 and for RADIO_TEXT it is > either 32 (2A group) or 64 (2B group). I don't know which group the si4713 > uses. > > Can you clarify how this is used? > > Regards, > >