RE: [PATCH v9.1] media: imx258: Add imx258 camera sensor driver

2018-03-25 Thread Yeh, Andy
, Jim Subject: Re: [PATCH v9.1] media: imx258: Add imx258 camera sensor driver On Fri, Mar 23, 2018 at 11:08:11PM +0900, Tomasz Figa wrote: > On Fri, Mar 23, 2018 at 10:50 PM, Sakari Ailus > wrote: > > Hi Tomasz, > > > > On Fri, Mar 23, 2018 at 08:43:50PM +0900, Tomasz

Re: [PATCH v9.1] media: imx258: Add imx258 camera sensor driver

2018-03-23 Thread Sakari Ailus
On Fri, Mar 23, 2018 at 11:08:11PM +0900, Tomasz Figa wrote: > On Fri, Mar 23, 2018 at 10:50 PM, Sakari Ailus > wrote: > > Hi Tomasz, > > > > On Fri, Mar 23, 2018 at 08:43:50PM +0900, Tomasz Figa wrote: > >> Hi Andy, > >> > >> Some issues found when reviewing cherry pick of this patch to Chrome >

Re: [PATCH v9.1] media: imx258: Add imx258 camera sensor driver

2018-03-23 Thread Tomasz Figa
On Fri, Mar 23, 2018 at 10:50 PM, Sakari Ailus wrote: > Hi Tomasz, > > On Fri, Mar 23, 2018 at 08:43:50PM +0900, Tomasz Figa wrote: >> Hi Andy, >> >> Some issues found when reviewing cherry pick of this patch to Chrome >> OS kernel. Please see inline. >> >> On Sat, Mar 17, 2018 at 1:38 AM, Andy Ye

Re: [PATCH v9.1] media: imx258: Add imx258 camera sensor driver

2018-03-23 Thread Sakari Ailus
Hi Tomasz, On Fri, Mar 23, 2018 at 08:43:50PM +0900, Tomasz Figa wrote: > Hi Andy, > > Some issues found when reviewing cherry pick of this patch to Chrome > OS kernel. Please see inline. > > On Sat, Mar 17, 2018 at 1:38 AM, Andy Yeh wrote: > > [snip] > > > + case V4L2_CID_VBLANK: > > +

Re: [PATCH v9.1] media: imx258: Add imx258 camera sensor driver

2018-03-23 Thread Tomasz Figa
Hi Andy, Some issues found when reviewing cherry pick of this patch to Chrome OS kernel. Please see inline. On Sat, Mar 17, 2018 at 1:38 AM, Andy Yeh wrote: [snip] > + case V4L2_CID_VBLANK: > + /* > +* Auto Frame Length Line Control is enabled by default. >

Re: [PATCH v9.1] media: imx258: Add imx258 camera sensor driver

2018-03-19 Thread kbuild test robot
Hi Jason, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6 next-20180319] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/co