Re: [PATCH v5 4/6] V4L: Events: Add backend

2010-02-22 Thread Hans Verkuil
On Sunday 21 February 2010 21:57:47 Sakari Ailus wrote: > Hans Verkuil wrote: > > Hi Sakari, > > Hi Hans, > > And many thanks for the comments again! > > > Here are some more comments. > > > ... > >> + > >> +static void v4l2_event_unsubscribe_all(struct v4l2_fh *fh) > >> +{ > >> + struct v4l2

Re: [PATCH v5 4/6] V4L: Events: Add backend

2010-02-21 Thread Sakari Ailus
Hans Verkuil wrote: > Hi Sakari, Hi Hans, And many thanks for the comments again! > Here are some more comments. > ... >> +int v4l2_event_dequeue(struct v4l2_fh *fh, struct v4l2_event *event) >> +{ >> +struct v4l2_events *events = fh->events; >> +struct v4l2_kevent *kev; >> +unsigne

Re: [PATCH v5 4/6] V4L: Events: Add backend

2010-02-21 Thread Sakari Ailus
Aguirre, Sergio wrote: > Heippa! Hi, Sergio! Your lines seem to be over 80 characters long. :I ... >> +int v4l2_event_dequeue(struct v4l2_fh *fh, struct v4l2_event *event) >> +{ >> +struct v4l2_events *events = fh->events; >> +struct v4l2_kevent *kev; >> +unsigned long flags; >> + >>

Re: [PATCH v5 4/6] V4L: Events: Add backend

2010-02-20 Thread Hans Verkuil
Hi Sakari, Here are some more comments. On Friday 19 February 2010 20:21:58 Sakari Ailus wrote: > Add event handling backend to V4L2. The backend handles event subscription > and delivery to file handles. Event subscriptions are based on file handle. > Events may be delivered to all subscribed fi

RE: [PATCH v5 4/6] V4L: Events: Add backend

2010-02-19 Thread Aguirre, Sergio
Heippa! > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Sakari Ailus > Sent: Friday, February 19, 2010 1:22 PM > To: linux-media@vger.kernel.org > Cc: hverk...@xs4all.nl; laurent.pinch...@ideasonboard.com; iiva...@mm