Re: [PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-22 Thread Sakari Ailus
On Mon, Jan 22, 2018 at 10:37:43AM +0200, Sakari Ailus wrote: > Hi Andy, > > On Mon, Jan 22, 2018 at 08:03:23AM +, Yeh, Andy wrote: > > Hi Sakari, Tomasz, > > > > As below discussion that other drivers are with this pattern, I would > > prefer to defer to address the concern in later discuss

Re: [PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-22 Thread Sakari Ailus
Hi Andy, On Mon, Jan 22, 2018 at 08:03:23AM +, Yeh, Andy wrote: > Hi Sakari, Tomasz, > > As below discussion that other drivers are with this pattern, I would prefer > to defer to address the concern in later discussion with you and owners of > other sensors. > > Thanks a lot. I thought o

Re: [PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-22 Thread Sakari Ailus
On Mon, Jan 22, 2018 at 08:03:23AM +, Yeh, Andy wrote: > Hi Sakari, Tomasz, > > As below discussion that other drivers are with this pattern, I would > prefer to defer to address the concern in later discussion with you and > owners of other sensors. > > Thanks a lot. Works for me. -- Saka

RE: [PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-22 Thread Yeh, Andy
...@linux.intel.com] Sent: Friday, January 19, 2018 5:18 PM To: Yeh, Andy Cc: Tomasz Figa ; Linux Media Mailing List Subject: Re: [PATCH v4] media: imx258: Add imx258 camera sensor driver Hi Andy, On Fri, Jan 19, 2018 at 07:29:46AM +, Yeh, Andy wrote: > Thanks Tomasz, > > Agree with your poi

Re: [PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-19 Thread Sakari Ailus
Hi Andy, On Fri, Jan 19, 2018 at 07:29:46AM +, Yeh, Andy wrote: > Thanks Tomasz, > > Agree with your point, if so, we could just change as below with a simple > check of streaming flag. > And for Sakari, do you agree with Tomasz's comment? > > Kindly review and I would send v5 with the chan

RE: [PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-18 Thread Yeh, Andy
break; } - pm_runtime_put(&client->dev); - return ret; } Regards, Andy -Original Message- From: Tomasz Figa [mailto:tf...@chromium.org] Sent: Friday, January 19, 2018 12:18 PM To: Yeh, Andy Cc: Linux Media Mailing List ; Sakari Ailus Subject:

Re: [PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-18 Thread Tomasz Figa
Hi Andy, Thanks for the patch. Please see my comments inline. On Fri, Jan 19, 2018 at 12:37 PM, Andy Yeh wrote: > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Andy Yeh > --