RE: [PATCH v17 08/13] davinci: eliminate use of IO_ADDRESS() on sysmod

2011-03-22 Thread Nori, Sekhar
On Tue, Mar 22, 2011 at 18:45:03, Arnd Bergmann wrote: > On Tuesday 22 March 2011, Nori, Sekhar wrote: > > .. but forgot to fix this. There is nothing wrong with > > using writel, but it doesn't fit into what the subject > > of this patch is. > > Well, to be more exact, the __raw_writel was actual

Re: [PATCH v17 08/13] davinci: eliminate use of IO_ADDRESS() on sysmod

2011-03-22 Thread Arnd Bergmann
On Tuesday 22 March 2011, Nori, Sekhar wrote: > .. but forgot to fix this. There is nothing wrong with > using writel, but it doesn't fit into what the subject > of this patch is. Well, to be more exact, the __raw_writel was actually wrong here and it should be writel(), but it's certainly better

RE: [PATCH v17 08/13] davinci: eliminate use of IO_ADDRESS() on sysmod

2011-03-22 Thread Nori, Sekhar
On Tue, Mar 15, 2011 at 19:28:43, Hadli, Manjunath wrote: > Current devices.c file has a number of instances where > IO_ADDRESS() is used for system module register > access. Eliminate this in favor of a ioremap() > based access. > > Consequent to this, a new global pointer davinci_sysmodbase > ha