Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-15 Thread Sakari Ailus
8:48 PM > > To: Zheng, Jian Xu > > Cc: Chen, JasonX Z ; Tomasz Figa > > ; Yeh, Andy ; Linux Media > > Mailing List ; Chiang, AlanX > > ; Qiu, Tian Shu > > Subject: Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver > > > > On Thu, M

RE: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-14 Thread Zheng, Jian Xu
Media > Mailing List ; Chiang, AlanX > ; Qiu, Tian Shu > Subject: Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver > > On Thu, May 10, 2018 at 11:08:43AM +, Zheng, Jian Xu wrote: > > Hi Sakari & Jason, > > > > > -Original Message- >

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-12 Thread Tomasz Figa
y > > > > ; Linux Media Mailing List > > > me...@vger.kernel.org>; Sakari Ailus ; > > Chiang, > > > > AlanX > > > > Subject: Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver > > > > > > > > On Thu, May 10, 2018 at 3:56 P

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-12 Thread Sakari Ailus
...@vger.kernel.org] On Behalf Of Tomasz Figa > > > Sent: Thursday, May 10, 2018 3:04 PM > > > To: Zheng, Jian Xu > > > Cc: Chen, JasonX Z ; Yeh, Andy > > > ; Linux Media Mailing List > > me...@vger.kernel.org>; Sakari Ailus ; > Chiang, > > > A

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-12 Thread Sakari Ailus
2018 5:43 PM > > To: Chen, JasonX Z > > Cc: Tomasz Figa ; Yeh, Andy ; > > Linux Media Mailing List ; Chiang, AlanX > > > > Subject: Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver > > > > Hi Jason, > > > > On Wed, May 09, 20

RE: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-10 Thread Zheng, Jian Xu
ling List ; Chiang, AlanX > > Subject: Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver > > Hi Jason, > > On Wed, May 09, 2018 at 09:28:30AM +, Chen, JasonX Z wrote: > > Hello Tomasz > > > > >> +/* Test Pattern Control */ > >

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-10 Thread Tomasz Figa
To: Zheng, Jian Xu > > Cc: Chen, JasonX Z ; Yeh, Andy > > ; Linux Media Mailing List > me...@vger.kernel.org>; Sakari Ailus ; Chiang, > > AlanX > > Subject: Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver > > > > On

RE: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-10 Thread Zheng, Jian Xu
edia Mailing List me...@vger.kernel.org>; Sakari Ailus ; Chiang, > AlanX > Subject: Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver > > On Thu, May 10, 2018 at 3:56 PM Zheng, Jian Xu > wrote: > > > Hi Tomasz, > > > > -Original Message- >

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-10 Thread Tomasz Figa
ia Mailing List ; Sakari Ailus ; Chiang, AlanX < alanx.chi...@intel.com> > Subject: Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver > On Thu, May 10, 2018 at 3:56 PM Zheng, Jian Xu > wrote: > > Hi Tomasz, > > > -Original Message- > > &

RE: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-10 Thread Yeh, Andy
5 PM > > To: Chen, JasonX Z > > Cc: Yeh, Andy ; Linux Media Mailing List > me...@vger.kernel.org>; Sakari Ailus ; Chiang, > > AlanX > > Subject: Re: [PATCH v11] media: imx258: Add imx258 camera sensor > > driver > > > > Hi Jason, > > > >

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-10 Thread Tomasz Figa
; To: Chen, JasonX Z > > Cc: Yeh, Andy ; Linux Media Mailing List > me...@vger.kernel.org>; Sakari Ailus ; Chiang, > > AlanX > > Subject: Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver > > > > Hi Jason, > > > > > IPU3 HAL has a handl

RE: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-09 Thread Zheng, Jian Xu
org>; Sakari Ailus ; Chiang, > AlanX > Subject: Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver > > Hi Jason, > > > IPU3 HAL has a handler to bind test_pattern mode. > > The COLOR BAR MODE in HAL has been configured to 1 when APP requests > >

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-09 Thread Yunliang Ding
Hi Andy, A small catch which should be fixed along with your incremental patch. On 2018-05-02 at 23:46:08 +0800, Andy Yeh wrote: > From: Jason Chen > > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-09 Thread Mauro Carvalho Chehab
Em Wed, 2 May 2018 23:46:08 +0800 Andy Yeh escreveu: > From: Jason Chen > > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Andy Yeh > Signed-off-by: Alan Chiang > Reviewe

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-09 Thread Tomasz Figa
Hi Jason, On Wed, May 9, 2018 at 6:28 PM Chen, JasonX Z wrote: > Hello Tomasz > >> +/* Test Pattern Control */ > >> +#define IMX258_REG_TEST_PATTERN0x0600 > >> +#define IMX258_TEST_PATTERN_DISABLE0 > >> +#define IMX258_TEST_PATTERN_SOLID_COLOR1 > >> +#define IMX258_T

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-09 Thread Sakari Ailus
Hi Jason, On Wed, May 09, 2018 at 09:28:30AM +, Chen, JasonX Z wrote: > Hello Tomasz > > >> +/* Test Pattern Control */ > >> +#define IMX258_REG_TEST_PATTERN0x0600 > >> +#define IMX258_TEST_PATTERN_DISABLE0 > >> +#define IMX258_TEST_PATTERN_SOLID_COLOR1 > >> +#defi

RE: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-09 Thread Chen, JasonX Z
Hello Tomasz >> +/* Test Pattern Control */ >> +#define IMX258_REG_TEST_PATTERN0x0600 >> +#define IMX258_TEST_PATTERN_DISABLE0 >> +#define IMX258_TEST_PATTERN_SOLID_COLOR1 >> +#define IMX258_TEST_PATTERN_COLOR_BARS 2 #define >> +IMX258_TEST_PATTERN_GREY_COLOR 3 >> +#de

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-08 Thread Tomasz Figa
Hi Andy, Sorry, missed one problem in previous review. Would you be able to send a fixup patch? On Thu, May 3, 2018 at 12:38 AM Andy Yeh wrote: > From: Jason Chen > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the >

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-03 Thread Sakari Ailus
Hi Andy, On Wed, May 02, 2018 at 11:46:08PM +0800, Andy Yeh wrote: > From: Jason Chen > > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Andy Yeh > Signed-off-by: Alan Chian