Sekhar,
>> >> + status = -EBUSY;
>> >[Hiremath, Vaibhav] Is -EBUSY right return value, I think it should be -
>> >ENXIO or -ENOMEM.
>> >
>> I see -ENXIO & -ENOMEM being used by drivers. -ENXIO stands for "No such
>device or address". ENOMEM stands for "Out of memory" . Since we are trying
On Fri, Dec 04, 2009 at 01:21:43, Karicheri, Muralidharan wrote:
>
[...]
> >
> >> + if (!res) {
> >> + status = -EBUSY;
> >> + goto fail_nores;
> >> + }
> >> +
> >> + ccdc_base_addr = ioremap_nocache(res->start, res_len);
> >> + if (!ccdc_base_addr) {
> >> + status
>> +#include
>[Hiremath, Vaibhav] This should not be here, this should get handled in
>board file. The driver should be generic.
>
See my comments against the platform part of this patch.
>> #include
>> #include
>> #include "dm355_ccdc_regs.h"
>> @@ -105,7 +106,6 @@ static struct ccdc_param
> -Original Message-
> From: Karicheri, Muralidharan
> Sent: Tuesday, December 01, 2009 11:46 PM
> To: linux-media@vger.kernel.org; hverk...@xs4all.nl;
> khil...@deeprootsystems.com
> Cc: davinci-linux-open-sou...@linux.davincidsp.com; Hiremath,
> Vaibhav; Karicheri, Muralidharan
> Subject: