Re: [PATCH 2/7] davinci: eliminate use of IO_ADDRESS() on sysmod

2011-03-15 Thread Arnd Bergmann
On Tuesday 15 March 2011 07:00:44 Nori, Sekhar wrote: > > * If you need to access sysmod in multiple places, a nicer > > way would be to make the virtual address pointer static, > > and export the accessor functions for it, rather than > > having a global pointer. > > Seems like opinion is

RE: [PATCH 2/7] davinci: eliminate use of IO_ADDRESS() on sysmod

2011-03-14 Thread Nori, Sekhar
Hi Arnd, On Mon, Mar 14, 2011 at 21:51:51, Arnd Bergmann wrote: > On Monday 14 March 2011, Manjunath Hadli wrote: > > Current devices.c file has a number of instances where > > IO_ADDRESS() is used for system module register > > access. Eliminate this in favor of a ioremap() > > based access. > >

Re: [PATCH 2/7] davinci: eliminate use of IO_ADDRESS() on sysmod

2011-03-14 Thread Arnd Bergmann
On Monday 14 March 2011, Manjunath Hadli wrote: > Current devices.c file has a number of instances where > IO_ADDRESS() is used for system module register > access. Eliminate this in favor of a ioremap() > based access. > > Consequent to this, a new global pointer davinci_sysmodbase > has been int

Re: [PATCH 2/7] davinci: eliminate use of IO_ADDRESS() on sysmod

2011-03-14 Thread Sergei Shtylyov
Hello. Manjunath Hadli wrote: Current devices.c file has a number of instances where IO_ADDRESS() is used for system module register access. Eliminate this in favor of a ioremap() based access. Consequent to this, a new global pointer davinci_sysmodbase has been introduced which gets initial