RE: [PATCH 2/4] v4l: add documentation for selection API

2011-09-27 Thread Kamil Debski
Hi Tomasz and Laurent, I have commented on the MFC case below. > From: Tomasz Stanislawski [mailto:t.stanisl...@samsung.com] > > Hi Laurent, > > On 09/27/2011 01:17 PM, Laurent Pinchart wrote: > > Hi Tomasz, > > > > On Friday 23 September 2011 17:22:27 Tomasz Stanislawski wrote: > >> On 09/23/2

Re: [PATCH 2/4] v4l: add documentation for selection API

2011-09-27 Thread Tomasz Stanislawski
Hi Laurent, On 09/27/2011 01:17 PM, Laurent Pinchart wrote: Hi Tomasz, On Friday 23 September 2011 17:22:27 Tomasz Stanislawski wrote: On 09/23/2011 03:13 PM, Laurent Pinchart wrote: [snip] I have to ideas to add subpixels to selection API. 1. Introduce struct v4l2_frect similar to str

Re: [PATCH 2/4] v4l: add documentation for selection API

2011-09-27 Thread Hans Verkuil
On Tuesday, September 27, 2011 15:36:15 Tomasz Stanislawski wrote: > Hi Hans, > Thank you for a quick review :). > > On 09/27/2011 11:20 AM, Hans Verkuil wrote: > > On Wednesday, August 31, 2011 14:28:21 Tomasz Stanislawski wrote: > >> This patch adds a documentation for VIDIOC_{G/S}_SELECTION ioc

Re: [PATCH 2/4] v4l: add documentation for selection API

2011-09-27 Thread Tomasz Stanislawski
Hi Hans, Thank you for a quick review :). On 09/27/2011 11:20 AM, Hans Verkuil wrote: On Wednesday, August 31, 2011 14:28:21 Tomasz Stanislawski wrote: This patch adds a documentation for VIDIOC_{G/S}_SELECTION ioctl. Moreover, the patch adds the description of modeling of composing, cropping a

Re: [PATCH 2/4] v4l: add documentation for selection API

2011-09-27 Thread Hans Verkuil
On Tuesday, September 27, 2011 13:11:35 Laurent Pinchart wrote: > On Tuesday 27 September 2011 11:20:29 Hans Verkuil wrote: > > On Wednesday, August 31, 2011 14:28:21 Tomasz Stanislawski wrote: > > > This patch adds a documentation for VIDIOC_{G/S}_SELECTION ioctl. > > > Moreover, the patch adds th

Re: [PATCH 2/4] v4l: add documentation for selection API

2011-09-27 Thread Laurent Pinchart
Hi Tomasz, On Friday 23 September 2011 17:22:27 Tomasz Stanislawski wrote: > On 09/23/2011 03:13 PM, Laurent Pinchart wrote: [snip] > +The composing targets refer to a memory buffer. The limits of > composing +coordinates are obtained using > V4L2_SEL_COMPOSE_BOUNDS. +All coordina

Re: [PATCH 2/4] v4l: add documentation for selection API

2011-09-27 Thread Laurent Pinchart
On Tuesday 27 September 2011 11:20:29 Hans Verkuil wrote: > On Wednesday, August 31, 2011 14:28:21 Tomasz Stanislawski wrote: > > This patch adds a documentation for VIDIOC_{G/S}_SELECTION ioctl. > > Moreover, the patch adds the description of modeling of composing, > > cropping and scaling feature

Re: [PATCH 2/4] v4l: add documentation for selection API

2011-09-27 Thread Hans Verkuil
On Wednesday, August 31, 2011 14:28:21 Tomasz Stanislawski wrote: > This patch adds a documentation for VIDIOC_{G/S}_SELECTION ioctl. Moreover, > the > patch adds the description of modeling of composing, cropping and scaling > features in V4L2. Finally, some examples are presented. > > Signed-of

Re: [PATCH 2/4] v4l: add documentation for selection API

2011-09-23 Thread Tomasz Stanislawski
On 09/23/2011 03:13 PM, Laurent Pinchart wrote: Hi Laurent, Thank you very much for your comments. The crop/compose setup is much more complicated task than I expected. The discussion is very helpful to find the optimal solution. +selection targets available for a video capture device. The t

Re: [PATCH 2/4] v4l: add documentation for selection API

2011-09-23 Thread Laurent Pinchart
Hi Tomasz, On Friday 23 September 2011 14:36:51 Tomasz Stanislawski wrote: > On 09/23/2011 12:41 AM, Laurent Pinchart wrote: > > Hi Laurent, > Thank you for the review. Your welcome. Sorry once again for the delay. > It looks that spelling highlighting is not enough :). That's what review is f

Re: [PATCH 2/4] v4l: add documentation for selection API

2011-09-23 Thread Tomasz Stanislawski
On 09/23/2011 12:41 AM, Laurent Pinchart wrote: Hi Laurent, Thank you for the review. It looks that spelling highlighting is not enough :). I discussed some of your comments. There are still some open issues. Hi Tomasz, Thanks for the patch, and sorry for the late reply. On Wednesday 31 Augu

Re: [PATCH 2/4] v4l: add documentation for selection API

2011-09-22 Thread Laurent Pinchart
Hi Tomasz, Thanks for the patch, and sorry for the late reply. On Wednesday 31 August 2011 14:28:21 Tomasz Stanislawski wrote: > This patch adds a documentation for VIDIOC_{G/S}_SELECTION ioctl. Moreover, > the patch adds the description of modeling of composing, cropping and > scaling features i