RE: [PATCH 1/3] v4l: add contorl definitions for codec devices.

2012-03-07 Thread Kamil Debski
Hi Hans, hi Jeongtae, > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: 02 March 2012 09:13 > > Hi Jeongtae! > > Some review notes below... > > On Friday, March 02, 2012 03:17:40 Jeongtae Park wrote: > > Add control definitions for controls specific to codec devices. > > > > Signed-off-b

Re: [PATCH 1/3] v4l: add contorl definitions for codec devices.

2012-03-02 Thread Sylwester Nawrocki
Hi Jongtae, On 03/02/2012 03:17 AM, Jeongtae Park wrote: > @@ -1458,17 +1462,18 @@ enum v4l2_mpeg_video_header_mode { > }; > #define V4L2_CID_MPEG_VIDEO_MAX_REF_PIC > (V4L2_CID_MPEG_BASE+217) > #define V4L2_CID_MPEG_VIDEO_MB_RC_ENABLE (V4L2_CID_MPEG_BASE+218) >

Re: [PATCH 1/3] v4l: add contorl definitions for codec devices.

2012-03-02 Thread Hans Verkuil
Hi Jeongtae! Some review notes below... On Friday, March 02, 2012 03:17:40 Jeongtae Park wrote: > Add control definitions for controls specific to codec devices. > > Signed-off-by: Jeongtae Park > Cc: Marek Szyprowski > Cc: Kamil Debski > --- > include/linux/videodev2.h | 51 ++