On Thursday 02 July 2009 22:32:38 m-kariche...@ti.com wrote:
> From: Muralidharan Karicheri
>
> Re-sending to add description (and also experimental status) for
> VPFE_CMD_S_CCDC_RAW_PARAMS and updating debug prints with \n and
> fixing an error coder ENOMEM
>
> VPFE Capture bridge driver
>
> T
Hans,
>
>I've only one request: can you add something along the lines of:
>
>"This is an experimental ioctl that will change in future kernels.
>Use with care."
>
>And at the top add: "EXPERIMENTAL IOCTL"
>
>That way it is unambiguous that this will change. And it definitely has
>to change! On th
On Thursday 02 July 2009 19:05:51 m-kariche...@ti.com wrote:
> From: Muralidharan Karicheri
>
> Re-sending to add description for VPFE_CMD_S_CCDC_RAW_PARAMS and
> updating debug prints with \n and fixing an error coder ENOMEM
>
> VPFE Capture bridge driver
>
> This is version, v3 of vpfe captur
y Klimov
>Cc: Karicheri, Muralidharan; linux-media@vger.kernel.org; davinci-linux-
>open-sou...@linux.davincidsp.com
>Subject: Re: [PATCH 1/11 - v3] vpfe capture bridge driver for DM355 and
>DM6446
>
>On Wednesday 17 June 2009 23:29:31 Alexey Klimov wrote:
>> Hello,
>>
>>
On Wednesday 17 June 2009 23:29:31 Alexey Klimov wrote:
> Hello,
>
> very small comments, see below please
Thanks, I've added the missing newlines and the wrong return code in a
separate patch in my pull request.
Regards,
Hans
--
Hans Verkuil - video4linux developer - sponsored by TAN
Hello,
very small comments, see below please
On Thu, Jun 18, 2009 at 12:11 AM, wrote:
> From: Muralidharan Karicheri
> +static int vpfe_enable_clock(struct vpfe_device *vpfe_dev)
> +{
> + struct vpfe_config *vpfe_cfg = vpfe_dev->cfg;
> + int ret = -ENOENT;
> +
> + vpfe_cfg-
