RE: [PATCH 04/12] mm: alloc_contig_freed_pages() added

2011-04-05 Thread Marek Szyprowski
Hello, On Monday, April 04, 2011 3:15 PM MichaƂ Nazarewicz wrote: > > What kind of success have you had running this in practice? I'd be > > worried that some silly task or a sticky dentry would end up in the > > range that you want to allocate in. > > I'm not sure what you are asking. > > The

Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added

2011-04-04 Thread Michal Nazarewicz
On Fri, 2011-04-01 at 00:51 +0200, Michal Nazarewicz wrote: The function is called from alloc_contig_range() (see patch 05/12) which makes sure that the PFN is valid. Situation where there is not enough space is caught earlier in alloc_contig_range(). alloc_contig_freed_pages() must be given a

Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added

2011-04-01 Thread Dave Hansen
On Fri, 2011-04-01 at 00:51 +0200, Michal Nazarewicz wrote: > On Fri, 01 Apr 2011 00:26:51 +0200, Dave Hansen > wrote: > >> Bug in the above place does not mean that we could not allocate > >> memory. It means caller is broken. > > > > Could you explain that a bit? > > > > Is this a case wher

Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added

2011-03-31 Thread Michal Nazarewicz
On Fri, 01 Apr 2011 00:26:51 +0200, Dave Hansen wrote: On Fri, 2011-04-01 at 00:18 +0200, Michal Nazarewicz wrote: On Thu, 31 Mar 2011 23:14:38 +0200, Dave Hansen wrote: > We BUG_ON() in bootmem. Basically if we try to allocate an early-boot > structure and fail, we're screwed. We can't ke

Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added

2011-03-31 Thread Dave Hansen
On Fri, 2011-04-01 at 00:18 +0200, Michal Nazarewicz wrote: > On Thu, 31 Mar 2011 23:14:38 +0200, Dave Hansen wrote: > > We BUG_ON() in bootmem. Basically if we try to allocate an early-boot > > structure and fail, we're screwed. We can't keep running without an > > inode hash, or a mem_map[]. >

Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added

2011-03-31 Thread Michal Nazarewicz
On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote: +unsigned long alloc_contig_freed_pages(unsigned long start, unsigned long end, + gfp_t flag) +{ + unsigned long pfn = start, count; + struct page *page; + struct zone *zone; +

Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added

2011-03-31 Thread Dave Hansen
On Thu, 2011-03-31 at 23:09 +0200, Michal Nazarewicz wrote: > On Thu, 31 Mar 2011 17:58:03 +0200, Dave Hansen > wrote: > > On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote: > >> +unsigned long alloc_contig_freed_pages(unsigned long start, unsigned > >> long end, > >> +

Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added

2011-03-31 Thread Michal Nazarewicz
On Thu, 31 Mar 2011 17:58:03 +0200, Dave Hansen wrote: On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote: +unsigned long alloc_contig_freed_pages(unsigned long start, unsigned long end, + gfp_t flag) +{ + unsigned long pfn = start, count

Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added

2011-03-31 Thread Dave Hansen
On Thu, 2011-03-31 at 15:24 -0400, Steven Rostedt wrote: > On Thu, Mar 31, 2011 at 08:58:03AM -0700, Dave Hansen wrote: > > On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote: > > > > > > +unsigned long alloc_contig_freed_pages(unsigned long start, unsigned > > > long end, > > > +

Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added

2011-03-31 Thread Steven Rostedt
On Thu, Mar 31, 2011 at 08:58:03AM -0700, Dave Hansen wrote: > On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote: > > > > +unsigned long alloc_contig_freed_pages(unsigned long start, unsigned long > > end, > > + gfp_t flag) > > +{ > > + unsigned

Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added

2011-03-31 Thread Dave Hansen
On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote: > > +unsigned long alloc_contig_freed_pages(unsigned long start, unsigned long > end, > + gfp_t flag) > +{ > + unsigned long pfn = start, count; > + struct page *page; > + struct zone