RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2012-11-27 Thread Libin Yang
Hi Guennadi, [snip] >> [Libin] Yes, you are right. We should consider the driver may be reused. >> I didn't realize it. Another question is: If we use devm_clk_get(), what >> I understand, the clk will be put when the device is being released. It >> means the driver will hold the clk all the time

RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2012-11-27 Thread Guennadi Liakhovetski
> >> Best Regards, > >> Libin > >> > >> >-Original Message- > >> >From: Albert Wang > >> >Sent: Tuesday, November 27, 2012 7:21 PM > >> >To: Guennadi Liakhovetski > >> >Cc: cor...@lwn.net; linux-media@vger.ker

RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2012-11-27 Thread Libin Yang
; >Sent: Tuesday, November 27, 2012 7:21 PM >> >To: Guennadi Liakhovetski >> >Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang >> >Subject: RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for >> >marvell-ccic >driver >> > >

RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2012-11-27 Thread Guennadi Liakhovetski
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang > >Subject: RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for > >marvell-ccic driver > > > >Hi, Guennadi > > > >We will update the patch by following your good suggest

RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2012-11-27 Thread Libin Yang
Hello Guennadi, Please see my comments below. Best Regards, Libin >-Original Message- >From: Albert Wang >Sent: Tuesday, November 27, 2012 7:21 PM >To: Guennadi Liakhovetski >Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang >Subject: RE: [PATCH 02/15] [m

RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2012-11-27 Thread Albert Wang
ng >Subject: Re: [PATCH 02/15] [media] marvell-ccic: add MIPI support for >marvell-ccic driver > >Hi Albert > >A general question first: is the MIPI CSI-2 implementation common to all ccic >variants or >specific to your SoC? > I think it's for all marvell ccic. >

Re: [PATCH 02/15] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2012-11-27 Thread Guennadi Liakhovetski
Hi Albert A general question first: is the MIPI CSI-2 implementation common to all ccic variants or specific to your SoC? On Fri, 23 Nov 2012, Albert Wang wrote: > From: Libin Yang > > This patch adds the MIPI support for marvell-ccic. > Board driver should determine whether using MIPI or not