RE: [PATCH] s5p-mfc: limit the size of the CPB

2014-07-16 Thread Kamil Debski
Hi Panpan, I merged your patch to my tree. However, next time please base the patch on the newest branch from Mauro. Please mind the whitespaces, I had to manually correct them. Also, please add version number to the [PATCH] part of subject e.g. [PATCH v10]. Best wishes, -- Kamil Debski Samsung

RE: [PATCH] s5p-mfc: limit the size of the CPB

2014-07-15 Thread Kamil Debski
Hi, Please also rebase the patches onto the master branch of the media tree. http://git.linuxtv.org/cgit.cgi/media_tree.git/ Best wishes, -- Kamil Debski Samsung R&D Institute Poland > -Original Message- > From: panpan liu [mailto:panpan1@samsung.com] > Sent: Tuesday, July 15, 201

RE: [PATCH] s5p-mfc: limit the size of the CPB

2014-07-15 Thread Kamil Debski
Hi Panpan, Checkpatch gives errors on your patch. -- Applying 24839 hit enter to continue... -- Checkpatch: -- ERROR: do not set execute permissions for source files #34: FILE: drivers/media/platform/s5p-mfc/s5p_m

RE: [PATCH] s5p-mfc: limit the size of the CPB

2014-07-14 Thread Kamil Debski
Hi, > From: panpan liu [mailto:panpan1@samsung.com] > Sent: Monday, July 14, 2014 1:18 PM > Subject: [PATCH] s5p-mfc: limit the size of the CPB > > The register of the CPB limits the size. The max size is 4M, so it > is more reasonable. The commit message should be rephrased as well. It is n

RE: [PATCH] s5p-mfc: limit the size of the CPB

2014-07-14 Thread Kamil Debski
Hi panpan, Thank you for your patch, please find my comments inline. > From: panpan liu [mailto:panpan1@samsung.com] > Sent: Monday, July 14, 2014 9:22 AM > > The register of the CPB limits the size. The max size is 4M, so it is > more reasonable. > > Signed-off-by: panpan liu > --- > dri