Mauro, Hans
Can I pull this patch as is via my tree, or shall we ask the author to
split it into two: to add the subdev operation and to implement it for
soc-camera?
Thanks
Guennadi
On Thu, 20 Jan 2011, Qing Xu wrote:
> add vidioc_enum_framesizes implementation, follow default_g_parm()
> and
-Original Message-
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
Sent: 2011年1月21日 18:43
To: Hans Verkuil
Cc: Qing Xu; linux-media@vger.kernel.org; Laurent Pinchart
Subject: Re: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl
On Fri, 21 Jan 2011, Hans Verkuil wrote
On Fri, 21 Jan 2011, Hans Verkuil wrote:
> On Friday, January 21, 2011 09:05:07 Guennadi Liakhovetski wrote:
> > On Thu, 20 Jan 2011, Qing Xu wrote:
> >
> > > Hi Guennadi, Hans,
> > >
> > > I update this patch, I use enum_framesizes instead of
> > > enum_mbus_fsizes, which is already defined in
On Friday, January 21, 2011 09:05:07 Guennadi Liakhovetski wrote:
> On Thu, 20 Jan 2011, Qing Xu wrote:
>
> > Hi Guennadi, Hans,
> >
> > I update this patch, I use enum_framesizes instead of
> > enum_mbus_fsizes, which is already defined in v4l2-subdev.h,
> > so, do not need to modify v4l2-subdev
On Thu, 20 Jan 2011, Qing Xu wrote:
> Hi Guennadi, Hans,
>
> I update this patch, I use enum_framesizes instead of
> enum_mbus_fsizes, which is already defined in v4l2-subdev.h,
> so, do not need to modify v4l2-subdev.h now.
>
> Are you ok with it?
Hm, you see, this would mean, hijacking a "wro
Hi Guennadi, Hans,
I update this patch, I use enum_framesizes instead of
enum_mbus_fsizes, which is already defined in v4l2-subdev.h,
so, do not need to modify v4l2-subdev.h now.
Are you ok with it?
-Qing
-Original Message-
From: Qing Xu [mailto:qi...@marvell.com]
Sent: 2011年1月21日 9:48
Hi Guennadi,
Thanks for your careful review and patient and your time!!
-Qing
-Original Message-
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
Sent: 2011年1月20日 16:28
To: Qing Xu
Cc: Linux Media Mailing List; Hans Verkuil
Subject: Re: [PATCH] [media] v4l: soc-camera: add
On Thu, 20 Jan 2011, Qing Xu wrote:
> add vidioc_enum_framesizes implementation, follow default_g_parm()
> and g_mbus_fmt() method
Yes, thanks, that's more like what I meant! Now, this patch also touches a
generic v4l2 file include/media/v4l2-subdev.h, and that in a very
essential way - it ads
Hm, sorry! My below comment:
On Wed, 19 Jan 2011, Guennadi Liakhovetski wrote:
> On Tue, 18 Jan 2011, Qing Xu wrote:
[snip]
> > @@ -1160,6 +1169,28 @@ static int default_s_parm(struct soc_camera_device
> > *icd,
> > return v4l2_subdev_call(sd, video, s_parm, parm);
> > }
> >
> > +sta
On Thu, 20 Jan 2011, Qing Xu wrote:
> add vidioc_enum_framesizes implementation, follow default_g_parm()
> and g_mbus_fmt() method
>
> Signed-off-by: Qing Xu
> ---
> drivers/media/video/soc_camera.c | 36
> include/media/soc_camera.h |1 +
> incl
On Tue, 18 Jan 2011, Qing Xu wrote:
> Hi Guennadi,
>
> Thanks for reviewing my patch! I update it again following your
> suggestion, please take your time to review it again, Thanks a lot!
>
> -Qing
>
> Email: qi...@marvell.com
> Application Processor Systems Engineering,
> Marvell Technology
Hi Guennadi,
Thanks for reviewing my patch! I update it again following your suggestion,
please take your time to review it again, Thanks a lot!
-Qing
Email: qi...@marvell.com
Application Processor Systems Engineering,
Marvell Technology Group Ltd.
-Original Message-
From: Qing Xu [mai
On Mon, 17 Jan 2011, Qing Xu wrote:
> add vidioc_enum_framesizes implementation, follow default_g_parm()
> and g_mbus_fmt() method
>
> Signed-off-by: Qing Xu
> ---
> drivers/media/video/soc_camera.c | 42
> ++
> include/media/soc_camera.h |1 +
>
Hi Guennadi,
On Monday 10 January 2011 09:20:05 Guennadi Liakhovetski wrote:
> On Sun, 9 Jan 2011, Qing Xu wrote:
> > On Fri, 7 Jan 2011, Guennadi Liakhovetski wrote:
> > > On Fri, 7 Jan 2011, Qing Xu wrote:
> > > > pass VIDIOC_ENUM_FRAMESIZES down to sub device drivers. So far no
> > > > special
On Sun, 9 Jan 2011, Qing Xu wrote:
> On Mon, 10 Jan 2011, Qing Xu wrote:
>
> > On Fri, 7 Jan 2011, Guennadi Liakhovetski wrote:
>
> > On Fri, 7 Jan 2011, Qing Xu wrote:
> >
> > > pass VIDIOC_ENUM_FRAMESIZES down to sub device drivers. So far no
> > > special handling in soc-camera core.
> >
> >
On Mon, 10 Jan 2011, Qing Xu wrote:
> On Fri, 7 Jan 2011, Guennadi Liakhovetski wrote:
> On Fri, 7 Jan 2011, Qing Xu wrote:
>
> > pass VIDIOC_ENUM_FRAMESIZES down to sub device drivers. So far no
> > special handling in soc-camera core.
>
> Hm, no, guess what? I don't think this can work. The par
On Mon, 10 Jan 2011, Qing Xu wrote:
> On Fri, 7 Jan 2011, Guennadi Liakhovetski wrote:
> On Fri, 7 Jan 2011, Qing Xu wrote:
>
> > pass VIDIOC_ENUM_FRAMESIZES down to sub device drivers. So far no
> > special handling in soc-camera core.
>
> Hm, no, guess what? I don't think this can work. The par
On Fri, 7 Jan 2011, Guennadi Liakhovetski wrote:
> On Fri, 7 Jan 2011, Qing Xu wrote:
>
> > pass VIDIOC_ENUM_FRAMESIZES down to sub device drivers. So far no
> > special handling in soc-camera core.
>
> Hm, no, guess what? I don't think this can work. The parameter, that this
> routine gets fro
On Fri, 7 Jan 2011, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Friday 07 January 2011 15:37:35 Guennadi Liakhovetski wrote:
> > On Fri, 7 Jan 2011, Qing Xu wrote:
> > > pass VIDIOC_ENUM_FRAMESIZES down to sub device drivers. So far no
> > > special handling in soc-camera core.
> >
> > Hm, no,
Hi Guennadi,
On Friday 07 January 2011 15:37:35 Guennadi Liakhovetski wrote:
> On Fri, 7 Jan 2011, Qing Xu wrote:
> > pass VIDIOC_ENUM_FRAMESIZES down to sub device drivers. So far no
> > special handling in soc-camera core.
>
> Hm, no, guess what? I don't think this can work. The parameter, that
On Fri, 7 Jan 2011, Qing Xu wrote:
> pass VIDIOC_ENUM_FRAMESIZES down to sub device drivers. So far no
> special handling in soc-camera core.
Hm, no, guess what? I don't think this can work. The parameter, that this
routine gets from the user struct v4l2_frmsizeenum contains a member
pixel_form
21 matches
Mail list logo
